Merge remote-tracking branch 'origin/anchor' into anchor

.github/workflows/release.yml

@@ -62,5 +62,5 @@ jobs:
         with:
           repo_token: ${{ secrets.GITHUB_TOKEN }}
           tag: ${{ steps.version.outputs.version}}
-          file: ./.pio/build/*/*${{ steps.version.outputs.version }}*-{all,update}.bin
+          file: ./.pio/build/*/*-{all,update}.bin
           file_glob: true

Readme.md

@@ -43,10 +43,6 @@ What is included
 
 For the details of the mapped PGNs and NMEA sentences refer to [Conversions](doc/Conversions.pdf).
 
-License
--------
-This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either [version 2 of the License](LICENSE), or (at your option) any later version.
-
 Hardware
 --------
 The software is prepared to run on different kinds of ESP32 based modules and accessoirs. For some of them prebuild binaries are available that only need to be flashed, others would require to add some definitions of the used PINs and features and to build the binary.
@@ -174,25 +170,6 @@ For details refer to the [example description](lib/exampletask/Readme.md).
 
 Changelog
 ---------
-[20251126](../../releases/tag/20251126)
-* fix a bug in the Actisense reader that could lead to an endless loop (making the device completely non responsive)
-* upgrade to 4.24.1 of the NMEA2000 library (2025/11/01) - refer to the [changes](https://github.com/ttlappalainen/NMEA2000/blob/master/Documents/src/changes.md) - Especially UTF8 support
-*********
-[20251007](../../releases/tag/20251007)
-*********
-* add AIS Aton translations (PGN 129041 <-> Ais class 21)
-* improved mapping of AIS transducer information (NMEA2000) to AIS channel and Talker on NMEA0183
-* use a forked version of the NMEA2000 library (as an intermediate workaround)
-* [#114](../../issues/114) correctly translate AIS type 1/3 from PGN 129038
-* add support for a generic S3 build in the build UI
-* [#117](../../issues/117) add support for a transmit enable pin for RS 485 conections (also in the build UI)
-* [#116](../../issues/116) SDA and SCL are swapped in the build UI
-* [#112](../../issues/112) clearify licenses
-* [#110](../../issues/110) / [#115](../../pull/115) support for the M5 GPS unit v1.1
-* [#102](../../issues/102) optimize Wifi reconnect handling
-* [#111](../../pull/111) allow for a custom python build script
-* [#113](../../issues/113) support for M5 stack Env4
-
 [20250305](../../releases/tag/20250305)
 *********
 * better handling for reconnect to a raspberry pi after reset [#102](../../issues/102)

extra_script.py

@@ -10,7 +10,7 @@ from datetime import datetime
 import re
 import pprint
 from platformio.project.config import ProjectConfig
-
+from platformio.project.exception import InvalidProjectConfError
 
 Import("env")
 #print(env.Dump())
@@ -104,7 +104,18 @@ def writeFileIfChanged(fileName,data):
     return True    
 
 def mergeConfig(base,other):
-    for cname in other:
+    try:
+        customconfig = env.GetProjectOption("custom_config")
+    except InvalidProjectConfError:
+        customconfig = None
+    for bdir in other:
+        if customconfig and os.path.exists(os.path.join(bdir,customconfig)):
+            cname=os.path.join(bdir,customconfig)
+            print("merge custom config {}".format(cname))
+            with open(cname,'rb') as ah:
+                base += json.load(ah)
+            continue   
+        cname=os.path.join(bdir,"config.json")
         if os.path.exists(cname):
             print("merge config %s"%cname)
             with open(cname,'rb') as ah:
@@ -150,25 +161,13 @@ def expandConfig(config):
                     rt.append(replaceTexts(c,replace))
     return rt
 
-def createUserItemList(dirs,itemName,files):
-    rt=[]
-    for d in dirs:
-        iname=os.path.join(d,itemName)
-        if os.path.exists(iname):
-            rt.append(iname)
-    for f in files:
-        if not os.path.exists(f):
-            raise Exception("user item %s not found"%f)
-        rt.append(f)
-    return rt
-
-def generateMergedConfig(inFile,outFile,addFiles=[]):
+def generateMergedConfig(inFile,outFile,addDirs=[]):
     if not os.path.exists(inFile):
         raise Exception("unable to read cfg file %s"%inFile)
     data=""
     with open(inFile,'rb') as ch:    
         config=json.load(ch)
-        config=mergeConfig(config,addFiles)
+        config=mergeConfig(config,addDirs)
         config=expandConfig(config)
         data=json.dumps(config,indent=2)
         writeFileIfChanged(outFile,data)
@@ -388,7 +387,12 @@ def getLibs():
 
 
 
-def joinFiles(target,flist):
+def joinFiles(target,pattern,dirlist):
+    flist=[]
+    for dir in dirlist:
+            fn=os.path.join(dir,pattern)
+            if os.path.exists(fn):
+                flist.append(fn)
     current=False
     if os.path.exists(target):
         current=True
@@ -459,28 +463,7 @@ def handleDeps(env):
         )
     env.AddBuildMiddleware(injectIncludes)
 
-def getOption(env,name,toArray=True):
-    try:
-        opt=env.GetProjectOption(name)
-        if toArray:
-            if opt is None:
-                return []
-            if isinstance(opt,list):
-                return opt
-            return opt.split("\n" if "\n" in opt else ",")
-        return opt
-    except:
-        pass
-    if toArray:
-        return []
 
-def getFileList(files):
-    base=basePath()
-    rt=[]
-    for f in files:
-        if f is not None and f != "":
-            rt.append(os.path.join(base,f))
-    return rt
 def prebuild(env):
     global userTaskDirs
     print("#prebuild running")
@@ -490,18 +473,14 @@ def prebuild(env):
     if ldf_mode == 'off':
         print("##ldf off - own dependency handling")
         handleDeps(env)
-    extraConfigs=getOption(env,'custom_config',toArray=True)
-    extraJs=getOption(env,'custom_js',toArray=True)
-    extraCss=getOption(env,'custom_css',toArray=True)
-
     userTaskDirs=getUserTaskDirs()
     mergedConfig=os.path.join(outPath(),os.path.basename(CFG_FILE))
-    generateMergedConfig(os.path.join(basePath(),CFG_FILE),mergedConfig,createUserItemList(userTaskDirs,"config.json", getFileList(extraConfigs)))
+    generateMergedConfig(os.path.join(basePath(),CFG_FILE),mergedConfig,userTaskDirs)
     compressFile(mergedConfig,mergedConfig+".gz")
     generateCfg(mergedConfig,os.path.join(outPath(),CFG_INCLUDE),False)
     generateCfg(mergedConfig,os.path.join(outPath(),CFG_INCLUDE_IMPL),True)
-    joinFiles(os.path.join(outPath(),INDEXJS+".gz"),createUserItemList(["web"]+userTaskDirs,INDEXJS,getFileList(extraJs)))
-    joinFiles(os.path.join(outPath(),INDEXCSS+".gz"),createUserItemList(["web"]+userTaskDirs,INDEXCSS,getFileList(extraCss)))
+    joinFiles(os.path.join(outPath(),INDEXJS+".gz"),INDEXJS,["web"]+userTaskDirs)
+    joinFiles(os.path.join(outPath(),INDEXCSS+".gz"),INDEXCSS,["web"]+userTaskDirs)
     embedded=getEmbeddedFiles(env)
     filedefs=[]
     for ef in embedded:
@@ -547,16 +526,17 @@ env.Append(
 )
 #script does not run on clean yet - maybe in the future
 env.AddPostAction("clean",cleangenerated)
-extraScripts=getFileList(getOption(env,'custom_script',toArray=True))
-for script in extraScripts:
+
+#look for extra task scripts and include them here
+for taskdir in userTaskDirs:
+    script = os.path.join(taskdir, "extra_task.py")
     if os.path.isfile(script):
-        print(f"#extra {script}")
+        taskname = os.path.basename(os.path.normpath(taskdir))
+        print("#extra task script for '{}'".format(taskname))
         with open(script) as fh:
             try:
-                code = compile(fh.read(), script, 'exec')
-            except SyntaxError as e:
-                print(f"#ERROR: script {script} does not compile: {e}")
+                code = compile(fh.read(), taskname, 'exec')
+            except SyntaxError:
+                print("#ERROR: script does not compile")
                 continue
             exec(code)
-    else:
-        print(f"#ERROR: script {script} not found")

extra_script.py.new

@@ -0,0 +1,542 @@
+print("running extra...")
+import gzip
+import shutil
+import os
+import sys
+import inspect
+import json
+import glob
+from datetime import datetime
+import re
+import pprint
+from platformio.project.config import ProjectConfig
+from platformio.project.exception import InvalidProjectConfError
+
+Import("env")
+#print(env.Dump())
+OWN_FILE="extra_script.py"
+GEN_DIR='lib/generated'
+CFG_FILE='web/config.json'
+XDR_FILE='web/xdrconfig.json'
+INDEXJS="index.js"
+INDEXCSS="index.css"
+CFG_INCLUDE='GwConfigDefinitions.h'
+CFG_INCLUDE_IMPL='GwConfigDefImpl.h'
+XDR_INCLUDE='GwXdrTypeMappings.h'
+TASK_INCLUDE='GwUserTasks.h'
+GROVE_CONFIG="GwM5GroveGen.h"
+GROVE_CONFIG_IN="lib/hardware/GwM5Grove.in"
+EMBEDDED_INCLUDE="GwEmbeddedFiles.h"
+
+def getEmbeddedFiles(env):
+    rt=[]
+    efiles=env.GetProjectOption("board_build.embed_files")
+    for f in efiles.split("\n"):
+        if f == '':
+            continue
+        rt.append(f)
+    return rt  
+
+def basePath():
+    #see: https://stackoverflow.com/questions/16771894/python-nameerror-global-name-file-is-not-defined
+    return os.path.dirname(inspect.getfile(lambda: None))
+
+def outPath():
+    return os.path.join(basePath(),GEN_DIR)
+def checkDir():
+    dn=outPath()
+    if not os.path.exists(dn):
+        os.makedirs(dn)
+    if not os.path.isdir(dn):
+        print("unable to create %s"%dn)
+        return False
+    return True    
+
+def isCurrent(infile,outfile):
+    if os.path.exists(outfile):
+        otime=os.path.getmtime(outfile)
+        itime=os.path.getmtime(infile)
+        if (otime >= itime):
+            own=os.path.join(basePath(),OWN_FILE)
+            if os.path.exists(own):
+                owntime=os.path.getmtime(own)
+                if owntime > otime:
+                    return False
+            print("%s is newer then %s, no need to recreate"%(outfile,infile))
+            return True
+    return False        
+def compressFile(inFile,outfile):
+    if isCurrent(inFile,outfile):
+        return
+    print("compressing %s"%inFile)
+    with open(inFile, 'rb') as f_in:
+        with gzip.open(outfile, 'wb') as f_out:
+            shutil.copyfileobj(f_in, f_out)
+
+def generateFile(infile,outfile,callback,inMode='rb',outMode='w'):
+    if isCurrent(infile,outfile):
+        return
+    print("creating %s"%outfile)
+    oh=None
+    with open(infile,inMode) as ch:
+        with open(outfile,outMode) as oh:
+            try:
+                callback(ch,oh,inFile=infile)
+                oh.close()
+            except Exception as e:
+                try:
+                    oh.close()
+                except:
+                    pass
+                os.unlink(outfile)
+                raise
+
+def writeFileIfChanged(fileName,data):
+    if os.path.exists(fileName):
+        with open(fileName,"r") as ih:
+            old=ih.read()
+            ih.close()
+            if old == data:
+                return False
+    print("#generating %s"%fileName)
+    with open(fileName,"w") as oh:
+        oh.write(data)
+    return True    
+
+def mergeConfig(base,other):
+    try:
+        customconfig = env.GetProjectOption("custom_config")
+    except InvalidProjectConfError:
+        customconfig = None
+    for bdir in other:
+        if customconfig and os.path.exists(os.path.join(bdir,customconfig)):
+            cname=os.path.join(bdir,customconfig)
+            print("merge custom config {}".format(cname))
+            with open(cname,'rb') as ah:
+                base += json.load(ah)
+            continue   
+        cname=os.path.join(bdir,"config.json")
+        if os.path.exists(cname):
+            print("merge config %s"%cname)
+            with open(cname,'rb') as ah:
+                merge=json.load(ah)
+                base=base+merge
+    return base
+
+def replaceTexts(data,replacements):
+    if replacements is None:
+        return data
+    if isinstance(data,str):
+        for k,v in replacements.items():
+            data=data.replace("$"+k,str(v))
+        return data
+    if isinstance(data,list):
+        rt=[]
+        for e in data:
+            rt.append(replaceTexts(e,replacements))
+        return rt
+    if isinstance(data,dict):   
+        rt={} 
+        for k,v in data.items():
+            rt[replaceTexts(k,replacements)]=replaceTexts(v,replacements)
+        return rt
+    return data
+def expandConfig(config):
+    rt=[]
+    for item in config:
+        type=item.get('type')
+        if type != 'array':
+            rt.append(item)
+            continue
+        replacements=item.get('replace')
+        children=item.get('children')
+        name=item.get('name')
+        if name is None:
+            name="#unknown#"
+        if not isinstance(replacements,list):
+            raise Exception("missing replacements at array %s"%name)
+        for replace in replacements:
+            if children is not None:
+                for c in children:
+                    rt.append(replaceTexts(c,replace))
+    return rt
+
+def generateMergedConfig(inFile,outFile,addDirs=[]):
+    if not os.path.exists(inFile):
+        raise Exception("unable to read cfg file %s"%inFile)
+    data=""
+    with open(inFile,'rb') as ch:    
+        config=json.load(ch)
+        config=mergeConfig(config,addDirs)
+        config=expandConfig(config)
+        data=json.dumps(config,indent=2)
+        writeFileIfChanged(outFile,data)
+
+def generateCfg(inFile,outFile,impl):
+    if not os.path.exists(inFile):
+        raise Exception("unable to read cfg file %s"%inFile)
+    data=""
+    with open(inFile,'rb') as ch:    
+        config=json.load(ch)     
+        data+="//generated from %s\n"%inFile
+        l=len(config)
+        idx=0
+        if not impl:
+            data+='#include "GwConfigItem.h"\n'
+            data+='class GwConfigDefinitions{\n'
+            data+='  public:\n'
+            data+='  int getNumConfig() const{return %d;}\n'%(l)
+            for item in config:
+                n=item.get('name')
+                if n is None:
+                    continue
+                if len(n) > 15:
+                    raise Exception("%s: config names must be max 15 caracters"%n)
+                data+='  static constexpr const char* %s="%s";\n'%(n,n)
+            data+="};\n"
+        else:
+            data+='void GwConfigHandler::populateConfigs(GwConfigInterface **config){\n'
+            for item in config:
+                name=item.get('name')
+                if name is None:
+                    continue
+                data+='  configs[%d]='%(idx)
+                idx+=1
+                secret="false";
+                if item.get('type') == 'password':
+                    secret="true"
+                data+="     new GwConfigInterface(%s,\"%s\",%s);\n"%(name,item.get('default'),secret)
+            data+='}\n'  
+    writeFileIfChanged(outFile,data)    
+                    
+def labelFilter(label):
+    return re.sub("[^a-zA-Z0-9]","",re.sub("\([0-9]*\)","",label))    
+def generateXdrMappings(fp,oh,inFile=''):
+    jdoc=json.load(fp)
+    oh.write("static GwXDRTypeMapping* typeMappings[]={\n")
+    first=True
+    for cat in jdoc:
+        item=jdoc[cat]
+        cid=item.get('id')
+        if cid is None:
+            continue
+        tc=item.get('type')
+        if tc is not None:
+            if first:
+                first=False
+            else:
+                oh.write(",\n")
+            oh.write("   new GwXDRTypeMapping(%d,0,%d) /*%s*/"%(cid,tc,cat))
+        fields=item.get('fields')
+        if fields is None:
+            continue
+        idx=0
+        for fe in fields:
+            if not isinstance(fe,dict):
+                continue
+            tc=fe.get('t')
+            id=fe.get('v')
+            if id is None:
+                id=idx
+            idx+=1
+            l=fe.get('l') or ''
+            if tc is None or id is None:
+                continue
+            if first:
+                first=False
+            else:
+                oh.write(",\n")
+            oh.write("   new GwXDRTypeMapping(%d,%d,%d) /*%s:%s*/"%(cid,id,tc,cat,l))
+    oh.write("\n")
+    oh.write("};\n")
+    for cat in jdoc:
+        item=jdoc[cat]
+        cid=item.get('id')
+        if cid is None:
+            continue
+        selectors=item.get('selector')
+        if selectors is not None:
+            for selector in selectors:
+                label=selector.get('l')
+                value=selector.get('v')
+                if label is not None and value is not None:
+                    label=labelFilter(label)
+                    define=("GWXDRSEL_%s_%s"%(cat,label)).upper()
+                    oh.write("    #define %s %s\n"%(define,value))
+        fields=item.get('fields')
+        if fields is not None:
+            idx=0
+            for field in fields:
+                v=field.get('v')
+                if v is None:
+                    v=idx
+                else:
+                    v=int(v)
+                label=field.get('l')
+                if v is not None and label is not None:
+                    define=("GWXDRFIELD_%s_%s"%(cat,labelFilter(label))).upper();
+                    oh.write("    #define %s %s\n"%(define,str(v)))
+                idx+=1
+
+class Grove:
+    def __init__(self,name) -> None:
+        self.name=name
+    def _ss(self,z=False):
+        if z:
+            return self.name
+        return self.name if self.name != 'Z' else ''
+    def _suffix(self):
+        return '_'+self.name if self.name != 'Z' else ''
+    def replace(self,line):
+        if line is None:
+            return line
+        return line.replace('$G$',self._ss()).replace('$Z$',self._ss(True)).replace('$GS$',self._suffix())
+def generateGroveDefs(inh,outh,inFile=''):
+    GROVES=[Grove('Z'),Grove('A'),Grove('B'),Grove('C')]
+    definition=[]
+    started=False
+    def writeConfig():
+        for grove in GROVES:        
+            for cl in definition:
+                outh.write(grove.replace(cl))
+
+    for line in inh:
+        if re.match(" *#GROVE",line):
+            started=True
+            if len(definition) > 0:
+                writeConfig()
+            definition=[]
+            continue
+        if started:
+            definition.append(line)
+    if len(definition) > 0:
+        writeConfig()
+
+
+
+userTaskDirs=[]
+
+def getUserTaskDirs():
+    rt=[]
+    taskdirs=glob.glob(os.path.join( basePath(),'lib','*task*'))
+    for task in taskdirs:
+        rt.append(task)
+    return rt
+
+def checkAndAdd(file,names,ilist):
+    if not file.endswith('.h'):
+        return
+    match=False
+    for cmp in names:
+        #print("##check %s<->%s"%(f.lower(),cmp))
+        if file.lower() == cmp:
+            match=True
+    if not match:
+        return
+    ilist.append(file) 
+def genereateUserTasks(outfile):
+    includes=[]
+    for task in userTaskDirs:
+        #print("##taskdir=%s"%task)
+        base=os.path.basename(task)
+        includeNames=[base.lower()+".h",'gw'+base.lower()+'.h']
+        for f in os.listdir(task):
+            checkAndAdd(f,includeNames,includes)
+    includeData=""
+    for i in includes:
+        print("#task include %s"%i)
+        includeData+="#include <%s>\n"%i
+    writeFileIfChanged(outfile,includeData)            
+
+def generateEmbedded(elist,outFile):
+    content=""
+    for entry in elist:
+        content+="EMBED_GZ_FILE(\"%s\",%s,\"%s\");\n"%entry
+    writeFileIfChanged(outFile,content)    
+
+def getContentType(fn):
+    if (fn.endswith('.gz')):
+        fn=fn[0:-3]
+    if (fn.endswith('html')):
+        return "text/html"
+    if (fn.endswith('json')):
+        return "application/json"
+    if (fn.endswith('js')):
+        return "text/javascript"
+    if (fn.endswith('css')):    
+        return "text/css"
+    return "application/octet-stream"
+
+
+def getLibs():
+    base=os.path.join(basePath(),"lib")
+    rt=[]
+    for sd in os.listdir(base):
+        if sd == '..':
+            continue
+        if sd == '.':
+            continue
+        fn=os.path.join(base,sd)
+        if os.path.isdir(fn):
+            rt.append(sd)
+    EXTRAS=['generated']
+    for e in EXTRAS:
+        if not e in rt:
+            rt.append(e)
+    return rt
+
+
+
+def joinFiles(target,pattern,dirlist):
+    flist=[]
+    for dir in dirlist:
+            fn=os.path.join(dir,pattern)
+            if os.path.exists(fn):
+                flist.append(fn)
+    current=False
+    if os.path.exists(target):
+        current=True
+        for f in flist:
+            if not isCurrent(f,target):
+                current=False
+                break
+    if current:
+        print("%s is up to date"%target)
+        return
+    print("creating %s"%target)
+    with gzip.open(target,"wb") as oh:
+        for fn in flist:
+            print("adding %s to %s"%(fn,target))
+            with open(fn,"rb") as rh:
+                shutil.copyfileobj(rh,oh)
+    
+
+OWNLIBS=getLibs()+["FS","WiFi"]
+GLOBAL_INCLUDES=[]
+
+def handleDeps(env):
+    #overwrite the GetProjectConfig
+    #to inject all our libs
+    oldGetProjectConfig=env.GetProjectConfig    
+    def GetProjectConfigX(env):        
+        rt=oldGetProjectConfig()
+        cenv="env:"+env['PIOENV']
+        libs=[]
+        for section,options in rt.as_tuple():
+            if section == cenv:
+                for key,values in options:
+                    if key == 'lib_deps':
+                        libs=values
+    
+        mustUpdate=False
+        for lib in OWNLIBS:
+            if not lib in libs:
+                libs.append(lib)
+                mustUpdate=True
+        if mustUpdate:
+            update=[(cenv,[('lib_deps',libs)])]
+            rt.update(update)
+        return rt
+    env.AddMethod(GetProjectConfigX,"GetProjectConfig")
+    #store the list of all includes after we resolved
+    #the dependencies for our main project
+    #we will use them for all compilations afterwards
+    oldLibBuilder=env.ConfigureProjectLibBuilder
+    def ConfigureProjectLibBuilderX(env):
+        global GLOBAL_INCLUDES
+        project=oldLibBuilder()
+        #print("##ConfigureProjectLibBuilderX")
+        #pprint.pprint(project)
+        if project.depbuilders:
+            #print("##depbuilders %s"%",".join(map(lambda x: x.path,project.depbuilders)))
+            for db in project.depbuilders:
+                idirs=db.get_include_dirs()
+                for id in idirs:
+                    if not id in GLOBAL_INCLUDES:
+                        GLOBAL_INCLUDES.append(id)
+        return project
+    env.AddMethod(ConfigureProjectLibBuilderX,"ConfigureProjectLibBuilder")
+    def injectIncludes(env,node):
+        return env.Object(
+            node,
+            CPPPATH=env["CPPPATH"]+GLOBAL_INCLUDES
+        )
+    env.AddBuildMiddleware(injectIncludes)
+
+
+def prebuild(env):
+    global userTaskDirs
+    print("#prebuild running")
+    if not checkDir():
+        sys.exit(1)
+    ldf_mode=env.GetProjectOption("lib_ldf_mode")
+    if ldf_mode == 'off':
+        print("##ldf off - own dependency handling")
+        handleDeps(env)
+    userTaskDirs=getUserTaskDirs()
+    mergedConfig=os.path.join(outPath(),os.path.basename(CFG_FILE))
+    generateMergedConfig(os.path.join(basePath(),CFG_FILE),mergedConfig,userTaskDirs)
+    compressFile(mergedConfig,mergedConfig+".gz")
+    generateCfg(mergedConfig,os.path.join(outPath(),CFG_INCLUDE),False)
+    generateCfg(mergedConfig,os.path.join(outPath(),CFG_INCLUDE_IMPL),True)
+    joinFiles(os.path.join(outPath(),INDEXJS+".gz"),INDEXJS,["web"]+userTaskDirs)
+    joinFiles(os.path.join(outPath(),INDEXCSS+".gz"),INDEXCSS,["web"]+userTaskDirs)
+    embedded=getEmbeddedFiles(env)
+    filedefs=[]
+    for ef in embedded:
+        print("#checking embedded file %s"%ef)
+        (dn,fn)=os.path.split(ef)
+        pureName=fn
+        if pureName.endswith('.gz'):
+            pureName=pureName[0:-3]
+        ct=getContentType(pureName)
+        usname=ef.replace('/','_').replace('.','_')
+        filedefs.append((pureName,usname,ct))
+        inFile=os.path.join(basePath(),"web",pureName)
+        if os.path.exists(inFile):
+            compressFile(inFile,ef)
+        else:
+            print("#WARNING: infile %s for %s not found"%(inFile,ef))
+    generateEmbedded(filedefs,os.path.join(outPath(),EMBEDDED_INCLUDE))
+    genereateUserTasks(os.path.join(outPath(), TASK_INCLUDE))
+    generateFile(os.path.join(basePath(),XDR_FILE),os.path.join(outPath(),XDR_INCLUDE),generateXdrMappings)
+    generateFile(os.path.join(basePath(),GROVE_CONFIG_IN),os.path.join(outPath(),GROVE_CONFIG),generateGroveDefs,inMode='r')
+    version="dev"+datetime.now().strftime("%Y%m%d")
+    env.Append(CPPDEFINES=[('GWDEVVERSION',version)])
+
+def cleangenerated(source, target, env):
+    od=outPath()
+    if os.path.isdir(od):
+        print("#cleaning up %s"%od)
+        for f in os.listdir(od):
+            if f == "." or f == "..":
+                continue
+            fn=os.path.join(od,f)
+            os.unlink(f)
+
+
+print("#prescript...")
+prebuild(env)
+board="PLATFORM_BOARD_%s"%env["BOARD"].replace("-","_").upper()
+print("Board=#%s#"%board)
+print("BuildFlags=%s"%(" ".join(env["BUILD_FLAGS"])))
+env.Append(
+    LINKFLAGS=[ "-u", "custom_app_desc" ],
+    CPPDEFINES=[(board,"1")]
+)
+#script does not run on clean yet - maybe in the future
+env.AddPostAction("clean",cleangenerated)
+
+#look for extra task scripts and include them here
+for taskdir in userTaskDirs:
+    script = os.path.join(taskdir, "extra_task.py")
+    if os.path.isfile(script):
+        taskname = os.path.basename(os.path.normpath(taskdir))
+        print("#extra task script for '{}'".format(taskname))
+        with open(script) as fh:
+            try:
+                code = compile(fh.read(), taskname, 'exec')
+            except SyntaxError:
+                print("#ERROR: script does not compile")
+                continue
+            exec(code)

extra_script.py.old

@@ -0,0 +1,518 @@
+print("running extra...")
+import gzip
+import shutil
+import os
+import sys
+import inspect
+import json
+import glob
+from datetime import datetime
+import re
+import pprint
+from platformio.project.config import ProjectConfig
+
+
+Import("env")
+#print(env.Dump())
+OWN_FILE="extra_script.py"
+GEN_DIR='lib/generated'
+CFG_FILE='web/config.json'
+XDR_FILE='web/xdrconfig.json'
+INDEXJS="index.js"
+INDEXCSS="index.css"
+CFG_INCLUDE='GwConfigDefinitions.h'
+CFG_INCLUDE_IMPL='GwConfigDefImpl.h'
+XDR_INCLUDE='GwXdrTypeMappings.h'
+TASK_INCLUDE='GwUserTasks.h'
+GROVE_CONFIG="GwM5GroveGen.h"
+GROVE_CONFIG_IN="lib/hardware/GwM5Grove.in"
+EMBEDDED_INCLUDE="GwEmbeddedFiles.h"
+
+def getEmbeddedFiles(env):
+    rt=[]
+    efiles=env.GetProjectOption("board_build.embed_files")
+    for f in efiles.split("\n"):
+        if f == '':
+            continue
+        rt.append(f)
+    return rt  
+
+def basePath():
+    #see: https://stackoverflow.com/questions/16771894/python-nameerror-global-name-file-is-not-defined
+    return os.path.dirname(inspect.getfile(lambda: None))
+
+def outPath():
+    return os.path.join(basePath(),GEN_DIR)
+def checkDir():
+    dn=outPath()
+    if not os.path.exists(dn):
+        os.makedirs(dn)
+    if not os.path.isdir(dn):
+        print("unable to create %s"%dn)
+        return False
+    return True    
+
+def isCurrent(infile,outfile):
+    if os.path.exists(outfile):
+        otime=os.path.getmtime(outfile)
+        itime=os.path.getmtime(infile)
+        if (otime >= itime):
+            own=os.path.join(basePath(),OWN_FILE)
+            if os.path.exists(own):
+                owntime=os.path.getmtime(own)
+                if owntime > otime:
+                    return False
+            print("%s is newer then %s, no need to recreate"%(outfile,infile))
+            return True
+    return False        
+def compressFile(inFile,outfile):
+    if isCurrent(inFile,outfile):
+        return
+    print("compressing %s"%inFile)
+    with open(inFile, 'rb') as f_in:
+        with gzip.open(outfile, 'wb') as f_out:
+            shutil.copyfileobj(f_in, f_out)
+
+def generateFile(infile,outfile,callback,inMode='rb',outMode='w'):
+    if isCurrent(infile,outfile):
+        return
+    print("creating %s"%outfile)
+    oh=None
+    with open(infile,inMode) as ch:
+        with open(outfile,outMode) as oh:
+            try:
+                callback(ch,oh,inFile=infile)
+                oh.close()
+            except Exception as e:
+                try:
+                    oh.close()
+                except:
+                    pass
+                os.unlink(outfile)
+                raise
+
+def writeFileIfChanged(fileName,data):
+    if os.path.exists(fileName):
+        with open(fileName,"r") as ih:
+            old=ih.read()
+            ih.close()
+            if old == data:
+                return False
+    print("#generating %s"%fileName)
+    with open(fileName,"w") as oh:
+        oh.write(data)
+    return True    
+
+def mergeConfig(base,other):
+    for bdir in other:
+        cname=os.path.join(bdir,"config.json")
+        if os.path.exists(cname):
+            print("merge config %s"%cname)
+            with open(cname,'rb') as ah:
+                merge=json.load(ah)
+                base=base+merge
+    return base
+
+def replaceTexts(data,replacements):
+    if replacements is None:
+        return data
+    if isinstance(data,str):
+        for k,v in replacements.items():
+            data=data.replace("$"+k,str(v))
+        return data
+    if isinstance(data,list):
+        rt=[]
+        for e in data:
+            rt.append(replaceTexts(e,replacements))
+        return rt
+    if isinstance(data,dict):   
+        rt={} 
+        for k,v in data.items():
+            rt[replaceTexts(k,replacements)]=replaceTexts(v,replacements)
+        return rt
+    return data
+def expandConfig(config):
+    rt=[]
+    for item in config:
+        type=item.get('type')
+        if type != 'array':
+            rt.append(item)
+            continue
+        replacements=item.get('replace')
+        children=item.get('children')
+        name=item.get('name')
+        if name is None:
+            name="#unknown#"
+        if not isinstance(replacements,list):
+            raise Exception("missing replacements at array %s"%name)
+        for replace in replacements:
+            if children is not None:
+                for c in children:
+                    rt.append(replaceTexts(c,replace))
+    return rt
+
+def generateMergedConfig(inFile,outFile,addDirs=[]):
+    if not os.path.exists(inFile):
+        raise Exception("unable to read cfg file %s"%inFile)
+    data=""
+    with open(inFile,'rb') as ch:    
+        config=json.load(ch)
+        config=mergeConfig(config,addDirs)
+        config=expandConfig(config)
+        data=json.dumps(config,indent=2)
+        writeFileIfChanged(outFile,data)
+
+def generateCfg(inFile,outFile,impl):
+    if not os.path.exists(inFile):
+        raise Exception("unable to read cfg file %s"%inFile)
+    data=""
+    with open(inFile,'rb') as ch:    
+        config=json.load(ch)     
+        data+="//generated from %s\n"%inFile
+        l=len(config)
+        idx=0
+        if not impl:
+            data+='#include "GwConfigItem.h"\n'
+            data+='class GwConfigDefinitions{\n'
+            data+='  public:\n'
+            data+='  int getNumConfig() const{return %d;}\n'%(l)
+            for item in config:
+                n=item.get('name')
+                if n is None:
+                    continue
+                if len(n) > 15:
+                    raise Exception("%s: config names must be max 15 caracters"%n)
+                data+='  static constexpr const char* %s="%s";\n'%(n,n)
+            data+="};\n"
+        else:
+            data+='void GwConfigHandler::populateConfigs(GwConfigInterface **config){\n'
+            for item in config:
+                name=item.get('name')
+                if name is None:
+                    continue
+                data+='  configs[%d]='%(idx)
+                idx+=1
+                secret="false";
+                if item.get('type') == 'password':
+                    secret="true"
+                data+="     new GwConfigInterface(%s,\"%s\",%s);\n"%(name,item.get('default'),secret)
+            data+='}\n'  
+    writeFileIfChanged(outFile,data)    
+                    
+def labelFilter(label):
+    return re.sub("[^a-zA-Z0-9]","",re.sub("\([0-9]*\)","",label))    
+def generateXdrMappings(fp,oh,inFile=''):
+    jdoc=json.load(fp)
+    oh.write("static GwXDRTypeMapping* typeMappings[]={\n")
+    first=True
+    for cat in jdoc:
+        item=jdoc[cat]
+        cid=item.get('id')
+        if cid is None:
+            continue
+        tc=item.get('type')
+        if tc is not None:
+            if first:
+                first=False
+            else:
+                oh.write(",\n")
+            oh.write("   new GwXDRTypeMapping(%d,0,%d) /*%s*/"%(cid,tc,cat))
+        fields=item.get('fields')
+        if fields is None:
+            continue
+        idx=0
+        for fe in fields:
+            if not isinstance(fe,dict):
+                continue
+            tc=fe.get('t')
+            id=fe.get('v')
+            if id is None:
+                id=idx
+            idx+=1
+            l=fe.get('l') or ''
+            if tc is None or id is None:
+                continue
+            if first:
+                first=False
+            else:
+                oh.write(",\n")
+            oh.write("   new GwXDRTypeMapping(%d,%d,%d) /*%s:%s*/"%(cid,id,tc,cat,l))
+    oh.write("\n")
+    oh.write("};\n")
+    for cat in jdoc:
+        item=jdoc[cat]
+        cid=item.get('id')
+        if cid is None:
+            continue
+        selectors=item.get('selector')
+        if selectors is not None:
+            for selector in selectors:
+                label=selector.get('l')
+                value=selector.get('v')
+                if label is not None and value is not None:
+                    label=labelFilter(label)
+                    define=("GWXDRSEL_%s_%s"%(cat,label)).upper()
+                    oh.write("    #define %s %s\n"%(define,value))
+        fields=item.get('fields')
+        if fields is not None:
+            idx=0
+            for field in fields:
+                v=field.get('v')
+                if v is None:
+                    v=idx
+                else:
+                    v=int(v)
+                label=field.get('l')
+                if v is not None and label is not None:
+                    define=("GWXDRFIELD_%s_%s"%(cat,labelFilter(label))).upper();
+                    oh.write("    #define %s %s\n"%(define,str(v)))
+                idx+=1
+
+class Grove:
+    def __init__(self,name) -> None:
+        self.name=name
+    def _ss(self,z=False):
+        if z:
+            return self.name
+        return self.name if self.name is not 'Z' else ''
+    def _suffix(self):
+        return '_'+self.name if self.name is not 'Z' else ''
+    def replace(self,line):
+        if line is None:
+            return line
+        return line.replace('$G$',self._ss()).replace('$Z$',self._ss(True)).replace('$GS$',self._suffix())
+def generateGroveDefs(inh,outh,inFile=''):
+    GROVES=[Grove('Z'),Grove('A'),Grove('B'),Grove('C')]
+    definition=[]
+    started=False
+    def writeConfig():
+        for grove in GROVES:        
+            for cl in definition:
+                outh.write(grove.replace(cl))
+
+    for line in inh:
+        if re.match(" *#GROVE",line):
+            started=True
+            if len(definition) > 0:
+                writeConfig()
+            definition=[]
+            continue
+        if started:
+            definition.append(line)
+    if len(definition) > 0:
+        writeConfig()
+
+
+
+userTaskDirs=[]
+
+def getUserTaskDirs():
+    rt=[]
+    taskdirs=glob.glob(os.path.join( basePath(),'lib','*task*'))
+    for task in taskdirs:
+        rt.append(task)
+    return rt
+
+def checkAndAdd(file,names,ilist):
+    if not file.endswith('.h'):
+        return
+    match=False
+    for cmp in names:
+        #print("##check %s<->%s"%(f.lower(),cmp))
+        if file.lower() == cmp:
+            match=True
+    if not match:
+        return
+    ilist.append(file) 
+def genereateUserTasks(outfile):
+    includes=[]
+    for task in userTaskDirs:
+        #print("##taskdir=%s"%task)
+        base=os.path.basename(task)
+        includeNames=[base.lower()+".h",'gw'+base.lower()+'.h']
+        for f in os.listdir(task):
+            checkAndAdd(f,includeNames,includes)
+    includeData=""
+    for i in includes:
+        print("#task include %s"%i)
+        includeData+="#include <%s>\n"%i
+    writeFileIfChanged(outfile,includeData)            
+
+def generateEmbedded(elist,outFile):
+    content=""
+    for entry in elist:
+        content+="EMBED_GZ_FILE(\"%s\",%s,\"%s\");\n"%entry
+    writeFileIfChanged(outFile,content)    
+
+def getContentType(fn):
+    if (fn.endswith('.gz')):
+        fn=fn[0:-3]
+    if (fn.endswith('html')):
+        return "text/html"
+    if (fn.endswith('json')):
+        return "application/json"
+    if (fn.endswith('js')):
+        return "text/javascript"
+    if (fn.endswith('css')):    
+        return "text/css"
+    return "application/octet-stream"
+
+
+def getLibs():
+    base=os.path.join(basePath(),"lib")
+    rt=[]
+    for sd in os.listdir(base):
+        if sd == '..':
+            continue
+        if sd == '.':
+            continue
+        fn=os.path.join(base,sd)
+        if os.path.isdir(fn):
+            rt.append(sd)
+    EXTRAS=['generated']
+    for e in EXTRAS:
+        if not e in rt:
+            rt.append(e)
+    return rt
+
+
+
+def joinFiles(target,pattern,dirlist):
+    flist=[]
+    for dir in dirlist:
+            fn=os.path.join(dir,pattern)
+            if os.path.exists(fn):
+                flist.append(fn)
+    current=False
+    if os.path.exists(target):
+        current=True
+        for f in flist:
+            if not isCurrent(f,target):
+                current=False
+                break
+    if current:
+        print("%s is up to date"%target)
+        return
+    print("creating %s"%target)
+    with gzip.open(target,"wb") as oh:
+        for fn in flist:
+            print("adding %s to %s"%(fn,target))
+            with open(fn,"rb") as rh:
+                shutil.copyfileobj(rh,oh)
+    
+
+OWNLIBS=getLibs()+["FS","WiFi"]
+GLOBAL_INCLUDES=[]
+
+def handleDeps(env):
+    #overwrite the GetProjectConfig
+    #to inject all our libs
+    oldGetProjectConfig=env.GetProjectConfig    
+    def GetProjectConfigX(env):        
+        rt=oldGetProjectConfig()
+        cenv="env:"+env['PIOENV']
+        libs=[]
+        for section,options in rt.as_tuple():
+            if section == cenv:
+                for key,values in options:
+                    if key == 'lib_deps':
+                        libs=values
+    
+        mustUpdate=False
+        for lib in OWNLIBS:
+            if not lib in libs:
+                libs.append(lib)
+                mustUpdate=True
+        if mustUpdate:
+            update=[(cenv,[('lib_deps',libs)])]
+            rt.update(update)
+        return rt
+    env.AddMethod(GetProjectConfigX,"GetProjectConfig")
+    #store the list of all includes after we resolved
+    #the dependencies for our main project
+    #we will use them for all compilations afterwards
+    oldLibBuilder=env.ConfigureProjectLibBuilder
+    def ConfigureProjectLibBuilderX(env):
+        global GLOBAL_INCLUDES
+        project=oldLibBuilder()
+        #print("##ConfigureProjectLibBuilderX")
+        #pprint.pprint(project)
+        if project.depbuilders:
+            #print("##depbuilders %s"%",".join(map(lambda x: x.path,project.depbuilders)))
+            for db in project.depbuilders:
+                idirs=db.get_include_dirs()
+                for id in idirs:
+                    if not id in GLOBAL_INCLUDES:
+                        GLOBAL_INCLUDES.append(id)
+        return project
+    env.AddMethod(ConfigureProjectLibBuilderX,"ConfigureProjectLibBuilder")
+    def injectIncludes(env,node):
+        return env.Object(
+            node,
+            CPPPATH=env["CPPPATH"]+GLOBAL_INCLUDES
+        )
+    env.AddBuildMiddleware(injectIncludes)
+
+
+def prebuild(env):
+    global userTaskDirs
+    print("#prebuild running")
+    if not checkDir():
+        sys.exit(1)
+    ldf_mode=env.GetProjectOption("lib_ldf_mode")
+    if ldf_mode == 'off':
+        print("##ldf off - own dependency handling")
+        handleDeps(env)
+    userTaskDirs=getUserTaskDirs()
+    mergedConfig=os.path.join(outPath(),os.path.basename(CFG_FILE))
+    generateMergedConfig(os.path.join(basePath(),CFG_FILE),mergedConfig,userTaskDirs)
+    compressFile(mergedConfig,mergedConfig+".gz")
+    generateCfg(mergedConfig,os.path.join(outPath(),CFG_INCLUDE),False)
+    generateCfg(mergedConfig,os.path.join(outPath(),CFG_INCLUDE_IMPL),True)
+    joinFiles(os.path.join(outPath(),INDEXJS+".gz"),INDEXJS,["web"]+userTaskDirs)
+    joinFiles(os.path.join(outPath(),INDEXCSS+".gz"),INDEXCSS,["web"]+userTaskDirs)
+    embedded=getEmbeddedFiles(env)
+    filedefs=[]
+    for ef in embedded:
+        print("#checking embedded file %s"%ef)
+        (dn,fn)=os.path.split(ef)
+        pureName=fn
+        if pureName.endswith('.gz'):
+            pureName=pureName[0:-3]
+        ct=getContentType(pureName)
+        usname=ef.replace('/','_').replace('.','_')
+        filedefs.append((pureName,usname,ct))
+        inFile=os.path.join(basePath(),"web",pureName)
+        if os.path.exists(inFile):
+            compressFile(inFile,ef)
+        else:
+            print("#WARNING: infile %s for %s not found"%(inFile,ef))
+    generateEmbedded(filedefs,os.path.join(outPath(),EMBEDDED_INCLUDE))
+    genereateUserTasks(os.path.join(outPath(), TASK_INCLUDE))
+    generateFile(os.path.join(basePath(),XDR_FILE),os.path.join(outPath(),XDR_INCLUDE),generateXdrMappings)
+    generateFile(os.path.join(basePath(),GROVE_CONFIG_IN),os.path.join(outPath(),GROVE_CONFIG),generateGroveDefs,inMode='r')
+    version="dev"+datetime.now().strftime("%Y%m%d")
+    env.Append(CPPDEFINES=[('GWDEVVERSION',version)])
+
+def cleangenerated(source, target, env):
+    od=outPath()
+    if os.path.isdir(od):
+        print("#cleaning up %s"%od)
+        for f in os.listdir(od):
+            if f == "." or f == "..":
+                continue
+            fn=os.path.join(od,f)
+            os.unlink(f)
+
+
+print("#prescript...")
+prebuild(env)
+board="PLATFORM_BOARD_%s"%env["BOARD"].replace("-","_").upper()
+print("Board=#%s#"%board)
+print("BuildFlags=%s"%(" ".join(env["BUILD_FLAGS"])))
+env.Append(
+    LINKFLAGS=[ "-u", "custom_app_desc" ],
+    CPPDEFINES=[(board,"1")]
+)
+#script does not run on clean yet - maybe in the future
+env.AddPostAction("clean",cleangenerated)

lib/aisparser/ais_decoder.cpp

@@ -627,7 +627,7 @@ void AisDecoder::decodeType21(PayloadBuffer &_buffer, unsigned int _uMsgType, in
   }
 
   // decode message fields (binary buffer has to go through all fields, but some fields are not used)
-  auto repeat=_buffer.getUnsignedValue(2);                 // repeatIndicator
+  _buffer.getUnsignedValue(2);                 // repeatIndicator
   auto mmsi = _buffer.getUnsignedValue(30);
   auto aidType = _buffer.getUnsignedValue(5);
   auto name = _buffer.getString(120);
@@ -640,11 +640,11 @@ void AisDecoder::decodeType21(PayloadBuffer &_buffer, unsigned int _uMsgType, in
   auto toStarboard = _buffer.getUnsignedValue(6);
 
   _buffer.getUnsignedValue(4);        // epfd type
-  auto timestamp=_buffer.getUnsignedValue(6);        // timestamp
-  auto offPosition=_buffer.getBoolValue();             // off position
+  _buffer.getUnsignedValue(6);        // timestamp
+  _buffer.getBoolValue();             // off position
   _buffer.getUnsignedValue(8);        // reserved
-  auto raim=_buffer.getBoolValue();             // RAIM
-  auto virtualAton=_buffer.getBoolValue();             // virtual aid
+  _buffer.getBoolValue();             // RAIM
+  _buffer.getBoolValue();             // virtual aid
   _buffer.getBoolValue();             // assigned mode
   _buffer.getUnsignedValue(1);        // spare
 
@@ -654,9 +654,7 @@ void AisDecoder::decodeType21(PayloadBuffer &_buffer, unsigned int _uMsgType, in
     nameExt = _buffer.getString(88);
   }
 
-  onType21(mmsi, aidType, name + nameExt, posAccuracy, posLon, posLat, 
-    toBow, toStern, toPort, toStarboard,
-    repeat,timestamp, raim, virtualAton, offPosition);
+  onType21(mmsi, aidType, name + nameExt, posAccuracy, posLon, posLat, toBow, toStern, toPort, toStarboard);
 }
 
 /* decode Voyage Report and Static Data (type nibble already pulled from buffer) */

lib/aisparser/ais_decoder.h

@@ -297,8 +297,7 @@ namespace AIS
                               bool assigned, unsigned int repeat, bool raim) = 0;
         
         virtual void onType21(unsigned int _uMmsi, unsigned int _uAidType, const std::string &_strName, bool _bPosAccuracy, int _iPosLon, int _iPosLat,
-                              unsigned int _uToBow, unsigned int _uToStern, unsigned int _uToPort, unsigned int _uToStarboard, 
-                              unsigned int repeat,unsigned int timestamp, bool raim, bool virtualAton, bool offPosition) = 0;
+                              unsigned int _uToBow, unsigned int _uToStern, unsigned int _uToPort, unsigned int _uToStarboard) = 0;
         
         virtual void onType24A(unsigned int _uMsgType, unsigned int _repeat, unsigned int _uMmsi, const std::string &_strName) = 0;
         

lib/appinfo/GwAppInfo.h

@@ -14,9 +14,6 @@
 #define LOGLEVEL GwLog::DEBUG
 #endif
 #endif
-#ifdef GWBUILD_NAME
-#define FIRMWARE_TYPE GWSTRINGIFY(GWBUILD_NAME)
-#else
+
 #define FIRMWARE_TYPE GWSTRINGIFY(PIO_ENV_BUILD)
-#endif
 #define IDF_VERSION GWSTRINGIFY(ESP_IDF_VERSION_MAJOR) "." GWSTRINGIFY(ESP_IDF_VERSION_MINOR) "." GWSTRINGIFY(ESP_IDF_VERSION_PATCH)

lib/channel/GwChannel.cpp

@@ -249,16 +249,3 @@ unsigned long GwChannel::countTx(){
     if (! countOut) return 0UL;
     return countOut->getGlobal();
 }
-String GwChannel::typeString(int type){
-    switch (type){
-        case GWSERIAL_TYPE_UNI:
-            return "UNI";
-        case GWSERIAL_TYPE_BI:
-            return "BI";
-        case GWSERIAL_TYPE_RX:
-            return "RX";
-        case GWSERIAL_TYPE_TX:
-            return "TX";
-    }
-    return "UNKNOWN";
-}

lib/channel/GwChannel.h

@@ -77,8 +77,7 @@ class GwChannel{
         if (maxSourceId < 0) return source == sourceId;
         return (source >= sourceId && source <= maxSourceId);
     }
-    static String typeString(int type);
-    String getMode(){return typeString(impl->getType());}
+    String getMode(){return impl->getMode();}
     int getMinId(){return sourceId;};
 };
 

lib/channel/GwChannelInterface.h

@@ -1,11 +1,10 @@
 #pragma once
 #include "GwBuffer.h"
-#include "GwChannelModes.h"
 class GwChannelInterface{
     public:
         virtual void loop(bool handleRead,bool handleWrite)=0;
         virtual void readMessages(GwMessageFetcher *writer)=0;
         virtual size_t sendToClients(const char *buffer, int sourceId, bool partial=false)=0;
         virtual Stream * getStream(bool partialWrites){ return NULL;}
-        virtual int getType(){ return GWSERIAL_TYPE_BI;} //return the numeric type
+        virtual String getMode(){return "UNKNOWN";}
 };

lib/channel/GwChannelList.cpp

@@ -15,10 +15,8 @@ class SerInit{
         int tx=-1;
         int mode=-1;
         int fixedBaud=-1;
-        int ena=-1;
-        int elow=1;
-        SerInit(int s,int r,int t, int m, int b=-1,int en=-1,int el=-1):
-            serial(s),rx(r),tx(t),mode(m),fixedBaud(b),ena(en),elow(el){}
+        SerInit(int s,int r,int t, int m, int b=-1):
+            serial(s),rx(r),tx(t),mode(m),fixedBaud(b){}
 };
 std::vector<SerInit> serialInits;
 
@@ -49,20 +47,11 @@ static int typeFromMode(const char *mode){
 #ifndef GWSERIAL_RX
 #define GWSERIAL_RX -1
 #endif
-#ifndef GWSERIAL_ENA
-#define GWSERIAL_ENA -1
-#endif
-#ifndef GWSERIAL_ELO
-#define GWSERIAL_ELO 0
-#endif
-#ifndef GWSERIAL_BAUD
-#define GWSERIAL_BAUD -1
-#endif
 #ifdef GWSERIAL_TYPE
-    CFG_SERIAL(SERIAL1_CHANNEL_ID, GWSERIAL_RX, GWSERIAL_TX, GWSERIAL_TYPE,GWSERIAL_BAUD,GWSERIAL_ENA,GWSERIAL_ELO)
+    CFG_SERIAL(SERIAL1_CHANNEL_ID, GWSERIAL_RX, GWSERIAL_TX, GWSERIAL_TYPE)
 #else
 #ifdef GWSERIAL_MODE
-CFG_SERIAL(SERIAL1_CHANNEL_ID, GWSERIAL_RX, GWSERIAL_TX, typeFromMode(GWSERIAL_MODE),GWSERIAL_BAUD,GWSERIAL_ENA,GWSERIAL_ELO)
+CFG_SERIAL(SERIAL1_CHANNEL_ID, GWSERIAL_RX, GWSERIAL_TX, typeFromMode(GWSERIAL_MODE))
 #endif
 #endif
     // serial 2
@@ -72,20 +61,11 @@ CFG_SERIAL(SERIAL1_CHANNEL_ID, GWSERIAL_RX, GWSERIAL_TX, typeFromMode(GWSERIAL_M
 #ifndef GWSERIAL2_RX
 #define GWSERIAL2_RX -1
 #endif
-#ifndef GWSERIAL2_ENA
-#define GWSERIAL2_ENA -1
-#endif
-#ifndef GWSERIAL2_ELO
-#define GWSERIAL2_ELO 0
-#endif
-#ifndef GWSERIAL2_BAUD
-#define GWSERIAL2_BAUD -1
-#endif
 #ifdef GWSERIAL2_TYPE
-    CFG_SERIAL(SERIAL2_CHANNEL_ID, GWSERIAL2_RX, GWSERIAL2_TX, GWSERIAL2_TYPE,GWSERIAL2_BAUD,GWSERIAL2_ENA,GWSERIAL2_ELO)
+    CFG_SERIAL(SERIAL2_CHANNEL_ID, GWSERIAL2_RX, GWSERIAL2_TX, GWSERIAL2_TYPE)
 #else
 #ifdef GWSERIAL2_MODE
-CFG_SERIAL(SERIAL2_CHANNEL_ID, GWSERIAL2_RX, GWSERIAL2_TX, typeFromMode(GWSERIAL2_MODE),GWSERIAL2_BAUD,GWSERIAL2_ENA,GWSERIAL2_ELO)
+CFG_SERIAL(SERIAL2_CHANNEL_ID, GWSERIAL2_RX, GWSERIAL2_TX, typeFromMode(GWSERIAL2_MODE))
 #endif
 #endif
     class GwSerialLog : public GwLogWriter
@@ -305,8 +285,8 @@ static  ChannelParam channelParameters[]={
 };
 
 template<typename T>
-GwSerial* createSerial(GwLog *logger, T* s,int id, int type, bool canRead=true){
-    return new GwSerialImpl<T>(logger,s,id,type,canRead);
+GwSerial* createSerial(GwLog *logger, T* s,int id, bool canRead=true){
+    return new GwSerialImpl<T>(logger,s,id,canRead);
 } 
 
 static ChannelParam * findChannelParam(int id){
@@ -320,7 +300,7 @@ static ChannelParam * findChannelParam(int id){
     return param;
 }
 
-static GwSerial * createSerialImpl(GwConfigHandler *config,GwLog *logger, int idx,int type,int rx,int tx, bool setLog,int ena=-1,int elow=1){
+static GwSerial * createSerialImpl(GwConfigHandler *config,GwLog *logger, int idx,int rx,int tx, bool setLog=false){
     LOG_DEBUG(GwLog::DEBUG,"create serial: channel=%d, rx=%d,tx=%d",
         idx,rx,tx);
     ChannelParam *param=findChannelParam(idx);
@@ -332,45 +312,19 @@ static GwSerial * createSerialImpl(GwConfigHandler *config,GwLog *logger, int id
     GwLog *streamLog=setLog?nullptr:logger;
     switch(param->id){
         case USB_CHANNEL_ID:
-            serialStream=createSerial(streamLog,&USBSerial,param->id,type);
+            serialStream=createSerial(streamLog,&USBSerial,param->id);
             break;
         case SERIAL1_CHANNEL_ID:
-            serialStream=createSerial(streamLog,&Serial1,param->id,type);
+            serialStream=createSerial(streamLog,&Serial1,param->id);
             break;
         case SERIAL2_CHANNEL_ID:
-            serialStream=createSerial(streamLog,&Serial2,param->id,type);
+            serialStream=createSerial(streamLog,&Serial2,param->id);
             break;
     }
     if (serialStream == nullptr){
         LOG_DEBUG(GwLog::ERROR,"invalid serial config with id %d",param->id);
         return nullptr;
     }
-    if (ena >= 0){
-        int value=-1;
-        if (type == GWSERIAL_TYPE_UNI){
-            String cfgMode=config->getString(param->direction);
-            if (cfgMode == "send"){
-                value=elow?0:1;
-            } 
-            else{
-               value=elow?1:0;
-            }
-        }
-        if (type == GWSERIAL_TYPE_RX){
-            value=elow?1:0;
-        }
-        if (type == GWSERIAL_TYPE_TX){
-            value=elow?0:1;
-        }
-        if (value >= 0){
-             LOG_DEBUG(GwLog::LOG,"serial %d: setting output enable %d to %d",param->id,ena,value);
-             pinMode(ena,OUTPUT); 
-             digitalWrite(ena,value); 
-        }
-        else{
-            LOG_DEBUG(GwLog::ERROR,"serial %d: output enable ignored for mode %d",param->id, type);
-        }
-    }
     serialStream->begin(config->getInt(param->baud,115200),SERIAL_8N1,rx,tx);
     if (setLog){
         logger->setWriter(new GwSerialLog(serialStream,config->getBool(param->preventLog,false)));
@@ -378,13 +332,12 @@ static GwSerial * createSerialImpl(GwConfigHandler *config,GwLog *logger, int id
     }
     return serialStream;
 }
-static GwChannel * createChannel(GwLog *logger, GwConfigHandler *config, int id,GwChannelInterface *impl){
+static GwChannel * createChannel(GwLog *logger, GwConfigHandler *config, int id,GwChannelInterface *impl, int type=GWSERIAL_TYPE_BI){
     ChannelParam *param=findChannelParam(id);
     if (param == nullptr){
         LOG_DEBUG(GwLog::ERROR,"invalid channel id %d",id);
         return nullptr;
     }
-    int type=impl->getType();
     bool canRead=false;
     bool canWrite=false;
     bool validType=false;
@@ -472,10 +425,10 @@ void GwChannelList::begin(bool fallbackSerial){
     GwChannel *channel=NULL;
     //usb
     if (! fallbackSerial){
-        GwSerial *usbSerial=createSerialImpl(config, logger,USB_CHANNEL_ID,GWSERIAL_TYPE_BI,GWUSB_RX,GWUSB_TX,true);
+        GwSerial *usbSerial=createSerialImpl(config, logger,USB_CHANNEL_ID,GWUSB_RX,GWUSB_TX,true);
         if (usbSerial != nullptr){
             usbSerial->enableWriteLock(); //as it is used for logging we need this additionally
-            GwChannel *usbChannel=createChannel(logger,config,USB_CHANNEL_ID,usbSerial);
+            GwChannel *usbChannel=createChannel(logger,config,USB_CHANNEL_ID,usbSerial,GWSERIAL_TYPE_BI);
             if (usbChannel != nullptr){
                 addChannel(usbChannel);
             }
@@ -491,11 +444,10 @@ void GwChannelList::begin(bool fallbackSerial){
 
     //new serial config handling
     for (auto &&init:serialInits){
-        LOG_INFO("creating serial channel %d, rx=%d,tx=%d,type=%d fixedBaud=%d ena=%d elow=%d",
-            init.serial,init.rx,init.tx,init.mode,init.fixedBaud,init.ena,init.elow);
-        GwSerial *ser=createSerialImpl(config,logger,init.serial,init.mode,init.rx,init.tx,false,init.ena,init.elow);
+        LOG_INFO("creating serial channel %d, rx=%d,tx=%d,type=%d",init.serial,init.rx,init.tx,init.mode);
+        GwSerial *ser=createSerialImpl(config,logger,init.serial,init.rx,init.tx);
         if (ser != nullptr){
-            channel=createChannel(logger,config,init.serial,ser);
+            channel=createChannel(logger,config,init.serial,ser,init.mode);
             if (channel != nullptr){
                 addChannel(channel);
             }
@@ -514,8 +466,8 @@ void GwChannelList::begin(bool fallbackSerial){
             config->getInt(config->remotePort),
             config->getBool(config->readTCL)
         );
-        addChannel(createChannel(logger,config,TCP_CLIENT_CHANNEL_ID,client));
     }
+    addChannel(createChannel(logger,config,TCP_CLIENT_CHANNEL_ID,client));
 
     //udp writer
     if (config->getBool(GwConfigDefinitions::udpwEnabled)){

lib/config/GwConverterConfig.h

@@ -3,7 +3,7 @@
   This code is free software; you can redistribute it and/or
   modify it under the terms of the GNU Lesser General Public
   License as published by the Free Software Foundation; either
-  version 2 of the License, or (at your option) any later version.
+  version 2.1 of the License, or (at your option) any later version.
   This code is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU

lib/exampletask/Readme.md

@@ -57,44 +57,6 @@ Files
      
      Starting from Version 20250305 you should normally not use this file name any more as those styles would be added for all build environments. Instead define a parameter _custom_css_ in your [platformio.ini](platformio.ini) for the environments you would like to add some styles for. This parameter accepts a list of file names (relative to the project root, separated by , or as multi line entry)
 
-   * [script.py](script.py)<br>
-     Starting from version 20251007 you can define a parameter "custom_script" in your [platformio.ini](platformio.ini).
-     This parameter can contain a list of file names (relative to the project root) that will be added as a [platformio extra script](https://docs.platformio.org/en/latest/scripting/index.html#scripting). The scripts will be loaded at the end of the main [extra_script](../../extra_script.py).
-     You can add code there that is specific for your build.
-     Example:
-     ```
-      # PlatformIO extra script for obp60task
-      epdtype = "unknown"
-      pcbvers = "unknown"
-      for x in env["BUILD_FLAGS"]:
-          if x.startswith("-D HARDWARE_"):
-              pcbvers = x.split('_')[1]
-          if x.startswith("-D DISPLAY_"):
-              epdtype = x.split('_')[1]
-
-      propfilename = os.path.join(env["PROJECT_LIBDEPS_DIR"], env     ["PIOENV"], "GxEPD2/library.properties")
-      properties = {}
-      with open(propfilename, 'r') as file:
-          for line in file:
-              match = re.match(r'^([^=]+)=(.*)$', line)
-              if match:
-                  key = match.group(1).strip()
-                  value = match.group(2).strip()
-                  properties[key] = value
-
-      gxepd2vers = "unknown"
-      try:
-          if properties["name"] == "GxEPD2":
-              gxepd2vers = properties["version"]
-      except:
-          pass
-
-      env["CPPDEFINES"].extend([("BOARD", env["BOARD"]), ("EPDTYPE",      epdtype), ("PCBVERS", pcbvers), ("GXEPD2VERS", gxepd2vers)])
-
-      print("added hardware info to CPPDEFINES")
-      print("friendly board name is '{}'".format(env.GetProjectOption     ("board_name")))
-     ```
-
 
  Interfaces
  ----------

lib/exampletask/platformio.ini

@@ -14,6 +14,5 @@ custom_config=
     lib/exampletask/exampleConfig.json
 custom_js=lib/exampletask/example.js
 custom_css=lib/exampletask/example.css
-custom_script=lib/exampletask/script.py
 upload_port = /dev/esp32
 upload_protocol = esptool    

lib/exampletask/script.py

@@ -1,4 +0,0 @@
-Import("env")
-
-print("exampletask extra script running")
-syntax error here

lib/hardware/GwChannelModes.h

@@ -1,23 +0,0 @@
-/*
-  This code is free software; you can redistribute it and/or
-  modify it under the terms of the GNU Lesser General Public
-  License as published by the Free Software Foundation; either
-  version 2 of the License, or (at your option) any later version.
-  This code is distributed in the hope that it will be useful,
-  but WITHOUT ANY WARRANTY; without even the implied warranty of
-  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-  Lesser General Public License for more details.
-  You should have received a copy of the GNU Lesser General Public
-  License along with this library; if not, write to the Free Software
-  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-
-  defines for the channel modes(types)
-*/
-#ifndef _GWCHANNELMODES_H
-#define _GWCHANNELMODES_H
-#define GWSERIAL_TYPE_UNI 1
-#define GWSERIAL_TYPE_BI 2
-#define GWSERIAL_TYPE_RX 3
-#define GWSERIAL_TYPE_TX 4
-#define GWSERIAL_TYPE_UNK 0
-#endif

lib/hardware/GwHardware.h

@@ -2,7 +2,7 @@
   This code is free software; you can redistribute it and/or
   modify it under the terms of the GNU Lesser General Public
   License as published by the Free Software Foundation; either
-  version 2 of the License, or (at your option) any later version.
+  version 2.1 of the License, or (at your option) any later version.
   This code is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
@@ -20,7 +20,11 @@
 #endif
 #ifndef _GWHARDWARE_H
 #define _GWHARDWARE_H
-#include "GwChannelModes.h"
+#define GWSERIAL_TYPE_UNI 1
+#define GWSERIAL_TYPE_BI 2
+#define GWSERIAL_TYPE_RX 3
+#define GWSERIAL_TYPE_TX 4
+#define GWSERIAL_TYPE_UNK 0
 #include <GwConfigItem.h>
 #include <HardwareSerial.h>
 #include "GwAppInfo.h"

lib/hardware/GwM5Base.h

@@ -2,7 +2,7 @@
   This code is free software; you can redistribute it and/or
   modify it under the terms of the GNU Lesser General Public
   License as published by the Free Software Foundation; either
-  version 2 of the License, or (at your option) any later version.
+  version 2.1 of the License, or (at your option) any later version.
   This code is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
@@ -35,12 +35,7 @@
 #ifdef M5_GPS_KIT
   GWRESOURCE_USE(BASE,M5_GPS_KIT)
   GWRESOURCE_USE(SERIAL1,M5_GPS_KIT)
-  #define _GWI_SERIAL1 BOARD_LEFT1,-1,GWSERIAL_TYPE_RX,9600
-#endif
-#ifdef M5_GPSV2_KIT
-  GWRESOURCE_USE(BASE,M5_GPSV2_KIT)
-  GWRESOURCE_USE(SERIAL1,M5_GPSV2_KIT)
-  #define _GWI_SERIAL1 BOARD_LEFT1,-1,GWSERIAL_TYPE_RX,115200
+  #define _GWI_SERIAL1 BOARD_LEFT1,-1,GWSERIAL_TYPE_UNI,9600
 #endif
 
 //M5 ProtoHub
@@ -66,7 +61,7 @@
 #endif
 
 //can kit for M5 Atom
-#if defined (M5_CAN_KIT) 
+#ifdef M5_CAN_KIT
   GWRESOURCE_USE(BASE,M5_CAN_KIT)
   GWRESOURCE_USE(CAN,M5_CANKIT)
   #define ESP32_CAN_TX_PIN BOARD_LEFT1

lib/hardware/GwM5Grove.h

@@ -2,7 +2,7 @@
   This code is free software; you can redistribute it and/or
   modify it under the terms of the GNU Lesser General Public
   License as published by the Free Software Foundation; either
-  version 2 of the License, or (at your option) any later version.
+  version 2.1 of the License, or (at your option) any later version.
   This code is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU

lib/hardware/GwM5Grove.in

@@ -2,7 +2,7 @@
   This code is free software; you can redistribute it and/or
   modify it under the terms of the GNU Lesser General Public
   License as published by the Free Software Foundation; either
-  version 2 of the License, or (at your option) any later version.
+  version 2.1 of the License, or (at your option) any later version.
   This code is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
@@ -43,13 +43,6 @@
   #define _GWI_SERIAL_GROOVE$GS$ GWSERIAL_TYPE_RX,9600
 #endif
 
-#GROVE
-//https://docs.m5stack.com/en/unit/Unit-GPS%20v1.1
-#ifdef M5_GPSV11_UNIT$GS$
-  GWRESOURCE_USE(GROOVE$G$,M5_GPSV11_UNIT$GS$)
-  #define _GWI_SERIAL_GROOVE$GS$ GWSERIAL_TYPE_RX,115200
-#endif
-
 #GROVE
 //CAN via groove 
 #ifdef M5_CANUNIT$GS$
@@ -71,15 +64,15 @@
 #endif
 
 #GROVE
-#ifdef M5_ENV4$GS$
-  #ifndef M5_GROOVEIIC$GS$
-    #define M5_GROOVEIIC$GS$
-  #endif
-  GROOVE_IIC(SHT4X,$Z$,1)
-  GROOVE_IIC(BMP280,$Z$,1)
-  #define _GWSHT4X
-  #define _GWBMP280
-#endif
+//#ifdef M5_ENV4$GS$
+//  #ifndef M5_GROOVEIIC$GS$
+//    #define M5_GROOVEIIC$GS$
+//  #endif
+//  GROOVE_IIC(SHT3X,$Z$,1)
+//  GROOVE_IIC(BMP280,$Z$,1)
+//  #define _GWSHT3X
+//  #define _GWBMP280
+//#endif
 
 #GROVE
 //example: -DSHT3XG1_A : defines STH3Xn1 on grove A - x depends on the other devices
@@ -100,25 +93,6 @@
   #define _GWSHT3X
 #endif
 
-#GROVE
-//example: -DSHT4XG1_A : defines STH4Xn1 on grove A - x depends on the other devices
-#ifdef GWSHT4XG1$GS$
-  #ifndef M5_GROOVEIIC$GS$
-    #define M5_GROOVEIIC$GS$
-  #endif
-  GROOVE_IIC(SHT4X,$Z$,1)
-  #define _GWSHT4X
-#endif
-
-#GROVE
-#ifdef GWSHT4XG2$GS$
-  #ifndef M5_GROOVEIIC$GS$
-    #define M5_GROOVEIIC$GS$
-  #endif
-  GROOVE_IIC(SHT4X,$Z$,2)
-  #define _GWSHT4X
-#endif
-
 #GROVE
 #ifdef GWQMP6988G1$GS$
   #ifndef M5_GROOVEIIC$GS$

lib/iictask/GwBME280.cpp

@@ -23,7 +23,6 @@ class BME280Config : public IICSensorBase{
     bool prAct=true;
     bool tmAct=true;
     bool huAct=true;
-    bool sEnv=true;
     tN2kTempSource tmSrc=tN2kTempSource::N2kts_InsideTemperature;
     tN2kHumiditySource huSrc=tN2kHumiditySource::N2khs_InsideHumidity;
     tN2kPressureSource prSrc=tN2kPressureSource::N2kps_Atmospheric;
@@ -153,7 +152,6 @@ SensorBase::Creator registerBME280(GwApi *api){
     CFG_SGET(s, prNam, prefix);       \
     CFG_SGET(s, tmOff, prefix);       \
     CFG_SGET(s, prOff, prefix);       \
-    CFG_SGET(s, sEnv, prefix);        \
     s->busId = bus;                   \
     s->addr = baddr;                  \
     s->ok = true;                     \

lib/iictask/GwBMP280.cpp

@@ -29,7 +29,6 @@ class BMP280Config : public IICSensorBase{
     public:
     bool prAct=true;
     bool tmAct=true;
-    bool sEnv=true;
     tN2kTempSource tmSrc=tN2kTempSource::N2kts_InsideTemperature;
     tN2kPressureSource prSrc=tN2kPressureSource::N2kps_Atmospheric;
     tN2kHumiditySource huSrc=tN2kHumiditySource::N2khs_Undef;
@@ -151,7 +150,6 @@ SensorBase::Creator registerBMP280(GwApi *api){
     CFG_SGET(s, prNam, prefix);           \
     CFG_SGET(s, tmOff, prefix);           \
     CFG_SGET(s, prOff, prefix);           \
-    CFG_SGET(s, sEnv,prefix);           \
     s->busId = bus;                       \
     s->addr = baddr;                      \
     s->ok = true;                         \

lib/iictask/GwIicSensors.h

@@ -104,19 +104,12 @@ void sendN2kTemperature(GwApi *api,CFG &cfg,double value, int counterId){
 
 template <class CFG>
 void sendN2kEnvironmentalParameters(GwApi *api,CFG &cfg,double tmValue, double huValue, double prValue, int counterId){
-    if (! cfg.sEnv) return;
     tN2kMsg msg;
     SetN2kEnvironmentalParameters(msg,1,cfg.tmSrc,tmValue,cfg.huSrc,huValue,prValue);
     api->sendN2kMessage(msg);
-    if (huValue != N2kDoubleNA){
-        api->increment(counterId,cfg.prefix+String("ehum"));
-    }
-    if (prValue != N2kDoubleNA){
-        api->increment(counterId,cfg.prefix+String("epress"));
-    }
-    if (tmValue != N2kDoubleNA){
-        api->increment(counterId,cfg.prefix+String("etemp"));
-    }
+    api->increment(counterId,cfg.prefix+String("hum"));
+    api->increment(counterId,cfg.prefix+String("press"));
+    api->increment(counterId,cfg.prefix+String("temp"));
 }
 
 #ifndef _GWI_IIC1

lib/iictask/GwIicTask.cpp

@@ -23,7 +23,7 @@ static std::vector<IICGrove> iicGroveList;
 #include "GwBME280.h"
 #include "GwBMP280.h"
 #include "GwQMP6988.h"
-#include "GwSHTXX.h"
+#include "GwSHT3X.h"
 #include <map>
 
 #include "GwTimer.h"
@@ -91,7 +91,6 @@ void initIicTask(GwApi *api){
     GwConfigHandler *config=api->getConfig();
     std::vector<SensorBase::Creator> creators;
     creators.push_back(registerSHT3X(api));
-    creators.push_back(registerSHT4X(api));
     creators.push_back(registerQMP6988(api));
     creators.push_back(registerBME280(api));
     creators.push_back(registerBMP280(api));
@@ -148,13 +147,13 @@ bool initWire(GwLog *logger, TwoWire &wire, int num){
         #ifdef _GWI_IIC1
             return initWireDo(logger,wire,num,_GWI_IIC1);
         #endif
-        return initWireDo(logger,wire,num,"",GWIIC_SCL,GWIIC_SDA);
+        return initWireDo(logger,wire,num,"",GWIIC_SDA,GWIIC_SCL);
     }
     if (num == 2){
         #ifdef _GWI_IIC2
             return initWireDo(logger,wire,num,_GWI_IIC2);
         #endif
-        return initWireDo(logger,wire,num,"",GWIIC_SCL2,GWIIC_SDA2);
+        return initWireDo(logger,wire,num,"",GWIIC_SDA2,GWIIC_SCL2);
     }
     return false;
 }

lib/iictask/GwQMP6988.cpp

@@ -9,9 +9,6 @@ class QMP6988Config : public IICSensorBase{
     public:
         String prNam="Pressure";
         bool prAct=true;
-        bool sEnv=true;
-        tN2kTempSource tmSrc=tN2kTempSource::N2kts_InsideTemperature;
-        tN2kHumiditySource huSrc=tN2kHumiditySource::N2khs_Undef;
         tN2kPressureSource prSrc=tN2kPressureSource::N2kps_Atmospheric;
         float prOff=0;
         QMP6988 *device=nullptr;
@@ -42,7 +39,6 @@ class QMP6988Config : public IICSensorBase{
             float computed=pressure+prOff;
             LOG_DEBUG(GwLog::DEBUG,"%s measure %2.0fPa, computed %2.0fPa",prefix.c_str(), pressure,computed);
             sendN2kPressure(api,*this,computed,counterId);
-            sendN2kEnvironmentalParameters(api,*this,N2kDoubleNA,N2kDoubleNA,computed,counterId);
         }
         
         
@@ -94,7 +90,6 @@ SensorBase::Creator registerQMP6988(GwApi *api){
             CFG_SGET(s,prAct,prefix); \
             CFG_SGET(s,intv,prefix); \
             CFG_SGET(s,prOff,prefix); \
-            CFG_SGET(s,sEnv,prefix); \
             s->busId = bus;                       \
             s->addr = baddr;                      \
             s->ok = true;                         \

lib/iictask/GwSHT3X.cpp

@@ -0,0 +1,138 @@
+#include "GwSHT3X.h"
+#ifdef _GWSHT3X
+class SHT3XConfig;
+static GwSensorConfigInitializerList<SHT3XConfig> configs;
+class SHT3XConfig : public IICSensorBase{
+    public:
+    String tmNam;
+    String huNam;
+    bool tmAct=false;
+    bool huAct=false;
+    tN2kHumiditySource huSrc;
+    tN2kTempSource tmSrc;
+    SHT3X *device=nullptr;
+    using IICSensorBase::IICSensorBase;
+    virtual bool isActive(){
+        return tmAct || huAct;
+    }
+    virtual bool initDevice(GwApi * api,TwoWire *wire){
+        if (! isActive()) return false;
+        device=new SHT3X();
+        device->init(addr,wire);
+        GwLog *logger=api->getLogger();
+        LOG_DEBUG(GwLog::LOG,"initialized %s at address %d, intv %ld",prefix.c_str(),(int)addr,intv);
+        return true;
+    }
+    virtual bool preinit(GwApi * api){
+        GwLog *logger=api->getLogger();
+        LOG_DEBUG(GwLog::LOG,"%s configured",prefix.c_str());
+        addHumidXdr(api,*this);
+        addTempXdr(api,*this);
+        return isActive();
+    }
+    virtual void measure(GwApi * api,TwoWire *wire, int counterId)
+    {
+        if (!device)
+            return;
+        GwLog *logger=api->getLogger();    
+        int rt = 0;
+        if ((rt = device->get()) == 0)
+        {
+            double temp = device->cTemp;
+            temp = CToKelvin(temp);
+            double humid = device->humidity;
+            LOG_DEBUG(GwLog::DEBUG, "%s measure temp=%2.1f, humid=%2.0f",prefix.c_str(), (float)temp, (float)humid);
+            if (huAct)
+            {
+                sendN2kHumidity(api, *this, humid, counterId);
+            }
+            if (tmAct)
+            {
+                sendN2kTemperature(api, *this, temp, counterId);
+            }
+        }
+        else
+        {
+            LOG_DEBUG(GwLog::DEBUG, "unable to query %s: %d",prefix.c_str(), rt);
+        }
+    }
+    
+    virtual void readConfig(GwConfigHandler *cfg){
+        if (ok) return;
+        configs.readConfig(this,cfg);
+        return;
+    }
+};
+SensorBase::Creator creator=[](GwApi *api,const String &prfx)-> SensorBase*{
+    if (! configs.knowsPrefix(prfx)) return nullptr;
+    return new SHT3XConfig(api,prfx);
+};
+SensorBase::Creator registerSHT3X(GwApi *api){
+    GwLog *logger=api->getLogger();
+    #if defined(GWSHT3X) || defined (GWSHT3X11)
+    {
+        api->addSensor(creator(api,"SHT3X11"));
+        CHECK_IIC1();
+        #pragma message "GWSHT3X11 defined"
+    }
+    #endif
+    #if defined(GWSHT3X12)
+    {
+        api->addSensor(creator(api,"SHT3X12"));
+        CHECK_IIC1();
+        #pragma message "GWSHT3X12 defined"
+    }
+    #endif
+    #if defined(GWSHT3X21)
+    {
+        api->addSensor(creator(api,"SHT3X21"));
+        CHECK_IIC2();
+        #pragma message "GWSHT3X21 defined"
+    }
+    #endif
+    #if defined(GWSHT3X22)
+    {
+        api->addSensor(creator(api,"SHT3X22"));
+        CHECK_IIC2();
+        #pragma message "GWSHT3X22 defined"
+    }
+    #endif
+    return creator;
+};
+
+/**
+ * we do not dynamically compute the config names
+ * just to get compile time errors if something does not fit
+ * correctly
+ */
+#define CFGSHT3X(s, prefix, bus, baddr) \
+    CFG_SGET(s, tmNam, prefix);         \
+    CFG_SGET(s, huNam, prefix);         \
+    CFG_SGET(s, iid, prefix);           \
+    CFG_SGET(s, tmAct, prefix);         \
+    CFG_SGET(s, huAct, prefix);         \
+    CFG_SGET(s, intv, prefix);          \
+    CFG_SGET(s, huSrc, prefix);         \
+    CFG_SGET(s, tmSrc, prefix);         \
+    s->busId = bus;                     \
+    s->addr = baddr;                    \
+    s->ok = true;                       \
+    s->intv *= 1000;
+
+#define SCSHT3X(prefix, bus, addr) \
+    GWSENSORDEF(configs, SHT3XConfig, CFGSHT3X, prefix, bus, addr)
+
+SCSHT3X(SHT3X11, 1, 0x44);
+SCSHT3X(SHT3X12, 1, 0x45);
+SCSHT3X(SHT3X21, 2, 0x44);
+SCSHT3X(SHT3X22, 2, 0x45);
+
+#else
+SensorBase::Creator registerSHT3X(GwApi *api){
+    return SensorBase::Creator();
+}
+
+#endif
+
+
+

lib/iictask/GwSHT3X.h

@@ -1,13 +1,10 @@
-#ifndef _GWSHTXX_H
-#define _GWSHTXX_H
+#ifndef _GWSHT3X_H
+#define _GWSHT3X_H
 #include "GwIicSensors.h"
 #ifdef _GWIIC
     #if defined(GWSHT3X) || defined(GWSHT3X11) || defined(GWSHT3X12) || defined(GWSHT3X21) || defined(GWSHT3X22)
         #define _GWSHT3X
     #endif
-    #if defined(GWSHT4X) || defined(GWSHT4X11) || defined(GWSHT4X12) || defined(GWSHT4X21) || defined(GWSHT4X22)
-        #define _GWSHT4X
-    #endif
 #else
     #undef _GWSHT3X
     #undef GWSHT3X
@@ -15,19 +12,9 @@
     #undef GWSHT3X12
     #undef GWSHT3X21
     #undef GWSHT3X22
-    #undef _GWSHT4X
-    #undef GWSHT4X
-    #undef GWSHT4X11
-    #undef GWSHT4X12
-    #undef GWSHT4X21
-    #undef GWSHT4X22
 #endif
 #ifdef _GWSHT3X
     #include "SHT3X.h"
 #endif
-#ifdef _GWSHT4X
-    #include "SHT4X.h"
-#endif
 SensorBase::Creator registerSHT3X(GwApi *api);
-SensorBase::Creator registerSHT4X(GwApi *api);
 #endif

lib/iictask/GwSHTXX.cpp

@@ -1,254 +0,0 @@
-#include "GwSHTXX.h"
-#if defined(_GWSHT3X) || defined(_GWSHT4X)
-class SHTXXConfig : public IICSensorBase{
-    public:
-    String tmNam;
-    String huNam;
-    bool tmAct=false;
-    bool huAct=false;
-    bool sEnv=true;
-    tN2kHumiditySource huSrc;
-    tN2kTempSource tmSrc;
-    using IICSensorBase::IICSensorBase;
-    virtual bool isActive(){
-        return tmAct || huAct;
-    }
-    virtual bool preinit(GwApi * api){
-        GwLog *logger=api->getLogger();
-        LOG_DEBUG(GwLog::LOG,"%s configured",prefix.c_str());
-        addHumidXdr(api,*this);
-        addTempXdr(api,*this);
-        return isActive();
-    }
-    virtual bool doMeasure(GwApi * api,double &temp, double &humid){
-        return false;
-    }
-    virtual void measure(GwApi * api,TwoWire *wire, int counterId) override
-    {
-        GwLog *logger=api->getLogger();    
-        double temp = N2kDoubleNA;
-        double humid = N2kDoubleNA;
-        if (doMeasure(api,temp,humid)){
-            temp = CToKelvin(temp);
-            LOG_DEBUG(GwLog::DEBUG, "%s measure temp=%2.1f, humid=%2.0f",prefix.c_str(), (float)temp, (float)humid);
-            if (huAct)
-            {
-                sendN2kHumidity(api, *this, humid, counterId);
-            }
-            if (tmAct)
-            {
-                sendN2kTemperature(api, *this, temp, counterId);
-            }
-            if (huAct || tmAct){
-                sendN2kEnvironmentalParameters(api,*this,temp,humid,N2kDoubleNA,counterId);   
-            }
-        }
-    }
-    
-};
-/**
- * we do not dynamically compute the config names
- * just to get compile time errors if something does not fit
- * correctly
- */
-#define INITSHTXX(type,prefix,bus,baddr) \
-[] (type *s ,GwConfigHandler *cfg) { \
-    CFG_SGET(s, tmNam, prefix); \
-    CFG_SGET(s, huNam, prefix); \
-    CFG_SGET(s, iid, prefix);   \
-    CFG_SGET(s, tmAct, prefix); \
-    CFG_SGET(s, huAct, prefix); \
-    CFG_SGET(s, intv, prefix); \
-    CFG_SGET(s, huSrc, prefix); \
-    CFG_SGET(s, tmSrc, prefix); \
-    CFG_SGET(s, sEnv,prefix); \
-    s->busId = bus; \
-    s->addr = baddr; \
-    s->ok = true; \
-    s->intv *= 1000; \
-}
-
-#if defined(_GWSHT3X)
-class SHT3XConfig;
-static GwSensorConfigInitializerList<SHT3XConfig> configs3;
-class SHT3XConfig : public SHTXXConfig{
-    SHT3X *device=nullptr;
-    public:
-    using SHTXXConfig::SHTXXConfig;
-    virtual bool initDevice(GwApi * api,TwoWire *wire)override{
-        if (! isActive()) return false;
-        device=new SHT3X();
-        device->init(addr,wire);
-        GwLog *logger=api->getLogger();
-        LOG_DEBUG(GwLog::LOG,"initialized %s at address %d, intv %ld",prefix.c_str(),(int)addr,intv);
-        return true;
-    }
-    virtual bool doMeasure(GwApi *api,double &temp, double &humid) override{
-        if (!device)
-            return false;
-        int rt=0;
-        GwLog *logger=api->getLogger();
-        if ((rt = device->get()) == 0)
-        {
-            temp = device->cTemp;
-            humid = device->humidity;
-            return true;
-        }
-        else{
-            LOG_DEBUG(GwLog::DEBUG, "unable to query %s: %d",prefix.c_str(), rt);
-        }
-        return false;
-    } 
-    virtual void readConfig(GwConfigHandler *cfg) override{
-        if (ok) return;
-        configs3.readConfig(this,cfg);
-        return;
-    }
-};
-
-SensorBase::Creator creator3=[](GwApi *api,const String &prfx)-> SensorBase*{
-        if (! configs3.knowsPrefix(prfx)) return nullptr;
-        return new SHT3XConfig(api,prfx);
-    };
-SensorBase::Creator registerSHT3X(GwApi *api){
-    GwLog *logger=api->getLogger();
-    #if defined(GWSHT3X) || defined (GWSHT3X11)
-    {
-        api->addSensor(creator3(api,"SHT3X11"));
-        CHECK_IIC1();
-        #pragma message "GWSHT3X11 defined"
-    }
-    #endif
-    #if defined(GWSHT3X12)
-    {
-        api->addSensor(creator3(api,"SHT3X12"));
-        CHECK_IIC1();
-        #pragma message "GWSHT3X12 defined"
-    }
-    #endif
-    #if defined(GWSHT3X21)
-    {
-        api->addSensor(creator3(api,"SHT3X21"));
-        CHECK_IIC2();
-        #pragma message "GWSHT3X21 defined"
-    }
-    #endif
-    #if defined(GWSHT3X22)
-    {
-        api->addSensor(creator3(api,"SHT3X22"));
-        CHECK_IIC2();
-        #pragma message "GWSHT3X22 defined"
-    }
-    #endif
-    return creator3;
-};
-
-
-#define SCSHT3X(prefix, bus, addr) \
-    GwSensorConfigInitializer<SHT3XConfig> __initCFGSHT3X ## prefix \
-        (configs3,GwSensorConfig<SHT3XConfig>(#prefix,INITSHTXX(SHT3XConfig,prefix,bus,addr)));
-
-SCSHT3X(SHT3X11, 1, 0x44);
-SCSHT3X(SHT3X12, 1, 0x45);
-SCSHT3X(SHT3X21, 2, 0x44);
-SCSHT3X(SHT3X22, 2, 0x45);
-
-#endif
-#if defined(_GWSHT4X)
-class SHT4XConfig;
-static GwSensorConfigInitializerList<SHT4XConfig> configs4;
-class SHT4XConfig : public SHTXXConfig{
-    SHT4X *device=nullptr;
-    public:
-    using SHTXXConfig::SHTXXConfig;
-    virtual bool initDevice(GwApi * api,TwoWire *wire)override{
-        if (! isActive()) return false;
-        device=new SHT4X();
-        device->begin(wire,addr);
-        GwLog *logger=api->getLogger();
-        LOG_DEBUG(GwLog::LOG,"initialized %s at address %d, intv %ld",prefix.c_str(),(int)addr,intv);
-        return true;
-    }
-    virtual bool doMeasure(GwApi *api,double &temp, double &humid) override{
-        if (!device)
-            return false;
-        GwLog *logger=api->getLogger();
-        if (device->update())
-        {
-            temp = device->cTemp;
-            humid = device->humidity;
-            return true;
-        }
-        else{
-            LOG_DEBUG(GwLog::DEBUG, "unable to query %s",prefix.c_str());
-        }
-        return false;
-    } 
-    virtual void readConfig(GwConfigHandler *cfg) override{
-        if (ok) return;
-        configs4.readConfig(this,cfg);
-        return;
-    }
-};
-
-SensorBase::Creator creator4=[](GwApi *api,const String &prfx)-> SensorBase*{
-        if (! configs4.knowsPrefix(prfx)) return nullptr;
-        return new SHT4XConfig(api,prfx);
-    };
-SensorBase::Creator registerSHT4X(GwApi *api){
-    GwLog *logger=api->getLogger();
-    #if defined(GWSHT4X) || defined (GWSHT4X11)
-    {
-        api->addSensor(creator3(api,"SHT4X11"));
-        CHECK_IIC1();
-        #pragma message "GWSHT4X11 defined"
-    }
-    #endif
-    #if defined(GWSHT4X12)
-    {
-        api->addSensor(creator3(api,"SHT4X12"));
-        CHECK_IIC1();
-        #pragma message "GWSHT4X12 defined"
-    }
-    #endif
-    #if defined(GWSHT4X21)
-    {
-        api->addSensor(creator3(api,"SHT4X21"));
-        CHECK_IIC2();
-        #pragma message "GWSHT4X21 defined"
-    }
-    #endif
-    #if defined(GWSHT4X22)
-    {
-        api->addSensor(creator3(api,"SHT4X22"));
-        CHECK_IIC2();
-        #pragma message "GWSHT4X22 defined"
-    }
-    #endif
-    return creator4;
-};
-
-
-#define SCSHT4X(prefix, bus, addr) \
-    GwSensorConfigInitializer<SHT4XConfig> __initCFGSHT4X ## prefix \
-        (configs4,GwSensorConfig<SHT4XConfig>(#prefix,INITSHTXX(SHT4XConfig,prefix,bus,addr)));
-
-SCSHT4X(SHT4X11, 1, 0x44);
-SCSHT4X(SHT4X12, 1, 0x45);
-SCSHT4X(SHT4X21, 2, 0x44);
-SCSHT4X(SHT4X22, 2, 0x45);
-#endif 
-#endif
-#ifndef _GWSHT3X
-SensorBase::Creator registerSHT3X(GwApi *api){
-    return SensorBase::Creator();
-}
-#endif
-#ifndef _GWSHT4X
-SensorBase::Creator registerSHT4X(GwApi *api){
-    return SensorBase::Creator();
-}
-#endif
-
-
-

lib/iictask/SHT3X.cpp

@@ -1,4 +1,4 @@
-#include "GwSHTXX.h"
+#include "GwSHT3X.h"
 #ifdef _GWSHT3X
 
 bool SHT3X::init(uint8_t slave_addr_in, TwoWire* wire_in)

lib/iictask/SHT4X.cpp

@@ -1,131 +0,0 @@
-#include "GwSHTXX.h"
-#ifdef _GWSHT4X
-
-uint8_t crc8(const uint8_t *data, int len) {
-    /*
-     *
-     * CRC-8 formula from page 14 of SHT spec pdf
-     *
-     * Test data 0xBE, 0xEF should yield 0x92
-     *
-     * Initialization data 0xFF
-     * Polynomial 0x31 (x8 + x5 +x4 +1)
-     * Final XOR 0x00
-     */
-
-    const uint8_t POLYNOMIAL(0x31);
-    uint8_t crc(0xFF);
-
-    for (int j = len; j; --j) {
-        crc ^= *data++;
-
-        for (int i = 8; i; --i) {
-            crc = (crc & 0x80) ? (crc << 1) ^ POLYNOMIAL : (crc << 1);
-        }
-    }
-    return crc;
-}
-
-bool SHT4X::begin(TwoWire* wire, uint8_t addr) {
-    _addr = addr;
-    _wire = wire;
-    int error;
-    _wire->beginTransmission(addr);
-    error = _wire->endTransmission();
-    if (error == 0) {
-        return true;
-    }
-    return false;
-}
-
-bool SHT4X::update() {
-    uint8_t readbuffer[6];
-    uint8_t cmd       = SHT4x_NOHEAT_HIGHPRECISION;
-    uint16_t duration = 10;
-
-    if (_heater == SHT4X_NO_HEATER) {
-        if (_precision == SHT4X_HIGH_PRECISION) {
-            cmd      = SHT4x_NOHEAT_HIGHPRECISION;
-            duration = 10;
-        }
-        if (_precision == SHT4X_MED_PRECISION) {
-            cmd      = SHT4x_NOHEAT_MEDPRECISION;
-            duration = 5;
-        }
-        if (_precision == SHT4X_LOW_PRECISION) {
-            cmd      = SHT4x_NOHEAT_LOWPRECISION;
-            duration = 2;
-        }
-    }
-
-    if (_heater == SHT4X_HIGH_HEATER_1S) {
-        cmd      = SHT4x_HIGHHEAT_1S;
-        duration = 1100;
-    }
-    if (_heater == SHT4X_HIGH_HEATER_100MS) {
-        cmd      = SHT4x_HIGHHEAT_100MS;
-        duration = 110;
-    }
-
-    if (_heater == SHT4X_MED_HEATER_1S) {
-        cmd      = SHT4x_MEDHEAT_1S;
-        duration = 1100;
-    }
-    if (_heater == SHT4X_MED_HEATER_100MS) {
-        cmd      = SHT4x_MEDHEAT_100MS;
-        duration = 110;
-    }
-
-    if (_heater == SHT4X_LOW_HEATER_1S) {
-        cmd      = SHT4x_LOWHEAT_1S;
-        duration = 1100;
-    }
-    if (_heater == SHT4X_LOW_HEATER_100MS) {
-        cmd      = SHT4x_LOWHEAT_100MS;
-        duration = 110;
-    }
-    // _i2c.writeByte(_addr, cmd, 1);
-    _wire->beginTransmission(_addr);
-    _wire->write(cmd);
-    _wire->write(1);
-    _wire->endTransmission();
-
-
-    delay(duration);
-
-    _wire->requestFrom(_addr, (uint8_t)6);
-
-    for (uint16_t i = 0; i < 6; i++) {
-        readbuffer[i] = _wire->read();
-    }
-
-    if (readbuffer[2] != crc8(readbuffer, 2) ||
-        readbuffer[5] != crc8(readbuffer + 3, 2)) {
-        return false;
-    }
-
-    float t_ticks  = (uint16_t)readbuffer[0] * 256 + (uint16_t)readbuffer[1];
-    float rh_ticks = (uint16_t)readbuffer[3] * 256 + (uint16_t)readbuffer[4];
-
-    cTemp    = -45 + 175 * t_ticks / 65535;
-    humidity = -6 + 125 * rh_ticks / 65535;
-    humidity = min(max(humidity, (float)0.0), (float)100.0);
-    return true;
-}
-
-void SHT4X::setPrecision(sht4x_precision_t prec) {
-    _precision = prec;
-}
-
-sht4x_precision_t SHT4X::getPrecision(void) {
-    return _precision;
-}
-
-void SHT4X::setHeater(sht4x_heater_t heat) {
-    _heater = heat;
-}
-
-sht4x_heater_t SHT4X::getHeater(void) {
-    return _heater;
-}
-#endif

lib/iictask/SHT4X.h

@@ -1,76 +0,0 @@
-#ifndef __SHT4X_H_
-#define __SHT4X_H_
-
-#include "Arduino.h"
-#include "Wire.h"
-
-#define SHT40_I2C_ADDR_44 0x44
-#define SHT40_I2C_ADDR_45 0x45
-#define SHT41_I2C_ADDR_44 0x44
-#define SHT41_I2C_ADDR_45 0x45
-#define SHT45_I2C_ADDR_44 0x44
-#define SHT45_I2C_ADDR_45 0x45
-
-#define SHT4x_DEFAULT_ADDR 0x44 /**< SHT4x I2C Address */
-#define SHT4x_NOHEAT_HIGHPRECISION \
-    0xFD /**< High precision measurement, no heater */
-#define SHT4x_NOHEAT_MEDPRECISION \
-    0xF6 /**< Medium precision measurement, no heater */
-#define SHT4x_NOHEAT_LOWPRECISION \
-    0xE0 /**< Low precision measurement, no heater */
-
-#define SHT4x_HIGHHEAT_1S \
-    0x39 /**< High precision measurement, high heat for 1 sec */
-#define SHT4x_HIGHHEAT_100MS \
-    0x32 /**< High precision measurement, high heat for 0.1 sec */
-#define SHT4x_MEDHEAT_1S \
-    0x2F /**< High precision measurement, med heat for 1 sec */
-#define SHT4x_MEDHEAT_100MS \
-    0x24 /**< High precision measurement, med heat for 0.1 sec */
-#define SHT4x_LOWHEAT_1S \
-    0x1E /**< High precision measurement, low heat for 1 sec */
-#define SHT4x_LOWHEAT_100MS \
-    0x15 /**< High precision measurement, low heat for 0.1 sec */
-
-#define SHT4x_READSERIAL 0x89 /**< Read Out of Serial Register */
-#define SHT4x_SOFTRESET  0x94 /**< Soft Reset */
-
-typedef enum {
-    SHT4X_HIGH_PRECISION,
-    SHT4X_MED_PRECISION,
-    SHT4X_LOW_PRECISION,
-} sht4x_precision_t;
-
-/** Optional pre-heater configuration setting */
-typedef enum {
-    SHT4X_NO_HEATER,
-    SHT4X_HIGH_HEATER_1S,
-    SHT4X_HIGH_HEATER_100MS,
-    SHT4X_MED_HEATER_1S,
-    SHT4X_MED_HEATER_100MS,
-    SHT4X_LOW_HEATER_1S,
-    SHT4X_LOW_HEATER_100MS,
-} sht4x_heater_t;
-
-class SHT4X {
-   public:
-    bool begin(TwoWire* wire = &Wire, uint8_t addr = SHT40_I2C_ADDR_44);
-    bool update(void);
-
-    float cTemp    = 0;
-    float humidity = 0;
-
-    void setPrecision(sht4x_precision_t prec);
-    sht4x_precision_t getPrecision(void);
-    void setHeater(sht4x_heater_t heat);
-    sht4x_heater_t getHeater(void);
-
-   private:
-    TwoWire* _wire;
-    uint8_t _addr;
-
-    sht4x_precision_t _precision = SHT4X_HIGH_PRECISION;
-    sht4x_heater_t _heater       = SHT4X_NO_HEATER;
-};
-
-#endif

lib/iictask/config.json

@@ -1,77 +1,49 @@
 [
     {
         "type": "array",
-        "name": "SHTXX",
+        "name": "SHT3X",
         "replace": [
             {
                 "b": "1",
                 "i": "11",
-                "n": "99",
-                "x": "3"
+                "n": "99"
             },
             {
                 "b": "1",
                 "i": "12",
-                "n": "98",
-                "x": "3"
+                "n": "98"
             },
             {
                 "b": "2",
                 "i": "21",
-                "n": "109",
-                "x": "3"
+                "n": "109"
             },
             {
                 "b": "2",
                 "i": "22",
-                "n": "108",
-                "x": "3"
-            },
-            {
-                "b": "1",
-                "i": "11",
-                "n": "119",
-                "x": "4"
-            },
-            {
-                "b": "1",
-                "i": "12",
-                "n": "118",
-                "x": "4"
-            },
-            {
-                "b": "2",
-                "i": "21",
-                "n": "129",
-                "x": "4"
-            },
-            {
-                "b": "2",
-                "i": "22",
-                "n": "128",
-                "x": "4"
+                "n": "108"
             }
 
 
         ],
         "children": [
             {
-                "name": "SHT$xX$itmAct",
-                "label": "SHT$xX$i Temp",
+                "name": "SHT3X$itmAct",
+                "label": "SHT3X$i Temp",
                 "type": "boolean",
                 "default": "true",
-                "description": "Enable the $i. I2C SHT$xX temp sensor (bus $b)",
+                "description": "Enable the $i. I2C SHT3x temp sensor (bus $b)",
                 "category": "iicsensors$b",
                 "capabilities": {
-                    "SHT$xX$i": "true"
+                    "SHT3X$i": "true"
                 }
             },
             {
-                "name": "SHT$xX$itmSrc",
-                "label": "SHT$xX$i Temp Type",
+                "name": "SHT3X$itmSrc",
+                "label": "SHT3X$i Temp Type",
                 "type": "list",
                 "default": "2",
-                "description": "the NMEA2000 source type for the temperature (PGN 130312,130311)",
+                "description": "the NMEA2000 source type for the temperature",
                 "list": [
                     {
                         "l": "SeaTemperature",
@@ -140,23 +112,23 @@
                 ],
                 "category": "iicsensors$b",
                 "capabilities": {
-                    "SHT$xX$i": "true"
+                    "SHT3X$i": "true"
                 }
             },
             {
-                "name": "SHT$xX$ihuAct",
-                "label": "SHT$xX$i Humidity",
+                "name": "SHT3X$ihuAct",
+                "label": "SHT3X$i Humidity",
                 "type": "boolean",
                 "default": "true",
-                "description": "Enable the $i. I2C SHT$xX humidity sensor (bus $b)",
+                "description": "Enable the $i. I2C SHT3x humidity sensor (bus $b)",
                 "category": "iicsensors$b",
                 "capabilities": {
-                    "SHT$xX$i": "true"
+                    "SHT3X$i": "true"
                 }
             },
             {
-                "name": "SHT$xX$ihuSrc",
-                "label": "SHT$xX$i Humid Type",
+                "name": "SHT3X$ihuSrc",
+                "label": "SHT3X$i Humid Type",
                 "list": [
                     {
                         "l": "OutsideHumidity",
@@ -169,68 +141,57 @@
                 ],
                 "category": "iicsensors$b",
                 "capabilities": {
-                    "SHT$xX": "true"
+                    "SHT3X": "true"
                 }
             },
             {
-                "name": "SHT$xX$iiid",
-                "label": "SHT$xX$i N2K iid",
+                "name": "SHT3X$iiid",
+                "label": "SHT3X$i N2K iid",
                 "type": "number",
                 "default": "$n",
-                "description": "the N2K instance id for the $i. SHT$xX Temperature and Humidity (PGN 130312,130311) ",
+                "description": "the N2K instance id for the $i. SHT3X Temperature and Humidity ",
                 "category": "iicsensors$b",
                 "min": 0,
                 "max": 253,
                 "check": "checkMinMax",
                 "capabilities": {
-                    "SHT$xX$i": "true"
+                    "SHT3X$i": "true"
                 }
             },
             {
-                "name": "SHT$xX$isEnv",
-                "label": "SHT$xX$i send Env",
-                "type": "boolean",
-                "default": "true",
-                "description": "also send PGN 130311",
-                "category": "iicsensors$b",
-                "capabilities": {
-                    "SHT$xX$i": "true"
-                }
-            },
-            {
-                "name": "SHT$xX$iintv",
-                "label": "SHT$xX$i Interval",
+                "name": "SHT3X$iintv",
+                "label": "SHT3X$i Interval",
                 "type": "number",
                 "default": 2,
-                "description": "Interval(s) to query SHT$xX Temperature and Humidity (1...300)",
+                "description": "Interval(s) to query SHT3X Temperature and Humidity (1...300)",
                 "category": "iicsensors$b",
                 "min": 1,
                 "max": 300,
                 "check": "checkMinMax",
                 "capabilities": {
-                    "SHT$xX$i": "true"
+                    "SHT3X$i": "true"
                 }
             },
             {
-                "name": "SHT$xX$itmNam",
-                "label": "SHT$xX$i Temp XDR",
+                "name": "SHT3X$itmNam",
+                "label": "SHT3X$i Temp XDR",
                 "type": "String",
                 "default": "Temp$i",
-                "description": "set the XDR transducer name for the $i. SHT$xX Temperature, leave empty to disable NMEA0183 XDR ",
+                "description": "set the XDR transducer name for the $i. SHT3X Temperature, leave empty to disable NMEA0183 XDR ",
                 "category": "iicsensors$b",
                 "capabilities": {
-                    "SHT$xX$i": "true"
+                    "SHT3X$i": "true"
                 }
             },
             {
-                "name": "SHT$xX$ihuNam",
-                "label": "SHT$xX$i Humid XDR",
+                "name": "SHT3X$ihuNam",
+                "label": "SHT3X$i Humid XDR",
                 "type": "String",
                 "default": "Humidity$i",
-                "description": "set the XDR transducer name for the $i. SHT$xX Humidity, leave empty to disable NMEA0183 XDR",
+                "description": "set the XDR transducer name for the $i. SHT3X Humidity, leave empty to disable NMEA0183 XDR",
                 "category": "iicsensors$b",
                 "capabilities": {
-                    "SHT$xX$i": "true"
+                    "SHT3X$i": "true"
                 }
             }
         ]
@@ -286,17 +247,6 @@
                     "QMP6988$i": "true"
                 }
             },
-            {
-                "name": "QMP6988$isEnv",
-                "label": "QMP6988$i send Env",
-                "type": "boolean",
-                "default": "true",
-                "description": "also send PGN 130311",
-                "category": "iicsensors$b",
-                "capabilities": {
-                    "QMP6988$i": "true"
-                }
-            },
             {
                 "name": "QMP6988$iintv",
                 "label": "QMP6988-$i Interval",
@@ -523,7 +473,7 @@
                 "label": "BME280-$i N2K iid",
                 "type": "number",
                 "default": "$n",
-                "description": "the N2K instance id for the BME280 Temperature, Humidity, Pressure (PGN 130312,130313, 130314) ",
+                "description": "the N2K instance id for the BME280 Temperature and Humidity ",
                 "category": "iicsensors$b",
                 "min": 0,
                 "max": 253,
@@ -532,17 +482,6 @@
                     "BME280$i": "true"
                 }
             },
-            {
-                "name": "BME280$isEnv",
-                "label": "BME280$i send Env",
-                "type": "boolean",
-                "default": "true",
-                "description": "also send PGN 130311",
-                "category": "iicsensors$b",
-                "capabilities": {
-                    "BME280$i": "true"
-                }
-            },
             {
                 "name": "BME280$iintv",
                 "label": "BME280-$i Interval",
@@ -744,7 +683,7 @@
                 "label": "BMP280-$i N2K iid",
                 "type": "number",
                 "default": "$n",
-                "description": "the N2K instance id for the BMP280 Temperature/Pressure (PGN 130312,130314)",
+                "description": "the N2K instance id for the BMP280 Temperature",
                 "category": "iicsensors$b",
                 "min": 0,
                 "max": 253,
@@ -753,17 +692,6 @@
                     "BMP280$i": "true"
                 }
             },
-            {
-                "name": "BMP280$isEnv",
-                "label": "BMP280$i send Env",
-                "type": "boolean",
-                "default": "true",
-                "description": "also send PGN 130311",
-                "category": "iicsensors$b",
-                "capabilities": {
-                    "BMP280$i": "true"
-                }
-            },
             {
                 "name": "BMP280$iintv",
                 "label": "BMP280-$i Interval",

lib/iictask/platformio.ini

@@ -11,17 +11,6 @@ build_flags=
     -D M5_CAN_KIT
     ${env.build_flags}
 
-[env:m5stack-atom-env4]
-extends = sensors
-board = m5stack-atom
-lib_deps = 
-    ${env.lib_deps}
-    ${sensors.lib_deps}
-build_flags=
-    -D M5_ENV4
-    -D M5_CAN_KIT
-    ${env.build_flags}
-
 
 [env:m5stack-atom-bme280]
 extends = sensors

lib/nmea0183ton2k/NMEA0183AIStoNMEA2000.h

@@ -2,7 +2,7 @@
   This code is free software; you can redistribute it and/or
   modify it under the terms of the GNU Lesser General Public
   License as published by the Free Software Foundation; either
-  version 2 of the License, or (at your option) any later version.
+  version 2.1 of the License, or (at your option) any later version.
   This code is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
@@ -27,8 +27,6 @@ const double nmTom = 1.852 * 1000;
 
 uint16_t DaysSince1970 = 0;
 
-#define boolbit(b) (b?1:0)
-
 class MyAisDecoder : public AIS::AisDecoder
 {
   public:
@@ -84,24 +82,25 @@ class MyAisDecoder : public AIS::AisDecoder
 
       tN2kMsg N2kMsg;
 
-      SetN2kPGN129038(
-        N2kMsg,
-        _uMsgType,
-        (tN2kAISRepeat)_Repeat,
-        _uMmsi,
-        _iPosLon/ 600000.0,
-        _iPosLat / 600000.0,
-        _bPosAccuracy,
-        _Raim,
-        _timestamp,
-        decodeCog(_iCog),
-        _uSog * knToms/10.0,
-        tN2kAISTransceiverInformation::N2kaischannel_A_VDL_reception,
-        decodeHeading(_iHeading),
-        decodeRot(_iRot),
-        (tN2kAISNavStatus)_uNavstatus,
-        0xff
-      );
+      // PGN129038
+      
+      N2kMsg.SetPGN(129038L);
+      N2kMsg.Priority = 4;
+      N2kMsg.AddByte((_Repeat & 0x03) << 6 | (_uMsgType & 0x3f));
+      N2kMsg.Add4ByteUInt(_uMmsi);
+      N2kMsg.Add4ByteDouble(_iPosLon / 600000.0, 1e-07);
+      N2kMsg.Add4ByteDouble(_iPosLat / 600000.0, 1e-07);
+      N2kMsg.AddByte((_timestamp & 0x3f) << 2 | (_Raim & 0x01) << 1 | (_bPosAccuracy & 0x01));
+      N2kMsg.Add2ByteUDouble(decodeCog(_iCog), 1e-04);
+      N2kMsg.Add2ByteUDouble(_uSog * knToms/10.0, 0.01);
+      N2kMsg.AddByte(0x00); // Communication State (19 bits)
+      N2kMsg.AddByte(0x00);
+      N2kMsg.AddByte(0x00); // AIS transceiver information (5 bits)
+      N2kMsg.Add2ByteUDouble(decodeHeading(_iHeading), 1e-04);
+      N2kMsg.Add2ByteDouble(decodeRot(_iRot), 3.125E-05); // 1e-3/32.0
+      N2kMsg.AddByte(0xF0 | (_uNavstatus & 0x0f));
+      N2kMsg.AddByte(0xff); // Reserved
+      N2kMsg.AddByte(0xff); // SID (NA)
 
       send(N2kMsg);
     }
@@ -256,40 +255,9 @@ class MyAisDecoder : public AIS::AisDecoder
       send(N2kMsg);      
     }
 
-    //mmsi, aidType, name + nameExt, posAccuracy, posLon, posLat, toBow, toStern, toPort, toStarboard
-    virtual void onType21(unsigned int mmsi , unsigned int aidType , const std::string & name, bool accuracy, int posLon, int posLat, unsigned int toBow, 
-      unsigned int toStern, unsigned int toPort, unsigned int toStarboard,
-      unsigned int repeat,unsigned int timestamp, bool raim, bool virtualAton, bool offPosition) override {
+
+    virtual void onType21(unsigned int , unsigned int , const std::string &, bool , int , int , unsigned int , unsigned int , unsigned int , unsigned int ) override {
       //Serial.println("21");
-      //the name can be at most 120bit+88bit (35 byte) + termination -> 36 Byte
-      //in principle we should use tN2kAISAtoNReportData to directly call the library
-      //function for 129041. But this makes the conversion really complex.
-      bool assignedMode=false;
-      tN2kGNSStype gnssType=tN2kGNSStype::N2kGNSSt_GPS; //canboat considers 0 as undefined...
-      tN2kAISTransceiverInformation transceiverInfo=tN2kAISTransceiverInformation::N2kaischannel_A_VDL_reception;
-      tN2kMsg N2kMsg;
-      N2kMsg.SetPGN(129041);
-      N2kMsg.Priority=4;
-      N2kMsg.AddByte((repeat & 0x03) << 6 | (21 & 0x3f));
-      N2kMsg.Add4ByteUInt(mmsi); //N2kData.UserID
-      N2kMsg.Add4ByteDouble(posLon / 600000.0, 1e-07);
-      N2kMsg.Add4ByteDouble(posLat / 600000.0, 1e-07);
-      N2kMsg.AddByte((timestamp & 0x3f)<<2 | boolbit(raim)<<1 | boolbit(accuracy)); 
-      N2kMsg.Add2ByteUDouble(toBow+toStern, 0.1);
-      N2kMsg.Add2ByteUDouble(toPort+toStarboard, 0.1);
-      N2kMsg.Add2ByteUDouble(toStarboard, 0.1);
-      N2kMsg.Add2ByteUDouble(toBow, 0.1);
-      N2kMsg.AddByte(boolbit(assignedMode) << 7 
-                    | boolbit(virtualAton) << 6 
-                    | boolbit(offPosition) << 5
-                    | (aidType & 0x1f)); 
-      N2kMsg.AddByte((gnssType & 0x0F) << 1 | 0xe0);
-      N2kMsg.AddByte(N2kUInt8NA); //status
-      N2kMsg.AddByte((transceiverInfo & 0x1f) | 0xe0);
-      //bit offset 208 (see canboat/pgns.xml) -> 26 bytes from start
-      //as MaxDataLen is 223 and the string can be at most 36 bytes + 2 byte heading - no further check here 
-      N2kMsg.AddVarStr(name.c_str());
-      send(N2kMsg);
     }
 
     virtual void onType24A(unsigned int _uMsgType, unsigned int _repeat, unsigned int _uMmsi,

lib/nmea0183ton2k/NMEA0183DataToN2K.cpp

@@ -143,7 +143,7 @@ private:
      */
     GwXDRFoundMapping getOtherFieldMapping(GwXDRFoundMapping &found, int field){
         if (found.empty) return GwXDRFoundMapping();
-        return xdrMappings->getMapping(0,found.definition->category,
+        return xdrMappings->getMapping(found.definition->category,
             found.definition->selector,
             field,
             found.instanceId);

lib/nmea2kto0183/N2kDataToNMEA0183.cpp

@@ -708,37 +708,12 @@ private:
         }
     }
 
-    //helper for converting the AIS transceiver info to talker/channel
-
-    void setTalkerChannel(tNMEA0183AISMsg &msg, tN2kAISTransceiverInformation &transceiver){
-        bool channelA=true;
-        bool own=false;
-        switch (transceiver){
-            case tN2kAISTransceiverInformation::N2kaischannel_A_VDL_reception:
-                channelA=true;
-                own=false;
-                break;
-            case tN2kAISTransceiverInformation::N2kaischannel_B_VDL_reception:
-                channelA=false;
-                own=false;
-                break;
-            case tN2kAISTransceiverInformation::N2kaischannel_A_VDL_transmission:
-                channelA=true;
-                own=true;
-                break;
-            case tN2kAISTransceiverInformation::N2kaischannel_B_VDL_transmission:
-                channelA=false;
-                own=true;
-                break;
-        }
-        msg.SetChannelAndTalker(channelA,own);
-    }
-
     //*****************************************************************************
     // 129038 AIS Class A Position Report (Message 1, 2, 3)
     void HandleAISClassAPosReport(const tN2kMsg &N2kMsg)
     {
 
+        unsigned char SID;
         tN2kAISRepeat _Repeat;
         uint32_t _UserID; // MMSI
         double _Latitude =N2kDoubleNA;
@@ -757,19 +732,64 @@ private:
         uint8_t _MessageType = 1;
         tNMEA0183AISMsg NMEA0183AISMsg;
 
-        if (ParseN2kPGN129038(N2kMsg, _MessageType, _Repeat, _UserID, _Latitude, _Longitude, _Accuracy, _RAIM, _Seconds,
+        if (ParseN2kPGN129038(N2kMsg, SID, _Repeat, _UserID, _Latitude, _Longitude, _Accuracy, _RAIM, _Seconds,
                               _COG, _SOG, _Heading, _ROT, _NavStatus,_AISTransceiverInformation,_SID))
         {
 
+// Debug
+#ifdef SERIAL_PRINT_AIS_FIELDS
+            Serial.println("–––––––––––––––––––––––– Msg 1 ––––––––––––––––––––––––––––––––");
+
+            const double pi = 3.1415926535897932384626433832795;
+            const double radToDeg = 180.0 / pi;
+            const double msTokn = 3600.0 / 1852.0;
+            const double radsToDegMin = 60 * 360.0 / (2 * pi); // [rad/s -> degree/minute]
+            Serial.print("Repeat: ");
+            Serial.println(_Repeat);
+            Serial.print("UserID: ");
+            Serial.println(_UserID);
+            Serial.print("Latitude: ");
+            Serial.println(_Latitude);
+            Serial.print("Longitude: ");
+            Serial.println(_Longitude);
+            Serial.print("Accuracy: ");
+            Serial.println(_Accuracy);
+            Serial.print("RAIM: ");
+            Serial.println(_RAIM);
+            Serial.print("Seconds: ");
+            Serial.println(_Seconds);
+            Serial.print("COG: ");
+            Serial.println(_COG * radToDeg);
+            Serial.print("SOG: ");
+            Serial.println(_SOG * msTokn);
+            Serial.print("Heading: ");
+            Serial.println(_Heading * radToDeg);
+            Serial.print("ROT: ");
+            Serial.println(_ROT * radsToDegMin);
+            Serial.print("NavStatus: ");
+            Serial.println(_NavStatus);
+#endif
 
-            setTalkerChannel(NMEA0183AISMsg,_AISTransceiverInformation);
-            if (_MessageType < 1 || _MessageType > 3) _MessageType=1; //only allow type 1...3 for 129038
             if (SetAISClassABMessage1(NMEA0183AISMsg, _MessageType, _Repeat, _UserID, _Latitude, _Longitude, _Accuracy,
                                       _RAIM, _Seconds, _COG, _SOG, _Heading, _ROT, _NavStatus))
             {
 
                 SendMessage(NMEA0183AISMsg);
 
+#ifdef SERIAL_PRINT_AIS_NMEA
+                // Debug Print AIS-NMEA
+                Serial.print(NMEA0183AISMsg.GetPrefix());
+                Serial.print(NMEA0183AISMsg.Sender());
+                Serial.print(NMEA0183AISMsg.MessageCode());
+                for (int i = 0; i < NMEA0183AISMsg.FieldCount(); i++)
+                {
+                    Serial.print(",");
+                    Serial.print(NMEA0183AISMsg.Field(i));
+                }
+                char buf[7];
+                sprintf(buf, "*%02X\r\n", NMEA0183AISMsg.GetCheckSum());
+                Serial.print(buf);
+#endif
             }
         }
     } // end 129038 AIS Class A Position Report Message 1/3
@@ -805,18 +825,84 @@ private:
                               _Length, _Beam, _PosRefStbd, _PosRefBow, _ETAdate, _ETAtime, _Draught, _Destination,21,
                               _AISversion, _GNSStype, _DTE, _AISinfo,_SID))
         {
-            setTalkerChannel(NMEA0183AISMsg,_AISinfo);
+
+#ifdef SERIAL_PRINT_AIS_FIELDS
+            // Debug Print N2k Values
+            Serial.println("––––––––––––––––––––––– Msg 5 –––––––––––––––––––––––––––––––––");
+            Serial.print("MessageID: ");
+            Serial.println(_MessageID);
+            Serial.print("Repeat: ");
+            Serial.println(_Repeat);
+            Serial.print("UserID: ");
+            Serial.println(_UserID);
+            Serial.print("IMONumber: ");
+            Serial.println(_IMONumber);
+            Serial.print("Callsign: ");
+            Serial.println(_Callsign);
+            Serial.print("VesselType: ");
+            Serial.println(_VesselType);
+            Serial.print("Name: ");
+            Serial.println(_Name);
+            Serial.print("Length: ");
+            Serial.println(_Length);
+            Serial.print("Beam: ");
+            Serial.println(_Beam);
+            Serial.print("PosRefStbd: ");
+            Serial.println(_PosRefStbd);
+            Serial.print("PosRefBow: ");
+            Serial.println(_PosRefBow);
+            Serial.print("ETAdate: ");
+            Serial.println(_ETAdate);
+            Serial.print("ETAtime: ");
+            Serial.println(_ETAtime);
+            Serial.print("Draught: ");
+            Serial.println(_Draught);
+            Serial.print("Destination: ");
+            Serial.println(_Destination);
+            Serial.print("GNSStype: ");
+            Serial.println(_GNSStype);
+            Serial.print("DTE: ");
+            Serial.println(_DTE);
+            Serial.println("––––––––––––––––––––––– Msg 5 –––––––––––––––––––––––––––––––––");
+#endif
+
             if (SetAISClassAMessage5(NMEA0183AISMsg, _MessageID, _Repeat, _UserID, _IMONumber, _Callsign, _Name, _VesselType,
                                      _Length, _Beam, _PosRefStbd, _PosRefBow, _ETAdate, _ETAtime, _Draught, _Destination,
-                                     _GNSStype, _DTE,_AISversion))
+                                     _GNSStype, _DTE))
             {
-                if (NMEA0183AISMsg.BuildMsg5Part1()){
-                    SendMessage(NMEA0183AISMsg);
-                }
-                if (NMEA0183AISMsg.BuildMsg5Part2()){
-                    SendMessage(NMEA0183AISMsg);
-                }
 
+                SendMessage(NMEA0183AISMsg.BuildMsg5Part1(NMEA0183AISMsg));
+
+#ifdef SERIAL_PRINT_AIS_NMEA
+                // Debug Print AIS-NMEA Message Type 5, Part 1
+                char buf[7];
+                Serial.print(NMEA0183AISMsg.GetPrefix());
+                Serial.print(NMEA0183AISMsg.Sender());
+                Serial.print(NMEA0183AISMsg.MessageCode());
+                for (int i = 0; i < NMEA0183AISMsg.FieldCount(); i++)
+                {
+                    Serial.print(",");
+                    Serial.print(NMEA0183AISMsg.Field(i));
+                }
+                sprintf(buf, "*%02X\r\n", NMEA0183AISMsg.GetCheckSum());
+                Serial.print(buf);
+#endif
+
+                SendMessage(NMEA0183AISMsg.BuildMsg5Part2(NMEA0183AISMsg));
+
+#ifdef SERIAL_PRINT_AIS_NMEA
+                // Print AIS-NMEA Message Type 5, Part 2
+                Serial.print(NMEA0183AISMsg.GetPrefix());
+                Serial.print(NMEA0183AISMsg.Sender());
+                Serial.print(NMEA0183AISMsg.MessageCode());
+                for (int i = 0; i < NMEA0183AISMsg.FieldCount(); i++)
+                {
+                    Serial.print(",");
+                    Serial.print(NMEA0183AISMsg.Field(i));
+                }
+                sprintf(buf, "*%02X\r\n", NMEA0183AISMsg.GetCheckSum());
+                Serial.print(buf);
+#endif
             }
         }
     }
@@ -840,21 +926,35 @@ private:
         tN2kAISUnit _Unit;
         bool _Display, _DSC, _Band, _Msg22, _State;
         tN2kAISMode _Mode;
-        tN2kAISTransceiverInformation  _AISTransceiverInformation;
+        tN2kAISTransceiverInformation  _AISTranceiverInformation;
         uint8_t _SID;
 
         if (ParseN2kPGN129039(N2kMsg, _MessageID, _Repeat, _UserID, _Latitude, _Longitude, _Accuracy, _RAIM,
-                              _Seconds, _COG, _SOG, _AISTransceiverInformation, _Heading, _Unit, _Display, _DSC, _Band, _Msg22, _Mode, _State,_SID))
+                              _Seconds, _COG, _SOG, _AISTranceiverInformation, _Heading, _Unit, _Display, _DSC, _Band, _Msg22, _Mode, _State,_SID))
         {
 
             tNMEA0183AISMsg NMEA0183AISMsg;
-            setTalkerChannel(NMEA0183AISMsg,_AISTransceiverInformation);
+
             if (SetAISClassBMessage18(NMEA0183AISMsg, _MessageID, _Repeat, _UserID, _Latitude, _Longitude, _Accuracy, _RAIM,
                                       _Seconds, _COG, _SOG,  _Heading, _Unit, _Display, _DSC, _Band, _Msg22, _Mode, _State))
             {
 
                 SendMessage(NMEA0183AISMsg);
 
+#ifdef SERIAL_PRINT_AIS_NMEA
+                // Debug Print AIS-NMEA
+                Serial.print(NMEA0183AISMsg.GetPrefix());
+                Serial.print(NMEA0183AISMsg.Sender());
+                Serial.print(NMEA0183AISMsg.MessageCode());
+                for (int i = 0; i < NMEA0183AISMsg.FieldCount(); i++)
+                {
+                    Serial.print(",");
+                    Serial.print(NMEA0183AISMsg.Field(i));
+                }
+                char buf[7];
+                sprintf(buf, "*%02X\r\n", NMEA0183AISMsg.GetCheckSum());
+                Serial.print(buf);
+#endif
             }
         }
         return;
@@ -876,10 +976,8 @@ private:
         {
 
             tNMEA0183AISMsg NMEA0183AISMsg;
-            setTalkerChannel(NMEA0183AISMsg,_AISInfo);
             if (SetAISClassBMessage24PartA(NMEA0183AISMsg, _MessageID, _Repeat, _UserID, _Name))
             {
-                SendMessage(NMEA0183AISMsg);
             }
         }
         return;
@@ -907,51 +1005,77 @@ private:
                               _Length, _Beam, _PosRefStbd, _PosRefBow, _MothershipID,_AISInfo,_SID))
         {
 
+//
+#ifdef SERIAL_PRINT_AIS_FIELDS
+            // Debug Print N2k Values
+            Serial.println("––––––––––––––––––––––– Msg 24 ––––––––––––––––––––––––––––––––");
+            Serial.print("MessageID: ");
+            Serial.println(_MessageID);
+            Serial.print("Repeat: ");
+            Serial.println(_Repeat);
+            Serial.print("UserID: ");
+            Serial.println(_UserID);
+            Serial.print("VesselType: ");
+            Serial.println(_VesselType);
+            Serial.print("Vendor: ");
+            Serial.println(_Vendor);
+            Serial.print("Callsign: ");
+            Serial.println(_Callsign);
+            Serial.print("Length: ");
+            Serial.println(_Length);
+            Serial.print("Beam: ");
+            Serial.println(_Beam);
+            Serial.print("PosRefStbd: ");
+            Serial.println(_PosRefStbd);
+            Serial.print("PosRefBow: ");
+            Serial.println(_PosRefBow);
+            Serial.print("MothershipID: ");
+            Serial.println(_MothershipID);
+            Serial.println("––––––––––––––––––––––– Msg 24 ––––––––––––––––––––––––––––––––");
+#endif
+
             tNMEA0183AISMsg NMEA0183AISMsg;
-            setTalkerChannel(NMEA0183AISMsg,_AISInfo);
-            if (SetAISClassBMessage24PartB(NMEA0183AISMsg, _MessageID, _Repeat, _UserID, _VesselType, _Vendor, _Callsign,
+
+            if (SetAISClassBMessage24(NMEA0183AISMsg, _MessageID, _Repeat, _UserID, _VesselType, _Vendor, _Callsign,
                                       _Length, _Beam, _PosRefStbd, _PosRefBow, _MothershipID))
             {
-                SendMessage(NMEA0183AISMsg);             
+
+                SendMessage(NMEA0183AISMsg.BuildMsg24PartA(NMEA0183AISMsg));
+
+#ifdef SERIAL_PRINT_AIS_NMEA
+                // Debug Print AIS-NMEA
+                char buf[7];
+                Serial.print(NMEA0183AISMsg.GetPrefix());
+                Serial.print(NMEA0183AISMsg.Sender());
+                Serial.print(NMEA0183AISMsg.MessageCode());
+                for (int i = 0; i < NMEA0183AISMsg.FieldCount(); i++)
+                {
+                    Serial.print(",");
+                    Serial.print(NMEA0183AISMsg.Field(i));
+                }
+                sprintf(buf, "*%02X\r\n", NMEA0183AISMsg.GetCheckSum());
+                Serial.print(buf);
+#endif
+
+                SendMessage(NMEA0183AISMsg.BuildMsg24PartB(NMEA0183AISMsg));
+
+#ifdef SERIAL_PRINT_AIS_NMEA
+                Serial.print(NMEA0183AISMsg.GetPrefix());
+                Serial.print(NMEA0183AISMsg.Sender());
+                Serial.print(NMEA0183AISMsg.MessageCode());
+                for (int i = 0; i < NMEA0183AISMsg.FieldCount(); i++)
+                {
+                    Serial.print(",");
+                    Serial.print(NMEA0183AISMsg.Field(i));
+                }
+                sprintf(buf, "*%02X\r\n", NMEA0183AISMsg.GetCheckSum());
+                Serial.print(buf);
+#endif
             }
         }
         return;
     }
 
-    //*****************************************************************************
-    // PGN 129041 Aton
-    void HandleAISMessage21(const tN2kMsg &N2kMsg)
-    {
-        tN2kAISAtoNReportData data;
-        if (ParseN2kPGN129041(N2kMsg,data)){
-            tNMEA0183AISMsg nmea0183Msg;
-            setTalkerChannel(nmea0183Msg,data.AISTransceiverInformation);
-            if (SetAISMessage21(
-                nmea0183Msg,
-                data.Repeat,
-                data.UserID,
-                data.Latitude,
-                data.Longitude,
-                data.Accuracy,
-                data.RAIM,
-                data.Seconds,
-                data.Length,
-                data.Beam,
-                data.PositionReferenceStarboard,
-                data.PositionReferenceTrueNorth,
-                data.AtoNType,
-                data.OffPositionIndicator,
-                data.VirtualAtoNFlag,
-                data.AssignedModeFlag,
-                data.GNSSType,
-                data.AtoNStatus,
-                data.AtoNName
-            )){
-                SendMessage(nmea0183Msg);
-            }
-        }
-    }
-
     void HandleSystemTime(const tN2kMsg &msg){
         unsigned char sid=-1;
         uint16_t DaysSince1970=N2kUInt16NA;
@@ -1147,12 +1271,12 @@ private:
         double Level=N2kDoubleNA;
         double Capacity=N2kDoubleNA;
         if (ParseN2kPGN127505(N2kMsg,Instance,FluidType,Level,Capacity)) {
-            GwXDRFoundMapping mapping=xdrMappings->getMapping(Level,XDRFLUID,FluidType,0,Instance);
+            GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRFLUID,FluidType,0,Instance);
             if (updateDouble(&mapping,Level)){
                 LOG_DEBUG(GwLog::DEBUG+1,"found fluidlevel mapping %s",mapping.definition->toString().c_str());
                 addToXdr(mapping.buildXdrEntry(Level));
             }
-            mapping=xdrMappings->getMapping(Capacity, XDRFLUID,FluidType,1,Instance);
+            mapping=xdrMappings->getMapping(XDRFLUID,FluidType,1,Instance);
             if (updateDouble(&mapping,Capacity)){
                 LOG_DEBUG(GwLog::DEBUG+1,"found fluid capacity mapping %s",mapping.definition->toString().c_str());
                 addToXdr(mapping.buildXdrEntry(Capacity));
@@ -1170,19 +1294,19 @@ private:
         double BatteryTemperature=N2kDoubleNA;
         if (ParseN2kPGN127508(N2kMsg,BatteryInstance,BatteryVoltage,BatteryCurrent,BatteryTemperature,SID)) {
             int i=0;
-            GwXDRFoundMapping mapping=xdrMappings->getMapping(BatteryVoltage, XDRBAT,0,0,BatteryInstance);
+            GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRBAT,0,0,BatteryInstance);
             if (updateDouble(&mapping,BatteryVoltage)){
                 LOG_DEBUG(GwLog::DEBUG+1,"found BatteryVoltage mapping %s",mapping.definition->toString().c_str());
                 addToXdr(mapping.buildXdrEntry(BatteryVoltage));
                 i++;
             }
-            mapping=xdrMappings->getMapping(BatteryCurrent,XDRBAT,0,1,BatteryInstance);
+            mapping=xdrMappings->getMapping(XDRBAT,0,1,BatteryInstance);
             if (updateDouble(&mapping,BatteryCurrent)){
                 LOG_DEBUG(GwLog::DEBUG+1,"found BatteryCurrent mapping %s",mapping.definition->toString().c_str());
                 addToXdr(mapping.buildXdrEntry(BatteryCurrent));
                 i++;
             }
-            mapping=xdrMappings->getMapping(BatteryTemperature,XDRBAT,0,2,BatteryInstance);
+            mapping=xdrMappings->getMapping(XDRBAT,0,2,BatteryInstance);
             if (updateDouble(&mapping,BatteryTemperature)){
                 LOG_DEBUG(GwLog::DEBUG+1,"found BatteryTemperature mapping %s",mapping.definition->toString().c_str());
                 addToXdr(mapping.buildXdrEntry(BatteryTemperature));
@@ -1214,13 +1338,13 @@ private:
             SendMessage(NMEA0183Msg);
         }
         int i=0;
-        GwXDRFoundMapping mapping=xdrMappings->getMapping(OutsideAmbientAirTemperature, XDRTEMP,N2kts_OutsideTemperature,0,0);
+        GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRTEMP,N2kts_OutsideTemperature,0,0);
         if (updateDouble(&mapping,OutsideAmbientAirTemperature)){
             LOG_DEBUG(GwLog::DEBUG+1,"found temperature mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(OutsideAmbientAirTemperature));
             i++;
         }
-        mapping=xdrMappings->getMapping(AtmosphericPressure,XDRPRESSURE,N2kps_Atmospheric,0,0);
+        mapping=xdrMappings->getMapping(XDRPRESSURE,N2kps_Atmospheric,0,0);
         if (updateDouble(&mapping,AtmosphericPressure)){
             LOG_DEBUG(GwLog::DEBUG+1,"found pressure mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(AtmosphericPressure));
@@ -1255,19 +1379,19 @@ private:
             SendMessage(NMEA0183Msg);
         }
 
-        GwXDRFoundMapping mapping=xdrMappings->getMapping(Temperature, XDRTEMP,TempSource,0,0);
+        GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRTEMP,TempSource,0,0);
         if (updateDouble(&mapping,Temperature)){
             LOG_DEBUG(GwLog::DEBUG+1,"found temperature mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(Temperature));
             i++;
         }
-        mapping=xdrMappings->getMapping(Humidity, XDRHUMIDITY,HumiditySource,0,0);
+        mapping=xdrMappings->getMapping(XDRHUMIDITY,HumiditySource,0,0);
         if (updateDouble(&mapping,Humidity)){
             LOG_DEBUG(GwLog::DEBUG+1,"found humidity mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(Humidity));
             i++;
         }   
-        mapping=xdrMappings->getMapping(AtmosphericPressure, XDRPRESSURE,N2kps_Atmospheric,0,0);
+        mapping=xdrMappings->getMapping(XDRPRESSURE,N2kps_Atmospheric,0,0);
         if (updateDouble(&mapping,AtmosphericPressure)){
             LOG_DEBUG(GwLog::DEBUG+1,"found pressure mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(AtmosphericPressure));
@@ -1302,12 +1426,12 @@ private:
             SendMessage(NMEA0183Msg);
         }
 
-        GwXDRFoundMapping mapping=xdrMappings->getMapping(Temperature, XDRTEMP,(int)TemperatureSource,0,TemperatureInstance);
+        GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRTEMP,(int)TemperatureSource,0,TemperatureInstance);
         if (updateDouble(&mapping,Temperature)){
             LOG_DEBUG(GwLog::DEBUG+1,"found temperature mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(Temperature));
         }
-        mapping=xdrMappings->getMapping(setTemperature, XDRTEMP,(int)TemperatureSource,1,TemperatureInstance);
+        mapping=xdrMappings->getMapping(XDRTEMP,(int)TemperatureSource,1,TemperatureInstance);
         if (updateDouble(&mapping,setTemperature)){
             LOG_DEBUG(GwLog::DEBUG+1,"found temperature mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(setTemperature));
@@ -1325,13 +1449,12 @@ private:
            LOG_DEBUG(GwLog::DEBUG,"unable to parse PGN %d",msg.PGN);
            return;
         }
-        GwXDRFoundMapping mapping;
-        mapping=xdrMappings->getMapping(ActualHumidity, XDRHUMIDITY,(int)HumiditySource,0,HumidityInstance);
+        GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRHUMIDITY,(int)HumiditySource,0,HumidityInstance);
         if (updateDouble(&mapping,ActualHumidity)){
             LOG_DEBUG(GwLog::DEBUG+1,"found humidity mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(ActualHumidity));
         }
-        mapping=xdrMappings->getMapping(SetHumidity, XDRHUMIDITY,(int)HumiditySource,1,HumidityInstance);
+        mapping=xdrMappings->getMapping(XDRHUMIDITY,(int)HumiditySource,1,HumidityInstance);
         if (updateDouble(&mapping,SetHumidity)){
             LOG_DEBUG(GwLog::DEBUG+1,"found humidity mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(SetHumidity));
@@ -1349,7 +1472,7 @@ private:
             LOG_DEBUG(GwLog::DEBUG,"unable to parse PGN %d",msg.PGN);
             return; 
         }
-        GwXDRFoundMapping mapping=xdrMappings->getMapping(ActualPressure, XDRPRESSURE,(int)PressureSource,0,PressureInstance);
+        GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRPRESSURE,(int)PressureSource,0,PressureInstance);
         if (! updateDouble(&mapping,ActualPressure)) return;
         LOG_DEBUG(GwLog::DEBUG+1,"found pressure mapping %s",mapping.definition->toString().c_str());
         addToXdr(mapping.buildXdrEntry(ActualPressure));
@@ -1367,12 +1490,12 @@ private:
            LOG_DEBUG(GwLog::DEBUG,"unable to parse PGN %d",msg.PGN); 
         }
         for (int i=0;i<8;i++){
-            GwXDRFoundMapping mapping=xdrMappings->getMapping(values[i], XDRENGINE,0,i,instance);
+            GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRENGINE,0,i,instance);
             if (! updateDouble(&mapping,values[i])) continue; 
             addToXdr(mapping.buildXdrEntry(values[i])); 
         }
         for (int i=0;i< 2;i++){
-            GwXDRFoundMapping mapping=xdrMappings->getMapping(ivalues[i],XDRENGINE,0,i+8,instance);
+            GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRENGINE,0,i+8,instance);
             if (! updateDouble(&mapping,ivalues[i])) continue; 
             addToXdr(mapping.buildXdrEntry((double)ivalues[i])); 
         }
@@ -1388,7 +1511,7 @@ private:
            LOG_DEBUG(GwLog::DEBUG,"unable to parse PGN %d",msg.PGN); 
         }
         for (int i=0;i<3;i++){
-            GwXDRFoundMapping mapping=xdrMappings->getMapping(values[i], XDRATTITUDE,0,i,instance);
+            GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRATTITUDE,0,i,instance);
             if (! updateDouble(&mapping,values[i])) continue; 
             addToXdr(mapping.buildXdrEntry(values[i])); 
         }
@@ -1402,15 +1525,15 @@ private:
             speed,pressure,tilt)){
            LOG_DEBUG(GwLog::DEBUG,"unable to parse PGN %d",msg.PGN); 
         }
-        GwXDRFoundMapping mapping=xdrMappings->getMapping(speed, XDRENGINE,0,10,instance);
+        GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRENGINE,0,10,instance);
         if (updateDouble(&mapping,speed)){
             addToXdr(mapping.buildXdrEntry(speed)); 
         }
-        mapping=xdrMappings->getMapping(pressure, XDRENGINE,0,11,instance);
+        mapping=xdrMappings->getMapping(XDRENGINE,0,11,instance);
         if (updateDouble(&mapping,pressure)){
             addToXdr(mapping.buildXdrEntry(pressure)); 
         }
-        mapping=xdrMappings->getMapping(tilt, XDRENGINE,0,12,instance);
+        mapping=xdrMappings->getMapping(XDRENGINE,0,12,instance);
         if (updateDouble(&mapping,tilt)){
             addToXdr(mapping.buildXdrEntry((double)tilt)); 
         }
@@ -1436,12 +1559,12 @@ private:
            LOG_DEBUG(GwLog::DEBUG,"unable to parse PGN %d",msg.PGN);
            return;
         }
-        GwXDRFoundMapping mapping=xdrMappings->getMapping(Temperature, XDRTEMP,(int)TemperatureSource,0,TemperatureInstance);
+        GwXDRFoundMapping mapping=xdrMappings->getMapping(XDRTEMP,(int)TemperatureSource,0,TemperatureInstance);
         if (updateDouble(&mapping,Temperature)){
             LOG_DEBUG(GwLog::DEBUG+1,"found temperature mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(Temperature));
         }
-        mapping=xdrMappings->getMapping(setTemperature, XDRTEMP,(int)TemperatureSource,1,TemperatureInstance);
+        mapping=xdrMappings->getMapping(XDRTEMP,(int)TemperatureSource,1,TemperatureInstance);
         if (updateDouble(&mapping,setTemperature)){
             LOG_DEBUG(GwLog::DEBUG+1,"found temperature mapping %s",mapping.definition->toString().c_str());
             addToXdr(mapping.buildXdrEntry(setTemperature));
@@ -1491,7 +1614,6 @@ private:
       converters.registerConverter(129794UL, &N2kToNMEA0183Functions::HandleAISClassAMessage5);   // AIS Class A Ship Static and Voyage related data, Message Type 5
       converters.registerConverter(129809UL, &N2kToNMEA0183Functions::HandleAISClassBMessage24A); // AIS Class B "CS" Static Data Report, Part A
       converters.registerConverter(129810UL, &N2kToNMEA0183Functions::HandleAISClassBMessage24B); // AIS Class B "CS" Static Data Report, Part B
-      converters.registerConverter(129041UL, &N2kToNMEA0183Functions::HandleAISMessage21);        // AIS Aton
 #endif
     }
 

lib/nmea2ktoais/NMEA0183AISMessages.cpp

@@ -26,7 +26,7 @@ OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 */
 
-#include "NMEA0183AISMessages.h"
+#include <NMEA0183AISMessages.h>
 #include <N2kTypes.h>
 #include <N2kMsg.h>
 #include <string.h>
@@ -34,7 +34,7 @@ OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 //#include <unordered_map>
 #include <sstream>
 #include <math.h>
-#include "NMEA0183AISMsg.h"
+#include <NMEA0183AISMsg.h>
 
 const double pi=3.1415926535897932384626433832795;
 const double kmhToms=1000.0/3600.0;
@@ -47,15 +47,17 @@ const double nmTom=1.852*1000;
 const double mToFathoms=0.546806649;
 const double mToFeet=3.2808398950131;
 const double radsToDegMin = 60 * 360.0 / (2 * pi);    // [rad/s -> degree/minute]
+const char Prefix='!';
 
+std::vector<ship *> vships;
 
+int numShips(){return vships.size();}
 // ************************  Helper for AIS  ***********************************
 static bool AddMessageType(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageType);
 static bool AddRepeat(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t Repeat);
 static bool AddUserID(tNMEA0183AISMsg &NMEA0183AISMsg, uint32_t UserID);
 static bool AddIMONumber(tNMEA0183AISMsg &NMEA0183AISMsg, uint32_t &IMONumber);
 static bool AddText(tNMEA0183AISMsg &NMEA0183AISMsg, char *FieldVal, uint8_t length);
-//static bool AddVesselType(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t VesselType);
 static bool AddDimensions(tNMEA0183AISMsg &NMEA0183AISMsg, double Length, double Beam, double PosRefStbd, double PosRefBow);
 static bool AddNavStatus(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t &NavStatus);
 static bool AddROT(tNMEA0183AISMsg &NMEA0183AISMsg, double &rot);
@@ -89,7 +91,7 @@ bool SetAISClassABMessage1( tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageType
   if ( !AddNavStatus(NMEA0183AISMsg, NavStatus) ) return false;        // 38-41    | 4    Navigational Status  e.g.: "Under way sailing"
   if ( !AddROT(NMEA0183AISMsg, ROT) ) return false;                    // 42-49    | 8    Rate of Turn (ROT)
   if ( !AddSOG(NMEA0183AISMsg, SOG) ) return false;                    // 50-59    | 10   [m/s -> kts]  SOG with one digit  x10, 1023 = N/A
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Accuracy) ) return false;// 60       | 1    GPS Accuracy 1 oder 0, Default 0
+  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Accuracy, 1) ) return false;// 60       | 1    GPS Accuracy 1 oder 0, Default 0
   if ( !AddLongitude(NMEA0183AISMsg, Longitude) ) return false;        // 61-88    | 28  Longitude in Minutes / 10000
   if ( !AddLatitude(NMEA0183AISMsg, Latitude) ) return false;          // 89-115   | 27  Latitude in Minutes / 10000
   if ( !AddCOG(NMEA0183AISMsg, COG) ) return false;                    // 116-127  | 12  Course over ground will be 3600 (0xE10) if that data is not available.
@@ -97,12 +99,17 @@ bool SetAISClassABMessage1( tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageType
   if ( !AddSeconds(NMEA0183AISMsg, Seconds) ) return false;            // 137-142  | 6    Seconds in UTC timestamp)
   if ( !NMEA0183AISMsg.AddIntToPayloadBin(0, 2) ) return false;        // 143-144  | 2    Maneuver Indicator: 0 (default) 1, 2  (not delivered within this PGN)
   if ( !NMEA0183AISMsg.AddIntToPayloadBin(0, 3) ) return false;        // 145-147  | 3   Spare
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(RAIM) ) return false;    // 148-148  | 1   RAIM flag 0 = RAIM not in use (default), 1 = RAIM in use
+  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(RAIM, 1) ) return false;    // 148-148  | 1   RAIM flag 0 = RAIM not in use (default), 1 = RAIM in use
   if ( !NMEA0183AISMsg.AddIntToPayloadBin(0, 19) ) return false;       // 149-167  | 19  Radio Status  (-> 0 NOT SENT WITH THIS PGN!!!!!)
-  if ( !NMEA0183AISMsg.InitAis()) return false;        
-  int padBits=0;
-  if ( !NMEA0183AISMsg.AddStrField( NMEA0183AISMsg.GetPayloadFix(padBits) ) ) return false;
-  if ( !NMEA0183AISMsg.AddUInt32Field(padBits) ) return false;           
+
+  if ( !NMEA0183AISMsg.Init("VDM","AI", Prefix) ) return false;
+  if ( !NMEA0183AISMsg.AddStrField("1") ) return false;
+  if ( !NMEA0183AISMsg.AddStrField("1") ) return false;
+  if ( !NMEA0183AISMsg.AddEmptyField() ) return false;
+  if ( !NMEA0183AISMsg.AddStrField("A") ) return false;
+  if ( !NMEA0183AISMsg.AddStrField( NMEA0183AISMsg.GetPayload() ) ) return false;
+  if ( !NMEA0183AISMsg.AddStrField("0") ) return false;    // Message 1,2,3 has always Zero Padding
+
   return true;
 }
 
@@ -114,16 +121,14 @@ bool  SetAISClassAMessage5(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, u
                           uint32_t UserID, uint32_t IMONumber, char *Callsign, char *Name,
                           uint8_t VesselType, double Length, double Beam, double PosRefStbd,
                           double PosRefBow, uint16_t ETAdate,  double ETAtime, double Draught,
-                          char *Destination, tN2kGNSStype GNSStype, uint8_t DTE,
-                          tN2kAISVersion AISversion) {
+                          char *Destination, tN2kGNSStype GNSStype, uint8_t DTE ) {
 
   // AIS Type 5 Message
   NMEA0183AISMsg.ClearAIS();
   if ( !AddMessageType(NMEA0183AISMsg, 5) ) return false;                // 0 - 5     | 6    Message Type -> Constant: 5
   if ( !AddRepeat(NMEA0183AISMsg, Repeat) ) return false;                // 6 - 7     | 2    Repeat Indicator: 0 = default; 3 = do not repeat any more
   if ( !AddUserID(NMEA0183AISMsg, UserID) ) return false;                // 8 - 37    | 30  MMSI
-  if ( !NMEA0183AISMsg.AddIntToPayloadBin((uint32_t)AISversion, 2) ) 
-    return false;                                                        // 38 - 39   |  2   AIS Version  -> 0 oder 1  NOT DERIVED FROM N2k, Always 1!!!!
+  if ( !NMEA0183AISMsg.AddIntToPayloadBin(1, 2) ) return false;          // 38 - 39   |  2   AIS Version  -> 0 oder 1  NOT DERIVED FROM N2k, Always 1!!!!
   if ( !AddIMONumber(NMEA0183AISMsg, IMONumber) ) return false;          // 40 - 69   | 30   IMO Number unisgned
   if ( !AddText(NMEA0183AISMsg, Callsign, 42) ) return false;            // 70 - 111  | 42   Call Sign  WDE4178      -> 7  6-bit characters -> Ascii lt. Table)
   if ( !AddText(NMEA0183AISMsg, Name, 120) ) return false;               // 112-231   | 120 Vessel Name  POINT FERMIN  -> 20 6-bit characters -> Ascii lt. Table
@@ -141,12 +146,10 @@ bool  SetAISClassAMessage5(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, u
 
 //  ****************************************************************************
 // AIS position report (class B 129039) -> Type 18: Standard Class B CS Position Report
-// PGN129039
-// ParseN2kAISClassBPosition(const tN2kMsg &N2kMsg, uint8_t &MessageID, tN2kAISRepeat &Repeat, uint32_t &UserID,
+//  ParseN2kPGN129039(const tN2kMsg &N2kMsg, uint8_t &MessageID, tN2kAISRepeat &Repeat, uint32_t &UserID,
 //                        double &Latitude, double &Longitude, bool &Accuracy, bool &RAIM,
-//                        uint8_t &Seconds, double &COG, double &SOG, tN2kAISTransceiverInformation &AISTransceiverInformation,
-//                        double &Heading, tN2kAISUnit &Unit, bool &Display, bool &DSC, bool &Band, bool &Msg22, tN2kAISMode &Mode,
-//                        bool &State)
+//                        uint8_t &Seconds, double &COG, double &SOG, double &Heading, tN2kAISUnit &Unit,
+//                        bool &Display, bool &DSC, bool &Band, bool &Msg22, tN2kAISMode &Mode, bool &State)
 //  VDM, VDO (AIS VHF Data-link message 18)
 bool SetAISClassBMessage18(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, uint8_t Repeat, uint32_t UserID,
                                   double Latitude, double Longitude, bool Accuracy, bool RAIM,
@@ -159,7 +162,7 @@ bool SetAISClassBMessage18(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, u
   if ( !AddUserID(NMEA0183AISMsg, UserID) ) return false;              // 8 - 37   | 30  MMSI
   if ( !NMEA0183AISMsg.AddIntToPayloadBin(0, 8) ) return false;        // 38-45    | 8   Regional Reserved
   if ( !AddSOG(NMEA0183AISMsg, SOG) ) return false;                    // 46-55    | 10   [m/s -> kts]  SOG with one digit  x10, 1023 = N/A
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Accuracy)) return false; // 56       | 1    GPS Accuracy 1 oder 0, Default 0
+  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Accuracy, 1)) return false; // 56       | 1    GPS Accuracy 1 oder 0, Default 0
   if ( !AddLongitude(NMEA0183AISMsg, Longitude) ) return false;        // 57-84    | 28  Longitude in Minutes / 10000
   if ( !AddLatitude(NMEA0183AISMsg, Latitude) ) return false;          // 85-111   | 27  Latitude in Minutes / 10000
   if ( !AddCOG(NMEA0183AISMsg, COG) ) return false;                    // 112-123  | 12  Course over ground will be 3600 (0xE10) if that data is not available.
@@ -168,16 +171,20 @@ bool SetAISClassBMessage18(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, u
   if ( !NMEA0183AISMsg.AddIntToPayloadBin(0, 2) ) return false;        // 139-140  | 2   Regional Reserved
   if ( !NMEA0183AISMsg.AddIntToPayloadBin(Unit, 1) ) return false;     // 141      | 1   0=Class B SOTDMA unit 1=Class B CS (Carrier Sense) unit
   if ( !NMEA0183AISMsg.AddIntToPayloadBin(Display, 1) ) return false;  // 142      | 1    0=No visual display, 1=Has display, (Probably not reliable).
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(DSC) ) return false;     // 143      | 1    If 1, unit is attached to a VHF voice radio with DSC capability.
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Band) ) return false;    // 144      | 1   If this flag is 1, the unit can use any part of the marine channel.
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Msg22)) return false;   // 145      | 1   If 1, unit can accept a channel assignment via Message Type 22.
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Mode) ) return false;    // 146      | 1   Assigned-mode flag: 0 = autonomous mode (default), 1 = assigned mode
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(RAIM) ) return false;    // 147      | 1   as for Message Type 1,2,3
+  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(DSC, 1) ) return false;     // 143      | 1    If 1, unit is attached to a VHF voice radio with DSC capability.
+  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Band, 1) ) return false;    // 144      | 1   If this flag is 1, the unit can use any part of the marine channel.
+  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Msg22, 1) ) return false;   // 145      | 1   If 1, unit can accept a channel assignment via Message Type 22.
+  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Mode, 1) ) return false;    // 146      | 1   Assigned-mode flag: 0 = autonomous mode (default), 1 = assigned mode
+  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(RAIM, 1) ) return false;    // 147      | 1   as for Message Type 1,2,3
   if ( !NMEA0183AISMsg.AddIntToPayloadBin(0, 20) ) return false;       // 148-167  | 20  Radio Status not in PGN 129039
-  if ( !NMEA0183AISMsg.InitAis()) return false;        
-  int padBits=0;
-  if ( !NMEA0183AISMsg.AddStrField( NMEA0183AISMsg.GetPayloadFix(padBits) ) ) return false;
-  if ( !NMEA0183AISMsg.AddUInt32Field(padBits) ) return false;    
+
+  if ( !NMEA0183AISMsg.Init("VDM","AI", Prefix) ) return false;
+  if ( !NMEA0183AISMsg.AddStrField("1") ) return false;
+  if ( !NMEA0183AISMsg.AddStrField("1") ) return false;
+  if ( !NMEA0183AISMsg.AddEmptyField() ) return false;
+  if ( !NMEA0183AISMsg.AddStrField("B") ) return false;
+  if ( !NMEA0183AISMsg.AddStrField( NMEA0183AISMsg.GetPayload() ) ) return false;
+  if ( !NMEA0183AISMsg.AddStrField("0") ) return false;    // Message 18, has always Zero Padding
 
   return true;
 }
@@ -210,28 +217,41 @@ bool SetAISClassBMessage18(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, u
 //  Part A: MessageID, Repeat, UserID, ShipName -> store in vector to call on Part B arrivals!!!
 //  Part B: MessageID, Repeat, UserID, VesselType (5), Callsign (5), Length & Beam, PosRefBow,.. (5)
 bool SetAISClassBMessage24PartA(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, uint8_t Repeat, uint32_t UserID, char *Name) {
-  // AIS Type 24 Message
-  NMEA0183AISMsg.ClearAIS();
-  // Common for PART A AND Part B Bit 0 - 39 / len 40
-  if ( !AddMessageType(NMEA0183AISMsg, 24) ) return false;                // 0 - 5    | 6    Message Type -> Constant: 24
-  if ( !AddRepeat(NMEA0183AISMsg, Repeat) ) return false;                 // 6 - 7    | 2    Repeat Indicator: 0 = default; 3 = do not repeat any more
-  if ( !AddUserID(NMEA0183AISMsg, UserID) ) return false;                 // 8 - 37   | 30  MMSI
-  if ( !NMEA0183AISMsg.AddIntToPayloadBin(0, 2) ) return false;           // 38-39    | 2    Part Number 0-1 ->
-  // Part A: 40 + 128 = len 168
-  if ( !AddText(NMEA0183AISMsg, Name, 120) ) return false;                // 40-159   | 120 Vessel Name  20 6-bit characters -> Ascii Table
-  if ( !NMEA0183AISMsg.AddIntToPayloadBin(0, 8) ) return false;           // 160-167  | 8    Spare
-  if ( !NMEA0183AISMsg.InitAis() ) return false;
-  int padBits=0;
-  if ( !NMEA0183AISMsg.AddStrField( NMEA0183AISMsg.GetPayloadFix(padBits) ) ) return false;
-  if ( !NMEA0183AISMsg.AddUInt32Field(padBits) ) return false;    
+
+  bool found = false;
+  for (size_t i = 0; i < vships.size(); i++) {
+    if ( vships[i]->_userID == UserID ) {
+      found = true;
+      break;
+    }
+  }
+  if ( ! found ) {
+    std::string nm;
+    nm+= Name;
+    vships.push_back(new ship(UserID, nm));
+  }
   return true;
 }
 
 // ***************************************************************************************************************
-bool  SetAISClassBMessage24PartB(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, uint8_t Repeat,
+bool  SetAISClassBMessage24(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, uint8_t Repeat,
                           uint32_t UserID, uint8_t VesselType, char *VendorID, char *Callsign,
                           double Length, double Beam, double PosRefStbd,  double PosRefBow, uint32_t MothershipID ) {
 
+  uint8_t PartNr = 0;            // Identifier for the message part number; always 0 for Part A
+  char *ShipName = (char*)" ";   // get from vector to look up for sent Messages Part A
+
+  uint8_t i;
+  for ( i = 0; i < vships.size(); i++) {
+    if ( vships[i]->_userID == UserID ) {
+      ShipName = const_cast<char*>( vships[i]->_shipName.c_str() );
+    }
+  }
+  if ( i > MAX_SHIP_IN_VECTOR ) {
+    std::vector<ship *>::iterator it=vships.begin();
+    delete *it;
+    vships.erase(it);
+  }
 
   // AIS Type 24 Message
   NMEA0183AISMsg.ClearAIS();
@@ -239,7 +259,11 @@ bool  SetAISClassBMessage24PartB(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t Messag
   if ( !AddMessageType(NMEA0183AISMsg, 24) ) return false;                // 0 - 5    | 6    Message Type -> Constant: 24
   if ( !AddRepeat(NMEA0183AISMsg, Repeat) ) return false;                 // 6 - 7    | 2    Repeat Indicator: 0 = default; 3 = do not repeat any more
   if ( !AddUserID(NMEA0183AISMsg, UserID) ) return false;                 // 8 - 37   | 30  MMSI
-  if ( !NMEA0183AISMsg.AddIntToPayloadBin(1, 2) ) return false;      // 38-39    | 2    Part Number 0-1 ->
+  if ( !NMEA0183AISMsg.AddIntToPayloadBin(PartNr, 2) ) return false;      // 38-39    | 2    Part Number 0-1 ->
+
+  // Part A: 40 + 128 = len 168
+  if ( !AddText(NMEA0183AISMsg, ShipName, 120) ) return false;            // 40-159   | 120 Vessel Name  20 6-bit characters -> Ascii Table
+  if ( !NMEA0183AISMsg.AddIntToPayloadBin(0, 8) ) return false;           // 160-167  | 8    Spare
 
   // https://www.navcen.uscg.gov/?pageName=AISMessagesB
   // PART B: 40 + 128 = len 168
@@ -248,59 +272,6 @@ bool  SetAISClassBMessage24PartB(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t Messag
   if ( !AddText(NMEA0183AISMsg, Callsign, 42) ) return false;                // 218-259 | 90-131 | 42   Call Sign  WDE4178      -> 7  6-bit characters, as in Msg Type 5
   if ( !AddDimensions(NMEA0183AISMsg, Length, Beam, PosRefStbd, PosRefBow) ) return false;  // 260-289 | 132-161 | 30 Dimensions
   if ( !NMEA0183AISMsg.AddIntToPayloadBin(0, 6) ) return false;              // 290-295 | 162-167 | 6    Spare
-  if ( !NMEA0183AISMsg.InitAis() ) return false;
-  int padBits=0;
-  if ( !NMEA0183AISMsg.AddStrField( NMEA0183AISMsg.GetPayloadFix(padBits) ) ) return false;
-  if ( !NMEA0183AISMsg.AddUInt32Field(padBits) ) return false;                            
-  return true;
-}
-
-//  ****************************************************************************
-// AIS ATON report (129041) -> Type 21: Position and status report for aids-to-navigation
-// PGN129041
-
-bool SetAISMessage21(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t Repeat, uint32_t UserID,
-			   double Latitude, double Longitude, bool Accuracy, bool RAIM,
-			   uint8_t Seconds, double Length, double Beam, double PositionReferenceStarboard,
-         double PositionReferenceTrueNord, tN2kAISAtoNType Type, bool OffPositionIndicator,
-         bool VirtualAtoNFlag, bool AssignedModeFlag, tN2kGNSStype GNSSType, uint8_t AtoNStatus,
-         char * atonName ) {
-  //
-  NMEA0183AISMsg.ClearAIS();
-  if ( !AddMessageType(NMEA0183AISMsg, 21) ) return false;      // 0 - 5    | 6    Message Type -> Constant: 18
-  if ( !AddRepeat(NMEA0183AISMsg, Repeat) ) return false;              // 6 - 7    | 2    Repeat Indicator: 0 = default; 3 = do not repeat any more
-  if ( !AddUserID(NMEA0183AISMsg, UserID) ) return false;              // 8 - 37   | 30  MMSI
-  if ( ! NMEA0183AISMsg.AddIntToPayloadBin(Type,5)) return false;      //          | 5 aid type
-  //the name must be split:
-  //if it's > 120 bits the rest goes to the last parameter
-  if ( !NMEA0183AISMsg.AddEncodedCharToPayloadBin(atonName,120)) 
-    return false;                                                       //          | 120 name  
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(Accuracy) ) return false; //          | 1 accuracy
-  if ( !AddLongitude(NMEA0183AISMsg,Longitude)) return false;          //          | 28 lon
-  if ( !AddLatitude(NMEA0183AISMsg,Latitude)) return false;            //          | 27 lat
-  if ( !AddDimensions(NMEA0183AISMsg, Length, Beam, 
-    PositionReferenceStarboard, PositionReferenceTrueNord)) return false; //       | 30 dim
-  if ( !AddEPFDFixType(NMEA0183AISMsg,GNSSType)) return false;         //          | 4 fix type
-  if ( !AddSeconds(NMEA0183AISMsg,Seconds)) return false;              //          | 6 second
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(OffPositionIndicator)) 
-      return false;                                                    //          | 1 off
-  if ( !NMEA0183AISMsg.AddIntToPayloadBin(0,8)) return false;     //          | 8 reserverd
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(RAIM)) return false;      //          | 1 raim
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(VirtualAtoNFlag)) 
-      return false;                                                    //          | 1 virt
-  if ( !NMEA0183AISMsg.AddBoolToPayloadBin(AssignedModeFlag))
-      return false;                                                    //          | 1 assigned
-  if ( !NMEA0183AISMsg.AddIntToPayloadBin(0,1)) return false;          //          | 1 spare
-  size_t l=strlen(atonName);
-  if (l >=20){
-    uint8_t bitlen=(l-20)*6;
-    if (bitlen > 88) bitlen=88;
-    if ( !NMEA0183AISMsg.AddEncodedCharToPayloadBin(atonName+20,bitlen)) return false;    //          | name
-  }
-  if ( !NMEA0183AISMsg.InitAis() ) return false;
-  int padBits=0;
-  if ( !NMEA0183AISMsg.AddStrField( NMEA0183AISMsg.GetPayload(padBits) ) ) return false;
-  if ( !NMEA0183AISMsg.AddUInt32Field(padBits) ) return false;   
 
   return true;
 }
@@ -354,6 +325,7 @@ bool AddIMONumber(tNMEA0183AISMsg &NMEA0183AISMsg, uint32_t &IMONumber) {
 // 120bit Name or Destination
 bool AddText(tNMEA0183AISMsg &NMEA0183AISMsg, char *FieldVal, uint8_t length) {
   uint8_t len = length/6;
+
   if ( strlen(FieldVal) > len ) FieldVal[len] = 0;
   if ( !NMEA0183AISMsg.AddEncodedCharToPayloadBin(FieldVal, length) ) return false;
   return true;
@@ -375,26 +347,29 @@ bool AddDimensions(tNMEA0183AISMsg &NMEA0183AISMsg, double Length, double Beam,
   uint16_t _PosRefStbd = 0;
   uint16_t _PosRefPort = 0;
 
-  if ( PosRefBow >= 0.0 && PosRefBow <= 511.0 ) {
-    _PosRefBow = ceil(PosRefBow);
+  if (PosRefBow < 0) PosRefBow=0; //could be N2kIsNA
+  if ( PosRefBow <= 511.0 ) {
+    _PosRefBow = round(PosRefBow);
   } else {
     _PosRefBow = 511;
   }
-
-  if ( PosRefStbd >= 0.0 && PosRefStbd <= 63.0 ) {
-    _PosRefStbd = ceil(PosRefStbd);
+  if (PosRefStbd < 0 ) PosRefStbd=0; //could be N2kIsNA
+  if (PosRefStbd <= 63.0 ) {
+    _PosRefStbd = round(PosRefStbd);
   } else {
     _PosRefStbd = 63;
   }
 
   if ( !N2kIsNA(Length) ) {
-    _PosRefStern = ceil( Length ) - _PosRefBow;
-    if ( _PosRefStern < 0 ) _PosRefStern = 0;
+    if (Length >= PosRefBow){
+      _PosRefStern=round(Length - PosRefBow);
+    }
     if ( _PosRefStern > 511 ) _PosRefStern = 511;
   }
   if ( !N2kIsNA(Beam) ) {
-    _PosRefPort = ceil( Beam ) - _PosRefStbd;
-    if ( _PosRefPort < 0 ) _PosRefPort = 0;
+    if (Beam >= PosRefStbd){
+      _PosRefPort = round( Beam - PosRefStbd);  
+    }
     if ( _PosRefPort > 63 ) _PosRefPort = 63;
   }
 
@@ -597,5 +572,3 @@ bool AddETADateTime(tNMEA0183AISMsg &NMEA0183AISMsg, uint16_t &ETAdate, double &
   if ( ! NMEA0183AISMsg.AddIntToPayloadBin(minute, 6) ) return false;
   return true;
 }
-
-

lib/nmea2ktoais/NMEA0183AISMessages.h

@@ -27,16 +27,24 @@ OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #ifndef _tNMEA0183AISMessages_H_
 #define _tNMEA0183AISMessages_H_
 
-
 #include <stdio.h>
 #include <time.h>
 #include <string.h>
 #include <N2kTypes.h>
-#include "NMEA0183AISMsg.h"
+#include <NMEA0183AISMsg.h>
 #include <stddef.h>
 #include <vector>
 #include <string>
 
+#define MAX_SHIP_IN_VECTOR 200
+class ship {
+public:
+    uint32_t _userID;
+    std::string _shipName;
+
+    ship(uint32_t UserID, std::string ShipName) :  _userID(UserID), _shipName(ShipName) {}
+};
+
 
 // Types 1, 2 and 3: Position Report Class A or B
 bool SetAISClassABMessage1(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageType, uint8_t Repeat,
@@ -49,8 +57,7 @@ bool SetAISClassAMessage5(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, ui
                           uint32_t UserID, uint32_t IMONumber, char *Callsign, char *Name,
                           uint8_t VesselType, double Length, double Beam, double PosRefStbd,
                           double PosRefBow, uint16_t ETAdate,  double ETAtime, double Draught,
-                          char *Destination, tN2kGNSStype GNSStype, uint8_t DTE,
-                          tN2kAISVersion AISversion);
+                          char *Destination, tN2kGNSStype GNSStype, uint8_t DTE );
 
 //*****************************************************************************
 // AIS position report (class B 129039) -> Standard Class B CS Position Report Message Type 18 Part B
@@ -66,19 +73,11 @@ bool SetAISClassBMessage24PartA(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t Message
 
 //*****************************************************************************
 // Static Data Report Class B, Message Type 24
-bool  SetAISClassBMessage24PartB(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, uint8_t Repeat,
+bool  SetAISClassBMessage24(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t MessageID, uint8_t Repeat,
                           uint32_t UserID, uint8_t VesselType, char *VendorID, char *Callsign,
                            double Length, double Beam, double PosRefStbd,  double PosRefBow, uint32_t MothershipID );
 
-//*****************************************************************************
-// Aton class 21
-bool SetAISMessage21(tNMEA0183AISMsg &NMEA0183AISMsg, uint8_t Repeat, uint32_t UserID,
-			   double Latitude, double Longitude, bool Accuracy, bool RAIM,
-			   uint8_t Seconds, double Length, double Beam, double PositionReferenceStarboard,
-         double PositionReferenceTrueNord, tN2kAISAtoNType Type, bool OffPositionIndicator,
-         bool VirtualAtoNFlag, bool AssignedModeFlag, tN2kGNSStype GNSSType, uint8_t AtoNStatus,
-         char * atonName );
-
+int numShips();
 inline int32_t aRoundToInt(double x) {
   return x >= 0
       ? (int32_t) floor(x + 0.5)

lib/nmea2ktoais/NMEA0183AISMsg.cpp

@@ -25,7 +25,7 @@ OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 #include "NMEA0183AISMsg.h"
 #include <NMEA0183Msg.h>
-//#include <Arduino.h>
+#include <Arduino.h>
 #include <math.h>
 #include <stdint.h>
 #include <stdlib.h>
@@ -43,37 +43,52 @@ tNMEA0183AISMsg::tNMEA0183AISMsg() {
 //*****************************************************************************
 void tNMEA0183AISMsg::ClearAIS() {
 
+  PayloadBin[0]=0;
   Payload[0]=0;
-  PayloadBin.reset();
   iAddPldBin=0;
   iAddPld=0;
 }
 
+//*****************************************************************************
+// Add 6bit with no data.
+bool tNMEA0183AISMsg::AddEmptyFieldToPayloadBin(uint8_t iBits) {
+
+  if ( (iAddPldBin + iBits * 6) >= AIS_BIN_MAX_LEN ) return false; // Is there room for any data
+
+  for (uint8_t i=0;i<iBits;i++) {
+    strncpy(PayloadBin+iAddPldBin, EmptyAISField, 6);
+    iAddPldBin+=6;
+  }
+
+  return true;
+}
 
 //*****************************************************************************
 bool tNMEA0183AISMsg::AddIntToPayloadBin(int32_t ival, uint16_t countBits) {
 
   if ( (iAddPldBin + countBits ) >= AIS_BIN_MAX_LEN ) return false; // Is there room for any data
 
-  bset = ival;
+  AISBitSet bset(ival);
 
+  PayloadBin[iAddPldBin]=0;
   uint16_t iAdd=iAddPldBin;
 
   for(int i = countBits-1; i >= 0 ; i--) {
-    PayloadBin[iAdd]=bset [i];
+    PayloadBin[iAdd] = bset[i]?'1':'0';
     iAdd++;
   }
 
   iAddPldBin += countBits;
+  PayloadBin[iAddPldBin]=0;
 
   return true;
 }
 
 //  ****************************************************************************
-bool tNMEA0183AISMsg::AddBoolToPayloadBin(bool &bval) {
-  if ( (iAddPldBin + 1 ) >= AIS_BIN_MAX_LEN ) return false;
-  PayloadBin[iAddPldBin]=bval;
-  iAddPldBin++; 
+bool tNMEA0183AISMsg::AddBoolToPayloadBin(bool &bval, uint8_t size) {
+  int8_t iTemp;
+  (bval == true)? iTemp = 1 : iTemp = 0;
+  if ( ! AddIntToPayloadBin(iTemp, size) ) return false;
   return true;
 }
 
@@ -84,11 +99,13 @@ bool tNMEA0183AISMsg::AddEncodedCharToPayloadBin(char *sval, size_t countBits) {
 
   if ( (iAddPldBin + countBits ) >= AIS_BIN_MAX_LEN ) return false; // Is there room for any data
 
-  const char * ptr;
+  PayloadBin[iAddPldBin]=0;
+  std::bitset<6> bs;
+  char * ptr;
   size_t len = strlen(sval);  // e.g.: should be 7 for Callsign
   if ( len * 6 > countBits ) len = countBits / 6;
 
-  for (size_t i = 0; i<len; i++) {
+  for (int i = 0; i<len; i++) {
 
     ptr = strchr(AsciiChar, sval[i]);
     if ( ptr ) {
@@ -100,44 +117,37 @@ bool tNMEA0183AISMsg::AddEncodedCharToPayloadBin(char *sval, size_t countBits) {
       AddIntToPayloadBin(0, 6);
     }
   }
+
+  PayloadBin[iAddPldBin+1]=0;
+
   // fill up with "@", also covers empty sval
   if ( len * 6 < countBits ) {
-    for (size_t i=0;i<(countBits/6-len);i++) {
+    for (int i=0;i<(countBits/6-len);i++) {
       AddIntToPayloadBin(0, 6);
     }
   }
+  PayloadBin[iAddPldBin]=0;
   return true;
 }
 
 // *****************************************************************************
-template <unsigned int S>
-int tNMEA0183AISMsg::ConvertBinaryAISPayloadBinToAscii(std::bitset<S> &src,uint16_t maxSize,uint16_t bitSize,uint16_t stoffset) {
-  Payload[0]='\0';
-  uint16_t slen=maxSize;
-  if (stoffset >= slen) return 0;
-  slen-=stoffset;
-  uint16_t bitLen=bitSize > 0?bitSize:slen;
-  uint16_t len= bitLen / 6; 
-  if ((len * 6) < bitLen) len+=1;
-  uint16_t padBits=0; 
+bool tNMEA0183AISMsg::ConvertBinaryAISPayloadBinToAscii(const char *payloadbin) {
+  uint16_t len;
+
+  len = strlen( payloadbin ) / 6;  // 28
   uint32_t offset;
-  std::bitset<6> s;
+  char s[7];
   uint8_t dec;
   int i;
   for ( i=0; i<len; i++ ) {
     offset = i * 6;
-    int k = 5;
-    for (uint32_t j=offset; j<offset+6; j++ ) {
-      if (j < slen){
-        s[k] = src[stoffset+j];
+    int k = 0;
+    for (int j=offset; j<offset+6; j++ ) {
+      s[k] = payloadbin[j];
+       k++;
     }
-      else{
     s[k]=0;
-        padBits++;
-      }
-      k--;
-    }
-    dec = s.to_ulong();
+    dec = strtoull (s, NULL, 2);  //binToDec
 
     if (dec < 40 ) dec += 48;
     else dec += 56;
@@ -146,56 +156,142 @@ int tNMEA0183AISMsg::ConvertBinaryAISPayloadBinToAscii(std::bitset<S> &src,uint1
   }
   Payload[i]=0;
 
-  return padBits;
-}
-
-void tNMEA0183AISMsg::SetChannelAndTalker(bool channelA,bool own){
-  channel[0]=channelA?'A':'B';
-  strcpy(talker,own?"VDO":"VDM");
+  return true;
 }
 
 //**********************  BUILD 2-parted AIS Sentences  ************************
-bool tNMEA0183AISMsg::InitAis(int max,int number,int sequence){
-  if ( !Init(talker,"AI", '!') ) return false;
-  if ( !AddUInt32Field(max) ) return false;
-  if ( !AddUInt32Field(number) ) return false;
-  if (sequence >= 0){
-    if ( !AddUInt32Field(sequence) ) return false;
-  }
-  else{
-    if ( !AddEmptyField() ) return false;
-  }
-  if ( !AddStrField(channel) ) return false;
-  return true;
-}
-bool  tNMEA0183AISMsg::BuildMsg5Part1() {
-  if ( iAddPldBin != 424 ) return false;
-  InitAis(2,1,5);
-  int padBits=0;
-  AddStrField( GetPayload(padBits,0,336));
-  AddUInt32Field(padBits);
-  return true;
+const tNMEA0183AISMsg&  tNMEA0183AISMsg::BuildMsg5Part1(tNMEA0183AISMsg &AISMsg) {
+
+  Init("VDM", "AI", '!');
+  AddStrField("2");
+  AddStrField("1");
+  AddStrField("5");
+  AddStrField("A");
+  AddStrField( GetPayloadType5_Part1() );
+  AddStrField("0");
+
+  return AISMsg;
 }
 
-bool  tNMEA0183AISMsg::BuildMsg5Part2() {
-  if ( iAddPldBin != 424 ) return false;
-  InitAis(2,2,5);
-  int padBits=0;
-  AddStrField( GetPayload(padBits,336,88) );
-  AddUInt32Field(padBits);
-  return true;
+const tNMEA0183AISMsg&  tNMEA0183AISMsg::BuildMsg5Part2(tNMEA0183AISMsg &AISMsg) {
+
+  Init("VDM", "AI", '!');
+  AddStrField("2");
+  AddStrField("2");
+  AddStrField("5");
+  AddStrField("A");
+  AddStrField( GetPayloadType5_Part2() );
+  AddStrField("2"); // Message 5, Part 2 has always 2 Padding Zeros
+
+  return AISMsg;
 }
 
+const tNMEA0183AISMsg&  tNMEA0183AISMsg::BuildMsg24PartA(tNMEA0183AISMsg &AISMsg) {
+
+  Init("VDM", "AI", '!');
+  AddStrField("1");
+  AddStrField("1");
+  AddEmptyField();
+  AddStrField("A");
+  AddStrField( GetPayloadType24_PartA() );
+  AddStrField("0");
+
+  return AISMsg;
+}
+
+const tNMEA0183AISMsg& tNMEA0183AISMsg::BuildMsg24PartB(tNMEA0183AISMsg &AISMsg) {
+
+  Init("VDM", "AI", '!');
+  AddStrField("1");
+  AddStrField("1");
+  AddEmptyField();
+  AddStrField("A");
+  AddStrField( GetPayloadType24_PartB() );
+  AddStrField("0");    // Message 24, both parts have always Zero Padding
+
+  return AISMsg;
+}
 
 //*******************************  AIS PAYLOADS  *********************************
+//******************************************************************************
 // get converted Payload for Message 1, 2, 3 & 18, always Length 168
-const char *tNMEA0183AISMsg::GetPayloadFix(int &padBits,uint16_t fixLen){
-  uint16_t lenbin = iAddPldBin;
-  if ( lenbin != fixLen ) return nullptr;
-  return GetPayload(padBits,0,0);
-}
-const char *tNMEA0183AISMsg::GetPayload(int &padBits,uint16_t offset,uint16_t bitLen) {
-  padBits=ConvertBinaryAISPayloadBinToAscii<AIS_BIN_MAX_LEN>(PayloadBin,iAddPldBin, bitLen,offset );
+const char *tNMEA0183AISMsg::GetPayload() {
+
+  uint16_t lenbin = strlen( PayloadBin);
+  if ( lenbin != 168 ) return nullptr;
+
+  if ( !ConvertBinaryAISPayloadBinToAscii( PayloadBin ) ) return nullptr;
   return Payload;
 }
 
+//******************************************************************************
+// get converted Part 1 of Payload for Message 5
+const char *tNMEA0183AISMsg::GetPayloadType5_Part1() {
+
+  uint16_t lenbin = strlen( PayloadBin);
+  if ( lenbin != 424 ) return nullptr;
+
+  char to[337];
+  strncpy(to, PayloadBin, 336);    // First Part is always 336 Length
+  to[336]=0;
+
+  if ( !ConvertBinaryAISPayloadBinToAscii( to ) ) return nullptr;
+
+  return Payload;
+}
+
+//******************************************************************************
+// get converted Part 2 of Payload for Message 5
+const char *tNMEA0183AISMsg::GetPayloadType5_Part2() {
+
+  uint16_t lenbin = strlen( PayloadBin);
+  if ( lenbin != 424 ) return nullptr;
+
+  lenbin = 88;        // Second Part is always 424 - 336 + 2 padding Zeros in Length
+  char to[91];
+  strncpy(to, PayloadBin + 336, lenbin);
+  to[88]='0'; to[89]='0'; to[90]=0;
+
+  if ( !ConvertBinaryAISPayloadBinToAscii( to ) ) return nullptr;
+  return Payload;
+}
+
+//******************************************************************************
+// get converted Part A of Payload for Message 24
+// Bit 0.....167, len 168
+// In PayloadBin is Part A and Part B chained together with Length 296
+const char *tNMEA0183AISMsg::GetPayloadType24_PartA() {
+  uint16_t lenbin = strlen( PayloadBin);
+  if ( lenbin != 296 ) return nullptr;    // too short for Part A
+
+  char to[169];    // Part A has Length 168
+  *to = '\0';
+  for (int i=0; i<168; i++){
+    to[i] = PayloadBin[i];
+  }
+  to[168]=0;
+  if ( !ConvertBinaryAISPayloadBinToAscii( to ) ) return nullptr;
+  return Payload;
+
+}
+
+//******************************************************************************
+// get converted Part B of Payload for Message 24
+// Bit 0.....38 + bit39='1' (part number) + bit 168........295  296='\0' of total PayloadBin
+// binary part B: len 40 + 128 = len 168
+const char *tNMEA0183AISMsg::GetPayloadType24_PartB() {
+  uint16_t lenbin = strlen( PayloadBin);
+  if ( lenbin != 296 ) return nullptr;    // too short for Part B
+  char to[169];    // Part B has Length 168
+  *to = '\0';
+  for (int i=0; i<39; i++){
+    to[i] = PayloadBin[i];
+  }
+  to[39] = 49;  // part number 1
+  for (int i=40; i<168; i++) {
+    to[i] = PayloadBin[i+128];
+  }
+  to[168]=0;
+  if ( !ConvertBinaryAISPayloadBinToAscii( to ) ) return nullptr;
+  return Payload;
+}

lib/nmea2ktoais/NMEA0183AISMsg.h

@@ -45,48 +45,43 @@ OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 #define BITSET_LENGTH 120
 
+typedef std::bitset<BITSET_LENGTH> AISBitSet;
 class tNMEA0183AISMsg : public tNMEA0183Msg {
 
   protected:  // AIS-NMEA
-    std::bitset<BITSET_LENGTH> bset;
     static const char *EmptyAISField;  // 6bits 0      not used yet.....
     static const char *AsciChar;
 
     uint16_t iAddPldBin;
     char Payload[AIS_MSG_MAX_LEN];
     uint8_t  iAddPld;
-    char talker[4]="VDM";
-    char channel[2]="A";
-    std::bitset<AIS_BIN_MAX_LEN> PayloadBin;
+
   public:
+    char PayloadBin[AIS_BIN_MAX_LEN];
+    char PayloadBin2[AIS_BIN_MAX_LEN];
     // Clear message
     void ClearAIS();
 
   public:
     tNMEA0183AISMsg();
-    const char *GetPayloadFix(int &padBits,uint16_t fixLen=168);
-    const char *GetPayload(int &padBits,uint16_t offset=0,uint16_t bitLen=0);
+    const char *GetPayload();
+    const char *GetPayloadType5_Part1();
+    const char *GetPayloadType5_Part2();
+    const char *GetPayloadType24_PartA();
+    const char *GetPayloadType24_PartB();
+    const char *GetPayloadBin() const { return  PayloadBin; }
 
-    bool BuildMsg5Part1();
-    bool BuildMsg5Part2();
-    bool InitAis(int max=1,int number=1,int sequence=-1);
+    const tNMEA0183AISMsg& BuildMsg5Part1(tNMEA0183AISMsg &AISMsg);
+    const tNMEA0183AISMsg& BuildMsg5Part2(tNMEA0183AISMsg &AISMsg);
+    const tNMEA0183AISMsg& BuildMsg24PartA(tNMEA0183AISMsg &AISMsg);
+    const tNMEA0183AISMsg& BuildMsg24PartB(tNMEA0183AISMsg &AISMsg);
 
     // Generally Used
     bool AddIntToPayloadBin(int32_t ival, uint16_t countBits);
-    bool AddBoolToPayloadBin(bool &bval);
+    bool AddBoolToPayloadBin(bool &bval, uint8_t size);
     bool AddEncodedCharToPayloadBin(char *sval, size_t Length);
-    /**
-     * @param channelA - if set A, otherwise B
-     * @param own - if set VDO, else VDM
-     */
-    void SetChannelAndTalker(bool channelA,bool own=false);
-    /**
-     * convert the payload to ascii
-     * return the number of padding bits
-     * @param bitSize the number of bits to be used, 0 - use all bits
-     */
-    template  <unsigned int SZ>
-    int ConvertBinaryAISPayloadBinToAscii(std::bitset<SZ> &src,uint16_t maxSize, uint16_t bitSize,uint16_t offset=0);
+    bool AddEmptyFieldToPayloadBin(uint8_t iBits);
+    bool ConvertBinaryAISPayloadBinToAscii(const char *payloadbin);
 
   // AIS Helper functions
   protected:

lib/nmea2ktoais/README.md

@@ -1,11 +1,11 @@
-# NMEA2000 to NMEA0183 AIS Converter
+# NMEA2000 -> NMEA0183 AIS converter  v1.0.0
 
+Import from https://github.com/ronzeiller/NMEA0183-AIS
 
 NMEA0183  AIS library © Ronnie Zeiller, www.zeiller.eu
 
 Addendum for NMEA2000 and NMEA0183 Library from Timo Lappalainen https://github.com/ttlappalainen
 
-to get NMEA0183 AIS data from N2k-bus
 
 ## Conversions:
 
@@ -15,33 +15,6 @@ to get NMEA0183 AIS data from N2k-bus
 - NMEA2000 PGN 129809 => AIS Class B "CS" Static Data Report, making a list of UserID (MMSI) and Ship Names used for Message 24 Part A
 - NMEA2000 PGN 129810 => AIS Class B "CS" Static Data Report, Message 24 Part A+B
 
-### Versions
-1.0.6 2024-03-25
-- fixed to work with Timo´s NMEA2000 v4.21.3
-
-1.0.5 2023-12-02
-- removed VDO remote print statements
-
-1.0.4 2023-12-02
-- merged @Isoltero master with fixed memory over run, added VDO remote print statements Thanks to Luis Soltero
-- fixed example, thanks to @arduinomnomnom
-
-1.0.3 2022-05-01
-- Update Examples: AISTransceiverInformation in ParseN2kPGN129039 for changes in NMEA2000 library: https://github.com/ttlappalainen/NMEA2000
-
-
-1.0.2 2022-04-30
-- bugfix: malloc without free. Thanks to Luis Soltero (Issue https://github.com/ronzeiller/NMEA0183-AIS/issues/3)
-
-1.0.1 2022-03-15
-- bugfix: buffer overrun missing space for termination. Thanks to Luis Soltero (Issue https://github.com/ronzeiller/NMEA0183-AIS/issues/2)
-
-2020-12-25
-- corrected Navigational Status 0. Thanks to Li-Ren (Issue https://github.com/ronzeiller/NMEA0183-AIS/issues/1)
-
-1.0.0 2019-11-24
-- initial upload
-
 ### Remarks
 1. Message Type could be set to 1 or 3 (identical messages) on demand
 2. Maneuver Indicator (not part of NMEA2000 PGN 129038) => will be set to 0 (default)
@@ -60,14 +33,17 @@ To use this library you need also:
 
 ## License
 
-MIT license
-
-Copyright (c) 2019-2022 Ronnie Zeiller, www.zeiller.eu
-
-Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-
-
-The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the "Software"), to deal in
+the Software without restriction, including without limitation the rights to use,
+copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the
+Software, and to permit persons to whom the Software is furnished to do so,
+subject to the following conditions:
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
+INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A
+PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF
+CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE
+OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

lib/obp60task/BoatDataCalibration.cpp

@@ -0,0 +1,192 @@
+#if defined BOARD_OBP60S3 || defined BOARD_OBP40S3
+
+#include "BoatDataCalibration.h"
+#include <cmath>
+#include <math.h>
+#include <unordered_map>
+
+CalibrationDataList calibrationData;
+std::unordered_map<std::string, TypeCalibData> CalibrationDataList::calibMap; // list of calibration data instances
+
+void CalibrationDataList::readConfig(GwConfigHandler* config, GwLog* logger)
+// Initial load of calibration data into internal list
+// This method is called once at init phase of <obp60task> to read the configuration values
+{
+    std::string instance;
+    double offset;
+    double slope;
+    double smooth;
+
+    String calInstance = "";
+    String calOffset = "";
+    String calSlope = "";
+    String calSmooth = "";
+
+    // Load user format configuration values
+    String lengthFormat = config->getString(config->lengthFormat); // [m|ft]
+    String distanceFormat = config->getString(config->distanceFormat); // [m|km|nm]
+    String speedFormat = config->getString(config->speedFormat); // [m/s|km/h|kn]
+    String windspeedFormat = config->getString(config->windspeedFormat); // [m/s|km/h|kn|bft]
+    String tempFormat = config->getString(config->tempFormat); // [K|C|F]
+
+    // Read calibration settings for data instances
+    for (int i = 0; i < MAX_CALIBRATION_DATA; i++) {
+        calInstance = "calInstance" + String(i + 1);
+        calOffset = "calOffset" + String(i + 1);
+        calSlope = "calSlope" + String(i + 1);
+        calSmooth = "calSmooth" + String(i + 1);
+
+        instance = std::string(config->getString(calInstance, "---").c_str());
+        if (instance == "---") {
+            LOG_DEBUG(GwLog::LOG, "no calibration data for instance no. %d", i + 1);
+            continue;
+        }
+        calibMap[instance] = { 0.0f, 1.0f, 1.0f, 0.0f, false };
+        offset = (config->getString(calOffset, "")).toFloat();
+        slope = (config->getString(calSlope, "")).toFloat();
+        smooth = (config->getString(calSmooth, "")).toInt(); // user input is int; further math is done with double
+
+        // Convert calibration values to internal standard formats
+        if (instance == "AWS" || instance == "TWS") {
+            if (windspeedFormat == "m/s") {
+                // No conversion needed
+            } else if (windspeedFormat == "km/h") {
+                offset /= 3.6; // Convert km/h to m/s
+            } else if (windspeedFormat == "kn") {
+                offset /= 1.94384; // Convert kn to m/s
+            } else if (windspeedFormat == "bft") {
+                offset *= 2 + (offset / 2); // Convert Bft to m/s (approx) -> to be improved
+            }
+
+        } else if (instance == "AWA" || instance == "COG" || instance == "TWA" || instance == "TWD" || instance == "HDM" || instance == "PRPOS" || instance == "RPOS") {
+            offset *= M_PI / 180; // Convert deg to rad
+
+        } else if (instance == "DBT") {
+            if (lengthFormat == "m") {
+                // No conversion needed
+            } else if (lengthFormat == "ft") {
+                offset /= 3.28084; // Convert ft to m
+            }
+
+        } else if (instance == "SOG" || instance == "STW") {
+            if (speedFormat == "m/s") {
+                // No conversion needed
+            } else if (speedFormat == "km/h") {
+                offset /= 3.6; // Convert km/h to m/s
+            } else if (speedFormat == "kn") {
+                offset /= 1.94384; // Convert kn to m/s
+            }
+
+        } else if (instance == "WTemp") {
+            if (tempFormat == "K" || tempFormat == "C") {
+                // No conversion needed
+            } else if (tempFormat == "F") {
+                offset *= 9.0 / 5.0; // Convert °F to K
+                slope *= 9.0 / 5.0; // Convert °F to K
+            }
+        }
+
+        // transform smoothing factor from {0.01..10} to {0.3..0.95} and invert for exponential smoothing formula
+        if (smooth <= 0) {
+            smooth = 0;
+        } else {
+            if (smooth > 10) {
+                smooth = 10;
+            }
+            smooth = 0.3 + ((smooth - 0.01) * (0.95 - 0.3) / (10 - 0.01));
+        }
+        smooth = 1 - smooth;
+
+        calibMap[instance].offset = offset;
+        calibMap[instance].slope = slope;
+        calibMap[instance].smooth = smooth;
+        calibMap[instance].isCalibrated = false;
+        LOG_DEBUG(GwLog::LOG, "stored calibration data: %s, offset: %f, slope: %f, smoothing: %f", instance.c_str(),
+            calibMap[instance].offset, calibMap[instance].slope, calibMap[instance].smooth);
+    }
+    LOG_DEBUG(GwLog::LOG, "all calibration data read");
+}
+
+void CalibrationDataList::calibrateInstance(GwApi::BoatValue* boatDataValue, GwLog* logger)
+// Method to calibrate the boat data value
+{
+    std::string instance = boatDataValue->getName().c_str();
+    double offset = 0;
+    double slope = 1.0;
+    double dataValue = 0;
+    std::string format = "";
+
+    if (calibMap.find(instance) == calibMap.end()) {
+        LOG_DEBUG(GwLog::DEBUG, "BoatDataCalibration: %s not found in calibration data list", instance.c_str());
+        return;
+    } else if (!boatDataValue->valid) { // no valid boat data value, so we don't want to apply calibration data
+        calibMap[instance].isCalibrated = false;
+        return;
+    } else {
+        offset = calibMap[instance].offset;
+        slope = calibMap[instance].slope;
+        dataValue = boatDataValue->value;
+        format = boatDataValue->getFormat().c_str();
+        LOG_DEBUG(GwLog::DEBUG, "BoatDataCalibration: %s: value: %f, format: %s", instance.c_str(), dataValue, format.c_str());
+
+        if (format == "formatWind") { // instance is of type angle
+            dataValue = (dataValue * slope) + offset;
+            dataValue = fmod(dataValue, 2 * M_PI);
+            if (dataValue > (M_PI)) {
+                dataValue -= (2 * M_PI);
+            } else if (dataValue < (M_PI * -1)) {
+                dataValue += (2 * M_PI);
+            }
+        } else if (format == "formatCourse") { // instance is of type direction
+            dataValue = (dataValue * slope) + offset;
+            dataValue = fmod(dataValue, 2 * M_PI);
+            if (dataValue < 0) {
+                dataValue += (2 * M_PI);
+            }
+        } else if (format == "kelvinToC") { // instance is of type temperature
+            dataValue = ((dataValue - 273.15) * slope) + offset + 273.15;
+        } else {
+
+            dataValue = (dataValue * slope) + offset;
+        }
+
+        calibMap[instance].isCalibrated = true;
+        boatDataValue->value = dataValue;
+
+        calibrationData.smoothInstance(boatDataValue, logger); // smooth the boat data value
+        calibMap[instance].value = boatDataValue->value; // store the calibrated + smoothed value in the list
+
+        LOG_DEBUG(GwLog::DEBUG, "BoatDataCalibration: %s: Offset: %f, Slope: %f, Result: %f", instance.c_str(), offset, slope, calibMap[instance].value);
+    }
+}
+
+void CalibrationDataList::smoothInstance(GwApi::BoatValue* boatDataValue, GwLog* logger)
+// Method to smoothen the boat data value
+{
+    static std::unordered_map<std::string, double> lastValue; // array for last values of smoothed boat data values
+
+    std::string instance = boatDataValue->getName().c_str();
+    double oldValue = 0;
+    double dataValue = boatDataValue->value;
+    double smoothFactor = 0;
+
+    if (!boatDataValue->valid) { // no valid boat data value, so we don't want to smoothen value
+        return;
+    } else if (calibMap.find(instance) == calibMap.end()) {
+        LOG_DEBUG(GwLog::DEBUG, "BoatDataCalibration: smooth factor for %s not found in calibration data list", instance.c_str());
+        return;
+    } else {
+        smoothFactor = calibMap[instance].smooth;
+
+        if (lastValue.find(instance) != lastValue.end()) {
+            oldValue = lastValue[instance];
+            dataValue = oldValue + (smoothFactor * (dataValue - oldValue)); // exponential smoothing algorithm
+        }
+        lastValue[instance] = dataValue; // store the new value for next cycle; first time, store only the current value and return
+        boatDataValue->value = dataValue; // set the smoothed value to the boat data value
+
+        LOG_DEBUG(GwLog::DEBUG, "BoatDataCalibration: %s: Smoothing factor: %f, Smoothed value: %f", instance.c_str(), smoothFactor, dataValue);
+    }
+}
+
+#endif

lib/obp60task/BoatDataCalibration.h

@@ -0,0 +1,33 @@
+// Functions lib for data instance calibration
+
+#ifndef _BOATDATACALIBRATION_H
+#define _BOATDATACALIBRATION_H
+
+#include "Pagedata.h"
+#include <string>
+#include <unordered_map>
+
+#define MAX_CALIBRATION_DATA 3 // maximum number of calibration data instances
+
+typedef struct {
+    double offset; // calibration offset
+    double slope; // calibration slope
+    double smooth; // smoothing factor
+    double value; // calibrated data value
+    bool isCalibrated; // is data instance value calibrated?
+} TypeCalibData;
+
+class CalibrationDataList {
+public:
+    static std::unordered_map<std::string, TypeCalibData> calibMap; // list of calibration data instances
+
+    void readConfig(GwConfigHandler* config, GwLog* logger);
+    void calibrateInstance(GwApi::BoatValue* boatDataValue, GwLog* logger);
+    void smoothInstance(GwApi::BoatValue* boatDataValue, GwLog* logger);
+
+private:
+};
+
+extern CalibrationDataList calibrationData; // this list holds all calibration data
+
+#endif

lib/obp60task/ConfigMenu.cpp

@@ -0,0 +1,194 @@
+/*
+  Menu system for online configuration
+*/
+#include "ConfigMenu.h"
+
+ConfigMenuItem::ConfigMenuItem(String itemtype, String itemlabel, uint16_t itemval, String itemunit) {
+    if (! (itemtype == "int" or itemtype == "bool")) {
+        valtype = "int";
+    } else {
+        valtype = itemtype;
+    }
+    label = itemlabel;
+    min = 0;
+    max = std::numeric_limits<uint16_t>::max();
+    value = itemval;
+    unit = itemunit;
+}
+
+void ConfigMenuItem::setRange(uint16_t valmin, uint16_t valmax, std::vector<uint16_t> valsteps) {
+    min = valmin;
+    max = valmax;
+    steps = valsteps;
+};
+
+bool ConfigMenuItem::checkRange(uint16_t checkval) {
+    return (checkval >= min) and (checkval <= max);
+}
+
+String ConfigMenuItem::getLabel() {
+    return label;
+};
+
+uint16_t ConfigMenuItem::getValue() {
+    return value;
+}
+
+bool ConfigMenuItem::setValue(uint16_t newval) {
+    if (valtype == "int") {
+        if (newval >= min and newval <= max) {
+            value = newval;
+            return true;
+        }
+        return false; // out of range
+    } else if (valtype == "bool") {
+        value = (newval != 0) ? 1 : 0;
+        return true;
+    }
+    return false; // invalid type
+};
+
+void ConfigMenuItem::incValue() {
+    // increase value by step
+    if (valtype == "int") {
+        if (value + step < max) {
+            value += step;
+        } else {
+            value = max;
+        }
+    } else if (valtype == "bool") {
+        value = !value;
+    }
+};
+
+void ConfigMenuItem::decValue() {
+    // decrease value by step
+    if (valtype == "int") {
+        if (value - step > min) {
+            value -= step;
+        } else {
+            value = min;
+        }
+    } else if (valtype == "bool") {
+        value = !value;
+    }
+};
+
+String ConfigMenuItem::getUnit() {
+    return unit;
+}
+
+uint16_t ConfigMenuItem::getStep() {
+    return step;
+}
+
+void ConfigMenuItem::setStep(uint16_t newstep) {
+    if (std::find(steps.begin(), steps.end(), newstep) == steps.end()) {
+        return; // invalid step: not in list of possible steps
+    }
+    step = newstep;
+}
+
+int8_t ConfigMenuItem::getPos() {
+    return position;
+};
+
+void ConfigMenuItem::setPos(int8_t newpos) {
+    position = newpos;
+};
+
+String ConfigMenuItem::getType() {
+    return valtype;
+}
+
+ConfigMenu::ConfigMenu(String menutitle, uint16_t menu_x, uint16_t menu_y) {
+    title = menutitle;
+    x = menu_x;
+    y = menu_y;
+};
+
+ConfigMenuItem* ConfigMenu::addItem(String key, String label, String valtype, uint16_t val, String valunit) {
+    if (items.find(key) != items.end()) {
+        // duplicate keys not allowed
+        return nullptr;
+    }
+    ConfigMenuItem *itm = new ConfigMenuItem(valtype, label, val, valunit);
+    items.insert(std::pair<String, ConfigMenuItem*>(key, itm));
+    // Append key to index, index starting with 0
+    int8_t ix = items.size() - 1;
+    index[ix] = key;
+    itm->setPos(ix);
+    return itm;
+};
+
+void ConfigMenu::setItemDimension(uint16_t itemwidth, uint16_t itemheight) {
+    w = itemwidth;
+    h = itemheight;
+};
+
+void ConfigMenu::setItemActive(String key) {
+    if (items.find(key) != items.end()) {
+        activeitem = items[key]->getPos();
+    } else {
+        activeitem = -1;
+    }
+};
+
+int8_t ConfigMenu::getActiveIndex() {
+    return activeitem;
+}
+
+ConfigMenuItem* ConfigMenu::getActiveItem() {
+    if (activeitem < 0) {
+        return nullptr;
+    }
+    return items[index[activeitem]];
+};
+
+ConfigMenuItem* ConfigMenu::getItemByIndex(uint8_t ix) {
+    if (ix > index.size() - 1) {
+        return nullptr;
+    }
+    return items[index[ix]];
+};
+
+ConfigMenuItem* ConfigMenu::getItemByKey(String key) {
+    if (items.find(key) == items.end()) {
+        return nullptr;
+    }
+    return items[key];
+};
+
+uint8_t ConfigMenu::getItemCount() {
+    return items.size();
+};
+
+void ConfigMenu::goPrev() {
+    if (activeitem == 0) {
+        activeitem = items.size() - 1;
+    } else {
+        activeitem--;
+    }
+}
+
+void ConfigMenu::goNext() {
+    if (activeitem == items.size() - 1) {
+        activeitem = 0;
+    } else {
+        activeitem++;
+    }
+}
+
+Point ConfigMenu::getXY() {
+    return {static_cast<double>(x), static_cast<double>(y)};
+}
+
+Rect ConfigMenu::getRect() {
+    return {static_cast<double>(x), static_cast<double>(y),
+            static_cast<double>(w), static_cast<double>(h)};
+}
+
+Rect ConfigMenu::getItemRect(int8_t index) {
+    return {static_cast<double>(x), static_cast<double>(y + index * h),
+            static_cast<double>(w), static_cast<double>(h)};
+}

lib/obp60task/ConfigMenu.h

@@ -0,0 +1,63 @@
+#pragma once
+
+#include <Arduino.h>
+#include <vector>
+#include <map>
+#include "Graphics.h"  // for Point and Rect
+
+class ConfigMenuItem {
+private:
+    String label;
+    uint16_t value;
+    String unit;
+    String valtype; // "int" | "bool"
+    uint16_t min;
+    uint16_t max;
+    std::vector<uint16_t> steps;
+    uint16_t step;
+    int8_t position; // counted fom 0
+
+public:
+    ConfigMenuItem(String itemtype, String itemlabel, uint16_t itemval, String itemunit);
+    void setRange(uint16_t valmin, uint16_t valmax, std::vector<uint16_t> steps);
+    bool checkRange(uint16_t checkval);
+    String getLabel();
+    uint16_t getValue();
+    bool setValue(uint16_t newval);
+    void incValue();
+    void decValue();
+    String getUnit();
+    uint16_t getStep();
+    void setStep(uint16_t newstep);
+    int8_t getPos();
+    void setPos(int8_t newpos);
+    String getType();
+};
+
+class ConfigMenu {
+private:
+    String title;
+    std::map <String,ConfigMenuItem*> items;
+    std::map <uint8_t,String> index;
+    int8_t activeitem = -1; // refers to position of item
+    uint16_t x;
+    uint16_t y;
+    uint16_t w;
+    uint16_t h;
+
+public:
+    ConfigMenu(String title, uint16_t menu_x, uint16_t menu_y);
+    ConfigMenuItem* addItem(String key, String label, String valtype, uint16_t val, String valunit);
+    void setItemDimension(uint16_t itemwidth, uint16_t itemheight);
+    int8_t getActiveIndex();
+    void setItemActive(String key);
+    ConfigMenuItem* getActiveItem();
+    ConfigMenuItem* getItemByIndex(uint8_t index);
+    ConfigMenuItem* getItemByKey(String key);
+    uint8_t getItemCount();
+    void goPrev();
+    void goNext();
+    Point getXY();
+    Rect getRect();
+    Rect getItemRect(int8_t index);
+};

lib/obp60task/ImageDecoder.cpp

@@ -1,14 +0,0 @@
-#include "ImageDecoder.h"
-#include <mbedtls/base64.h>
-
-// Decoder for Base64 content
-bool ImageDecoder::decodeBase64(const String& base64, uint8_t* outBuffer, size_t outSize, size_t& decodedSize) {
-    int ret = mbedtls_base64_decode(
-        outBuffer,
-        outSize,
-        &decodedSize,
-        (const unsigned char*)base64.c_str(),
-        base64.length()
-    );
-    return (ret == 0);
-}

lib/obp60task/ImageDecoder.h

@@ -1,9 +0,0 @@
-
-#pragma once
-#include <Arduino.h>
-#include <vector>
-
-class ImageDecoder {
-public:
-    bool decodeBase64(const String& base64, uint8_t* outBuffer, size_t outSize, size_t& decodedSize);
-};

lib/obp60task/LedSpiTask.cpp

@@ -22,11 +22,9 @@ static uint8_t mulcolor(uint8_t f1, uint8_t f2){
 }
 
 Color setBrightness(const Color &color,uint8_t brightness){
-    if (brightness > 100) brightness = 100;
-
     uint16_t br255=brightness*255;
     br255=br255/100;
-    //Very simple for now
+    //very simple for now
     Color rt=color;
     rt.g=mulcolor(rt.g,br255);
     rt.b=mulcolor(rt.b,br255);

lib/obp60task/NetworkClient.cpp

@@ -1,181 +0,0 @@
-#include "NetworkClient.h"
-
-extern "C" {
-    #include "puff.h"
-}
-
-// Constructor
-NetworkClient::NetworkClient(size_t reserveSize)
-    : _doc(reserveSize),
-      _valid(false)
-{
-}
-
-// Skip GZIP Header an goto DEFLATE content
-int NetworkClient::skipGzipHeader(const uint8_t* data, size_t len) {
-    if (len < 10) return -1;
-
-    if (data[0] != 0x1F || data[1] != 0x8B || data[2] != 8) {
-        return -1;
-    }
-
-    size_t pos = 10;
-    uint8_t flags = data[3];
-
-    if (flags & 4) {
-        if (pos + 2 > len) return -1;
-        uint16_t xlen = data[pos] | (data[pos+1] << 8);
-        pos += 2 + xlen;
-    }
-
-    if (flags & 8) {
-        while (pos < len && data[pos] != 0) pos++;
-        pos++;
-    }
-
-    if (flags & 16) {
-        while (pos < len && data[pos] != 0) pos++;
-        pos++;
-    }
-
-    if (flags & 2) pos += 2;
-
-    if (pos >= len) return -1;
-
-    return pos;
-}
-
-// HTTP GET + GZIP Decompression (reading in chunks)
-bool NetworkClient::httpGetGzip(const String& url, uint8_t*& outData, size_t& outLen) {
-
-    const size_t capacity = READLIMIT;   // Read limit for data (can be adjusted in NetworkClient.h)
-    uint8_t* buffer = (uint8_t*)malloc(capacity);
-
-    if (!buffer) {
-        if (DEBUG) {Serial.println("Malloc failed (buffer");}
-        return false;
-    }
-
-    HTTPClient http;
-
-    // Timeouts to prevent hanging connections
-    http.setConnectTimeout(CONNECTIONTIMEOUT);  // Connect timeout in ms (can be adjusted in NetworkClient.h)
-    http.setTimeout(TCPREADTIMEOUT);            // Read timeout in ms (can be adjusted in NetworkClient.h)
-
-    http.begin(url);
-    http.addHeader("Accept-Encoding", "gzip");
-
-    int code = http.GET();
-    if (code != HTTP_CODE_OK) {
-        Serial.printf("HTTP ERROR: %d\n", code);
-
-        // Hard reset HTTP + socket
-        WiFiClient* tmp = http.getStreamPtr();
-        if (tmp) tmp->stop();   // Force close TCP socket
-        http.end();
-
-        free(buffer);
-        return false;
-    }
-
-    WiFiClient* stream = http.getStreamPtr();
-
-    size_t len = 0;
-    uint32_t lastData = millis();
-    const uint32_t READ_TIMEOUT = READDATATIMEOUT;   // Timeout for reading data (can be adjusted in NetworkClient.h)
-
-    bool complete = false;
-
-    while (http.connected() && !complete) {
-
-        size_t avail = stream->available();
-
-        if (avail == 0) {
-            if (millis() - lastData > READ_TIMEOUT) {
-                Serial.println("TIMEOUT waiting for data!");
-                break;
-            }
-            delay(1);
-            continue;
-        }
-
-        if (len + avail > capacity)
-            avail = capacity - len;
-
-        int read = stream->readBytes(buffer + len, avail);
-        len += read;
-        lastData = millis();
-
-        if (DEBUG) {Serial.printf("Read chunk: %d (total: %d)\n", read, (int)len);}
-
-        if (len < 20) continue;  // Not enough data for header
-
-        int headerOffset = skipGzipHeader(buffer, len);
-        if (headerOffset < 0) continue;
-
-        unsigned long testLen = len * 8; // Dynamic expansion
-        uint8_t* test = (uint8_t*)malloc(testLen);
-
-        if (!test) continue;
-
-        unsigned long srcLen = len - headerOffset;
-
-        int res = puff(test, &testLen, buffer + headerOffset, &srcLen);
-        if (res == 0) {
-            if (DEBUG) {Serial.printf("Decompress OK! Size: %lu bytes\n", testLen);}
-            outData = test;
-            outLen = testLen;
-            complete = true;
-            break;
-        }
-
-        free(test);
-    }
-
-    // --- Added: Force-close connection in all cases to avoid stuck TCP sockets ---
-    if (stream) stream->stop();
-
-    http.end();
-    free(buffer);
-
-    if (!complete) {
-        Serial.println("Failed to complete decompress.");
-        return false;
-    }
-
-    return true;
-}
-
-// Decompress JSON
-bool NetworkClient::fetchAndDecompressJson(const String& url) {
-
-    _valid = false;
-
-    uint8_t* raw = nullptr;
-    size_t rawLen = 0;
-
-    if (!httpGetGzip(url, raw, rawLen)) {
-        Serial.println("GZIP download/decompress failed.");
-        return false;
-    }
-
-    DeserializationError err = deserializeJson(_doc, raw, rawLen);
-    free(raw);
-
-    if (err) {
-        Serial.printf("JSON ERROR: %s\n", err.c_str());
-        return false;
-    }
-
-    if (DEBUG) {Serial.println("JSON OK!");}
-    _valid = true;
-    return true;
-}
-
-JsonDocument& NetworkClient::json() {
-    return _doc;
-}
-
-bool NetworkClient::isValid() const {
-    return _valid;
-}

lib/obp60task/NetworkClient.h

@@ -1,27 +0,0 @@
-#pragma once
-#include <ArduinoJson.h>
-#include <WiFi.h>
-#include <HTTPClient.h>
-
-#define DEBUG false             // Debug flag for NetworkClient for more live information
-#define READLIMIT 200000        // HTTP read limit in byte for gzip content (can be adjusted)
-#define CONNECTIONTIMEOUT 3000  // Timeout in ms for HTTP connection 
-#define TCPREADTIMEOUT 2000     // Timeout in ms for read HTTP client stack
-#define READDATATIMEOUT 2000    // Timeout in ms for read data
-
-class NetworkClient {
-public:
-    NetworkClient(size_t reserveSize = 0);
-
-    bool fetchAndDecompressJson(const String& url);
-    JsonDocument& json();
-    bool isValid() const;
-
-private:
-    DynamicJsonDocument _doc;
-    bool _valid;
-
-    int skipGzipHeader(const uint8_t* data, size_t len);
-    bool httpGetGzip(const String& url, uint8_t*& outData, size_t& outLen);
-};
-

lib/obp60task/OBP60Extensions.cpp

@@ -1,9 +1,9 @@
 #if defined BOARD_OBP60S3 || defined BOARD_OBP40S3
 
 #include <Arduino.h>
+#include <PCF8574.h>      // Driver for PCF8574 output modul from Horter
 #include <Wire.h>         // I2C
 #include <RTClib.h>       // Driver for DS1388 RTC
-#include <PCF8574.h>      // PCF8574 modules from Horter
 #include "SunRise.h"      // Lib for sunrise and sunset calculation
 #include "Pagedata.h"
 #include "OBP60Hardware.h"
@@ -24,10 +24,11 @@
 #include "fonts/Ubuntu_Bold20pt8b.h"
 #include "fonts/Ubuntu_Bold32pt8b.h"
 #include "fonts/Atari16px8b.h" // Key label font
-#include "fonts/IBM8x8px.h"
 
 // E-Ink Display
-// Definition for e-paper width an height refer OBP60Hardware.h
+#define GxEPD_WIDTH 400     // Display width
+#define GxEPD_HEIGHT 300    // Display height
+
 #ifdef DISPLAY_GDEW042T2
 // Set display type and SPI pins for display
 GxEPD2_BW<GxEPD2_420, GxEPD2_420::HEIGHT> display(GxEPD2_420(OBP_SPI_CS, OBP_SPI_DC, OBP_SPI_RST, OBP_SPI_BUSY)); // GDEW042T2 400x300, UC8176 (IL0398)
@@ -57,18 +58,12 @@ GxEPD2_BW<GxEPD2_420_SE0420NQ04, GxEPD2_420_SE0420NQ04::HEIGHT> & getdisplay(){r
 #endif
 
 // Horter I2C moduls
-PCF8574 pcf8574_Modul1(PCF8574_I2C_ADDR1); // First digital IO modul PCF8574 from Horter
+PCF8574 pcf8574_Out(PCF8574_I2C_ADDR1); // First digital output modul PCF8574 from Horter
 
 // FRAM
 Adafruit_FRAM_I2C fram;
 bool hasFRAM = false;
 
-// SD Card
-#ifdef BOARD_OBP40S3
-sdmmc_card_t *sdcard;
-#endif
-bool hasSDCard = false;
-
 // Global vars
 bool blinkingLED = false;       // Enable / disable blinking flash LED
 bool statusLED = false;         // Actual status of flash LED on/off
@@ -83,20 +78,16 @@ LedTaskData *ledTaskData=nullptr;
 
 void hardwareInit(GwApi *api)
 {
-    GwLog *logger = api->getLogger();
-    GwConfigHandler *config = api->getConfig();
-
     Wire.begin();
     // Init PCF8574 digital outputs
-    Wire.setClock(I2C_SPEED_LOW);   // Set I2C clock on 10 kHz
-    if(pcf8574_Modul1.begin()){        // Initialize PCF8574
-        pcf8574_Modul1.write8(255);    // Clear all outputs (low activ)
+    Wire.setClock(I2C_SPEED);       // Set I2C clock on 10 kHz
+    if(pcf8574_Out.begin()){        // Initialize PCF8574
+        pcf8574_Out.write8(255);    // Clear all outputs
     }
-    Wire.setClock(I2C_SPEED);       // Set I2C clock on 100 kHz
     fram = Adafruit_FRAM_I2C();
     if (esp_reset_reason() ==  ESP_RST_POWERON) {
         // help initialize FRAM
-        logger->logDebug(GwLog::LOG, "Delaying I2C init for 250ms due to cold boot");
+        api->getLogger()->logDebug(GwLog::LOG,"Delaying I2C init for 250ms due to cold boot");
         delay(250);
     }
     // FRAM (e.g. MB85RC256V)
@@ -108,112 +99,13 @@ void hardwareInit(GwApi *api)
         // Boot counter
         uint8_t framcounter = fram.read(0x0000);
         fram.write(0x0000, framcounter+1);
-        logger->logDebug(GwLog::LOG, "FRAM detected: 0x%04x/0x%04x (counter=%d)", manufacturerID, productID, framcounter);
+        api->getLogger()->logDebug(GwLog::LOG,"FRAM detected: 0x%04x/0x%04x (counter=%d)", manufacturerID, productID, framcounter);
     }
     else {
         hasFRAM = false;
-        logger->logDebug(GwLog::LOG, "NO FRAM detected");
-    }
-    // SD Card
-    hasSDCard = false;
-#ifdef BOARD_OBP40S3
-    if (config->getBool(config->useSDCard)) {
-        esp_err_t ret;
-        sdmmc_host_t host = SDSPI_HOST_DEFAULT();
-        host.slot = SPI3_HOST;
-        logger->logDebug(GwLog::DEBUG, "SDSPI_HOST: max_freq_khz=%d" , host.max_freq_khz);
-        spi_bus_config_t bus_cfg = {
-            .mosi_io_num = SD_SPI_MOSI,
-            .miso_io_num = SD_SPI_MISO,
-            .sclk_io_num = SD_SPI_CLK,
-            .quadwp_io_num = -1,
-            .quadhd_io_num = -1,
-            .max_transfer_sz = 4000,
-        };
-        ret = spi_bus_initialize((spi_host_device_t) host.slot, &bus_cfg, SDSPI_DEFAULT_DMA);
-        if (ret != ESP_OK) {
-            logger->logDebug(GwLog::ERROR, "Failed to initialize SPI bus for SD card");
-        } else {
-            sdspi_device_config_t slot_config = SDSPI_DEVICE_CONFIG_DEFAULT();
-            slot_config.gpio_cs = SD_SPI_CS;
-            slot_config.host_id = (spi_host_device_t) host.slot;
-            esp_vfs_fat_sdmmc_mount_config_t mount_config = {
-                .format_if_mount_failed = false,
-                .max_files = 5,
-                .allocation_unit_size = 16 * 1024
-            };
-            ret = esp_vfs_fat_sdspi_mount(MOUNT_POINT, &host, &slot_config, &mount_config, &sdcard);
-            if (ret != ESP_OK) {
-                if (ret == ESP_FAIL) {
-                    logger->logDebug(GwLog::ERROR, "Failed to mount SD card filesystem");
-                } else {
-                    // ret == 263 could be not powered up yet
-                    logger->logDebug(GwLog::ERROR, "Failed to initialize SD card (error #%d)", ret);
-                }
-            } else {
-                logger->logDebug(GwLog::LOG, "SD card filesystem mounted at '%s'", MOUNT_POINT);
-                hasSDCard = true;
+        api->getLogger()->logDebug(GwLog::LOG,"NO FRAM detected");
     }
 }
-        if (hasSDCard) {
-            // read some stats
-            String features = "";
-            if (sdcard->is_mem) features += "MEM "; // Memory card
-            if (sdcard->is_sdio) features += "IO "; // IO Card
-            if (sdcard->is_mmc) features += "MMC "; // MMC Card
-            if (sdcard->is_ddr) features += "DDR ";
-            // if (sdcard->is_uhs1) features += "UHS-1 ";
-            // ext_csd. Extended information
-            // uint8_t rev, uint8_t power_class
-            logger->logDebug(GwLog::LOG, "SD card features: %s", features);
-            logger->logDebug(GwLog::LOG, "SD card size: %lluMB", ((uint64_t) sdcard->csd.capacity) * sdcard->csd.sector_size / (1024 * 1024));
-        }
-    }
-#endif
-}
-
-void powerInit(String powermode) {
-    // Max Power | Only 5.0V | Min Power
-    if (powermode == "Max Power" || powermode == "Only 5.0V") {
-#ifdef HARDWARE_V21
-        setPortPin(OBP_POWER_50, true); // Power on 5.0V rail
-#endif
-#ifdef BOARD_OBP40S3
-        setPortPin(OBP_POWER_EPD, true);// Power on ePaper display
-        setPortPin(OBP_POWER_SD, true); // Power on SD card
-#endif
-    } else { // Min Power
-#ifdef HARDWARE_V21
-        setPortPin(OBP_POWER_50, false); // Power off 5.0V rail
-#endif
-#ifdef BOARD_OBP40S3
-        setPortPin(OBP_POWER_EPD, false);// Power off ePaper display
-        setPortPin(OBP_POWER_SD, false); // Power off SD card
-#endif
-    }
-}
-
-void setPCF8574PortPinModul1(uint8_t pin, uint8_t value)
-{
-  static bool firstRunFinished;
-  static uint8_t port1;                      // Retained data for port bits 
-  // If fisrt run then set all outputs to low
-  if(firstRunFinished == false){
-    port1 = 255;                             // Low active
-    firstRunFinished = true;
-  }
-  if (pin > 7) return;
-  Wire.setClock(I2C_SPEED_LOW);              // Set I2C clock on 10 kHz for longer wires
-  // Set bit
-  if (pcf8574_Modul1.begin(port1))           // Check module availability and start it
-  {
-    if (value == LOW)  port1 &= ~(1 << pin); // Set bit
-    else               port1 |=  (1 << pin);
-    pcf8574_Modul1.write8(port1);            // Write byte
-  }
-  Wire.setClock(I2C_SPEED);                  // Set I2C clock on 100 kHz
-}
-
 
 void setPortPin(uint pin, bool value){
     pinMode(pin, OUTPUT);
@@ -331,40 +223,6 @@ void toggleBacklightLED(uint brightness, const Color &color){
     ledTaskData->setLedData(current); 
 }
 
-void stepsBacklightLED(uint brightness, const Color &color){
-    static uint step = 0;
-    uint actBrightness = 0;
-    // Different brightness steps
-    if(step == 0){
-        actBrightness = brightness;         // 100% from brightess
-        statusBacklightLED = true;
-    }
-    if(step == 1){
-        actBrightness = brightness * 0.5;   // 50% from brightess
-        statusBacklightLED = true;
-    }
-    if(step == 2){
-        actBrightness = brightness * 0.2;   // 20% from brightess
-        statusBacklightLED = true;
-    }
-    if(step == 3){
-        actBrightness = 0;                  // 0%
-        statusBacklightLED = false;
-    }
-    if(actBrightness < 5){                  // Limiter if values too low
-        actBrightness = 5;
-    }
-    step = step + 1;    // Increment step counter
-    if(step == 4){      // Reset counter
-        step = 0;
-    }
-    if (ledTaskData == nullptr) return;
-    Color nv=setBrightness(statusBacklightLED?color:COLOR_BLACK,actBrightness);
-    LedInterface current=ledTaskData->getLedData();
-    current.setBacklight(nv);
-    ledTaskData->setLedData(current); 
-}
-
 void setFlashLED(bool status){
     if (ledTaskData == nullptr) return;
     Color c=status?COLOR_RED:COLOR_BLACK;
@@ -484,33 +342,12 @@ void drawTextCenter(int16_t cx, int16_t cy, String text) {
     getdisplay().print(text);
 }
 
-// Draw centered botton with centered text
-void drawButtonCenter(int16_t cx, int16_t cy, int8_t sx, int8_t sy, String text, uint16_t fg, uint16_t bg, bool inverted) {
-    int16_t x1, y1;
-    uint16_t w, h;
-    uint16_t color;
-
-    getdisplay().getTextBounds(text, cx, cy, &x1, &y1, &w, &h); // Find text center
-    getdisplay().setCursor(cx - w/2, cy + h/2);                 // Set cursor to center
-    //getdisplay().drawPixel(cx, cy, fg);                         // Debug pixel for center position
-    if (inverted) {
-        getdisplay().fillRoundRect(cx - sx / 2, cy - sy / 2, sx, sy, 5, fg); // Draw button
-        getdisplay().setTextColor(bg);
-        getdisplay().print(text);                               // Draw text
-     }
-     else{
-        getdisplay().drawRoundRect(cx - sx / 2, cy - sy / 2, sx, sy, 5, fg); // Draw button
-        getdisplay().setTextColor(fg);
-        getdisplay().print(text);                               // Draw text
-     }
-}
-
 // Draw right aligned text
 void drawTextRalign(int16_t x, int16_t y, String text) {
     int16_t x1, y1;
     uint16_t w, h;
     getdisplay().getTextBounds(text, 0, 150, &x1, &y1, &w, &h);
-    getdisplay().setCursor(x - w - 1, y); // '-1' required since some strings wrap around w/o it
+    getdisplay().setCursor(x - w, y);
     getdisplay().print(text);
 }
 
@@ -981,30 +818,4 @@ void doImageRequest(GwApi *api, int *pageno, const PageStruct pages[MAX_PAGE_NUM
     imageBuffer.clear();
 }
 
-
-
-// Calculate the distance between two Geo coordinates
-double distanceBetweenCoordinates(double lat1, double lon1, double lat2, double lon2) {
-    // Grad → Radiant
-    double lat1Rad = lat1 * DEG_TO_RAD;
-    double lon1Rad = lon1 * DEG_TO_RAD;
-    double lat2Rad = lat2 * DEG_TO_RAD;
-    double lon2Rad = lon2 * DEG_TO_RAD;
-
-    // Differenzen
-    double dLat = lat2Rad - lat1Rad;
-    double dLon = lon2Rad - lon1Rad;
-
-    // Haversine-Formel
-    double a = sin(dLat / 2.0) * sin(dLat / 2.0) +
-               cos(lat1Rad) * cos(lat2Rad) *
-               sin(dLon / 2.0) * sin(dLon / 2.0);
-
-    double c = 2.0 * atan2(sqrt(a), sqrt(1.0 - a));
-
-    // Abstand in Metern
-    return double(EARTH_RADIUS) * c;
-}
-
-
 #endif

lib/obp60task/OBP60Extensions.h

@@ -7,13 +7,6 @@
 #include "Graphics.h"
 #include <GxEPD2_BW.h>                  // E-paper lib V2
 #include <Adafruit_FRAM_I2C.h>          // I2C FRAM
-#include <math.h>
-
-#ifdef BOARD_OBP40S3
-#include "esp_vfs_fat.h"
-#include "sdmmc_cmd.h"
-#define MOUNT_POINT "/sdcard"
-#endif
 
 // FRAM address reservations 32kB: 0x0000 - 0x7FFF
 // 0x0000 - 0x03ff: single variables
@@ -23,7 +16,6 @@
 #define FRAM_VOLTAGE_AVG 0x000A
 #define FRAM_VOLTAGE_TREND 0x000B
 #define FRAM_VOLTAGE_MODE 0x000C
-// Wind page
 #define FRAM_WIND_SIZE 0x000D
 #define FRAM_WIND_SRC 0x000E
 #define FRAM_WIND_MODE 0x000F
@@ -31,15 +23,8 @@
 #define FRAM_BAROGRAPH_START 0x0400
 #define FRAM_BAROGRAPH_END 0x13FF
 
-#define PI 3.1415926535897932384626433832795
-#define EARTH_RADIUS 6371000.0
-
 extern Adafruit_FRAM_I2C fram;
 extern bool hasFRAM;
-extern bool hasSDCard;
-#ifdef BOARD_OBP40S3
-extern sdmmc_card_t *sdcard;
-#endif
 
 // Fonts declarations for display (#includes see OBP60Extensions.cpp)
 extern const GFXfont DSEG7Classic_BoldItalic16pt7b;
@@ -55,7 +40,6 @@ extern const GFXfont Ubuntu_Bold16pt8b;
 extern const GFXfont Ubuntu_Bold20pt8b;
 extern const GFXfont Ubuntu_Bold32pt8b;
 extern const GFXfont Atari16px;
-extern const GFXfont IBM8x8px;
 
 // Global functions
 #ifdef DISPLAY_GDEW042T2
@@ -87,16 +71,14 @@ void deepSleep(CommonData &common);
 uint8_t getLastPage();
 
 void hardwareInit(GwApi *api);
-void powerInit(String powermode);
 
-void setPCF8574PortPinModul1(uint8_t pin, uint8_t value);// Set PCF8574 port pin
 void setPortPin(uint pin, bool value);          // Set port pin for extension port
+
 void togglePortPin(uint pin);                   // Toggle extension port pin
 
 Color colorMapping(const String &colorString);          // Color mapping string to CHSV colors
 void setBacklightLED(uint brightness, const Color &color);// Set backlight LEDs
 void toggleBacklightLED(uint brightness,const Color &color);// Toggle backlight LEDs
-void stepsBacklightLED(uint brightness, const Color &color);// Set backlight LEDs in 4 steps (100%, 50%, 10%, 0%)
 BacklightMode backlightMapping(const String &backlightString);// Configuration string to value
 
 void setFlashLED(bool status);                  // Set flash LED
@@ -109,7 +91,6 @@ void setBuzzerPower(uint power);                // Set buzzer power
 String xdrDelete(String input);                 // Delete xdr prefix from string
 
 void drawTextCenter(int16_t cx, int16_t cy, String text);
-void drawButtonCenter(int16_t cx, int16_t cy, int8_t sx, int8_t sy, String text, uint16_t fg, uint16_t bg, bool inverted);
 void drawTextRalign(int16_t x, int16_t y, String text);
 void drawTextBoxed(Rect box, String text, uint16_t fg, uint16_t bg, bool inverted, bool border);
 

lib/obp60task/OBP60Formatter.cpp

@@ -49,22 +49,12 @@ String formatLongitude(double lon) {
     return String(degree, 0) + "\x90 " + String(minute, 4) + "' " + ((lon > 0) ? "E" : "W");
 }
 
-// Convert and format boat value from SI to user defined format (definition for compatibility purposes)
 FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata){
-
-    return formatValue(value, commondata, false); // call <formatValue> with standard handling of user setting for simulation data
-}
-
-// Convert and format boat value from SI to user defined format
-// generate random simulation data; can be deselected to use conversion+formatting function even in simulation mode
-FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool ignoreSimuDataSetting){
     GwLog *logger = commondata.logger;
     FormattedData result;
     static int dayoffset = 0;
     double rawvalue = 0;
 
-    result.cvalue = value->value;
-
     // Load configuration values
     String stimeZone = commondata.config->getString(commondata.config->timeZone);               // [UTC -14.00...+12.00]
     double timeZone = stimeZone.toDouble();
@@ -74,14 +64,7 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
     String windspeedFormat = commondata.config->getString(commondata.config->windspeedFormat);  // [m/s|km/h|kn|bft]
     String tempFormat = commondata.config->getString(commondata.config->tempFormat);            // [K|°C|°F]
     String dateFormat = commondata.config->getString(commondata.config->dateFormat);            // [DE|GB|US]
-    String precision = commondata.config->getString(commondata.config->valueprecision);         // [1|2]
-
-    bool usesimudata;
-    if (ignoreSimuDataSetting){
-        usesimudata = false; // ignore user setting for simulation data; we want to format the boat value passed to this function
-    } else {
-        usesimudata = commondata.config->getBool(commondata.config->useSimuData);              // [on|off]
-    }
+    bool usesimudata = commondata.config->getBool(commondata.config->useSimuData);              // [on|off]
 
     // If boat value not valid
     if (! value->valid && !usesimudata){
@@ -89,29 +72,6 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
         return result;
     }
     
-    const char* fmt_dec_1;
-    const char* fmt_dec_10;
-    const char* fmt_dec_100;
-    double limit_dec_10;
-    double limit_dec_100;
-    if (precision == "1") {
-	//
-	//All values are displayed using a DSEG7* font. In this font, ' ' is a very short space, and '.' takes up no space at all. 
-	//For a space that is as long as a number, '!' is used. For details see  https://www.keshikan.net/fonts-e.html
-	//
-        fmt_dec_1 = "!%1.1f";  //insert a blank digit and then display a two-digit number
-        fmt_dec_10 = "!%2.0f"; //insert a blank digit and then display a two-digit number
-        fmt_dec_100 = "%3.0f"; //dispay a three digit number
-	limit_dec_10=9.95; // use fmt_dec_1 below this number to avoid formatting 9.96 as 10.0 instead of 10
-	limit_dec_100=99.5; 
-    } else {
-        fmt_dec_1 = "%3.2f";
-        fmt_dec_10 = "%3.1f";
-        fmt_dec_100 = "%3.0f";
-	limit_dec_10=9.995;
-	limit_dec_100=99.95;
-    }
-
 //    LOG_DEBUG(GwLog::DEBUG,"formatValue init: getFormat: %s date->value: %f time->value: %f", value->getFormat(), commondata.date->value, commondata.time->value);
     static const int bsize = 30;
     char buffer[bsize+1];
@@ -175,7 +135,6 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             val=modf(val*3600.0/60.0,&intmin);
             modf(val*60.0,&intsec);
             snprintf(buffer,bsize,"%02.0f:%02.0f:%02.0f",inthr,intmin,intsec);
-            result.cvalue = timeInSeconds;
         }
         else{
             static long sec;
@@ -185,7 +144,6 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             }
             sec = sec % 60;
             snprintf(buffer,bsize,"11:36:%02i", int(sec));
-            result.cvalue = sec;
             lasttime = millis();
         }
         if(timeZone == 0){
@@ -206,7 +164,6 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             snprintf(buffer,bsize,"%3.0f", rawvalue);
         }
         result.unit = "";
-        result.cvalue = rawvalue;
     }
     //########################################################
     else if (value->getFormat() == "formatCourse" || value->getFormat() == "formatWind"){
@@ -216,15 +173,14 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = value->value;
         }
         else{
-            course = M_PI_2 + float(random(-17, 17) / 100.0); // create random course/wind values with 90° +/- 10°
+            course = 2.53 + float(random(0, 10) / 100.0);
             rawvalue = course;
         }    
-        course = course * RAD_TO_DEG;      // Unit conversion form rad to deg
+        course = course * 57.2958;      // Unit conversion form rad to deg
 
         // Format 3 numbers with prefix zero
         snprintf(buffer,bsize,"%03.0f",course);
         result.unit = "Deg";
-        result.cvalue = course;
     }
     //########################################################
     else if (value->getFormat() == "formatKnots" && (value->getName() == "SOG" || value->getName() == "STW")){
@@ -234,7 +190,7 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = value->value;
         }
         else{
-            rawvalue = 4.0 + float(random(-30, 40) / 10.0); // create random speed values from [1..8] m/s
+            rawvalue = 4.0 + float(random(0, 40));
             speed = rawvalue;
         }
         if(String(speedFormat) == "km/h"){
@@ -249,16 +205,15 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             speed = speed;              // Unit conversion form m/s to m/s
             result.unit = "m/s";
         }
-        if(speed < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, speed);
+        if(speed < 10){
+            snprintf(buffer,bsize,"%3.2f",speed);
         }
-        else if (speed < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, speed);
+        if(speed >= 10 && speed < 100){
+            snprintf(buffer,bsize,"%3.1f",speed);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, speed);
+        if(speed >= 100){
+            snprintf(buffer,bsize,"%3.0f",speed);
         }
-        result.cvalue = speed;
     }
     //########################################################
     else if (value->getFormat() == "formatKnots" && (value->getName() == "AWS" || value->getName() == "TWS" || value->getName() == "MaxAws" || value->getName() == "MaxTws")){
@@ -268,7 +223,7 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = value->value;
         }
         else{
-            rawvalue = 4.0 + float(random(0, 40) / 10.0); // create random wind speed values from [4..8] m/s
+            rawvalue = 4.0 + float(random(0, 40));
             speed = rawvalue;
         }
         if(String(windspeedFormat) == "km/h"){
@@ -283,40 +238,40 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             if(speed < 0.3){
                 speed = 0;
             }
-            else if (speed < 1.5) {
+            if(speed >=0.3 && speed < 1.5){
                 speed = 1;
             }
-            else if (speed < 3.3) {
+            if(speed >=1.5 && speed < 3.3){
                 speed = 2;
             }
-            else if (speed < 5.4) {
+            if(speed >=3.3 && speed < 5.4){
                 speed = 3;
             }
-            else if (speed < 7.9) {
+            if(speed >=5.4 && speed < 7.9){
                 speed = 4;
             }
-            else if (speed < 10.7) {
+            if(speed >=7.9 && speed < 10.7){
                 speed = 5;
             }
-            else if (speed < 13.8) {
+            if(speed >=10.7 && speed < 13.8){
                 speed = 6;
             }
-            else if (speed < 17.1) {
+            if(speed >=13.8 && speed < 17.1){
                 speed = 7;
             }
-            else if (speed < 20.7) {
+            if(speed >=17.1 && speed < 20.7){
                 speed = 8;
             }
-            else if (speed < 24.4) {
+            if(speed >=20.7 && speed < 24.4){
                 speed = 9;
             }
-            else if (speed < 28.4) {
+            if(speed >=24.4 && speed < 28.4){
                 speed = 10;
             }
-            else if (speed < 32.6) {
+            if(speed >=28.4 && speed < 32.6){
                 speed = 11;
             }
-            else {
+            if(speed >=32.6){
                 speed = 12;
             }
             result.unit = "bft";
@@ -329,17 +284,16 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             snprintf(buffer,bsize,"%2.0f",speed);
         }
         else{
-            if (speed < limit_dec_10){
-                snprintf(buffer, bsize, fmt_dec_1, speed);
+            if(speed < 10){
+                snprintf(buffer,bsize,"%3.2f",speed);
             }
-            else if (speed < limit_dec_100){
-                snprintf(buffer, bsize, fmt_dec_10, speed);
+            if(speed >= 10 && speed < 100){
+                snprintf(buffer,bsize,"%3.1f",speed);
             }
-            else {
-                snprintf(buffer, bsize, fmt_dec_100, speed);
+            if(speed >= 100){
+                snprintf(buffer,bsize,"%3.0f",speed);
             }
         }
-        result.cvalue = speed;
     }
     //########################################################
     else if (value->getFormat() == "formatRot"){
@@ -366,7 +320,6 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
         if(rotation <= -10 || rotation >= 10){
             snprintf(buffer,bsize,"%3.0f",rotation);
         }
-        result.cvalue = rotation;
     }
     //########################################################
     else if (value->getFormat() == "formatDop"){
@@ -383,16 +336,12 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
         if(dop > 99.9){
             dop = 99.9;
         }
-        if (dop < limit_dec_10){
-            snprintf(buffer, bsize, fmt_dec_1, dop);
+        if(dop < 10){
+            snprintf(buffer,bsize,"%3.2f",dop);
         }
-        else if(dop < limit_dec_100){
-            snprintf(buffer, bsize, fmt_dec_10, dop);
+        if(dop >= 10 && dop < 100){
+            snprintf(buffer,bsize,"%3.1f",dop);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, dop);
-        }
-        result.cvalue = dop;
     }
     //########################################################
     else if (value->getFormat() == "formatLatitude"){
@@ -417,7 +366,6 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 35.0 + float(random(0, 10)) / 10000.0;
             snprintf(buffer,bsize," 51\" %2.4f' N", rawvalue);
         }
-        result.cvalue = rawvalue;
     }
     //########################################################
     else if (value->getFormat() == "formatLongitude"){
@@ -442,7 +390,6 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 6.0 + float(random(0, 10)) / 100000.0;
             snprintf(buffer,bsize," 15\" %2.4f'", rawvalue);
         }
-        result.cvalue = rawvalue;
     }
     //########################################################
     else if (value->getFormat() == "formatDepth"){
@@ -452,7 +399,7 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = value->value;
         }
         else{
-            rawvalue = 18.0 + float(random(0, 100)) / 10.0; // create random depth values from [18..28] metres
+            rawvalue = 18.0 + float(random(0, 100)) / 10.0;
             depth = rawvalue;
         }
         if(String(lengthFormat) == "ft"){
@@ -462,49 +409,34 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
         else{
             result.unit = "m";
         }
-        if (depth < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, depth);
+        if(depth < 10){
+            snprintf(buffer,bsize,"%3.2f",depth);
         }
-        else if (depth < limit_dec_100){
-            snprintf(buffer, bsize, fmt_dec_10, depth);
+        if(depth >= 10 && depth < 100){
+            snprintf(buffer,bsize,"%3.1f",depth);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, depth);
+        if(depth >= 100){
+            snprintf(buffer,bsize,"%3.0f",depth);
         }
-        result.cvalue = depth;
     }
     //########################################################
     else if (value->getFormat() == "formatXte"){
         double xte = 0;
-        if(usesimudata == false) {
-            xte = value->value;
+        if (!usesimudata) {
+            xte = abs(value->value);
             rawvalue = value->value;
-        }
-        else{
+        } else {
             rawvalue = 6.0 + float(random(0, 4));
             xte = rawvalue;
         }
-        if(String(distanceFormat) == "km"){
-            xte = xte * 0.001;
-            result.unit = "km";
-        }
-        else if(String(distanceFormat) == "nm"){
-            xte = xte * 0.000539957;
-            result.unit = "nm";
-        }
-        else{;
-            result.unit = "m";
-        }
-        if(xte < 10){
-            snprintf(buffer,bsize,"%3.2f",xte);
-        }
-        if(xte >= 10 && xte < 100){
-            snprintf(buffer,bsize,"%3.1f",xte);
-        }
         if (xte >= 100) {
-            snprintf(buffer,bsize,"%3.0f",xte);
+            snprintf(buffer,bsize,"%3.0f",value->value);
+        } else if (xte >= 10) {
+            snprintf(buffer,bsize,"%3.1f",value->value);
+        } else {
+            snprintf(buffer,bsize,"%3.2f",value->value);
         }
-        result.cvalue = xte;
+        result.unit = "nm";
     }
     //########################################################
     else if (value->getFormat() == "kelvinToC"){
@@ -528,16 +460,15 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
         else{
             result.unit = "K";
         }
-        if(temp < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, temp);
+        if(temp < 10){
+            snprintf(buffer,bsize,"%3.2f",temp);
         }
-        else if (temp < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, temp);
+        if(temp >= 10 && temp < 100){
+            snprintf(buffer,bsize,"%3.1f",temp);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, temp);
+        if(temp >= 100){
+            snprintf(buffer,bsize,"%3.0f",temp);
         }
-        result.cvalue = temp;
     }
     //########################################################
     else if (value->getFormat() == "mtr2nm"){
@@ -558,19 +489,18 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             distance = distance * 0.000539957;
             result.unit = "nm";
         }
-        else {
+        else{;
             result.unit = "m";
         }
-        if (distance < limit_dec_10){
-            snprintf(buffer, bsize, fmt_dec_1, distance);
+        if(distance < 10){
+            snprintf(buffer,bsize,"%3.2f",distance);
         }
-        else if (distance < limit_dec_100){
-            snprintf(buffer, bsize, fmt_dec_10, distance);
+        if(distance >= 10 && distance < 100){
+            snprintf(buffer,bsize,"%3.1f",distance);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, distance);
+        if(distance >= 100){
+            snprintf(buffer,bsize,"%3.0f",distance);
         }
-        result.cvalue = distance;
     }
     //########################################################
     // Special XDR formats
@@ -589,7 +519,6 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
         }
         snprintf(buffer,bsize,"%4.0f",pressure);
         result.unit = "hPa";
-        result.cvalue = pressure;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:P:B"){
@@ -605,7 +534,6 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
         }
         snprintf(buffer,bsize,"%4.0f",pressure);
         result.unit = "mBar";
-        result.cvalue = pressure;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:U:V"){
@@ -618,14 +546,13 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 12 + float(random(0, 30)) / 10.0;
             voltage = rawvalue;
         }
-        if (voltage < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, voltage);
+        if(voltage < 10){
+            snprintf(buffer,bsize,"%3.2f",voltage);
         }
         else{
-            snprintf(buffer, bsize, fmt_dec_10, voltage);
+            snprintf(buffer,bsize,"%3.1f",voltage);
         }
         result.unit = "V";
-        result.cvalue = voltage;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:I:A"){
@@ -638,17 +565,16 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 8.2 + float(random(0, 50)) / 10.0;
             current = rawvalue;
         }
-        if (current < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, current);
+        if(current < 10){
+            snprintf(buffer,bsize,"%3.2f",current);
         }
-        else if(current < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, current);
+        if(current >= 10 && current < 100){
+            snprintf(buffer,bsize,"%3.1f",current);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, current);
+        if(current >= 100){
+            snprintf(buffer,bsize,"%3.0f",current);
         }
         result.unit = "A";
-        result.cvalue = current;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:C:K"){
@@ -661,17 +587,16 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 21.8 + float(random(0, 50)) / 10.0;
             temperature = rawvalue;
         }
-        if (temperature < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, temperature);
+        if(temperature < 10){
+            snprintf(buffer,bsize,"%3.2f",temperature);
         }
-        else if (temperature < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, temperature);
+        if(temperature >= 10 && temperature < 100){
+            snprintf(buffer,bsize,"%3.1f",temperature);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, temperature);
+        if(temperature >= 100){
+            snprintf(buffer,bsize,"%3.0f",temperature);
         }
         result.unit = "Deg C";
-        result.cvalue = temperature;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:C:C"){
@@ -684,17 +609,16 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 21.8 + float(random(0, 50)) / 10.0;
             temperature = rawvalue;
         }
-        if (temperature < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, temperature);
+        if(temperature < 10){
+            snprintf(buffer,bsize,"%3.2f",temperature);
         }
-        else if(temperature < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, temperature);
+        if(temperature >= 10 && temperature < 100){
+            snprintf(buffer,bsize,"%3.1f",temperature);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, temperature);
+        if(temperature >= 100){
+            snprintf(buffer,bsize,"%3.0f",temperature);
         }
         result.unit = "Deg C";
-        result.cvalue = temperature;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:H:P"){
@@ -707,17 +631,16 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 41.3 + float(random(0, 50)) / 10.0;
             humidity = rawvalue;
         }
-        if (humidity < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, humidity);
+        if(humidity < 10){
+            snprintf(buffer,bsize,"%3.2f",humidity);
         }
-        else if(humidity < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, humidity);
+        if(humidity >= 10 && humidity < 100){
+            snprintf(buffer,bsize,"%3.1f",humidity);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, humidity);
+        if(humidity >= 100){
+            snprintf(buffer,bsize,"%3.0f",humidity);
         }
         result.unit = "%";
-        result.cvalue = humidity;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:V:P"){
@@ -730,17 +653,16 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 85.8 + float(random(0, 50)) / 10.0;
             volume = rawvalue;
         }
-        if (volume < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, volume);
+        if(volume < 10){
+            snprintf(buffer,bsize,"%3.2f",volume);
         }
-        else if (volume < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, volume);
+        if(volume >= 10 && volume < 100){
+            snprintf(buffer,bsize,"%3.1f",volume);
         }
-        else if (volume >= limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_100, volume);
+        if(volume >= 100){
+            snprintf(buffer,bsize,"%3.0f",volume);
         }
         result.unit = "%";
-        result.cvalue = volume;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:V:M"){
@@ -753,17 +675,16 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 75.2 + float(random(0, 50)) / 10.0;
             volume = rawvalue;
         }
-        if (volume < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, volume);
+        if(volume < 10){
+            snprintf(buffer,bsize,"%3.2f",volume);
         }
-        else if (volume < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, volume);
+        if(volume >= 10 && volume < 100){
+            snprintf(buffer,bsize,"%3.1f",volume);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, volume);
+        if(volume >= 100){
+            snprintf(buffer,bsize,"%3.0f",volume);
         }
         result.unit = "l";
-        result.cvalue = volume;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:R:I"){
@@ -776,40 +697,38 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 7.5 + float(random(0, 20)) / 10.0;
             flow = rawvalue;
         }
-        if (flow < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, flow);
+        if(flow < 10){
+            snprintf(buffer,bsize,"%3.2f",flow);
         }
-        else if (flow < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, flow);
+        if(flow >= 10 && flow < 100){
+            snprintf(buffer,bsize,"%3.1f",flow);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, flow);
+        if(flow >= 100){
+            snprintf(buffer,bsize,"%3.0f",flow);
         }
         result.unit = "l/min";
-        result.cvalue = flow;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:G:"){
         double generic = 0;
         if(usesimudata == false) {
-            generic = value->value;
+            generic = value->value;    // Value in l/min
             rawvalue = value->value;
         }
         else{
             rawvalue = 18.5 + float(random(0, 20)) / 10.0;
             generic = rawvalue;
         }
-        if (generic < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, generic);
+        if(generic < 10){
+            snprintf(buffer,bsize,"%3.2f",generic);
         }
-        else if (generic < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, generic);
+        if(generic >= 10 && generic < 100){
+            snprintf(buffer,bsize,"%3.1f",generic);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, generic);
+        if(generic >= 100){
+            snprintf(buffer,bsize,"%3.0f",generic);
         }
         result.unit = "";
-        result.cvalue = generic;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:A:P"){
@@ -822,17 +741,16 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 55.3 + float(random(0, 20)) / 10.0;
             dplace = rawvalue;
         }
-        if (dplace < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, dplace);
+        if(dplace < 10){
+            snprintf(buffer,bsize,"%3.2f",dplace);
         }
-        else if (dplace < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, dplace);
+        if(dplace >= 10 && dplace < 100){
+            snprintf(buffer,bsize,"%3.1f",dplace);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, dplace);
+        if(dplace >= 100){
+            snprintf(buffer,bsize,"%3.0f",dplace);
         }
         result.unit = "%";
-        result.cvalue = dplace;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:A:D"){
@@ -853,7 +771,6 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             snprintf(buffer,bsize,"%3.0f",angle);
         }
         result.unit = "Deg";
-        result.cvalue = angle;
     }
     //########################################################
     else if (value->getFormat() == "formatXdr:T:R"){
@@ -866,33 +783,31 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
             rawvalue = 2505 + random(0, 20);
             rpm = rawvalue;
         }
-        if (rpm < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, rpm);
+        if(rpm < 10){
+            snprintf(buffer,bsize,"%3.2f",rpm);
         }
-        else if (rpm < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, rpm);
+        if(rpm >= 10 && rpm < 100){
+            snprintf(buffer,bsize,"%3.1f",rpm);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, rpm);
+        if(rpm >= 100){
+            snprintf(buffer,bsize,"%3.0f",rpm);
         }
         result.unit = "rpm";
-        result.cvalue = rpm;
     }
     //########################################################
     // Default format
     //########################################################
     else{
-        if (value->value < limit_dec_10) {
-            snprintf(buffer, bsize, fmt_dec_1, value->value);
+        if(value->value < 10){
+            snprintf(buffer,bsize,"%3.2f",value->value);
         }
-        else if (value->value < limit_dec_100) {
-            snprintf(buffer, bsize, fmt_dec_10, value->value);
+        if(value->value >= 10 && value->value < 100){
+            snprintf(buffer,bsize,"%3.1f",value->value);
         }
-        else {
-            snprintf(buffer, bsize, fmt_dec_100, value->value);
+        if(value->value >= 100){
+            snprintf(buffer,bsize,"%3.0f",value->value);
         }
         result.unit = "";
-        result.cvalue = value->value;
     }
     buffer[bsize]=0;
     result.value = rawvalue;        // Return value is only necessary in case of simulation of graphic pointer
@@ -900,30 +815,4 @@ FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool
     return result;
 }
 
-// Helper method for conversion of any data value from SI to user defined format
-double convertValue(const double &value, const String &name, const String &format, CommonData &commondata)
-{
-    std::unique_ptr<GwApi::BoatValue> tmpBValue; // Temp variable to get converted data value from <OBP60Formatter::formatValue>
-    double result; // data value converted to user defined target data format
-    constexpr bool NO_SIMUDATA = true; // switch off simulation feature of <formatValue> function
-
-    // prepare temporary BoatValue structure for use in <formatValue>
-    tmpBValue = std::unique_ptr<GwApi::BoatValue>(new GwApi::BoatValue(name)); // we don't need boat value name for pure value conversion
-    tmpBValue->setFormat(format);
-    tmpBValue->valid = true;
-    tmpBValue->value = value;
-
-    result = formatValue(tmpBValue.get(), commondata, NO_SIMUDATA).cvalue; // get value (converted); ignore any simulation data setting
-    return result;
-}
-
-// Helper method for conversion of any data value from SI to user defined format
-double convertValue(const double &value, const String &format, CommonData &commondata)
-{
-    double result; // data value converted to user defined target data format
-
-    result = convertValue(value, "dummy", format, commondata);
-    return result;
-}
-
 #endif

lib/obp60task/OBP60Hardware.h

@@ -1,12 +1,11 @@
     // General hardware definitions
     // CAN and RS485 bus pin definitions see obp60task.h
 
-#if defined HARDWARE_V20 || HARDWARE_V21
+#ifdef HARDWARE_V21
     // Direction pin for RS485 NMEA0183
     #define OBP_DIRECTION_PIN 18
     // I2C
-    #define I2C_SPEED 10000UL       // 100kHz clock speed on I2C bus
-    #define I2C_SPEED_LOW 1000UL    // 10kHz clock speed on I2C bus for external bus
+    #define I2C_SPEED 10000UL       // 10kHz clock speed on I2C bus
     #define OBP_I2C_SDA 47
     #define OBP_I2C_SCL 21
     // DS1388 RTC
@@ -23,8 +22,8 @@
     #define AS5600_I2C_ADDR 0x36    // Addr. 0x36 (fix)
     // INA219
     #define SHUNT_VOLTAGE 0.075     // Shunt voltage in V by max. current (75mV)
-    #define INA219_I2C_ADDR1 0x41   // Addr. 0x41 (fix A0 = 5V, A1 = GND) for battery
-    #define INA219_I2C_ADDR2 0x44   // Addr. 0x44 (fix A0 = GND, A1 = 5V) for solar panels
+    #define INA219_I2C_ADDR1 0x40   // Addr. 0x41 (fix A0 = 5V, A1 = GND) for battery
+    #define INA219_I2C_ADDR2 0x41   // Addr. 0x44 (fix A0 = GND, A1 = 5V) for solar panels
     #define INA219_I2C_ADDR3 0x45   // Addr. 0x45 (fix A0 = 5V, A1 = 5V) for generator
     // INA226
     #define INA226_I2C_ADDR1 0x41   // Addr. 0x41 (fix A0 = 5V, A1 = GND) for battery
@@ -43,8 +42,6 @@
     #define OBP_SPI_DIN 48
     #define SHOW_TIME 6000        // Show time in [ms] for logo and WiFi QR code
     #define FULL_REFRESH_TIME 600 // Refresh cycle time in [s][600...3600] for full display update (very important healcy function)
-    #define GxEPD_WIDTH 400       // Display width
-    #define GxEPD_HEIGHT 300      // Display height
 
     // GPS (NEO-6M, NEO-M8N, ATGM336H)
     #define OBP_GPS_RX 2
@@ -85,8 +82,7 @@
     // Direction pin for RS485 NMEA0183
     #define OBP_DIRECTION_PIN 8
     // I2C
-    #define I2C_SPEED 100000UL      // 100kHz clock speed on I2C bus
-    #define I2C_SPEED_LOW 1000UL    // 10kHz clock speed on I2C bus for external bus
+    #define I2C_SPEED 10000UL       // 10kHz clock speed on I2C bus
     #define OBP_I2C_SDA 21
     #define OBP_I2C_SCL 38
     // DS1388 RTC
@@ -103,8 +99,8 @@
     #define AS5600_I2C_ADDR 0x36    // Addr. 0x36 (fix)
     // INA219
     #define SHUNT_VOLTAGE 0.075     // Shunt voltage in V by max. current (75mV)
-    #define INA219_I2C_ADDR1 0x41   // Addr. 0x41 (fix A0 = 5V, A1 = GND) for battery
-    #define INA219_I2C_ADDR2 0x44   // Addr. 0x44 (fix A0 = GND, A1 = 5V) for solar panels
+    #define INA219_I2C_ADDR1 0x40   // Addr. 0x41 (fix A0 = 5V, A1 = GND) for battery
+    #define INA219_I2C_ADDR2 0x41   // Addr. 0x44 (fix A0 = GND, A1 = 5V) for solar panels
     #define INA219_I2C_ADDR3 0x45   // Addr. 0x45 (fix A0 = 5V, A1 = 5V) for generator
     // INA226
     #define INA226_I2C_ADDR1 0x41   // Addr. 0x41 (fix A0 = 5V, A1 = GND) for battery
@@ -123,13 +119,11 @@
     #define OBP_SPI_DIN 11
     #define SHOW_TIME 6000        // Show time in [ms] for logo and WiFi QR code
     #define FULL_REFRESH_TIME 600 // Refresh cycle time in [s][600...3600] for full display update (very important healcy function)
-    #define GxEPD_WIDTH 400       // Display width
-    #define GxEPD_HEIGHT 300      // Display height
     // SPI SD-Card
-    #define SD_SPI_CS GPIO_NUM_10
-    #define SD_SPI_MOSI GPIO_NUM_40
-    #define SD_SPI_CLK GPIO_NUM_39
-    #define SD_SPI_MISO GPIO_NUM_13
+    #define SD_SPI_CS 10
+    #define SD_SPI_MOSI 40
+    #define SD_SPI_CLK 39
+    #define SD_SPI_MISO 13
 
     // GPS (NEO-6M, NEO-M8N, ATGM336H)
     #define OBP_GPS_RX 19

lib/obp60task/OBP60Keypad.h

@@ -58,7 +58,7 @@ void initKeys(CommonData &commonData) {
     commonData.keydata[5].h = height;
 }
 
-  #if defined HARDWARE_V20 || HARDWARE_V21
+  #ifdef HARDWARE_V21
   // Keypad functions for original OBP60 hardware
   int readKeypad(GwLog* logger, uint thSensitivity, bool use_syspage) {
     

lib/obp60task/OBPDataOperations.cpp

@@ -1,345 +1,10 @@
 #include "OBPDataOperations.h"
-//#include "BoatDataCalibration.h" // Functions lib for data instance calibration
 
-// --- Class CalibrationData ---------------
-CalibrationData::CalibrationData(GwLog* log)
-{
-    logger = log;
-}
-
-void CalibrationData::readConfig(GwConfigHandler* config)
-// Initial load of calibration data into internal list
-// This method is called once at init phase of <obp60task> to read the configuration values
-{
-    std::string instance;
-    double offset;
-    double slope;
-    double smooth;
-
-    String calInstance = "";
-    String calOffset = "";
-    String calSlope = "";
-    String calSmooth = "";
-
-    // Load user format configuration values
-    String lengthFormat = config->getString(config->lengthFormat); // [m|ft]
-    String distanceFormat = config->getString(config->distanceFormat); // [m|km|nm]
-    String speedFormat = config->getString(config->speedFormat); // [m/s|km/h|kn]
-    String windspeedFormat = config->getString(config->windspeedFormat); // [m/s|km/h|kn|bft]
-    String tempFormat = config->getString(config->tempFormat); // [K|C|F]
-
-    // Read calibration settings for data instances
-    for (int i = 0; i < MAX_CALIBRATION_DATA; i++) {
-        calInstance = "calInstance" + String(i + 1);
-        calOffset = "calOffset" + String(i + 1);
-        calSlope = "calSlope" + String(i + 1);
-        calSmooth = "calSmooth" + String(i + 1);
-
-        instance = std::string(config->getString(calInstance, "---").c_str());
-        if (instance == "---") {
-            LOG_DEBUG(GwLog::LOG, "No calibration data for instance no. %d", i + 1);
-            continue;
-        }
-
-        calibrationMap[instance] = { 0.0f, 1.0f, 1.0f, 0.0f, false };
-        offset = (config->getString(calOffset, "")).toDouble();
-        slope = (config->getString(calSlope, "")).toDouble();
-        smooth = (config->getString(calSmooth, "")).toInt(); // user input is int; further math is done with double
-
-        if (slope == 0.0) {
-            slope = 1.0; // eliminate adjustment if user selected "0" -> that would set the calibrated value to "0"
-        }
-
-        // Convert calibration values from user input format to internal standard SI format
-        if (instance == "AWS" || instance == "TWS") {
-            if (windspeedFormat == "m/s") {
-                // No conversion needed
-            } else if (windspeedFormat == "km/h") {
-                offset /= 3.6; // Convert km/h to m/s
-            } else if (windspeedFormat == "kn") {
-                offset /= 1.94384; // Convert kn to m/s
-            } else if (windspeedFormat == "bft") {
-                offset *= 2 + (offset / 2); // Convert Bft to m/s (approx) -> to be improved
-            }
-
-        } else if (instance == "AWA" || instance == "COG" || instance == "HDM" || instance == "HDT" || instance == "PRPOS" || instance == "RPOS" || instance == "TWA" || instance == "TWD") {
-            offset *= DEG_TO_RAD; // Convert deg to rad
-
-        } else if (instance == "DBS" || instance == "DBT") {
-            if (lengthFormat == "m") {
-                // No conversion needed
-            } else if (lengthFormat == "ft") {
-                offset /= 3.28084; // Convert ft to m
-            }
-
-        } else if (instance == "SOG" || instance == "STW") {
-            if (speedFormat == "m/s") {
-                // No conversion needed
-            } else if (speedFormat == "km/h") {
-                offset /= 3.6; // Convert km/h to m/s
-            } else if (speedFormat == "kn") {
-                offset /= 1.94384; // Convert kn to m/s
-            }
-
-        } else if (instance == "WTemp") {
-            if (tempFormat == "K" || tempFormat == "C") {
-                // No conversion needed
-            } else if (tempFormat == "F") {
-                offset *= 9.0 / 5.0; // Convert °F to K
-                slope *= 9.0 / 5.0; // Convert °F to K
-            }
-        }
-
-        // transform smoothing factor from [0.01..10] to [0.3..0.95] and invert for exponential smoothing formula
-        if (smooth <= 0) {
-            smooth = 0;
-        } else {
-            if (smooth > 10) {
-                smooth = 10;
-            }
-            smooth = 0.3 + ((smooth - 0.01) * (0.95 - 0.3) / (10 - 0.01));
-        }
-        smooth = 1 - smooth;
-
-        calibrationMap[instance].offset = offset;
-        calibrationMap[instance].slope = slope;
-        calibrationMap[instance].smooth = smooth;
-        calibrationMap[instance].isCalibrated = false;
-        LOG_DEBUG(GwLog::LOG, "Calibration data type added: %s, offset: %f, slope: %f, smoothing: %f", instance.c_str(),
-            calibrationMap[instance].offset, calibrationMap[instance].slope, calibrationMap[instance].smooth);
-    }
-    // LOG_DEBUG(GwLog::LOG, "All calibration data read");
-}
-
-// Handle calibrationMap and calibrate all boat data values
-void CalibrationData::handleCalibration(BoatValueList* boatValueList)
-{
-    GwApi::BoatValue* bValue;
-
-    for (const auto& cMap : calibrationMap) {
-        std::string instance = cMap.first.c_str();
-        bValue = boatValueList->findValueOrCreate(String(instance.c_str()));
-
-        calibrateInstance(bValue);
-        smoothInstance(bValue);
-    }
-}
-
-// Calibrate single boat data value
-// Return calibrated boat value or DBL_MAX, if no calibration was performed
-bool CalibrationData::calibrateInstance(GwApi::BoatValue* boatDataValue)
-{
-    std::string instance = boatDataValue->getName().c_str();
-    double offset = 0;
-    double slope = 1.0;
-    double dataValue = 0;
-    std::string format = "";
-
-    // we test this earlier, but for safety reason ...
-    if (calibrationMap.find(instance) == calibrationMap.end()) {
-        LOG_DEBUG(GwLog::DEBUG, "BoatDataCalibration: %s not in calibration list", instance.c_str());
-        return false;
-    }
-
-    calibrationMap[instance].isCalibrated = false; // reset calibration flag until properly calibrated
-
-    if (!boatDataValue->valid) { // no valid boat data value, so we don't want to apply calibration data
-        return false;
-    }
-
-    offset = calibrationMap[instance].offset;
-    slope = calibrationMap[instance].slope;
-    dataValue = boatDataValue->value;
-    format = boatDataValue->getFormat().c_str();
-    LOG_DEBUG(GwLog::DEBUG, "BoatDataCalibration: %s: value: %f, format: %s", instance.c_str(), dataValue, format.c_str());
-
-    if (format == "formatWind") { // instance is of type angle
-        dataValue = (dataValue * slope) + offset;
-        // dataValue = WindUtils::toPI(dataValue);
-        dataValue = WindUtils::to2PI(dataValue); // we should call <toPI> for format of [-180..180], but pages cannot display negative values properly yet
-
-    } else if (format == "formatCourse") { // instance is of type direction
-        dataValue = (dataValue * slope) + offset;
-        dataValue = WindUtils::to2PI(dataValue);
-
-    } else if (format == "kelvinToC") { // instance is of type temperature
-        dataValue = ((dataValue - 273.15) * slope) + offset + 273.15;
-
-    } else {
-        dataValue = (dataValue * slope) + offset;
-    }
-
-
-    boatDataValue->value = dataValue; // update boat data value with calibrated value
-    calibrationMap[instance].value = dataValue; // store the calibrated value in the list
-    calibrationMap[instance].isCalibrated = true;
-
-    LOG_DEBUG(GwLog::DEBUG, "BoatDataCalibration: %s: Offset: %f, Slope: %f, Result: %f", instance.c_str(), offset, slope, calibrationMap[instance].value);
-    return true;
-}
-
-// Smooth single boat data value
-// Return smoothed boat value or DBL_MAX, if no smoothing was performed
-bool CalibrationData::smoothInstance(GwApi::BoatValue* boatDataValue)
-{
-    std::string instance = boatDataValue->getName().c_str();
-    double oldValue = 0;
-    double dataValue = boatDataValue->value;
-    double smoothFactor = 0;
-
-    // we test this earlier, but for safety reason ...
-    if (calibrationMap.find(instance) == calibrationMap.end()) {
-        LOG_DEBUG(GwLog::DEBUG, "BoatDataCalibration: %s not in calibration list", instance.c_str());
-        return false;
-    }
-
-    calibrationMap[instance].isCalibrated = false; // reset calibration flag until properly calibrated
-
-    if (!boatDataValue->valid) { // no valid boat data value, so we don't need to do anything
-        return false;
-    }
-
-    smoothFactor = calibrationMap[instance].smooth;
-
-    if (lastValue.find(instance) != lastValue.end()) {
-        oldValue = lastValue[instance];
-        dataValue = oldValue + (smoothFactor * (dataValue - oldValue)); // exponential smoothing algorithm
-    }
-    lastValue[instance] = dataValue; // store the new value for next cycle; first time, store only the current value and return
-
-    boatDataValue->value = dataValue; // update boat data value with smoothed value
-    calibrationMap[instance].value = dataValue; // store the smoothed value in the list
-    calibrationMap[instance].isCalibrated = true;
-
-    LOG_DEBUG(GwLog::DEBUG, "BoatDataCalibration: %s: smooth: %f, oldValue: %f, result: %f", instance.c_str(), smoothFactor, oldValue, calibrationMap[instance].value);
-
-    return true;
-}
-// --- End Class CalibrationData ---------------
-
-// --- Class HstryBuf ---------------
-HstryBuf::HstryBuf(const String& name, int size, BoatValueList* boatValues, GwLog* log)
-    : logger(log)
-    , boatDataName(name)
-{
-    hstryBuf.resize(size);
-    boatValue = boatValues->findValueOrCreate(name);
-}
-
-void HstryBuf::init(const String& format, int updFreq, int mltplr, double minVal, double maxVal)
-{
-    hstryBuf.setMetaData(boatDataName, format, updFreq, mltplr, minVal, maxVal);
-    hstryMin = minVal;
-    hstryMax = maxVal;
-    if (!boatValue->valid) {
-        boatValue->setFormat(format);
-        boatValue->value = std::numeric_limits<double>::max(); // mark current value invalid
-    }
-}
-
-void HstryBuf::add(double value)
-{
-    if (value >= hstryMin && value <= hstryMax) {
-        hstryBuf.add(value);
-        LOG_DEBUG(GwLog::DEBUG, "HstryBuf::add:  name: %s, value: %.3f", hstryBuf.getName(), value);
-    }
-}
-
-void HstryBuf::handle(bool useSimuData, CommonData& common)
-{
-    // GwApi::BoatValue* tmpBVal;
-    std::unique_ptr<GwApi::BoatValue> tmpBVal; // Temp variable to get formatted and converted data value from OBP60Formatter
-
-    // create temporary boat value for calibration purposes and retrieval of simulation value
-    // tmpBVal = new GwApi::BoatValue(boatDataName.c_str());
-    tmpBVal = std::unique_ptr<GwApi::BoatValue>(new GwApi::BoatValue(boatDataName));
-    tmpBVal->setFormat(boatValue->getFormat());
-    tmpBVal->value = boatValue->value;
-    tmpBVal->valid = boatValue->valid;
-
-    if (boatValue->valid) {
-        // Calibrate boat value before adding it to history buffer
-        //calibrationData.calibrateInstance(tmpBVal.get(), logger);
-        //add(tmpBVal->value);
-        add(boatValue->value);
-
-    } else if (useSimuData) { // add simulated value to history buffer
-        double simSIValue = formatValue(tmpBVal.get(), common).value; // simulated value is generated at <formatValue>; here: retreive SI value
-        add(simSIValue);
-    } else {
-        // here we will add invalid (DBL_MAX) value; this will mark periods of missing data in buffer together with a timestamp
-    }
-}
-// --- End Class HstryBuf ---------------
-
-// --- Class HstryBuffers ---------------
-HstryBuffers::HstryBuffers(int size, BoatValueList* boatValues, GwLog* log)
-    : size(size)
-    , boatValueList(boatValues)
-    , logger(log)
-{
-
-    // collect boat values for true wind calculation
-    // should all have been already created at true wind object initialization
-    // potentially to be moved to history buffer handling
-    awaBVal = boatValueList->findValueOrCreate("AWA");
-    hdtBVal = boatValueList->findValueOrCreate("HDT");
-    hdmBVal = boatValueList->findValueOrCreate("HDM");
-    varBVal = boatValueList->findValueOrCreate("VAR");
-    cogBVal = boatValueList->findValueOrCreate("COG");
-    sogBVal = boatValueList->findValueOrCreate("SOG");
-    awdBVal = boatValueList->findValueOrCreate("AWD");
-}
-
-// Create history buffer for boat data type
-void HstryBuffers::addBuffer(const String& name)
-{
-    if (HstryBuffers::getBuffer(name) != nullptr) { // buffer for this data type already exists
-        return;
-    }
-    if (bufferParams.find(name) == bufferParams.end()) { // requested boat data type is not supported in list of <bufferParams>
-        return;
-    }
-
-    hstryBuffers[name] = std::unique_ptr<HstryBuf>(new HstryBuf(name, size, boatValueList, logger));
-
-    // Initialize metadata for buffer
-    String valueFormat = bufferParams[name].format; // Data format of boat data type
-    // String valueFormat = boatValueList->findValueOrCreate(name)->getFormat().c_str(); // Unfortunately, format is not yet available during system initialization
-    int hstryUpdFreq = bufferParams[name].hstryUpdFreq; // Update frequency for history buffers in ms
-    int mltplr = bufferParams[name].mltplr; // default multiplier which transforms original <double> value into buffer type format
-    double bufferMinVal = bufferParams[name].bufferMinVal; // Min value for this history buffer
-    double bufferMaxVal = bufferParams[name].bufferMaxVal; // Max value for this history buffer
-
-    hstryBuffers[name]->init(valueFormat, hstryUpdFreq, mltplr, bufferMinVal, bufferMaxVal);
-    LOG_DEBUG(GwLog::DEBUG, "HstryBuffers: new buffer added: name: %s, format: %s, multiplier: %d, min value: %.2f, max value: %.2f", name, valueFormat, mltplr, bufferMinVal, bufferMaxVal);
-}
-
-// Handle all registered history buffers
-void HstryBuffers::handleHstryBufs(bool useSimuData, CommonData& common)
-{
-    for (auto& bufMap : hstryBuffers) {
-        auto& buf = bufMap.second;
-        buf->handle(useSimuData, common);
-    }
-}
-
-RingBuffer<uint16_t>* HstryBuffers::getBuffer(const String& name)
-{
-    auto it = hstryBuffers.find(name);
-    if (it != hstryBuffers.end()) {
-        return &it->second->hstryBuf;
-    }
-    return nullptr;
-}
-// --- End Class HstryBuffers ---------------
-
-// --- Class WindUtils --------------
 double WindUtils::to2PI(double a)
 {
-    a = fmod(a, M_TWOPI);
+    a = fmod(a, 2 * M_PI);
     if (a < 0.0) {
-        a += M_TWOPI;
+        a += 2 * M_PI;
     }
     return a;
 }
@@ -355,18 +20,18 @@ double WindUtils::toPI(double a)
 
 double WindUtils::to360(double a)
 {
-    a = fmod(a, 360.0);
+    a = fmod(a, 360);
     if (a < 0.0) {
-        a += 360.0;
+        a += 360;
     }
     return a;
 }
 
 double WindUtils::to180(double a)
 {
-    a += 180.0;
+    a += 180;
     a = to360(a);
-    a -= 180.0;
+    a -= 180;
 
     return a;
 }
@@ -398,139 +63,95 @@ void WindUtils::addPolar(const double* phi1, const double* r1,
 
 void WindUtils::calcTwdSA(const double* AWA, const double* AWS,
     const double* CTW, const double* STW, const double* HDT,
-    double* TWD, double* TWS, double* TWA, double* AWD)
+    double* TWD, double* TWS, double* TWA)
 {
-    *AWD = *AWA + *HDT;
-    *AWD = to2PI(*AWD);
+    double awd = *AWA + *HDT;
+    awd = to2PI(awd);
     double stw = -*STW;
-    addPolar(AWD, AWS, CTW, &stw, TWD, TWS);
+    //    Serial.println("\ncalcTwdSA: AWA: " + String(*AWA) + ", AWS: " + String(*AWS) + ", CTW: " + String(*CTW) + ", STW: " + String(*STW) + ", HDT: " + String(*HDT));
+    addPolar(&awd, AWS, CTW, &stw, TWD, TWS);
 
-    // Normalize TWD and TWA to 0-360°/2PI
+    // Normalize TWD and TWA to 0-360°
     *TWD = to2PI(*TWD);
     *TWA = toPI(*TWD - *HDT);
+    //    Serial.println("calcTwdSA: TWD: " + String(*TWD) + ", TWS: " + String(*TWS));
 }
 
-double WindUtils::calcHDT(const double* hdmVal, const double* varVal, const double* cogVal, const double* sogVal)
-{
-    double hdt;
-    double minSogVal = 0.1; // SOG below this value (m/s) is assumed to be  data noise from GPS sensor
-
-    if (*hdmVal != DBL_MAX) {
-        hdt = *hdmVal + (*varVal != DBL_MAX ? *varVal : 0.0); // Use corrected HDM if HDT is not available (or just HDM if VAR is not available)
-        hdt = to2PI(hdt);
-    } else if (*cogVal != DBL_MAX && *sogVal >= minSogVal) {
-        hdt = *cogVal; // Use COG as fallback if HDT and HDM are not available, and SOG is not data noise
-    } else {
-        hdt = DBL_MAX; // Cannot calculate HDT without valid HDM or HDM+VAR or COG
-    }
-
-    return hdt;
-}
-
-bool WindUtils::calcWinds(const double* awaVal, const double* awsVal,
+bool WindUtils::calcTrueWind(const double* awaVal, const double* awsVal,
     const double* cogVal, const double* stwVal, const double* sogVal, const double* hdtVal,
-    const double* hdmVal, const double* varVal, double* twdVal, double* twsVal, double* twaVal, double* awdVal)
+    const double* hdmVal, const double* varVal, double* twdVal, double* twsVal, double* twaVal)
 {
     double stw, hdt, ctw;
-    double twd, tws, twa, awd;
-    double minSogVal = 0.1; // SOG below this value (m/s) is assumed to be  data noise from GPS sensor
+    double twd, tws, twa;
+    static const double DBL_MIN = std::numeric_limits<double>::lowest();
 
-    if (*hdtVal != DBL_MAX) {
+    if (*hdtVal != DBL_MIN) {
         hdt = *hdtVal; // Use HDT if available
     } else {
-        hdt = calcHDT(hdmVal, varVal, cogVal, sogVal);
+        if (*hdmVal != DBL_MIN && *varVal != DBL_MIN) {
+            hdt = *hdmVal + *varVal; // Use corrected HDM if HDT is not available
+            hdt = to2PI(hdt);
+        } else if (*cogVal != DBL_MIN) {
+            hdt = *cogVal; // Use COG as fallback if HDT and HDM are not available
+        } else {
+            return false; // Cannot calculate without valid HDT or HDM+VAR or COG
+        }
     }
 
-    if (*cogVal != DBL_MAX && *sogVal >= minSogVal) { // if SOG is data noise, we don't trust COG
-
-        ctw = *cogVal; // Use COG for CTW if available
+    if (*cogVal != DBL_MIN) {
+        ctw = *cogVal; // Use COG as CTW if available
+        //    ctw = *cogVal + ((*cogVal - hdt) / 2); // Estimate CTW from COG
     } else {
         ctw = hdt; // 2nd approximation for CTW; hdt must exist if we reach this part of the code
     }
 
-    if (*stwVal != DBL_MAX) {
+    if (*stwVal != DBL_MIN) {
         stw = *stwVal; // Use STW if available
-    } else if (*sogVal != DBL_MAX) {
+    } else if (*sogVal != DBL_MIN) {
         stw = *sogVal;
     } else {
         // If STW and SOG are not available, we cannot calculate true wind
         return false;
     }
-    // LOG_DEBUG(GwLog::DEBUG, "WindUtils:calcWinds: HDT: %.1f, CTW %.1f, STW %.1f", hdt, ctw, stw);
 
-    if ((*awaVal == DBL_MAX) || (*awsVal == DBL_MAX)) {
+    if ((*awaVal == DBL_MIN) || (*awsVal == DBL_MIN)) {
         // Cannot calculate true wind without valid AWA, AWS; other checks are done earlier
         return false;
     } else {
-        calcTwdSA(awaVal, awsVal, &ctw, &stw, &hdt, &twd, &tws, &twa, &awd);
+        calcTwdSA(awaVal, awsVal, &ctw, &stw, &hdt, &twd, &tws, &twa);
         *twdVal = twd;
         *twsVal = tws;
         *twaVal = twa;
-        *awdVal = awd;
 
         return true;
     }
 }
 
-// Calculate true wind data and add to obp60task boat data list
-bool WindUtils::addWinds()
+void HstryBuf::fillWndBufSimData(tBoatHstryData& hstryBufs)
+// Fill most part of TWD and TWS history buffer with simulated data
 {
-    double twd, tws, twa, awd, hdt;
-    bool twCalculated = false;
-    bool awdCalculated = false;
-
-    double awaVal = awaBVal->valid ? awaBVal->value : DBL_MAX;
-    double awsVal = awsBVal->valid ? awsBVal->value : DBL_MAX;
-    double cogVal = cogBVal->valid ? cogBVal->value : DBL_MAX;
-    double stwVal = stwBVal->valid ? stwBVal->value : DBL_MAX;
-    double sogVal = sogBVal->valid ? sogBVal->value : DBL_MAX;
-    double hdtVal = hdtBVal->valid ? hdtBVal->value : DBL_MAX;
-    double hdmVal = hdmBVal->valid ? hdmBVal->value : DBL_MAX;
-    double varVal = varBVal->valid ? varBVal->value : DBL_MAX;
-    LOG_DEBUG(GwLog::DEBUG, "WindUtils:addWinds: AWA %.1f, AWS %.1f, COG %.1f, STW %.1f, SOG %.2f, HDT %.1f, HDM %.1f, VAR %.1f", awaBVal->value * RAD_TO_DEG, awsBVal->value * 3.6 / 1.852,
-        cogBVal->value * RAD_TO_DEG, stwBVal->value * 3.6 / 1.852, sogBVal->value * 3.6 / 1.852, hdtBVal->value * RAD_TO_DEG, hdmBVal->value * RAD_TO_DEG, varBVal->value * RAD_TO_DEG);
-
-    // Check if TWD can be calculated from TWA and HDT/HDM
-    if (twaBVal->valid) {
-        if (!twdBVal->valid) {
-            if (hdtVal != DBL_MAX) {
-                hdt = hdtVal; // Use HDT if available
-            } else {
-                hdt = calcHDT(&hdmVal, &varVal, &cogVal, &sogVal);
+    double value = 20.0;
+    int16_t value2 = 0;
+    for (int i = 0; i < 900; i++) {
+        value += random(-20, 20);
+        value = WindUtils::to360(value);
+        value2 = static_cast<int16_t>(value * DEG_TO_RAD * 1000);
+        hstryBufs.twdHstry->add(value2);
     }
-            twd = twaBVal->value + hdt;
-            twd = to2PI(twd);
-            twdBVal->value = twd;
-            twdBVal->valid = true;
 }
 
-    } else {
-        // Calculate true winds and AWD; if true winds exist, use at least AWD calculation
-        twCalculated = calcWinds(&awaVal, &awsVal, &cogVal, &stwVal, &sogVal, &hdtVal, &hdmVal, &varVal, &twd, &tws, &twa, &awd);
+/* double genTwdSimDat()
+{
+    simTwd += random(-20, 20);
+    if (simTwd < 0.0)
+        simTwd += 360.0;
+    if (simTwd >= 360.0)
+        simTwd -= 360.0;
 
-        if (twCalculated) { // Replace values only, if successfully calculated and not already available
-            if (!twdBVal->valid) {
-                twdBVal->value = twd;
-                twdBVal->valid = true;
-            }
-            if (!twsBVal->valid) {
-                twsBVal->value = tws;
-                twsBVal->valid = true;
-            }
-            if (!twaBVal->valid) {
-                //twaBVal->value = twa;
-                twaBVal->value = to2PI(twa); // convert to [0..360], because pages cannot display negative values properly yet
-                twaBVal->valid = true;
-            }
-            if (!awdBVal->valid) {
-                awdBVal->value = awd;
-                awdBVal->valid = true;
-            }
-        }
-    }
-    LOG_DEBUG(GwLog::DEBUG, "WindUtils:addWinds: twCalculated %d, TWD %.1f, TWA %.1f, TWS %.2f kn, AWD: %.1f", twCalculated, twdBVal->value * RAD_TO_DEG,
-        twaBVal->value * RAD_TO_DEG, twsBVal->value * 3.6 / 1.852, awdBVal->value * RAD_TO_DEG);
+    int16_t z = static_cast<int16_t>(DegToRad(simTwd) * 1000.0);
+    pageData.boatHstry.twdHstry->add(z); // Fill the buffer with some test data
 
-    return twCalculated;
-}
-// --- End Class WindUtils --------------
+    simTws += random(-200, 150) / 10.0; // TWS value in knots
+    simTws = constrain(simTws, 0.0f, 50.0f); // Ensure TWS is between 0 and 50 knots
+    twsValue = simTws;
+}*/

lib/obp60task/OBPDataOperations.h

@@ -1,139 +1,36 @@
-// Function lib for boat data calibration, history buffer handling, true wind calculation, and other operations on boat data
 #pragma once
+#include "GwApi.h"
 #include "OBPRingBuffer.h"
-#include "Pagedata.h"
-#include "obp60task.h"
-#include <map>
-#include <unordered_map>
+#include <Arduino.h>
+#include <math.h>
 
-// Calibration of boat data values, when user setting available
-// supported boat data types are: AWA, AWS, COG, DBS, DBT, HDM, HDT, PRPOS, RPOS, SOG, STW, TWA, TWS, TWD, WTemp
-class CalibrationData {
-private:
 typedef struct {
-        double offset; // calibration offset
-        double slope; // calibration slope
-        double smooth; // smoothing factor
-        double value; // calibrated data value (for future use)
-        bool isCalibrated; // is data instance value calibrated? (for future use)
-    } tCalibrationData;
-
-    std::unordered_map<std::string, tCalibrationData> calibrationMap; // list of calibration data instances
-    std::unordered_map<std::string, double> lastValue; // array for last smoothed values of boat data values
-    GwLog* logger;
-
-    static constexpr int8_t MAX_CALIBRATION_DATA = 4; // maximum number of calibration data instances
-
-public:
-    CalibrationData(GwLog* log);
-    void readConfig(GwConfigHandler* config);
-    void handleCalibration(BoatValueList* boatValues); // Handle calibrationMap and calibrate all boat data values
-    bool calibrateInstance(GwApi::BoatValue* boatDataValue); // Calibrate single boat data value
-    bool smoothInstance(GwApi::BoatValue* boatDataValue); // Smooth single boat data value
-};
+    RingBuffer<int16_t>* twdHstry;
+    RingBuffer<int16_t>* twsHstry;
+} tBoatHstryData; // Holds pointers to all history buffers for boat data
 
 class HstryBuf {
-private:
-    RingBuffer<uint16_t> hstryBuf; // Circular buffer to store history values
-    String boatDataName;
-    double hstryMin;
-    double hstryMax;
-    GwApi::BoatValue* boatValue;
-    GwLog* logger;
-
-    friend class HstryBuffers;
 
 public:
-    HstryBuf(const String& name, int size, BoatValueList* boatValues, GwLog* log);
-    void init(const String& format, int updFreq, int mltplr, double minVal, double maxVal);
-    void add(double value);
-    void handle(bool useSimuData, CommonData& common);
-};
-
-class HstryBuffers {
-private:
-    std::map<String, std::unique_ptr<HstryBuf>> hstryBuffers;
-    int size; // size of all history buffers
-    BoatValueList* boatValueList;
-    GwLog* logger;
-    GwApi::BoatValue *awaBVal, *hdtBVal, *hdmBVal, *varBVal, *cogBVal, *sogBVal, *awdBVal; // boat values for true wind calculation
-
-    struct HistoryParams {
-        int hstryUpdFreq; // update frequency of history buffer (documentation only)
-        int mltplr; // specifies actual value precision being storable:
-                    // [10000: 0 - 6.5535 | 1000: 0 - 65.535 | 100: 0 - 650.35 | 10: 0 - 6503.5
-        double bufferMinVal; // minimum valid data value
-        double bufferMaxVal; // maximum valid data value
-        String format; // format of data type
-    };
-
-    // Define buffer parameters for supported boat data type
-    std::map<String, HistoryParams> bufferParams = {
-        { "AWA", { 1000, 10000, 0.0, M_TWOPI, "formatWind" } },
-        { "AWD", { 1000, 10000, 0.0, M_TWOPI, "formatCourse" } },
-        { "AWS", { 1000, 1000, 0.0, 65.0, "formatKnots" } },
-        { "COG", { 1000, 10000, 0.0, M_TWOPI, "formatCourse" } },
-        { "DBS", { 1000, 100, 0.0, 650.0, "formatDepth" } },
-        { "DBT", { 1000, 100, 0.0, 650.0, "formatDepth" } },
-        { "DPT", { 1000, 100, 0.0, 650.0, "formatDepth" } },
-        { "HDM", { 1000, 10000, 0.0, M_TWOPI, "formatCourse" } },
-        { "HDT", { 1000, 10000, 0.0, M_TWOPI, "formatCourse" } },
-        { "ROT", { 1000, 10000, -M_PI / 180.0 * 99.0, M_PI / 180.0 * 99.0, "formatRot" } }, // min/max is -/+ 99 degrees for "rate of turn"
-        { "SOG", { 1000, 1000, 0.0, 65.0, "formatKnots" } },
-        { "STW", { 1000, 1000, 0.0, 65.0, "formatKnots" } },
-        { "TWA", { 1000, 10000, 0.0, M_TWOPI, "formatWind" } },
-        { "TWD", { 1000, 10000, 0.0, M_TWOPI, "formatCourse" } },
-        { "TWS", { 1000, 1000, 0.0, 65.0, "formatKnots" } },
-        { "WTemp", { 1000, 100, 233.0, 650.0, "kelvinToC" } } // [-50..376] °C
-    };
-
-public:
-    HstryBuffers(int size, BoatValueList* boatValues, GwLog* log);
-    void addBuffer(const String& name);
-    void handleHstryBufs(bool useSimuData, CommonData& common);
-    RingBuffer<uint16_t>* getBuffer(const String& name);
+    void fillWndBufSimData(tBoatHstryData& hstryBufs); // Fill most part of the TWD and TWS history buffer with simulated data
 };
 
 class WindUtils {
-private:
-    GwApi::BoatValue *twaBVal, *twsBVal, *twdBVal;
-    GwApi::BoatValue *awaBVal, *awsBVal, *awdBVal, *cogBVal, *stwBVal, *sogBVal, *hdtBVal, *hdmBVal, *varBVal;
-    static constexpr double DBL_MAX = std::numeric_limits<double>::max();
-    GwLog* logger;
 
 public:
-    WindUtils(BoatValueList* boatValues, GwLog* log)
-        : logger(log)
-    {
-        twaBVal = boatValues->findValueOrCreate("TWA");
-        twsBVal = boatValues->findValueOrCreate("TWS");
-        twdBVal = boatValues->findValueOrCreate("TWD");
-        awaBVal = boatValues->findValueOrCreate("AWA");
-        awsBVal = boatValues->findValueOrCreate("AWS");
-        awdBVal = boatValues->findValueOrCreate("AWD");
-        cogBVal = boatValues->findValueOrCreate("COG");
-        stwBVal = boatValues->findValueOrCreate("STW");
-        sogBVal = boatValues->findValueOrCreate("SOG");
-        hdtBVal = boatValues->findValueOrCreate("HDT");
-        hdmBVal = boatValues->findValueOrCreate("HDM");
-        varBVal = boatValues->findValueOrCreate("VAR");
-    };
-
     static double to2PI(double a);
     static double toPI(double a);
     static double to360(double a);
     static double to180(double a);
-    void toCart(const double* phi, const double* r, double* x, double* y);
-    void toPol(const double* x, const double* y, double* phi, double* r);
-    void addPolar(const double* phi1, const double* r1,
+    static void toCart(const double* phi, const double* r, double* x, double* y);
+    static void toPol(const double* x, const double* y, double* phi, double* r);
+    static void addPolar(const double* phi1, const double* r1,
         const double* phi2, const double* r2,
         double* phi, double* r);
-    void calcTwdSA(const double* AWA, const double* AWS,
+    static void calcTwdSA(const double* AWA, const double* AWS,
         const double* CTW, const double* STW, const double* HDT,
-        double* TWD, double* TWS, double* TWA, double* AWD);
-    static double calcHDT(const double* hdmVal, const double* varVal, const double* cogVal, const double* sogVal);
-    bool calcWinds(const double* awaVal, const double* awsVal,
+        double* TWD, double* TWS, double* TWA);
+    static bool calcTrueWind(const double* awaVal, const double* awsVal,
         const double* cogVal, const double* stwVal, const double* sogVal, const double* hdtVal,
-        const double* hdmVal, const double* varVal, double* twdVal, double* twsVal, double* twaVal, double* awdVal);
-    bool addWinds();
+        const double* hdmVal, const double* varVal, double* twdVal, double* twsVal, double* twaVal);
 };

lib/obp60task/OBPRingBuffer.h

@@ -1,98 +1,60 @@
 #pragma once
-#include "FreeRTOS.h"
 #include "GwSynchronized.h"
+#include <algorithm>
+#include <limits>
+#include <stdexcept>
 #include <vector>
-#include <WString.h>
-
-template <typename T>
-struct PSRAMAllocator {
-    using value_type = T;
-
-    PSRAMAllocator() = default;
-
-    template <class U>
-    constexpr PSRAMAllocator(const PSRAMAllocator<U>&) noexcept { }
-
-    T* allocate(std::size_t n)
-    {
-        void* ptr = heap_caps_malloc(n * sizeof(T), MALLOC_CAP_SPIRAM);
-        if (!ptr) {
-            return nullptr;
-        } else {
-            return static_cast<T*>(ptr);
-        }
-    }
-
-    void deallocate(T* p, std::size_t) noexcept
-    {
-        heap_caps_free(p);
-    }
-};
-
-template <class T, class U>
-bool operator==(const PSRAMAllocator<T>&, const PSRAMAllocator<U>&) { return true; }
-
-template <class T, class U>
-bool operator!=(const PSRAMAllocator<T>&, const PSRAMAllocator<U>&) { return false; }
+#include "WString.h"
 
 template <typename T>
 class RingBuffer {
 private:
-    std::vector<T, PSRAMAllocator<T>> buffer; // THE buffer vector, allocated in PSRAM
+    mutable SemaphoreHandle_t bufLocker;
+    std::vector<T> buffer;
     size_t capacity;
     size_t head; // Points to the next insertion position
     size_t first; // Points to the first (oldest) valid element
     size_t last; // Points to the last (newest) valid element
     size_t count; // Number of valid elements currently in buffer
     bool is_Full; // Indicates that all buffer elements are used and ringing is in use
-    T MIN_VAL; // lowest possible value of buffer of type <T>
-    T MAX_VAL; // highest possible value of buffer of type <T> -> indicates invalid value in buffer
-    double dblMIN_VAL, dblMAX_VAL; // MIN_VAL, MAX_VAL in double format
-    mutable SemaphoreHandle_t bufLocker;
+    T MIN_VAL; // lowest possible value of buffer
+    T MAX_VAL; // highest possible value of buffer of type <T>
 
     // metadata for buffer
     String dataName; // Name of boat data in buffer
     String dataFmt; // Format of boat data in buffer
     int updFreq; // Update frequency in milliseconds
-    double mltplr; // Multiplier which transforms original <double> value into buffer type format
-    double smallest; // Value range of buffer: smallest value; needs to be => MIN_VAL
-    double largest; // Value range of buffer: biggest value; needs to be < MAX_VAL, since MAX_VAL indicates invalid entries
-
-    void initCommon();
+    T smallest; // Value range of buffer: smallest value
+    T largest; // Value range of buffer: biggest value
 
 public:
-    RingBuffer();
     RingBuffer(size_t size);
-    void setMetaData(String name, String format, int updateFrequency, double multiplier, double minValue, double maxValue); // Set meta data for buffer
-    bool getMetaData(String& name, String& format, int& updateFrequency, double& multiplier, double& minValue, double& maxValue); // Get meta data of buffer
-    bool getMetaData(String& name, String& format);
+    void setMetaData(String name, String format, int updateFrequency, T minValue, T maxValue); // Set meta data for buffer
+    bool getMetaData(String& name, String& format, int& updateFrequency, T& minValue, T& maxValue); // Get meta data of buffer
     String getName() const; // Get buffer name
-    String getFormat() const; // Get buffer data format
-    void add(const double& value); // Add a new value to  buffer
-    double get(size_t index) const; // Get value at specific position (0-based index from oldest to newest)
-    double getFirst() const; // Get the first (oldest) value in buffer
-    double getLast() const; // Get the last (newest) value in buffer
-    double getMin() const; // Get the lowest value in buffer
-    double getMin(size_t amount) const; // Get minimum value of the last <amount> values of buffer
-    double getMax() const; // Get the highest value in buffer
-    double getMax(size_t amount) const; // Get maximum value of the last <amount> values of buffer
-    double getMid() const; // Get mid value between <min> and <max> value in buffer
-    double getMid(size_t amount) const; // Get mid value between <min> and <max> value of the last <amount> values of buffer
-    double getMedian() const; // Get the median value in buffer
-    double getMedian(size_t amount) const; // Get the median value of the last <amount> values of buffer
+    void add(const T& value); // Add a new value to  buffer
+    T get(size_t index) const; // Get value at specific position (0-based index from oldest to newest)
+    T getFirst() const; // Get the first (oldest) value in buffer
+    T getLast() const; // Get the last (newest) value in buffer
+    T getMin() const; // Get the lowest value in buffer
+    T getMin(size_t amount) const; // Get minimum value of the last <amount> values of buffer
+    T getMax() const; // Get the highest value in buffer
+    T getMax(size_t amount) const; // Get maximum value of the last <amount> values of buffer
+    T getMid() const; // Get mid value between <min> and <max> value in buffer
+    T getMid(size_t amount) const; // Get mid value between <min> and <max> value of the last <amount> values of buffer
+    T getMedian() const; // Get the median value in buffer
+    T getMedian(size_t amount) const; // Get the median value of the last <amount> values of buffer
     size_t getCapacity() const; // Get the buffer capacity (maximum size)
     size_t getCurrentSize() const; // Get the current number of elements in buffer
     size_t getFirstIdx() const; // Get the index of oldest value in buffer
     size_t getLastIdx() const; // Get the index of newest value in buffer
     bool isEmpty() const; // Check if buffer is empty
     bool isFull() const; // Check if buffer is full
-    double getMinVal() const; // Get lowest possible value for buffer
-    double getMaxVal() const; // Get highest possible value for buffer; used for unset/invalid buffer data
+    T getMinVal() const; // Get lowest possible value for buffer; used for initialized buffer data
+    T getMaxVal() const; // Get highest possible value for buffer
     void clear(); // Clear buffer
-    void resize(size_t size); // Delete buffer and set new size
-    double operator[](size_t index) const; // Operator[] for convenient access (same as get())
-    std::vector<double> getAllValues() const; // Get all current values in native buffer format as a vector
-    std::vector<double> getAllValues(size_t amount) const; // Get last <amount> values in native buffer format as a vector
+    T operator[](size_t index) const; // Operator[] for convenient access (same as get())
+    std::vector<T> getAllValues() const; // Get all current values as a vector
 };
 
 #include "OBPRingBuffer.tpp"

lib/obp60task/OBPRingBuffer.tpp

@@ -1,36 +1,4 @@
 #include "OBPRingBuffer.h"
-#include <algorithm>
-#include <limits>
-#include <cmath>
-
-template <typename T>
-void RingBuffer<T>::initCommon()
-{
-    MIN_VAL = std::numeric_limits<T>::lowest();
-    MAX_VAL = std::numeric_limits<T>::max();
-    dblMIN_VAL = static_cast<double>(MIN_VAL);
-    dblMAX_VAL = static_cast<double>(MAX_VAL);
-    dataName = "";
-    dataFmt = "";
-    updFreq = -1;
-    mltplr = 1;
-    smallest = dblMIN_VAL;
-    largest = dblMAX_VAL;
-    bufLocker = xSemaphoreCreateMutex();
-}
-
-template <typename T>
-RingBuffer<T>::RingBuffer()
-    : capacity(0)
-    , head(0)
-    , first(0)
-    , last(0)
-    , count(0)
-    , is_Full(false)
-{
-    initCommon();
-    // <buffer> stays empty
-}
 
 template <typename T>
 RingBuffer<T>::RingBuffer(size_t size)
@@ -41,28 +9,40 @@ RingBuffer<T>::RingBuffer(size_t size)
     , count(0)
     , is_Full(false)
 {
-    initCommon();
+    bufLocker = xSemaphoreCreateMutex();
 
-    buffer.reserve(size);
-    buffer.resize(size, MAX_VAL); // MAX_VAL indicate invalid values
+    if (size == 0) {
+        // return false;
+    }
+
+    MIN_VAL = std::numeric_limits<T>::lowest();
+    MAX_VAL = std::numeric_limits<T>::max();
+    dataName = "";
+    dataFmt = "";
+    updFreq = -1;
+    smallest = MIN_VAL;
+    largest = MAX_VAL;
+
+    buffer.resize(size, MIN_VAL);
+
+    // return true;
 }
 
 // Specify meta data of buffer content
 template <typename T>
-void RingBuffer<T>::setMetaData(String name, String format, int updateFrequency, double multiplier, double minValue, double maxValue)
+void RingBuffer<T>::setMetaData(String name, String format, int updateFrequency, T minValue, T maxValue)
 {
     GWSYNCHRONIZED(&bufLocker);
     dataName = name;
     dataFmt = format;
     updFreq = updateFrequency;
-    mltplr = multiplier;
-    smallest = std::max(dblMIN_VAL, minValue);
-    largest = std::min(dblMAX_VAL, maxValue);
+    smallest = std::max(MIN_VAL, minValue);
+    largest = std::min(MAX_VAL, maxValue);
 }
 
 // Get meta data of buffer content
 template <typename T>
-bool RingBuffer<T>::getMetaData(String& name, String& format, int& updateFrequency, double& multiplier, double& minValue, double& maxValue)
+bool RingBuffer<T>::getMetaData(String& name, String& format, int& updateFrequency, T& minValue, T& maxValue)
 {
     if (dataName == "" || dataFmt == "" || updFreq == -1) {
         return false; // Meta data not set
@@ -72,26 +52,11 @@ bool RingBuffer<T>::getMetaData(String& name, String& format, int& updateFrequen
     name = dataName;
     format = dataFmt;
     updateFrequency = updFreq;
-    multiplier = mltplr;
     minValue = smallest;
     maxValue = largest;
     return true;
 }
 
-// Get meta data of buffer content
-template <typename T>
-bool RingBuffer<T>::getMetaData(String& name, String& format)
-{
-    if (dataName == "" || dataFmt == "") {
-        return false; // Meta data not set
-    }
-
-    GWSYNCHRONIZED(&bufLocker);
-    name = dataName;
-    format = dataFmt;
-    return true;
-}
-
 // Get buffer name
 template <typename T>
 String RingBuffer<T>::getName() const
@@ -99,22 +64,15 @@ String RingBuffer<T>::getName() const
     return dataName;
 }
 
-// Get buffer data format
-template <typename T>
-String RingBuffer<T>::getFormat() const
-{
-    return dataFmt;
-}
-
 // Add a new value to buffer
 template <typename T>
-void RingBuffer<T>::add(const double& value)
+void RingBuffer<T>::add(const T& value)
 {
     GWSYNCHRONIZED(&bufLocker);
     if (value < smallest || value > largest) {
-        buffer[head] = MAX_VAL; // Store MAX_VAL if value is out of range
+        buffer[head] = MIN_VAL; // Store MIN_VAL if value is out of range
     } else {
-        buffer[head] = static_cast<T>(std::round(value * mltplr));
+        buffer[head] = value;
     }
     last = head;
 
@@ -126,63 +84,63 @@ void RingBuffer<T>::add(const double& value)
             is_Full = true;
         }
     }
-    // Serial.printf("Ringbuffer: value %.3f, multiplier: %.1f, buffer: %d\n", value, mltplr, buffer[head]);
+
     head = (head + 1) % capacity;
 }
 
 // Get value at specific position (0-based index from oldest to newest)
 template <typename T>
-double RingBuffer<T>::get(size_t index) const
+T RingBuffer<T>::get(size_t index) const
 {
     GWSYNCHRONIZED(&bufLocker);
     if (isEmpty() || index < 0 || index >= count) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
 
     size_t realIndex = (first + index) % capacity;
-    return static_cast<double>(buffer[realIndex] / mltplr);
+    return buffer[realIndex];
 }
 
 // Operator[] for convenient access (same as get())
 template <typename T>
-double RingBuffer<T>::operator[](size_t index) const
+T RingBuffer<T>::operator[](size_t index) const
 {
     return get(index);
 }
 
 // Get the first (oldest) value in the buffer
 template <typename T>
-double RingBuffer<T>::getFirst() const
+T RingBuffer<T>::getFirst() const
 {
     if (isEmpty()) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
     return get(0);
 }
 
 // Get the last (newest) value in the buffer
 template <typename T>
-double RingBuffer<T>::getLast() const
+T RingBuffer<T>::getLast() const
 {
     if (isEmpty()) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
     return get(count - 1);
 }
 
 // Get the lowest value in the buffer
 template <typename T>
-double RingBuffer<T>::getMin() const
+T RingBuffer<T>::getMin() const
 {
     if (isEmpty()) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
 
-    double minVal = dblMAX_VAL;
-    double value;
+    T minVal = MAX_VAL;
+    T value;
     for (size_t i = 0; i < count; i++) {
         value = get(i);
-        if (value < minVal && value != dblMAX_VAL) {
+        if (value < minVal && value != MIN_VAL) {
             minVal = value;
         }
     }
@@ -191,19 +149,19 @@ double RingBuffer<T>::getMin() const
 
 // Get minimum value of the last <amount> values of buffer
 template <typename T>
-double RingBuffer<T>::getMin(size_t amount) const
+T RingBuffer<T>::getMin(size_t amount) const
 {
     if (isEmpty() || amount <= 0) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
     if (amount > count)
         amount = count;
 
-    double minVal = dblMAX_VAL;
-    double value;
+    T minVal = MAX_VAL;
+    T value;
     for (size_t i = 0; i < amount; i++) {
         value = get(count - 1 - i);
-        if (value < minVal && value != dblMAX_VAL) {
+        if (value < minVal && value != MIN_VAL) {
             minVal = value;
         }
     }
@@ -212,81 +170,75 @@ double RingBuffer<T>::getMin(size_t amount) const
 
 // Get the highest value in the buffer
 template <typename T>
-double RingBuffer<T>::getMax() const
+T RingBuffer<T>::getMax() const
 {
     if (isEmpty()) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
 
-    double maxVal = dblMIN_VAL;
-    double value;
+    T maxVal = MIN_VAL;
+    T value;
     for (size_t i = 0; i < count; i++) {
         value = get(i);
-        if (value > maxVal && value != dblMAX_VAL) {
+        if (value > maxVal && value != MIN_VAL) {
             maxVal = value;
         }
     }
-    if (maxVal == dblMIN_VAL) { // no change of initial value -> buffer has only invalid values (MAX_VAL)
-        maxVal = dblMAX_VAL;
-    }
     return maxVal;
 }
 
 // Get maximum value of the last <amount> values of buffer
 template <typename T>
-double RingBuffer<T>::getMax(size_t amount) const
+T RingBuffer<T>::getMax(size_t amount) const
 {
     if (isEmpty() || amount <= 0) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
     if (amount > count)
         amount = count;
 
-    double maxVal = dblMIN_VAL;
-    double value;
+    T maxVal = MIN_VAL;
+    T value;
     for (size_t i = 0; i < amount; i++) {
         value = get(count - 1 - i);
-        if (value > maxVal && value != dblMAX_VAL) {
+        if (value > maxVal && value != MIN_VAL) {
             maxVal = value;
         }
     }
-    if (maxVal == dblMIN_VAL) { // no change of initial value -> buffer has only invalid values (MAX_VAL)
-        maxVal = dblMAX_VAL;
-    }
     return maxVal;
 }
 
 // Get mid value between <min> and <max> value in the buffer
 template <typename T>
-double RingBuffer<T>::getMid() const
+T RingBuffer<T>::getMid() const
 {
     if (isEmpty()) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
 
-    return (getMin() + getMax()) / 2;
+    return (getMin() + getMax()) / static_cast<T>(2);
 }
 
 // Get mid value between <min> and <max> value of the last <amount> values of buffer
 template <typename T>
-double RingBuffer<T>::getMid(size_t amount) const
+T RingBuffer<T>::getMid(size_t amount) const
 {
     if (isEmpty() || amount <= 0) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
 
     if (amount > count)
         amount = count;
 
-    return (getMin(amount) + getMax(amount)) / 2;
+    return (getMin(amount) + getMax(amount)) / static_cast<T>(2);
 }
 
 // Get the median value in the buffer
 template <typename T>
-double RingBuffer<T>::getMedian() const
+T RingBuffer<T>::getMedian() const
 {
     if (isEmpty()) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
 
     // Create a temporary vector with current valid elements
@@ -302,20 +254,20 @@ double RingBuffer<T>::getMedian() const
 
     if (count % 2 == 1) {
         // Odd number of elements
-        return static_cast<double>(temp[count / 2]);
+        return temp[count / 2];
     } else {
         // Even number of elements - return average of middle two
         // Note: For integer types, this truncates. For floating point, it's exact.
-        return static_cast<double>((temp[count / 2 - 1] + temp[count / 2]) / 2);
+        return (temp[count / 2 - 1] + temp[count / 2]) / 2;
     }
 }
 
 // Get the median value of the last <amount> values of buffer
 template <typename T>
-double RingBuffer<T>::getMedian(size_t amount) const
+T RingBuffer<T>::getMedian(size_t amount) const
 {
     if (isEmpty() || amount <= 0) {
-        return dblMAX_VAL;
+        return MIN_VAL;
     }
     if (amount > count)
         amount = count;
@@ -325,7 +277,7 @@ double RingBuffer<T>::getMedian(size_t amount) const
     temp.reserve(amount);
 
     for (size_t i = 0; i < amount; i++) {
-        temp.push_back(get(count - 1 - i));
+        temp.push_back(get(i));
     }
 
     // Sort to find median
@@ -333,11 +285,11 @@ double RingBuffer<T>::getMedian(size_t amount) const
 
     if (amount % 2 == 1) {
         // Odd number of elements
-        return static_cast<double>(temp[amount / 2]);
+        return temp[amount / 2];
     } else {
         // Even number of elements - return average of middle two
         // Note: For integer types, this truncates. For floating point, it's exact.
-        return static_cast<double>((temp[amount / 2 - 1] + temp[amount / 2]) / 2);
+        return (temp[amount / 2 - 1] + temp[amount / 2]) / 2;
     }
 }
 
@@ -383,18 +335,18 @@ bool RingBuffer<T>::isFull() const
     return is_Full;
 }
 
-// Get lowest possible value for buffer
+// Get lowest possible value for buffer; used for non-set buffer data
 template <typename T>
-double RingBuffer<T>::getMinVal() const
+T RingBuffer<T>::getMinVal() const
 {
-    return dblMIN_VAL;
+    return MIN_VAL;
 }
 
-// Get highest possible value for buffer; used for unset/invalid buffer data
+// Get highest possible value for buffer
 template <typename T>
-double RingBuffer<T>::getMaxVal() const
+T RingBuffer<T>::getMaxVal() const
 {
-    return dblMAX_VAL;
+    return MAX_VAL;
 }
 
 // Clear buffer
@@ -409,28 +361,11 @@ void RingBuffer<T>::clear()
     is_Full = false;
 }
 
-// Delete buffer and set new size
+// Get all current values as a vector
 template <typename T>
-void RingBuffer<T>::resize(size_t newSize)
+std::vector<T> RingBuffer<T>::getAllValues() const
 {
-    GWSYNCHRONIZED(&bufLocker);
-    capacity = newSize;
-    head = 0;
-    first = 0;
-    last = 0;
-    count = 0;
-    is_Full = false;
-
-    buffer.clear();
-    buffer.reserve(newSize);
-    buffer.resize(newSize, MAX_VAL);
-}
-
-// Get all current values in native buffer format as a vector
-template <typename T>
-std::vector<double> RingBuffer<T>::getAllValues() const
-{
-    std::vector<double> result;
+    std::vector<T> result;
     result.reserve(count);
 
     for (size_t i = 0; i < count; i++) {
@@ -439,24 +374,3 @@ std::vector<double> RingBuffer<T>::getAllValues() const
 
     return result;
 }
-
-// Get last <amount> values in native buffer format as a vector
-template <typename T>
-std::vector<double> RingBuffer<T>::getAllValues(size_t amount) const
-{
-    std::vector<double> result;
-
-    if (isEmpty() || amount <= 0) {
-        return result;
-    }
-    if (amount > count)
-        amount = count;
-
-    result.reserve(amount);
-
-    for (size_t i = 0; i < amount; i++) {
-        result.push_back(get(count - 1 - i));
-    }
-
-    return result;
-}

lib/obp60task/OBPSensorTask.cpp

@@ -49,10 +49,8 @@ void sensorTask(void *param){
 
     // Init sensor stuff
     bool oneWire_ready = false;     // 1Wire initialized and ready to use
-    bool iRTC_ready = false;        // Software RTC initialized and ready to use
     bool RTC_ready = false;         // DS1388 initialized and ready to use
     bool GPS_ready = false;         // GPS initialized and ready to use
-    bool N2K_GPS_ready = false;     // GPS time on N2K bus
     bool BME280_ready = false;      // BME280 initialized and ready to use
     bool BMP280_ready = false;      // BMP280 initialized and ready to use
     bool BMP180_ready = false;      // BMP180 initialized and ready to use
@@ -384,7 +382,6 @@ void sensorTask(void *param){
             if (getLocalTime(&timeinfo)) {
                 api->getLogger()->logDebug(GwLog::LOG,"NTP time: %04d-%02d-%02d %02d:%02d:%02d UTC", timeinfo.tm_year+1900, timeinfo.tm_mon+1, timeinfo.tm_mday, timeinfo.tm_hour, timeinfo.tm_min, timeinfo.tm_sec);
                 rtc.setTimeStruct(timeinfo);
-                iRTC_ready = true;
                 sensors.rtcValid = true;
             } else {
                 api->getLogger()->logDebug(GwLog::LOG,"NTP time fetch failed!");
@@ -403,7 +400,7 @@ void sensorTask(void *param){
         if (millis() > starttime0 + 100)
         {
             starttime0 = millis();
-            // Send NMEA0183 GPS data on several bus systems (N2K an 0183) all 100ms
+            // Send NMEA0183 GPS data on several bus systems all 100ms
             if (GPS_ready == true && hdop->value <= hdopAccuracy)
             {
                 SNMEA0183Msg NMEA0183Msg;
@@ -415,55 +412,9 @@ void sensorTask(void *param){
             
         }
 
-        /*
-        Time set logic for RTC and N2K
-        ###############################
-
-        iRTC = Software RTC updatetd with NTP via internet
-        RTC = RTC chip on PCB
-        GPS = GPS Receiver on PCB
-        N2K = GPS time on N2K od 183 bus
-        0 = device not ready
-        1 = device ready
-        X = independend
-        () = source for set time N2K
-        -> = set RTC via iRTC
-        <- = set RTC via GPS
-
-        iRTC  RTC  GPS N2K
-          0    0    0  (1)
-          0    0   (1) (X)
-          0   (1)   0  (X)
-          0    1 <-(1) (X)
-         (1)   0    0  (X)
-          1    0   (1) (X)
-          1 ->(1)   0  (X)
-          1    1 <-(1) (X)
-
-        */
-
-        // If RTC DS1388 ready, then copy iRTC and GPS data to RTC all 1min
-        if(millis() > starttime11 + 1*60*1000){
+        // If RTC DS1388 ready, then copy GPS data to RTC all 5min
+        if(millis() > starttime11 + 5*60*1000){
             starttime11 = millis();
-            // Set RTC chip via iRTC (NTP)
-            if(iRTC_ready == true && RTC_ready == true && GPS_ready == false){
-                GwApi::Status status;
-                api->getStatus(status);
-                // Check WiFi connection
-                if (status.wifiClientConnected) {
-                    sensors.rtcTime = rtc.getTimeStruct();  // Get time from software RTC (iRTC)      
-                    DateTime now = DateTime(
-                        sensors.rtcTime.tm_year + 1900,
-                        sensors.rtcTime.tm_mon + 1,
-                        sensors.rtcTime.tm_mday,
-                        sensors.rtcTime.tm_hour,
-                        sensors.rtcTime.tm_min,
-                        sensors.rtcTime.tm_sec
-                    );   
-                    ds1388.adjust(now);
-                }    
-            }
-            // Set RTC chip via internal GPS
             if(rtcOn == "DS1388" && RTC_ready == true && GPS_ready == true){
                 api->getBoatDataValues(3,valueList);
                 if(gpsdays->valid && gpsseconds->valid && hdop->valid){
@@ -471,33 +422,40 @@ void sensorTask(void *param){
                     // sample input: date = "Dec 26 2009", time = "12:34:56"
                     // ds1388.adjust(DateTime("Dec 26 2009", "12:34:56"));
                     DateTime adjusttime(ts);
-                    api->getLogger()->logDebug(GwLog::LOG,"Adjust RTC time via internal GPS: %04d/%02d/%02d %02d:%02d:%02d",adjusttime.year(), adjusttime.month(), adjusttime.day(), adjusttime.hour(), adjusttime.minute(), adjusttime.second());
+                    api->getLogger()->logDebug(GwLog::LOG,"Adjust RTC time: %04d/%02d/%02d %02d:%02d:%02d",adjusttime.year(), adjusttime.month(), adjusttime.day(), adjusttime.hour(), adjusttime.minute(), adjusttime.second());
                     // Adjust RTC time as unix time value
                     ds1388.adjust(adjusttime);
                 }
             }
         }
 
-        // Set RTC chip via N2K or 183 in case the internal GPS is off (only one time)
-        if(N2K_GPS_ready == false && RTC_ready == true && GPS_ready == false){
-            api->getBoatDataValues(3,valueList);
-            if(gpsdays->valid && gpsseconds->valid && hdop->valid){
-                long ts = tNMEA0183Msg::daysToTime_t(gpsdays->value - (30*365+7))+floor(gpsseconds->value); // Adjusted to reference year 2000 (-30 years and 7 days for switch years)
-                // sample input: date = "Dec 26 2009", time = "12:34:56"
-                // ds1388.adjust(DateTime("Dec 26 2009", "12:34:56"));
-                DateTime adjusttime(ts);
-                api->getLogger()->logDebug(GwLog::LOG,"Adjust RTC time via N2K/183: %04d/%02d/%02d %02d:%02d:%02d",adjusttime.year(), adjusttime.month(), adjusttime.day(), adjusttime.hour(), adjusttime.minute(), adjusttime.second());
-                // Adjust RTC time as unix time value
-                ds1388.adjust(adjusttime);
-                // N2K GPS time ready
-                N2K_GPS_ready = true;
+        // Send 1Wire data for all temperature sensors all 2s
+        if(millis() > starttime13 + 2000 && String(oneWireOn) == "DS18B20" && oneWire_ready == true){
+            starttime13 = millis();
+            float tempC;
+            ds18b20.requestTemperatures();  // Collect all temperature values (max.8)
+            for(int i=0;i<numberOfDevices; i++){
+                // Send only one 1Wire data per loop step (time reduction)
+                if(i == loopCounter % numberOfDevices){
+                    if(ds18b20.getAddress(tempDeviceAddress, i)){
+                        // Read temperature value in Celsius
+                        tempC = ds18b20.getTempC(tempDeviceAddress); 
                     }
+                    // Send to NMEA200 bus for each sensor with instance number
+                    if(!isnan(tempC)){
+                        sensors.onewireTemp[i] = tempC; // Save values in SensorData
+                        api->getLogger()->logDebug(GwLog::DEBUG,"DS18B20-%1d Temp: %.1f",i,tempC);
+                        SetN2kPGN130316(N2kMsg, 0, i, N2kts_OutsideTemperature, CToKelvin(tempC), N2kDoubleNA);
+                        api->sendN2kMessage(N2kMsg);
+                    }
+                }    
+            }
+            loopCounter++;
         }
 
-        // Send RTC date and time to N2K all 500ms
+        // Get current RTC date and time all 500ms
         if (millis() > starttime12 + 500) {
             starttime12 = millis();
-            // Send date and time from RTC chip if GPS not ready
             if (rtcOn == "DS1388" && RTC_ready) {
                 DateTime dt = ds1388.now();
                 sensors.rtcTime.tm_year  = dt.year() - 1900; // Save values in SensorData
@@ -523,62 +481,21 @@ void sensorTask(void *param){
                     }
                     // N2K sysTime is double in n2klib
                     double sysTime = (dt.hour() * 3600) + (dt.minute() * 60) + dt.second();
-                    if(!isnan(daysAt1970) && !isnan(sysTime)){
-                        //api->getLogger()->logDebug(GwLog::LOG,"RTC time: %04d/%02d/%02d %02d:%02d:%02d",sensors.rtcTime.tm_year+1900,sensors.rtcTime.tm_mon, sensors.rtcTime.tm_mday, sensors.rtcTime.tm_hour, sensors.rtcTime.tm_min, sensors.rtcTime.tm_sec);
-                        //api->getLogger()->logDebug(GwLog::LOG,"Send PGN126992: %10d %10d",daysAt1970, (uint16_t)sysTime);
-                        SetN2kPGN126992(N2kMsg,0,daysAt1970,sysTime,N2ktimes_LocalCrystalClock);
-                        api->sendN2kMessage(N2kMsg);
-                    }
-                }
-            }
-            // Send date and time from software RTC (iRTC)
-            if (iRTC_ready == true && RTC_ready == false && GPS_ready == false) {
-                // Use internal RTC feature
-                sensors.rtcTime = rtc.getTimeStruct(); // Save software RTC values in SensorData
-                // TODO implement daysAt1970 and sysTime as methods of DateTime
-                const short daysOfYear[12] = {0,31,59,90,120,151,181,212,243,273,304,334};
-                uint16_t switchYear = ((sensors.rtcTime.tm_year-1)-1968)/4 - ((sensors.rtcTime.tm_year-1)-1900)/100 + ((sensors.rtcTime.tm_year-1)-1600)/400;
-                long daysAt1970 = (sensors.rtcTime.tm_year-1970)*365 + switchYear + daysOfYear[sensors.rtcTime.tm_mon-1] + sensors.rtcTime.tm_mday-1;
-                // If switch year then add one day
-                if ((sensors.rtcTime.tm_mon > 2) && (sensors.rtcTime.tm_year % 4 == 0  && (sensors.rtcTime.tm_year % 100 != 0 || sensors.rtcTime.tm_year % 400 == 0))) {
-                    daysAt1970 += 1;
-                }
-                // N2K sysTime is double in n2klib
-                double sysTime = (sensors.rtcTime.tm_hour * 3600) + (sensors.rtcTime.tm_min * 60) + sensors.rtcTime.tm_sec;
-                if(!isnan(daysAt1970) && !isnan(sysTime)){
+                    // WHY? isnan should always fail here
+                    //if(!isnan(daysAt1970) && !isnan(sysTime)){
                         //api->getLogger()->logDebug(GwLog::LOG,"RTC time: %04d/%02d/%02d %02d:%02d:%02d",sensors.rtcTime.tm_year+1900,sensors.rtcTime.tm_mon, sensors.rtcTime.tm_mday, sensors.rtcTime.tm_hour, sensors.rtcTime.tm_min, sensors.rtcTime.tm_sec);
                         //api->getLogger()->logDebug(GwLog::LOG,"Send PGN126992: %10d %10d",daysAt1970, (uint16_t)sysTime);
                         SetN2kPGN126992(N2kMsg,0,daysAt1970,sysTime,N2ktimes_LocalCrystalClock);
                         api->sendN2kMessage(N2kMsg);
+                    // }
                 }
+            } else if (sensors.rtcValid) {
+                // use internal rtc feature
+                sensors.rtcTime = rtc.getTimeStruct();
             }
         }
 
-        // Send 1Wire data for all temperature sensors to N2K all 2s
-        if(millis() > starttime13 + 2000 && String(oneWireOn) == "DS18B20" && oneWire_ready == true){
-            starttime13 = millis();
-            float tempC;
-            ds18b20.requestTemperatures();  // Collect all temperature values (max.8)
-            for(int i=0;i<numberOfDevices; i++){
-                // Send only one 1Wire data per loop step (time reduction)
-                if(i == loopCounter % numberOfDevices){
-                    if(ds18b20.getAddress(tempDeviceAddress, i)){
-                        // Read temperature value in Celsius
-                        tempC = ds18b20.getTempC(tempDeviceAddress); 
-                    }
-                    // Send to NMEA200 bus for each sensor with instance number
-                    if(!isnan(tempC)){
-                        sensors.onewireTemp[i] = tempC; // Save values in SensorData
-                        api->getLogger()->logDebug(GwLog::DEBUG,"DS18B20-%1d Temp: %.1f",i,tempC);
-                        SetN2kPGN130316(N2kMsg, 0, i, N2kts_OutsideTemperature, CToKelvin(tempC), N2kDoubleNA);
-                        api->sendN2kMessage(N2kMsg);
-                    }
-                }    
-            }
-            loopCounter++;
-        }
-
-        // Send supply voltage value to N2K all 1s
+        // Send supply voltage value all 1s
         if(millis() > starttime5 + 1000 && String(powsensor1) == "off"){
             starttime5 = millis();
             float rawVoltage = 0;       // Default value
@@ -648,7 +565,7 @@ void sensorTask(void *param){
             #endif
         }
 
-        // Send data from environment sensor to N2K all 2s
+        // Send data from environment sensor all 2s
         if(millis() > starttime6 + 2000){
             starttime6 = millis();
             unsigned char TempSource = 2;       // Inside temperature
@@ -713,7 +630,7 @@ void sensorTask(void *param){
             }                
         }
 
-        // Send rotation angle to N2K all 500ms
+        // Send rotation angle all 500ms
         if(millis() > starttime7 + 500){
             starttime7 = millis();
             double rotationAngle=0;
@@ -761,7 +678,7 @@ void sensorTask(void *param){
             }    
         }
 
-        // Send battery power value to N2K all 1s
+        // Send battery power value all 1s
         if(millis() > starttime8 + 1000 && (String(powsensor1) == "INA219" || String(powsensor1) == "INA226")){
             starttime8 = millis();
             if(String(powsensor1) == "INA226" && INA226_1_ready == true){
@@ -803,7 +720,7 @@ void sensorTask(void *param){
             }
         }
 
-        // Send solar power value to N2K all 1s
+        // Send solar power value all 1s
         if(millis() > starttime9 + 1000 && (String(powsensor2) == "INA219" || String(powsensor2) == "INA226")){
             starttime9 = millis();
             if(String(powsensor2) == "INA226" && INA226_2_ready == true){
@@ -833,7 +750,7 @@ void sensorTask(void *param){
             }
         }
 
-        // Send generator power value to N2K all 1s
+        // Send generator power value all 1s
         if(millis() > starttime10 + 1000 && (String(powsensor3) == "INA219" || String(powsensor3) == "INA226")){
             starttime10 = millis();
             if(String(powsensor3) == "INA226" && INA226_3_ready == true){

lib/obp60task/OBPcharts.cpp

@@ -1,805 +0,0 @@
-// Function lib for display of boat data in various chart formats
-#include "OBPcharts.h"
-#include "OBPDataOperations.h"
-#include "OBPRingBuffer.h"
-
-std::map<String, ChartProps> Chart::dfltChrtDta = {
-    { "formatWind", { 60.0 * DEG_TO_RAD, 10.0 * DEG_TO_RAD } }, // default course range 60 degrees
-    { "formatCourse", { 60.0 * DEG_TO_RAD, 10.0 * DEG_TO_RAD } }, // default course range 60 degrees
-    { "formatKnots", { 7.71, 2.56 } }, // default speed range in m/s
-    { "formatDepth", { 15.0, 5.0 } }, // default depth range in m
-    { "kelvinToC", { 30.0, 5.0 } } // default temp range in °C/K
-};
-
-// --- Class Chart ---------------
-
-// Chart - object holding the actual chart, incl. data buffer and format definition
-// Parameters: <dataBuf> the history data buffer for the chart
-//             <dfltRng> default range of chart, e.g. 30 = [0..30]
-//             <common> common program data; required for logger and color data
-//             <useSimuData> flag to indicate if simulation data is active
-Chart::Chart(RingBuffer<uint16_t>& dataBuf, double dfltRng, CommonData& common, bool useSimuData)
-    : dataBuf(dataBuf)
-    , dfltRng(dfltRng)
-    , commonData(&common)
-    , useSimuData(useSimuData)
-{
-    logger = commonData->logger;
-    fgColor = commonData->fgcolor;
-    bgColor = commonData->bgcolor;
-
-    dWidth = getdisplay().width();
-    dHeight = getdisplay().height();
-
-    dataBuf.getMetaData(dbName, dbFormat);
-    dbMIN_VAL = dataBuf.getMinVal();
-    dbMAX_VAL = dataBuf.getMaxVal();
-    bufSize = dataBuf.getCapacity();
-
-    // Initialize chart data format; shorter version of standard format indicator
-    if (dbFormat == "formatCourse" || dbFormat == "formatWind" || dbFormat == "formatRot") {
-        chrtDataFmt = WIND; // Chart is showing data of course / wind <degree> format
-    } else if (dbFormat == "formatRot") {
-        chrtDataFmt = ROTATION; // Chart is showing data of rotational <degree> format
-    } else if (dbFormat == "formatKnots") {
-        chrtDataFmt = SPEED; // Chart is showing data of speed or windspeed format
-    } else if (dbFormat == "formatDepth") {
-        chrtDataFmt = DEPTH; // Chart ist showing data of <depth> format
-    } else if (dbFormat == "kelvinToC") {
-        chrtDataFmt = TEMPERATURE; // Chart ist showing data of <temp> format
-    } else {
-        chrtDataFmt = OTHER; // Chart is showing any other data format
-    }
-
-    // "0" value is the same for any data format but for user defined temperature format
-    zeroValue = 0.0;
-    if (chrtDataFmt == TEMPERATURE) {
-        tempFormat = commonData->config->getString(commonData->config->tempFormat); // [K|°C|°F]
-        if (tempFormat == "K") {
-            zeroValue = 0.0;
-        } else if (tempFormat == "C") {
-            zeroValue = 273.15;
-        } else if (tempFormat == "F") {
-            zeroValue = 255.37;
-        }
-    }
-
-    // Read default range and range step for this chart type
-    if (dfltChrtDta.count(dbFormat)) {
-        dfltRng = dfltChrtDta[dbFormat].range;
-        rngStep = dfltChrtDta[dbFormat].step;
-    } else {
-        dfltRng = 15.0;
-        rngStep = 5.0;
-    }
-
-    // Initialize chart range values
-    chrtMin = zeroValue;
-    chrtMax = chrtMin + dfltRng;
-    chrtMid = (chrtMin + chrtMax) / 2;
-    chrtRng = dfltRng;
-    recalcRngMid = true; // initialize <chrtMid> and chart borders on first screen call
-
-    LOG_DEBUG(GwLog::DEBUG, "Chart Init: dWidth: %d, dHeight: %d, timAxis: %d, valAxis: %d, cRoot {x,y}: %d, %d, dbname: %s, rngStep: %.4f, chrtDataFmt: %d",
-        dWidth, dHeight, timAxis, valAxis, cRoot.x, cRoot.y, dbName, rngStep, chrtDataFmt);
-};
-
-Chart::~Chart()
-{
-}
-
-// Perform all actions to draw chart
-// Parameters: <chrtDir>:       chart timeline direction: 'H' = horizontal, 'V' = vertical
-//             <chrtSz>:        chart size: [0] = full size, [1] = half size left/top, [2] half size right/bottom
-//             <chrtIntv>:      chart timeline interval
-//             <prntName>;      print data name on horizontal half chart [true|false]
-//             <showCurrValue>: print current boat data value [true|false]
-//             <currValue>:     current boat data value; used only for test on valid data
-void Chart::showChrt(char chrtDir, int8_t chrtSz, const int8_t chrtIntv, bool prntName, bool showCurrValue, GwApi::BoatValue currValue)
-{
-    if (!setChartDimensions(chrtDir, chrtSz)) {
-        return; // wrong chart dimension parameters
-    }
-
-    drawChrt(chrtDir, chrtIntv, currValue);
-    drawChrtTimeAxis(chrtDir, chrtSz, chrtIntv);
-    drawChrtValAxis(chrtDir, chrtSz, prntName);
-
-    if (!bufDataValid) { // No valid data available
-        prntNoValidData(chrtDir);
-        return;
-    }
-
-    if (showCurrValue) { // show latest value from history buffer; this should be the most current one
-        currValue.value = dataBuf.getLast();
-        currValue.valid = currValue.value != dbMAX_VAL;
-        prntCurrValue(chrtDir, currValue);
-    }
-}
-
-// define dimensions and start points for chart
-bool Chart::setChartDimensions(const char direction, const int8_t size)
-{
-    if ((direction != HORIZONTAL && direction != VERTICAL) || (size < 0 || size > 2)) {
-        LOG_DEBUG(GwLog::ERROR, "obp60:setChartDimensions %s: wrong parameters", dataBuf.getName());
-        return false;
-    }
-
-    if (direction == HORIZONTAL) {
-        // horizontal chart timeline direction
-        timAxis = dWidth - 1;
-        switch (size) {
-        case 0:
-            valAxis = dHeight - top - bottom;
-            cRoot = { 0, top - 1 };
-            break;
-        case 1:
-            valAxis = (dHeight - top - bottom) / 2 - hGap;
-            cRoot = { 0, top - 1 };
-            break;
-        case 2:
-            valAxis = (dHeight - top - bottom) / 2 - hGap;
-            cRoot = { 0, top + (valAxis + hGap) + hGap - 1 };
-            break;
-        }
-
-    } else if (direction == VERTICAL) {
-        // vertical chart timeline direction
-        timAxis = dHeight - top - bottom;
-        switch (size) {
-        case 0:
-            valAxis = dWidth - 1;
-            cRoot = { 0, top - 1 };
-            break;
-        case 1:
-            valAxis = dWidth / 2 - vGap;
-            cRoot = { 0, top - 1 };
-            break;
-        case 2:
-            valAxis = dWidth / 2 - vGap;
-            cRoot = { dWidth / 2 + vGap - 1, top - 1 };
-            break;
-        }
-    }
-    LOG_DEBUG(GwLog::ERROR, "obp60:setChartDimensions %s: direction: %c, size: %d, dWidth: %d, dHeight: %d, timAxis: %d, valAxis: %d, cRoot{%d, %d}, top: %d, bottom: %d, hGap: %d, vGap: %d",
-        dataBuf.getName(), direction, size, dWidth, dHeight, timAxis, valAxis, cRoot.x, cRoot.y, top, bottom, hGap, vGap);
-    return true;
-}
-
-// draw chart
-void Chart::drawChrt(const char chrtDir, const int8_t chrtIntv, GwApi::BoatValue& currValue)
-{
-    double chrtScale; // Scale for data values in pixels per value
-
-    getBufferStartNSize(chrtIntv);
-
-    // LOG_DEBUG(GwLog::DEBUG, "Chart:drawChart: min: %.1f, mid: %.1f, max: %.1f, rng: %.1f", chrtMin, chrtMid, chrtMax, chrtRng);
-    calcChrtBorders(chrtMin, chrtMid, chrtMax, chrtRng);
-    chrtScale = double(valAxis) / chrtRng; // Chart scale: pixels per value step
-    LOG_DEBUG(GwLog::DEBUG, "Chart:drawChart: min: %.1f, mid: %.1f, max: %.1f, rng: %.1f", chrtMin, chrtMid, chrtMax, chrtRng);
-
-    // Do we have valid buffer data?
-    if (dataBuf.getMax() == dbMAX_VAL) { // only <MAX_VAL> values in buffer -> no valid wind data available
-        bufDataValid = false;
-        return;
-
-    } else if (currValue.valid || useSimuData) { // latest boat data valid or simulation mode
-        numNoData = 0; // reset data error counter
-        bufDataValid = true;
-
-    } else { // currently no valid data
-        numNoData++;
-        bufDataValid = true;
-
-        if (numNoData > THRESHOLD_NO_DATA) { // If more than 4 invalid values in a row, flag for invalid data
-            bufDataValid = false;
-            return;
-        }
-    }
-
-    drawChartLines(chrtDir, chrtIntv, chrtScale);
-}
-
-// Identify buffer size and buffer start position for chart
-void Chart::getBufferStartNSize(const int8_t chrtIntv)
-{
-    count = dataBuf.getCurrentSize();
-    currIdx = dataBuf.getLastIdx();
-    numAddedBufVals = (currIdx - lastAddedIdx + bufSize) % bufSize; // Number of values added to buffer since last display
-
-    if (chrtIntv != oldChrtIntv || count == 1) {
-        // new data interval selected by user; this is only x * 230 values instead of 240 seconds (4 minutes) per interval step
-        numBufVals = min(count, (timAxis - MIN_FREE_VALUES) * chrtIntv); // keep free or release MIN_FREE_VALUES on chart for plotting of new values
-        bufStart = max(0, count - numBufVals);
-        lastAddedIdx = currIdx;
-        oldChrtIntv = chrtIntv;
-
-    } else {
-        numBufVals = numBufVals + numAddedBufVals;
-        lastAddedIdx = currIdx;
-        if (count == bufSize) {
-            bufStart = max(0, bufStart - numAddedBufVals);
-        }
-    }
-}
-
-// check and adjust chart range and set range borders and range middle
-void Chart::calcChrtBorders(double& rngMin, double& rngMid, double& rngMax, double& rng)
-{
-    if (chrtDataFmt == WIND || chrtDataFmt == ROTATION) {
-
-        if (chrtDataFmt == ROTATION) {
-            // if chart data is of type 'rotation', we want to have <rndMid> always to be '0'
-            rngMid = 0;
-
-        } else { // WIND: Chart data is of type 'course' or 'wind'
-
-            // initialize <rngMid> if data buffer has just been started filling
-            if ((count == 1 && rngMid == 0) || rngMid == dbMAX_VAL) {
-                recalcRngMid = true;
-            }
-
-            if (recalcRngMid) {
-                // Set rngMid
-
-                rngMid = dataBuf.getMid(numBufVals);
-
-                if (rngMid == dbMAX_VAL) {
-                    rngMid = 0;
-                } else {
-                    rngMid = std::round(rngMid / rngStep) * rngStep; // Set new center value; round to next <rngStep> value
-
-                    // Check if range between  'min' and 'max' is > 180° or crosses '0'
-                    rngMin = dataBuf.getMin(numBufVals);
-                    rngMax = dataBuf.getMax(numBufVals);
-                    rng = (rngMax >= rngMin ? rngMax - rngMin : M_TWOPI - rngMin + rngMax);
-                    rng = std::max(rng, dfltRng); // keep at least default chart range
-
-                    if (rng > M_PI) { // If wind range > 180°, adjust wndCenter to smaller wind range end
-                        rngMid = WindUtils::to2PI(rngMid + M_PI);
-                    }
-                }
-                recalcRngMid = false; // Reset flag for <rngMid> determination
-
-                LOG_DEBUG(GwLog::DEBUG, "calcChrtRange: rngMin: %.1f°, rngMid: %.1f°, rngMax: %.1f°, rng: %.1f°, rngStep: %.1f°", rngMin * RAD_TO_DEG, rngMid * RAD_TO_DEG, rngMax * RAD_TO_DEG,
-                    rng * RAD_TO_DEG, rngStep * RAD_TO_DEG);
-            }
-        }
-
-        // check and adjust range between left, mid, and right chart limit
-        double halfRng = rng / 2.0; // we calculate with range between <rngMid> and edges
-        double tmpRng = getAngleRng(rngMid, numBufVals);
-        tmpRng = (tmpRng == dbMAX_VAL ? 0 : std::ceil(tmpRng / rngStep) * rngStep);
-
-        // LOG_DEBUG(GwLog::DEBUG, "calcChrtBorders: tmpRng: %.1f°, halfRng: %.1f°", tmpRng * RAD_TO_DEG, halfRng * RAD_TO_DEG);
-
-        if (tmpRng > halfRng) { // expand chart range to new value
-            halfRng = tmpRng;
-        }
-
-        else if (tmpRng + rngStep < halfRng) { // Contract chart range for higher resolution if possible
-            halfRng = std::max(dfltRng / 2.0, tmpRng);
-        }
-
-        rngMin = WindUtils::to2PI(rngMid - halfRng);
-        rngMax = (halfRng < M_PI ? rngMid + halfRng : rngMid + halfRng - (M_TWOPI / 360)); // if chart range is 360°, then make <rngMax> 1° smaller than <rngMin>
-        rngMax = WindUtils::to2PI(rngMax);
-
-        rng = halfRng * 2.0;
-
-        LOG_DEBUG(GwLog::DEBUG, "calcChrtBorders: rngMin: %.1f°, rngMid: %.1f°, rngMax: %.1f°, tmpRng: %.1f°, rng: %.1f°, rngStep: %.1f°", rngMin * RAD_TO_DEG, rngMid * RAD_TO_DEG, rngMax * RAD_TO_DEG,
-            tmpRng * RAD_TO_DEG, rng * RAD_TO_DEG, rngStep * RAD_TO_DEG);
-
-    } else { // chart data is of any other type
-
-        double currMinVal = dataBuf.getMin(numBufVals);
-        double currMaxVal = dataBuf.getMax(numBufVals);
-
-        if (currMinVal == dbMAX_VAL || currMaxVal == dbMAX_VAL) {
-            return; // no valid data
-        }
-
-        // check if current chart border have to be adjusted
-        if (currMinVal < rngMin || (currMinVal > (rngMin + rngStep))) { // decrease rngMin if required or increase if lowest value is higher than old rngMin
-            rngMin = std::floor(currMinVal / rngStep) * rngStep; // align low range to lowest buffer value and nearest range interval
-        }
-        if ((currMaxVal > rngMax) || (currMaxVal < (rngMax - rngStep))) { // increase rngMax if required or decrease if lowest value is lower than old rngMax
-            rngMax = std::ceil(currMaxVal / rngStep) * rngStep;
-        }
-
-        // Chart range starts at least at '0' if minimum data value allows it
-        if (rngMin > zeroValue && dbMIN_VAL <= zeroValue) {
-            rngMin = zeroValue;
-        }
-
-        // ensure minimum chart range in user format
-        if ((rngMax - rngMin) < dfltRng) {
-            rngMax = rngMin + dfltRng;
-        }
-
-        rngMid = (rngMin + rngMax) / 2.0;
-        rng = rngMax - rngMin;
-
-        LOG_DEBUG(GwLog::DEBUG, "calcChrtRange-end: currMinVal: %.1f, currMaxVal: %.1f, rngMin: %.1f, rngMid: %.1f, rngMax: %.1f, rng: %.1f, rngStep: %.1f, zeroValue: %.1f, dbMIN_VAL: %.1f",
-            currMinVal, currMaxVal, rngMin, rngMid, rngMax, rng, rngStep, zeroValue, dbMIN_VAL);
-    }
-}
-
-// Draw chart graph
-void Chart::drawChartLines(const char direction, const int8_t chrtIntv, const double chrtScale)
-{
-    double chrtVal; // Current data value
-    Pos point, prevPoint; // current and previous chart point
-
-    for (int i = 0; i < (numBufVals / chrtIntv); i++) {
-
-        chrtVal = dataBuf.get(bufStart + (i * chrtIntv)); // show the latest wind values in buffer; keep 1st value constant in a rolling buffer
-
-        if (chrtVal == dbMAX_VAL) {
-            chrtPrevVal = dbMAX_VAL;
-        } else {
-
-            point = setCurrentChartPoint(i, direction, chrtVal, chrtScale);
-
-            // if (i >= (numBufVals / chrtIntv) - 5) // log chart data of 1 line (adjust for test purposes)
-            //    LOG_DEBUG(GwLog::DEBUG, "PageWindPlot Chart: i: %d, chrtVal: %.2f, chrtMin: %.2f, {x,y} {%d,%d}", i, chrtVal, chrtMin, x, y);
-
-            if ((i == 0) || (chrtPrevVal == dbMAX_VAL)) {
-                // just a dot for 1st chart point or after some invalid values
-                prevPoint = point;
-
-            } else if (chrtDataFmt == WIND || chrtDataFmt == ROTATION) {
-                // cross borders check for degree values; shift values to [-PI..0..PI]; when crossing borders, range is 2x PI degrees
-
-                double normCurrVal = WindUtils::to2PI(chrtVal - chrtMin);
-                double normPrevVal = WindUtils::to2PI(chrtPrevVal - chrtMin);
-                // Check if pixel positions are far apart (crossing chart boundary); happens when one value is near chrtMax and the other near chrtMin
-                bool crossedBorders = std::abs(normCurrVal - normPrevVal) > (chrtRng / 2.0);
-
-                if (crossedBorders) { // If current value crosses chart borders compared to previous value, split line
-                    // LOG_DEBUG(GwLog::DEBUG, "PageWindPlot Chart: crossedBorders: %d, chrtVal: %.2f, chrtPrevVal: %.2f", crossedBorders, chrtVal, chrtPrevVal);
-                    bool wrappingFromHighToLow = normCurrVal < normPrevVal; // Determine which edge we're crossing
-
-                    if (direction == HORIZONTAL) {
-                        int ySplit = wrappingFromHighToLow ? (cRoot.y + valAxis) : cRoot.y;
-                        drawBoldLine(prevPoint.x, prevPoint.y, point.x, ySplit);
-                        prevPoint.y = wrappingFromHighToLow ? cRoot.y : (cRoot.y + valAxis);
-
-                    } else { // vertical chart
-                        int xSplit = wrappingFromHighToLow ? (cRoot.x + valAxis) : cRoot.x;
-                        drawBoldLine(prevPoint.x, prevPoint.y, xSplit, point.y);
-                        prevPoint.x = wrappingFromHighToLow ? cRoot.x : (cRoot.x + valAxis);
-                    }
-                }
-            }
-
-            if (chrtDataFmt == DEPTH) {
-                if (direction == HORIZONTAL) { // horizontal chart
-                    drawBoldLine(point.x, point.y, point.x, cRoot.y + valAxis);
-                } else { // vertical chart
-                    drawBoldLine(point.x, point.y, cRoot.x + valAxis, point.y);
-                }
-            } else {
-                drawBoldLine(prevPoint.x, prevPoint.y, point.x, point.y);
-            }
-
-            chrtPrevVal = chrtVal;
-            prevPoint = point;
-        }
-
-        // Reaching chart area top end
-        if (i >= timAxis - 1) {
-            oldChrtIntv = 0; // force reset of buffer start and number of values to show in next display loop
-
-            if (chrtDataFmt == WIND) { // degree of course or wind
-                recalcRngMid = true;
-                LOG_DEBUG(GwLog::DEBUG, "PageWindPlot: chart end: timAxis: %d, i: %d, bufStart: %d, numBufVals: %d, recalcRngCntr: %d", timAxis, i, bufStart, numBufVals, recalcRngMid);
-            }
-            break;
-        }
-    }
-}
-
-// Set current chart point to draw
-Pos Chart::setCurrentChartPoint(const int i, const char direction, const double chrtVal, const double chrtScale)
-{
-    Pos currentPoint;
-
-    if (direction == HORIZONTAL) {
-        currentPoint.x = cRoot.x + i; // Position in chart area
-
-        if (chrtDataFmt == WIND || chrtDataFmt == ROTATION) { // degree type value
-            currentPoint.y = cRoot.y + static_cast<int>((WindUtils::to2PI(chrtVal - chrtMin) * chrtScale) + 0.5); // calculate chart point and round
-        } else if (chrtDataFmt == SPEED or chrtDataFmt == TEMPERATURE) { // speed or temperature data format -> print low values at bottom
-            currentPoint.y = cRoot.y + valAxis - static_cast<int>(((chrtVal - chrtMin) * chrtScale) + 0.5); // calculate chart point and round
-        } else { // any other data format
-            currentPoint.y = cRoot.y + static_cast<int>(((chrtVal - chrtMin) * chrtScale) + 0.5); // calculate chart point and round
-        }
-
-    } else { // vertical chart
-        currentPoint.y = cRoot.y + timAxis - i; // Position in chart area
-
-        if (chrtDataFmt == WIND || chrtDataFmt == ROTATION) { // degree type value
-            currentPoint.x = cRoot.x + static_cast<int>((WindUtils::to2PI(chrtVal - chrtMin) * chrtScale) + 0.5); // calculate chart point and round
-        } else {
-            currentPoint.x = cRoot.x + static_cast<int>(((chrtVal - chrtMin) * chrtScale) + 0.5); // calculate chart point and round
-        }
-    }
-
-    return currentPoint;
-}
-
-// chart time axis label + lines
-void Chart::drawChrtTimeAxis(const char chrtDir, const int8_t chrtSz, const int8_t chrtIntv)
-{
-    float axSlots, intv, i;
-    char sTime[6];
-    int timeRng = chrtIntv * 4; // chart time interval: [1] 4 min., [2] 8 min., [3] 12 min., [4] 16 min., [8] 32 min.
-
-    getdisplay().setFont(&Ubuntu_Bold8pt8b);
-    getdisplay().setTextColor(fgColor);
-
-    axSlots = 5; // number of axis labels
-    intv = timAxis / (axSlots - 1); // minutes per chart axis interval (interval is 1 less than axSlots)
-    i = timeRng; // Chart axis label start at -32, -16, -12, ... minutes
-
-    if (chrtDir == HORIZONTAL) {
-        getdisplay().fillRect(0, cRoot.y, dWidth, 2, fgColor);
-
-        for (float j = 0; j < timAxis - 1; j += intv) { // fill time axis with values but keep area free on right hand side for value label
-
-            // draw text with appropriate offset
-            int tOffset = j == 0 ? 13 : -4;
-            snprintf(sTime, sizeof(sTime), "-%.0f", i);
-            drawTextCenter(cRoot.x + j + tOffset, cRoot.y - 8, sTime);
-            getdisplay().drawLine(cRoot.x + j, cRoot.y, cRoot.x + j, cRoot.y + 5, fgColor); // draw short vertical time mark
-
-            i -= chrtIntv;
-        }
-
-    } else { // vertical chart
-
-        for (float j = intv; j < timAxis - 1; j += intv) { // don't print time label at upper and lower end of time axis
-
-            i -= chrtIntv; // we start not at top chart position
-            snprintf(sTime, sizeof(sTime), "-%.0f", i);
-            getdisplay().drawLine(cRoot.x, cRoot.y + j, cRoot.x + valAxis, cRoot.y + j, fgColor); // Grid line
-
-            if (chrtSz == FULL_SIZE) { // full size chart
-                getdisplay().fillRect(0, cRoot.y + j - 9, 32, 15, bgColor); // clear small area to remove potential chart lines
-                getdisplay().setCursor((4 - strlen(sTime)) * 7, cRoot.y + j + 3); // time value; print left screen; value right-formated
-                getdisplay().printf("%s", sTime); // Range value
-            } else if (chrtSz == HALF_SIZE_RIGHT) { // half size chart; right side
-                drawTextCenter(dWidth / 2, cRoot.y + j, sTime); // time value; print mid screen
-            }
-        }
-    }
-}
-
-// chart value axis labels + lines
-void Chart::drawChrtValAxis(const char chrtDir, const int8_t chrtSz, bool prntName)
-{
-    const GFXfont* font;
-    constexpr bool NO_LABEL = false;
-    constexpr bool LABEL = true;
-
-    getdisplay().setTextColor(fgColor);
-
-    if (chrtDir == HORIZONTAL) {
-
-        if (chrtSz == FULL_SIZE) {
-
-            font = &Ubuntu_Bold12pt8b;
-
-            // print buffer data name on right hand side of time axis (max. size 5 characters)
-            getdisplay().setFont(font);
-            drawTextRalign(cRoot.x + timAxis, cRoot.y - 3, dbName.substring(0, 5));
-
-            if (chrtDataFmt == WIND) {
-                prntHorizChartThreeValueAxisLabel(font);
-                return;
-            }
-
-            // for any other data formats print multiple axis value lines on full charts
-            prntHorizChartMultiValueAxisLabel(font);
-            return;
-
-        } else { // half size chart -> just print edge values + middle chart line
-
-            font = &Ubuntu_Bold10pt8b;
-
-            if (prntName) {
-                // print buffer data name on right hand side of time axis (max. size 5 characters)
-                getdisplay().setFont(font);
-                drawTextRalign(cRoot.x + timAxis, cRoot.y - 3, dbName.substring(0, 5));
-            }
-
-            prntHorizChartThreeValueAxisLabel(font);
-            return;
-        }
-
-    } else { // vertical chart
-
-        if (chrtSz == FULL_SIZE) {
-            font = &Ubuntu_Bold12pt8b;
-            getdisplay().setFont(font); // use larger font
-            drawTextRalign(cRoot.x + (valAxis * 0.42), cRoot.y - 2, dbName.substring(0, 6)); // print buffer data name (max. size 5 characters)
-
-        } else {
-
-            font = &Ubuntu_Bold10pt8b;
-        }
-
-        prntVerticChartThreeValueAxisLabel(font);
-    }
-}
-
-// Print current data value
-void Chart::prntCurrValue(const char direction, GwApi::BoatValue& currValue)
-{
-    const int xPosVal = (direction == HORIZONTAL) ? cRoot.x + (timAxis / 2) - 56 : cRoot.x + 32;
-    const int yPosVal = (direction == HORIZONTAL) ? cRoot.y + valAxis - 7 : cRoot.y + timAxis - 7;
-
-    FormattedData frmtDbData = formatValue(&currValue, *commonData, NO_SIMUDATA);
-    String sdbValue = frmtDbData.svalue; // value as formatted string
-    String dbUnit = frmtDbData.unit; // Unit of value; limit length to 3 characters
-
-    getdisplay().fillRect(xPosVal - 1, yPosVal - 35, 128, 41, bgColor); // Clear area for TWS value
-    getdisplay().drawRect(xPosVal, yPosVal - 34, 126, 40, fgColor); // Draw box for TWS value
-    getdisplay().setFont(&DSEG7Classic_BoldItalic16pt7b);
-    getdisplay().setCursor(xPosVal + 1, yPosVal);
-    getdisplay().print(sdbValue); // value
-
-    getdisplay().setFont(&Ubuntu_Bold10pt8b);
-    getdisplay().setCursor(xPosVal + 76, yPosVal - 17);
-    getdisplay().print(dbName.substring(0, 3)); // Name, limited to 3 characters
-
-    getdisplay().setFont(&Ubuntu_Bold8pt8b);
-    getdisplay().setCursor(xPosVal + 76, yPosVal + 0);
-    getdisplay().print(dbUnit); // Unit
-}
-
-// print message for no valid data availabletemplate <typename T>
-void Chart::prntNoValidData(const char direction)
-{
-    Pos p;
-
-    getdisplay().setFont(&Ubuntu_Bold10pt8b);
-
-    if (direction == HORIZONTAL) {
-        p.x = cRoot.x + (timAxis / 2);
-        p.y = cRoot.y + (valAxis / 2) - 10;
-    } else {
-        p.x = cRoot.x + (valAxis / 2);
-        p.y = cRoot.y + (timAxis / 2) - 10;
-    }
-
-    getdisplay().fillRect(p.x - 37, p.y - 10, 78, 24, bgColor); // Clear area for message
-    drawTextCenter(p.x, p.y, "No data");
-
-    LOG_DEBUG(GwLog::LOG, "Page chart <%s>: No valid data available", dbName);
-}
-
-// Get maximum difference of last <amount> of dataBuf ringbuffer values to center chart; for angle data only
-double Chart::getAngleRng(const double center, size_t amount)
-{
-    size_t count = dataBuf.getCurrentSize();
-
-    if (dataBuf.isEmpty() || amount <= 0) {
-        return dbMAX_VAL;
-    }
-    if (amount > count)
-        amount = count;
-
-    double value = 0;
-    double range = 0;
-    double maxRng = dbMIN_VAL;
-
-    // Start from the newest value (last) and go backwards x times
-    for (size_t i = 0; i < amount; i++) {
-        value = dataBuf.get(count - 1 - i);
-
-        if (value == dbMAX_VAL) {
-            continue; // ignore invalid values
-        }
-
-        range = abs(fmod((value - center + (M_TWOPI + M_PI)), M_TWOPI) - M_PI);
-        if (range > maxRng)
-            maxRng = range;
-    }
-
-    if (maxRng > M_PI) {
-        maxRng = M_PI;
-    }
-
-    return (maxRng != dbMIN_VAL ? maxRng : dbMAX_VAL); // Return range from <mid> to <max>
-}
-
- // print value axis label with only three values: top, mid, and bottom for vertical chart
- void Chart::prntVerticChartThreeValueAxisLabel(const GFXfont* font)
-{
-    double cVal;
-    char sVal[7];
-
-    getdisplay().fillRect(cRoot.x, cRoot.y, valAxis, 2, fgColor); // top chart line
-    getdisplay().setFont(font);
-
-    cVal = chrtMin;
-    cVal = convertValue(cVal, dbName, dbFormat, *commonData); // value (converted)
-    snprintf(sVal, sizeof(sVal), "%.0f", round(cVal));
-    getdisplay().setCursor(cRoot.x, cRoot.y - 2);
-    getdisplay().printf("%s", sVal); // Range low end
-
-    cVal = chrtMid;
-    cVal = convertValue(cVal, dbName, dbFormat, *commonData); // value (converted)
-    snprintf(sVal, sizeof(sVal), "%.0f", round(cVal));
-    drawTextCenter(cRoot.x + (valAxis / 2), cRoot.y - 9, sVal); // Range mid end
-
-    cVal = chrtMax;
-    cVal = convertValue(cVal, dbName, dbFormat, *commonData); // value (converted)
-    snprintf(sVal, sizeof(sVal), "%.0f", round(cVal));
-    drawTextRalign(cRoot.x + valAxis - 2, cRoot.y - 2, sVal); // Range high end
-
-    // draw vertical grid lines for each axis label
-    for (int j = 0; j <= valAxis; j += (valAxis / 2)) {
-        getdisplay().drawLine(cRoot.x + j, cRoot.y, cRoot.x + j, cRoot.y + timAxis, fgColor);
-    }
-}
-
-// print value axis label with only three values: top, mid, and bottom for horizontal chart
-void Chart::prntHorizChartThreeValueAxisLabel(const GFXfont* font)
-{
-    double axLabel;
-    double chrtMin, chrtMid, chrtMax;
-    int xOffset, yOffset; // offset for text position of x axis label for different font sizes
-    String sVal;
-
-    if (font == &Ubuntu_Bold10pt8b) {
-        xOffset = 39;
-        yOffset = 15;
-    } else if (font == &Ubuntu_Bold12pt8b) {
-        xOffset = 51;
-        yOffset = 18;
-    }
-    getdisplay().setFont(font);
-
-    // convert & round chart bottom+top label to next range step
-    chrtMin = convertValue(this->chrtMin, dbName, dbFormat, *commonData);
-    chrtMid = convertValue(this->chrtMid, dbName, dbFormat, *commonData);
-    chrtMax = convertValue(this->chrtMax, dbName, dbFormat, *commonData);
-    chrtMin = std::round(chrtMin * 100.0) / 100.0;
-    chrtMid = std::round(chrtMid * 100.0) / 100.0;
-    chrtMax = std::round(chrtMax * 100.0) / 100.0;
-
-    // print top axis label
-    axLabel = (chrtDataFmt == SPEED || chrtDataFmt == TEMPERATURE) ? chrtMax : chrtMin;
-    sVal = formatLabel(axLabel);
-    getdisplay().fillRect(cRoot.x, cRoot.y + 2, xOffset + 3, yOffset, bgColor); // Clear small area to remove potential chart lines
-    drawTextRalign(cRoot.x + xOffset, cRoot.y + yOffset, sVal); // range value
-
-    // print mid axis label
-    axLabel = chrtMid;
-    sVal = formatLabel(axLabel);
-    getdisplay().fillRect(cRoot.x, cRoot.y + (valAxis / 2) - 8, xOffset + 3, 16, bgColor); // Clear small area to remove potential chart lines
-    drawTextRalign(cRoot.x + xOffset, cRoot.y + (valAxis / 2) + 6, sVal); // range value
-    getdisplay().drawLine(cRoot.x + xOffset + 3, cRoot.y + (valAxis / 2), cRoot.x + timAxis, cRoot.y + (valAxis / 2), fgColor);
-
-    // print bottom axis label
-    axLabel = (chrtDataFmt == SPEED || chrtDataFmt == TEMPERATURE) ? chrtMin : chrtMax;
-    sVal = formatLabel(axLabel);
-    getdisplay().fillRect(cRoot.x, cRoot.y + valAxis - 14, xOffset + 3, 15, bgColor); // Clear small area to remove potential chart lines
-    drawTextRalign(cRoot.x + xOffset, cRoot.y + valAxis, sVal); // range value
-    getdisplay().drawLine(cRoot.x + xOffset + 3, cRoot.y + valAxis, cRoot.x + timAxis, cRoot.y + valAxis, fgColor);
-}
-
-// print value axis label with multiple axis lines for horizontal chart
-void Chart::prntHorizChartMultiValueAxisLabel(const GFXfont* font)
-{
-    double chrtMin, chrtMax, chrtRng;
-    double axSlots, axIntv, axLabel;
-    int xOffset; // offset for text position of x axis label for different font sizes
-    String sVal;
-
-    if (font == &Ubuntu_Bold10pt8b) {
-        xOffset = 38;
-    } else if (font == &Ubuntu_Bold12pt8b) {
-        xOffset = 50;
-    }
-    getdisplay().setFont(font);
-
-    chrtMin = convertValue(this->chrtMin, dbName, dbFormat, *commonData);
-    // chrtMin = std::floor(chrtMin / rngStep) * rngStep;
-    chrtMin = std::round(chrtMin * 100.0) / 100.0;
-    chrtMax = convertValue(this->chrtMax, dbName, dbFormat, *commonData);
-    // chrtMax = std::ceil(chrtMax / rngStep) * rngStep;
-    chrtMax = std::round(chrtMax * 100.0) / 100.0;
-    chrtRng = std::round((chrtMax - chrtMin) * 100) / 100;
-
-    axSlots = valAxis / static_cast<double>(VALAXIS_STEP); // number of axis labels (and we want to have a double calculation, no integer)
-    axIntv = chrtRng / axSlots;
-    axLabel = chrtMin + axIntv;
-    LOG_DEBUG(GwLog::DEBUG, "Chart::printHorizMultiValueAxisLabel: chrtRng: %.2f, th-chrtRng: %.2f, axSlots: %.2f, axIntv: %.2f, axLabel: %.2f, chrtMin: %.2f, chrtMid: %.2f, chrtMax: %.2f", chrtRng, this->chrtRng, axSlots, axIntv, axLabel, this->chrtMin, chrtMid, chrtMax);
-
-    int loopStrt, loopEnd, loopStp;
-    if (chrtDataFmt == SPEED || chrtDataFmt == TEMPERATURE || chrtDataFmt == OTHER) {
-        // High value at top
-        loopStrt = valAxis - VALAXIS_STEP;
-        loopEnd = VALAXIS_STEP / 2;
-        loopStp = VALAXIS_STEP * -1;
-    } else {
-        // Low value at top
-        loopStrt = VALAXIS_STEP;
-        loopEnd = valAxis - (VALAXIS_STEP / 2);
-        loopStp = VALAXIS_STEP;
-    }
-
-    for (int j = loopStrt; (loopStp > 0) ? (j < loopEnd) : (j > loopEnd); j += loopStp) {
-        sVal = formatLabel(axLabel);
-        getdisplay().fillRect(cRoot.x, cRoot.y + j - 11, xOffset + 3, 21, bgColor); // Clear small area to remove potential chart lines
-        drawTextRalign(cRoot.x + xOffset, cRoot.y + j + 7, sVal); // range value
-        getdisplay().drawLine(cRoot.x + xOffset + 3, cRoot.y + j, cRoot.x + timAxis, cRoot.y + j, fgColor);
-
-        axLabel += axIntv;
-    }
-}
-
-// Draw chart line with thickness of 2px
-void Chart::drawBoldLine(const int16_t x1, const int16_t y1, const int16_t x2, const int16_t y2)
-{
-    int16_t dx = std::abs(x2 - x1);
-    int16_t dy = std::abs(y2 - y1);
-
-    getdisplay().drawLine(x1, y1, x2, y2, fgColor);
-
-    if (dx >= dy) { // line has horizontal tendency
-        getdisplay().drawLine(x1, y1 - 1, x2, y2 - 1, fgColor);
-    } else { // line has vertical tendency
-        getdisplay().drawLine(x1 - 1, y1, x2 - 1, y2, fgColor);
-    }
-}
-
-// Convert and format current axis label to user defined format; helper function for easier handling of OBP60Formatter
-String Chart::convNformatLabel(const double& label)
-{
-    GwApi::BoatValue tmpBVal(dbName); // temporary boat value for string formatter
-    String sVal;
-
-    tmpBVal.setFormat(dbFormat);
-    tmpBVal.valid = true;
-    tmpBVal.value = label;
-    sVal = formatValue(&tmpBVal, *commonData, NO_SIMUDATA).svalue; // Formatted value as string including unit conversion and switching decimal places
-    if (sVal.length() > 0 && sVal[0] == '!') {
-        sVal = sVal.substring(1); // cut leading "!" created at OBPFormatter; doesn't work for other fonts than 7SEG
-    }
-
-    return sVal;
-}
-
-// Format current axis label for printing w/o data format conversion (has been done earlier)
-String Chart::formatLabel(const double& label)
-{
-    char sVal[11];
-
-    if (dbFormat == "formatCourse" || dbFormat == "formatWind") {
-        // Format 3 numbers with prefix zero
-        snprintf(sVal, sizeof(sVal), "%03.0f", label);
-
-    } else if (dbFormat == "formatRot") {
-        if (label > -10 && label < 10) {
-            snprintf(sVal, sizeof(sVal), "%3.2f", label);
-        } else {
-            snprintf(sVal, sizeof(sVal), "%3.0f", label);
-        }
-    }
-
-    else {
-        if (label < 10) {
-            snprintf(sVal, sizeof(sVal), "%3.1f", label);
-        } else {
-            snprintf(sVal, sizeof(sVal), "%3.0f", label);
-        }
-    }
-
-    return String(sVal);
-}
-// --- Class Chart ---------------

lib/obp60task/OBPcharts.h

@@ -1,116 +0,0 @@
-// Function lib for display of boat data in various graphical chart formats
-#pragma once
-#include "Pagedata.h"
-#include "OBP60Extensions.h"
-
-struct Pos {
-    int x;
-    int y;
-};
-
-struct ChartProps {
-    double range;
-    double step;
-};
-
-template <typename T>
-class RingBuffer;
-class GwLog;
-
-class Chart {
-protected:
-    CommonData* commonData;
-    GwLog* logger;
-
-    enum ChrtDataFormat {
-        WIND,
-        ROTATION,
-        SPEED,
-        DEPTH,
-        TEMPERATURE,
-        OTHER
-    };
-
-    static constexpr char HORIZONTAL = 'H';
-    static constexpr char VERTICAL = 'V';
-    static constexpr int8_t FULL_SIZE = 0;
-    static constexpr int8_t HALF_SIZE_LEFT = 1;
-    static constexpr int8_t HALF_SIZE_RIGHT = 2;
-
-    static constexpr int8_t MIN_FREE_VALUES = 60; // free 60 values when chart line reaches chart end
-    static constexpr int8_t THRESHOLD_NO_DATA = 3; // max. seconds of invalid values in a row
-    static constexpr int8_t VALAXIS_STEP = 60; // pixels between two chart value axis labels
-
-    static constexpr bool NO_SIMUDATA = true; // switch off simulation feature of <formatValue> function
-
-    RingBuffer<uint16_t>& dataBuf; // Buffer to display
-    //char chrtDir; // Chart timeline direction: 'H' = horizontal, 'V' = vertical
-    //int8_t chrtSz; // Chart size: [0] = full size, [1] = half size left/top, [2] half size right/bottom
-    double dfltRng; // Default range of chart, e.g. 30 = [0..30]
-    uint16_t fgColor; // color code for any screen writing
-    uint16_t bgColor; // color code for screen background
-    bool useSimuData; // flag to indicate if simulation data is active
-    String tempFormat; // user defined format for temperature
-    double zeroValue; // "0" SI value for temperature
-
-    int dWidth; // Display width
-    int dHeight; // Display height
-    int top = 44; // chart gap at top of display (25 lines for standard gap + 19 lines for axis labels)
-    int bottom = 25; // chart gap at bottom of display to keep space for status line
-    int hGap = 11; // gap between 2 horizontal charts; actual gap is 2x <gap>
-    int vGap = 17; // gap between 2 vertical charts; actual gap is 2x <gap>
-    int timAxis, valAxis; // size of time and value chart axis
-    Pos cRoot; // start point of chart area
-    double chrtRng; // Range of buffer values from min to max value
-    double chrtMin; // Range low end value
-    double chrtMax; // Range high end value
-    double chrtMid; // Range mid value
-    double rngStep; // Defines the step of adjustment (e.g. 10 m/s) for value axis range
-    bool recalcRngMid = false; // Flag for re-calculation of mid value of chart for wind data types
-
-    String dbName, dbFormat; // Name and format of data buffer
-    ChrtDataFormat chrtDataFmt; // Data format of chart boat data type
-    double dbMIN_VAL; // Lowest possible value of buffer of type <T>
-    double dbMAX_VAL; // Highest possible value of buffer of type <T>; indicates invalid value in buffer
-    size_t bufSize; // History buffer size: 1.920 values for 32 min. history chart
-    int count; // current size of buffer
-    int numBufVals; // number of wind values available for current interval selection
-    int bufStart; // 1st data value in buffer to show
-    int numAddedBufVals; // Number of values added to buffer since last display
-    size_t currIdx; // Current index in TWD history buffer
-    size_t lastIdx; // Last index of TWD history buffer
-    size_t lastAddedIdx = 0; // Last index of TWD history buffer when new data was added
-    int numNoData; // Counter for multiple invalid data values in a row
-    bool bufDataValid = false; // Flag to indicate if buffer data is valid
-    int oldChrtIntv = 0; // remember recent user selection of data interval
-
-    double chrtPrevVal; // Last data value in chart area
-    int x, y; // x and y coordinates for drawing
-    int prevX, prevY; // Last x and y coordinates for drawing
-
-    bool setChartDimensions(const char direction, const int8_t size); //define dimensions and start points for chart
-    void drawChrt(const char chrtDir, const int8_t chrtIntv, GwApi::BoatValue& currValue); // Draw chart line
-    void getBufferStartNSize(const int8_t chrtIntv); // Identify buffer size and buffer start position for chart
-    void calcChrtBorders(double& rngMin, double& rngMid, double& rngMax, double& rng); // Calculate chart points for value axis and return range between <min> and <max>
-    void drawChartLines(const char direction, const int8_t chrtIntv, const double chrtScale); // Draw chart graph
-    Pos setCurrentChartPoint(const int i, const char direction, const double chrtVal, const double chrtScale); // Set current chart point to draw
-    void drawChrtTimeAxis(const char chrtDir, const int8_t chrtSz, const int8_t chrtIntv); // Draw time axis of chart, value and lines
-    void drawChrtValAxis(const char chrtDir, const int8_t chrtSz, bool prntLabel); // Draw value axis of chart, value and lines
-    void prntCurrValue(const char chrtDir, GwApi::BoatValue& currValue); // Add current boat data value to chart
-    void prntNoValidData(const char chrtDir); // print message for no valid data available
-    double getAngleRng(const double center, size_t amount); // Calculate range between chart center and edges
-    void prntVerticChartThreeValueAxisLabel(const GFXfont* font); // print value axis label with only three values: top, mid, and bottom for vertical chart
-    void prntHorizChartThreeValueAxisLabel(const GFXfont* font); // print value axis label with only three values: top, mid, and bottom for horizontal chart
-    void prntHorizChartMultiValueAxisLabel(const GFXfont* font); // print value axis label with multiple axis lines for horizontal chart
-    void drawBoldLine(const int16_t x1, const int16_t y1, const int16_t x2, const int16_t y2); // Draw chart line with thickness of 2px
-    String convNformatLabel(const double& label); // Convert and format current axis label to user defined format; helper function for easier handling of OBP60Formatter
-    String formatLabel(const double& label); // Format current axis label for printing w/o data format conversion (has been done earlier)
-
-public:
-    // Define default chart range and range step for each boat data type
-    static std::map<String, ChartProps> dfltChrtDta;
-
-    Chart(RingBuffer<uint16_t>& dataBuf, double dfltRng, CommonData& common, bool useSimuData); // Chart object of data chart
-    ~Chart();
-    void showChrt(char chrtDir, int8_t chrtSz, const int8_t chrtIntv, bool prntName, bool showCurrValue, GwApi::BoatValue currValue); // Perform all actions to draw chart
-};

lib/obp60task/PageAnchor.cpp

@@ -0,0 +1,433 @@
+#if defined BOARD_OBP60S3 || defined BOARD_OBP40S3
+
+#include "Pagedata.h"
+#include "OBP60Extensions.h"
+#include "ConfigMenu.h"
+
+/*
+  Anchor overview with additional associated data
+  This page is in experimental stage so be warned!
+  North is up.
+
+  Boatdata used
+    DBS - Water depth
+    HDT - Boat heading
+    AWS - Wind strength; Boat not moving so we assume AWS=TWS and AWD=TWD
+    AWD - Wind direction
+    LAT/LON - Boat position, current
+    HDOP - Position error
+
+  This is the fist page to contain a configuration page with 
+  data entry option.
+  Also it will make use of the new alarm function.
+
+  Data
+    Anchor position lat/lon
+    Depth at anchor position
+    Chain length used
+    Boat position current
+    Depth at boat position
+    Boat heading
+    Wind direction
+    Wind strength
+    Alarm j/n
+    Alarm radius
+    GPS position error
+    Timestamp while dropping anchor
+
+   Drop / raise function in device OBP40 has to be done inside 
+   config mode because of limited number of buttons.
+
+*/
+
+#define anchor_width 16
+#define anchor_height 16
+static unsigned char anchor_bits[] = {
+   0x80, 0x01, 0x40, 0x02, 0x40, 0x02, 0x80, 0x01, 0xf0, 0x0f, 0x80, 0x01,
+   0x80, 0x01, 0x88, 0x11, 0x8c, 0x31, 0x8e, 0x71, 0x84, 0x21, 0x86, 0x61,
+   0x86, 0x61, 0xfc, 0x3f, 0xf8, 0x1f, 0x80, 0x01 };
+
+class PageAnchor : public Page
+{
+private:
+    GwConfigHandler *config;
+    GwLog *logger;
+    bool simulation = false;
+    bool holdvalues = false;
+    String flashLED;
+    String backlightMode;
+    String lengthformat;
+
+    int scale = 50; // Radius of display circle in meter
+
+    bool alarm = false;
+    bool alarm_enabled = false;
+    uint8_t alarm_range;
+
+    uint8_t chain_length;
+    uint8_t chain;
+
+    bool anchor_set = false;
+    double anchor_lat;
+    double anchor_lon;
+    double anchor_depth;
+    int anchor_ts; // time stamp anchor dropped
+
+    char mode = 'N'; // (N)ormal, (C)onfig
+    int8_t editmode = -1; // marker for menu/edit/set function
+
+    ConfigMenu *menu;
+
+    void displayModeNormal(PageData &pageData) {
+
+        // Boatvalues: DBS, HDT, AWS, AWD, LAT, LON, HDOP
+        GwApi::BoatValue *bv_dbs = pageData.values[0]; // DBS
+        String sval_dbs = formatValue(bv_dbs, *commonData).svalue;
+        String sunit_dbs = formatValue(bv_dbs, *commonData).unit; 
+        GwApi::BoatValue *bv_hdt = pageData.values[1]; // HDT
+        String sval_hdt = formatValue(bv_hdt, *commonData).svalue;
+        GwApi::BoatValue *bv_aws = pageData.values[2]; // AWS
+        String sval_aws = formatValue(bv_aws, *commonData).svalue;
+        String sunit_aws = formatValue(bv_aws, *commonData).unit; 
+        GwApi::BoatValue *bv_awd = pageData.values[3]; // AWD
+        String sval_awd = formatValue(bv_awd, *commonData).svalue;
+        GwApi::BoatValue *bv_lat = pageData.values[4]; // LAT
+        String sval_lat = formatValue(bv_lat, *commonData).svalue;
+        GwApi::BoatValue *bv_lon = pageData.values[5]; // LON
+        String sval_lon = formatValue(bv_lon, *commonData).svalue;
+        GwApi::BoatValue *bv_hdop = pageData.values[6]; // HDOP
+        String sval_hdop = formatValue(bv_hdop, *commonData).svalue;
+        String sunit_hdop = formatValue(bv_hdop, *commonData).unit; 
+
+        LOG_DEBUG(GwLog::DEBUG,"Drawing at PageAnchor; DBS=%f, HDT=%f, AWS=%f", bv_dbs->value, bv_hdt->value, bv_aws->value);
+
+        Point c = {200, 150}; // center = anchor position
+        uint16_t r = 125;
+
+        Point b = {200, 180}; // boat position while dropping anchor
+
+        const std::vector<Point> pts_boat = { // polygon lines
+            {b.x - 5, b.y},
+            {b.x - 5, b.y - 10},
+            {b.x, b.y - 16},
+            {b.x + 5, b.y - 10},
+            {b.x + 5, b.y}
+        };
+        //rotatePoints und dann Linien zeichnen
+        // TODO rotate boat according to current heading
+        //drawPoly(rotatePoints(c, pts, RadToDeg(value2)), commonData->fgcolor);
+        drawPoly(pts_boat, commonData->fgcolor);
+
+        // Draw wind arrow
+        const std::vector<Point> pts_wind = {
+            {c.x, c.y - r + 25},
+            {c.x - 12, c.y - r - 4},
+            {c.x, c.y - r + 6},
+            {c.x + 12, c.y - r - 4}
+        };
+        if (bv_awd->valid) {
+            fillPoly4(rotatePoints(c, pts_wind, bv_awd->value), commonData->fgcolor);
+        }
+
+        // Title and corner value headings
+        getdisplay().setTextColor(commonData->fgcolor);
+        getdisplay().setFont(&Ubuntu_Bold12pt8b);
+        getdisplay().setCursor(8, 48);
+        getdisplay().print("Anchor");
+
+        getdisplay().setFont(&Ubuntu_Bold10pt8b);
+        getdisplay().setCursor(8, 200);
+        getdisplay().print("Depth");
+        drawTextRalign(392, 38, "Chain");
+        drawTextRalign(392, 200, "Wind");
+
+        // Units
+        getdisplay().setCursor(8, 272);
+        getdisplay().print(sunit_dbs);
+        drawTextRalign(392, 272, sunit_aws);
+        drawTextRalign(392, 100, lengthformat); // chain unit not implemented
+
+        // Corner values
+        getdisplay().setFont(&Ubuntu_Bold8pt8b);
+        getdisplay().setCursor(8, 70);
+        getdisplay().print("Alarm: ");
+        getdisplay().print(alarm_enabled ? "On" : "Off");
+
+        getdisplay().setCursor(8, 90);
+        getdisplay().print("HDOP");
+        getdisplay().setCursor(8, 106);
+        if (bv_hdop->valid) {
+            getdisplay().print(round(bv_hdop->value), 0);
+            getdisplay().print(sunit_hdop);
+        } else {
+            getdisplay().print("n/a");
+        }
+
+        // Values
+        getdisplay().setFont(&DSEG7Classic_BoldItalic20pt7b);
+        // Current chain used
+        getdisplay().setCursor(328, 85);
+        getdisplay().print("27");
+
+        // Depth
+        getdisplay().setCursor(8, 250);
+        getdisplay().print(sval_dbs);
+        // Wind
+        getdisplay().setCursor(328, 250);
+        getdisplay().print(sval_aws);
+
+        getdisplay().drawCircle(c.x, c.y, r, commonData->fgcolor);
+        getdisplay().drawCircle(c.x, c.y, r + 1, commonData->fgcolor);
+ 
+        // zoom scale
+        getdisplay().drawLine(c.x + 10, c.y, c.x + r - 4, c.y, commonData->fgcolor);
+        // arrow left
+        getdisplay().drawLine(c.x + 10, c.y, c.x + 16, c.y - 4, commonData->fgcolor);
+        getdisplay().drawLine(c.x + 10, c.y, c.x + 16, c.y + 4, commonData->fgcolor);
+        // arrow right
+        getdisplay().drawLine(c.x + r - 4, c.y, c.x + r - 10, c.y - 4, commonData->fgcolor);
+        getdisplay().drawLine(c.x + r - 4, c.y, c.x + r - 10, c.y + 4, commonData->fgcolor);
+        getdisplay().setFont(&Ubuntu_Bold8pt8b);
+        drawTextCenter(c.x + r / 2, c.y + 8, String(scale) + "m");
+ 
+        // alarm range circle
+        if (alarm_enabled) {
+            // alarm range in meter has to be smaller than the scale in meter
+            // r and r_range are pixel values
+            uint16_t r_range = int(alarm_range * r / scale);
+            LOG_DEBUG(GwLog::LOG,"Drawing at PageAnchor; Alarm range = %d", r_range);
+            getdisplay().drawCircle(c.x, c.y, r_range, commonData->fgcolor);
+        }
+ 
+        // draw anchor symbol (as bitmap)
+        getdisplay().drawXBitmap(c.x - anchor_width / 2, c.y - anchor_height / 2,
+                                 anchor_bits, anchor_width, anchor_height, commonData->fgcolor);
+
+    }
+
+    void displayModeConfig() {
+
+        getdisplay().setTextColor(commonData->fgcolor);
+        getdisplay().setFont(&Ubuntu_Bold12pt8b);
+        getdisplay().setCursor(8, 48);
+        getdisplay().print("Anchor configuration");
+        
+        // TODO
+        // show lat/lon for anchor pos
+        // show lat/lon for boat pos
+        // show distance anchor <-> boat
+
+        getdisplay().setFont(&Ubuntu_Bold8pt8b);
+        for (int i = 0 ; i < menu->getItemCount(); i++) {
+            ConfigMenuItem *itm = menu->getItemByIndex(i);
+            if (!itm) {
+                LOG_DEBUG(GwLog::ERROR, "Menu item not found: %d", i);
+            } else {
+                Rect r = menu->getItemRect(i);
+                bool inverted = (i == menu->getActiveIndex());
+                drawTextBoxed(r, itm->getLabel(), commonData->fgcolor, commonData->bgcolor, inverted, false);
+                if (inverted and editmode > 0) {
+                    // triangle as edit marker
+                    getdisplay().fillTriangle(r.x + r.w + 20, r.y, r.x + r.w + 30, r.y + r.h / 2, r.x + r.w + 20, r.y + r.h,  commonData->fgcolor);
+                }
+                getdisplay().setCursor(r.x + r.w + 40, r.y + r.h - 4);
+                if (itm->getType() == "int") {
+                    getdisplay().print(itm->getValue());
+                    getdisplay().print(itm->getUnit());
+                } else {
+                     getdisplay().print(itm->getValue() == 0 ? "No" : "Yes");
+                }
+            }
+        } 
+
+    }
+
+public:
+    PageAnchor(CommonData &common) 
+    {
+        commonData = &common;
+        config = commonData->config;
+        logger = commonData->logger;
+        logger->logDebug(GwLog::LOG,"Instantiate PageAnchor");
+
+        // preload configuration data
+        simulation = config->getBool(config->useSimuData);
+        holdvalues = config->getBool(config->holdvalues);
+        flashLED = config->getString(config->flashLED);
+        backlightMode = config->getString(config->backlight);
+        lengthformat = config->getString(config->lengthFormat);
+        chain_length = config->getInt(config->chainLength);
+
+        chain = 0;
+        anchor_set = false;
+        alarm_range = 30;
+
+        // Initialize config menu
+        menu = new ConfigMenu("Options", 40, 80);
+        menu->setItemDimension(150, 20);
+
+        ConfigMenuItem *newitem;
+        newitem = menu->addItem("chain", "Chain out", "int", 0, "m");
+        if (! newitem) {
+            // Demo: in case of failure exit here, should never be happen
+            logger->logDebug(GwLog::ERROR,"Menu item creation failed");
+            return;
+        }
+        newitem->setRange(0, 200, {1, 5, 10});
+        newitem = menu->addItem("chainmax", "Chain max", "int", chain_length, "m");
+        newitem->setRange(0, 200, {1, 5, 10});
+        newitem = menu->addItem("zoom", "Zoom", "int", 50, "m");
+        newitem->setRange(0, 200, {1, });
+        newitem = menu->addItem("range", "Alarm range", "int", 40, "m");
+        newitem->setRange(0, 200, {1, 5, 10});
+        newitem = menu->addItem("alat", "Adjust anchor lat.", "int", 0, "m");
+        newitem->setRange(0, 200, {1, 5, 10});
+        newitem = menu->addItem("alon", "Adjust anchor lon.", "int", 0, "m");
+        newitem->setRange(0, 200, {1, 5, 10});
+#ifdef BOARD_OBP40S3
+        // Intodruced here because of missing keys for OBP40
+        newitem = menu->addItem("anchor", "Anchor down", "bool", 0, "");
+#endif
+        menu->setItemActive("zoom");
+     }
+
+    void setupKeys(){
+        Page::setupKeys();
+        commonData->keydata[0].label = "MODE";
+        commonData->keydata[1].label = "ALARM";
+    }
+
+#ifdef BOARD_OBP60S3
+    int handleKey(int key){
+        if (key == 1) { // Switch between normal and config mode
+            if (mode == 'N') {
+                mode = 'C';
+            } else {
+                mode = 'N';
+            }
+            return 0;
+        }
+        if (mode == 'N') {
+            if (key == 2) { // Toggle alarm
+                alarm_enabled = !alarm_enabled;
+                return 0;
+            }
+        } else { // Config mode
+            if (key == 3) {
+                // menu down
+                menu->goNext();
+                return 0;
+            }
+            if (key == 4) {
+                // menu up
+                menu->goPrev();
+                return 0;
+            }
+        }
+        if (key == 11) { // Code for keylock
+            commonData->keylock = !commonData->keylock;
+            return 0;
+        }
+        return key;
+    }
+#endif
+#ifdef BOARD_OBP40S3
+    int handleKey(int key){
+        if (key == 1) { // Switch between normal and config mode
+            if (mode == 'N') {
+                mode = 'C';
+                commonData->keydata[1].label = "EDIT";
+            } else {
+                mode = 'N';
+                commonData->keydata[1].label = "ALARM";
+            }
+            return 0;
+        }
+        if (mode == 'N') {
+            if (key == 2) { // Toggle alarm
+                alarm_enabled = !alarm_enabled;
+                return 0;
+            }
+        } else { // Config mode
+            // TODO different code for OBP40 / OBP60 
+            if (key == 9) {
+                // menu down
+                if (editmode > 0) {
+                    // decrease item value
+                    menu->getActiveItem()->decValue();
+                } else {
+                    menu->goNext();
+                }
+                return 0;
+            }
+            if (key == 10) {
+                // menu up or value up
+                if (editmode > 0) {
+                    // increase item value
+                    menu->getActiveItem()->incValue();
+                } else {
+                    menu->goPrev();
+                }
+                return 0;
+            }
+            if (key == 2) {
+                // enter / leave edit mode for current menu item
+                if (editmode > 0) {
+                    commonData->keydata[1].label = "EDIT";
+                    editmode = 0;
+                } else {
+                    commonData->keydata[1].label = "SET";
+                    editmode = 1;
+                }
+                return 0;
+            }
+        }
+        if (key == 11) { // Code for keylock
+            commonData->keylock = !commonData->keylock;
+            return 0;
+        }
+        return key;
+    }
+#endif
+
+    void displayNew(PageData &pageData){
+    };
+
+    int displayPage(PageData &pageData){
+
+        // Logging boat values
+        LOG_DEBUG(GwLog::LOG,"Drawing at PageAnchor; Mode=%c", mode);
+
+        // Set display in partial refresh mode
+        getdisplay().setPartialWindow(0, 0, getdisplay().width(), getdisplay().height()); // Set partial update
+
+       if (mode == 'N') {
+           displayModeNormal(pageData);
+       } else if (mode == 'C') {
+           displayModeConfig();
+       }
+
+        return PAGE_UPDATE;
+    };
+};
+
+static Page *createPage(CommonData &common){
+    return new PageAnchor(common);
+}
+
+/**
+ * with the code below we make this page known to the PageTask
+ * we give it a type (name) that can be selected in the config
+ * we define which function is to be called
+ * and we provide the number of user parameters we expect
+ * this will be number of BoatValue pointers in pageData.values
+ */
+PageDescription registerPageAnchor(
+    "Anchor",   // Page name
+    createPage, // Action
+    0,          // Number of bus values depends on selection in Web configuration
+    {"DBS", "HDT", "AWS", "AWD", "LAT", "LON", "HDOP"}, // Names of bus values undepends on selection in Web configuration (refer GwBoatData.h)
+    true        // Show display header on/off
+);
+
+#endif

lib/obp60task/PageAutopilot.cpp

@@ -1,263 +0,0 @@
-#if defined BOARD_OBP60S3 || defined BOARD_OBP40S3
-
-#include "Pagedata.h"
-#include "OBP60Extensions.h"
-
-// These constants have to match the declaration below in :
-//  PageDescription registerPageAutopilot(
-//  {"HDM","HDT", "COG", "STW", "SOG", "DBT","XTE", "DTW", "BTW"}, // Bus values we need in the page
-const int HowManyValues = 9;
-
-const int AverageValues = 4;
-
-const int ShowHDM = 0;
-const int ShowHDT = 1;
-const int ShowCOG = 2;
-const int ShowSTW = 3;
-const int ShowSOG = 4;
-const int ShowDBT = 5;
-const int ShowXTE = 6;
-const int ShowDTW = 7;
-const int ShowBTW = 8;
-
-const int Compass_X0 = 200;         // X center point of compass band
-const int Compass_Y0 = 220;         // Y position of compass lines
-const int Compass_LineLength = 22;  // Length of compass lines
-const float Compass_LineDelta = 8.0;// Compass band: 1deg = 5 Pixels, 10deg = 50 Pixels 
-
-class PageAutopilot : public Page
-{
-    int WhichDataCompass = ShowHDM; // Start value
-    int WhichDataDisplay = ShowHDM; // Start value
-
-    public:
-    PageAutopilot(CommonData &common){
-        commonData = &common;
-        common.logger->logDebug(GwLog::LOG,"Instantiate PageAutopilot");
-    }
-
-    virtual void setupKeys(){
-        Page::setupKeys();
-        commonData->keydata[0].label = "CMP";
-        commonData->keydata[1].label = "SRC";
-   }
-    
-    virtual int handleKey(int key){
-        // Code for keylock
-   
-        if ( key == 1 ) {
-            WhichDataCompass += 1;
-            if ( WhichDataCompass > ShowCOG)
-                 WhichDataCompass = ShowHDM;
-           return 0;
-            }
-      if ( key == 2 ) {
-            WhichDataDisplay += 1;
-            if ( WhichDataDisplay > ShowDBT)
-                 WhichDataDisplay = ShowHDM;
-             }
-
-        if(key == 11){
-            commonData->keylock = !commonData->keylock;
-            return 0;                   // Commit the key
-        }
-        return key;
-    }
-
-    int displayPage(PageData &pageData){
-        GwConfigHandler *config = commonData->config;
-        GwLog *logger = commonData->logger;
-    
-        // Old values for hold function
-        static String OldDataText[HowManyValues] = {"", "", "","", "", "","", "", ""};
-        static String OldDataUnits[HowManyValues] = {"", "", "","", "", "","", "", ""};
-
-        // Get config data
-        String lengthformat = config->getString(config->lengthFormat);
-        // bool simulation = config->getBool(config->useSimuData);
-        bool holdvalues = config->getBool(config->holdvalues);
-        String flashLED = config->getString(config->flashLED);
-        String backlightMode = config->getString(config->backlight);
-        
-        GwApi::BoatValue *bvalue;
-        String DataName[HowManyValues];
-        double DataValue[HowManyValues];
-        bool DataValid[HowManyValues];
-        String DataText[HowManyValues];
-        String DataUnits[HowManyValues];
-        String DataFormat[HowManyValues];
-        FormattedData TheFormattedData;
-
-        for (int i = 0; i < HowManyValues; i++){
-            bvalue = pageData.values[i];
-            TheFormattedData = formatValue(bvalue, *commonData);   
-            DataName[i] = xdrDelete(bvalue->getName());
-            DataName[i] = DataName[i].substring(0, 6);  // String length limit for value name
-            DataUnits[i] = formatValue(bvalue, *commonData).unit;   
-            DataText[i] = TheFormattedData.svalue;  // Formatted value as string including unit conversion and switching decimal places
-            DataValue[i] = TheFormattedData.value;  // Value as double in SI unit
-            DataValid[i] = bvalue->valid;
-            DataFormat[i] = bvalue->getFormat();    // Unit of value
-            LOG_DEBUG(GwLog::LOG,"Drawing at PageAutopilot: %d %s %f %s %s",  i,  DataName[i], DataValue[i], DataFormat[i], DataText[i] );
-        }
-
-        // Optical warning by limit violation (unused)
-        if(String(flashLED) == "Limit Violation"){
-            setBlinkingLED(false);
-            setFlashLED(false); 
-        }
-
-        if (bvalue == NULL) return PAGE_OK; // WTF why this statement?
-        
-        //***********************************************************
-
-        // Set display in partial refresh mode
-        getdisplay().setPartialWindow(0, 0, getdisplay().width(), getdisplay().height()); // Set partial update
-        getdisplay().setTextColor(commonData->fgcolor);
-
-        // Horizontal line 2 pix top & bottom
-        // Print data on top half
-        getdisplay().fillRect(0, 130, 400, 2, commonData->fgcolor); 
-        getdisplay().setFont(&Ubuntu_Bold20pt8b);
-        getdisplay().setCursor(10, 70);
-        getdisplay().print(DataName[WhichDataDisplay]);                         // Page name
-        // Show unit
-        getdisplay().setFont(&Ubuntu_Bold12pt8b);
-        getdisplay().setCursor(10, 120);
-        getdisplay().print(DataUnits[WhichDataDisplay]); 
-        getdisplay().setCursor(190, 120);
-        getdisplay().setFont(&DSEG7Classic_BoldItalic42pt7b);
-  
-        if(holdvalues == false){
-            getdisplay().print(DataText[WhichDataDisplay]);                     // Real value as formated string
-        }
-        else{
-            getdisplay().print(OldDataText[WhichDataDisplay]);                  // Old value as formated string
-        }
-        if(DataValid[WhichDataDisplay] == true){
-            OldDataText[WhichDataDisplay] = DataText[WhichDataDisplay];         // Save the old value
-            OldDataUnits[WhichDataDisplay] = DataUnits[WhichDataDisplay];       // Save the old unit
-        }
-
-        // Now draw compass band                
-        // Get the data
-        double TheAngle = DataValue[WhichDataCompass];
-        static double AvgAngle = 0;
-        AvgAngle = ( AvgAngle * AverageValues + TheAngle ) / (AverageValues + 1 );
-
-        int TheTrend = round( ( TheAngle - AvgAngle) * 180.0 / M_PI );
-
-        static const int bsize = 30;
-        char buffer[bsize+1];
-        buffer[0]=0;              
-
-        getdisplay().setFont(&Ubuntu_Bold16pt8b);
-        getdisplay().setCursor(10, Compass_Y0-60);
-        getdisplay().print(DataName[WhichDataCompass]);                         // Page name
- 
-     
-        // Draw compass base line and pointer
-        getdisplay().fillRect(0, Compass_Y0, 400, 3, commonData->fgcolor);            
-        getdisplay().fillTriangle(Compass_X0,Compass_Y0-40,Compass_X0-10,Compass_Y0-80,Compass_X0+10,Compass_Y0-80,commonData->fgcolor);
-        // Draw trendlines
-        for ( int i = 1; i < abs(TheTrend) / 2; i++){
-            int x1;
-            if ( TheTrend < 0 )
-                    x1 = Compass_X0 +  20 * i;
-            else
-                    x1 = Compass_X0 - 20 * ( i + 1 );
-
-            getdisplay().fillRect(x1, Compass_Y0 -55, 10, 6, commonData->fgcolor);            
-                }          
-        // Central line +  satellite lines
-        double NextSector = round(TheAngle / ( M_PI / 9 )) * ( M_PI / 9 );  // Get the next 20degree value
-        double Offset = - ( NextSector -  TheAngle);                        // Offest of the center line compared to TheAngle in Radian
-        
-        int Delta_X = int (  Offset * 180.0 / M_PI  * Compass_LineDelta );
-        for ( int i = 0; i <=4; i++ ){
-                int x0;
-                x0 = Compass_X0 + Delta_X + 2 * i * 5 * Compass_LineDelta;
-                getdisplay().fillRect(x0-2, Compass_Y0 - 2 * Compass_LineLength, 5, 2 * Compass_LineLength, commonData->fgcolor);
-                x0 = Compass_X0 + Delta_X + ( 2 * i + 1 ) * 5 * Compass_LineDelta;
-                getdisplay().fillRect(x0-1, Compass_Y0 - Compass_LineLength, 3, Compass_LineLength, commonData->fgcolor);
-
-                x0 = Compass_X0 + Delta_X - 2 * i * 5 * Compass_LineDelta;
-                getdisplay().fillRect(x0-2, Compass_Y0 - 2 * Compass_LineLength, 5, 2 * Compass_LineLength, commonData->fgcolor);
-                x0 = Compass_X0 + Delta_X - ( 2 * i + 1 ) * 5 * Compass_LineDelta;
-                getdisplay().fillRect(x0-1, Compass_Y0 - Compass_LineLength, 3, Compass_LineLength, commonData->fgcolor);
-            }
-
-        getdisplay().fillRect(0, Compass_Y0, 400, 3, commonData->fgcolor);
-        // Add the numbers to the compass band
-        int x0;
-        float AngleToDisplay = NextSector * 180.0 / M_PI;
-
-        x0 = Compass_X0 + Delta_X;
-        getdisplay().setFont(&DSEG7Classic_BoldItalic16pt7b);
-
-        do {
-                getdisplay().setCursor(x0 - 40, Compass_Y0 + 40);
-                snprintf(buffer,bsize,"%03.0f", AngleToDisplay);
-                getdisplay().print(buffer);
-                AngleToDisplay += 20;
-                if ( AngleToDisplay >= 360.0 )
-                    AngleToDisplay -= 360.0;
-                x0 -= 4 * 5 * Compass_LineDelta;
-        } while (  x0 >= 0 - 60  );
-        
-        AngleToDisplay = NextSector * 180.0 / M_PI - 20;
-        if ( AngleToDisplay < 0 )
-            AngleToDisplay += 360.0;
-
-        x0 = Compass_X0 + Delta_X + 4 * 5 * Compass_LineDelta;
-        do {
-            getdisplay().setCursor(x0 - 40, Compass_Y0 + 40);
-            snprintf(buffer,bsize,"%03.0f", AngleToDisplay);
-            // Quick and dirty way to prevent wrapping text in next line
-            if ( ( x0 - 40 ) > 380 )
-                buffer[0] = 0;
-            else if ( ( x0 - 40 )  > 355 )
-                    buffer[1] = 0;
-            else if ( ( x0 - 40 )  >  325 ) 
-                buffer[2] = 0;
-                
-            getdisplay().print(buffer);             
-
-            AngleToDisplay -= 20;
-            if ( AngleToDisplay < 0 )
-                AngleToDisplay += 360.0;
-            x0 += 4 * 5 * Compass_LineDelta;
-        } while (x0 < ( 400 - 20 -40 ) );
-
-        // static int x_test = 320;
-        // x_test += 2;
-
-        // snprintf(buffer,bsize,"%03d", x_test);
-        // getdisplay().setCursor(x_test, Compass_Y0 - 60);
-        // getdisplay().print(buffer);
-        // if ( x_test > 390)
-        //     x_test = 320;
-
-        return PAGE_UPDATE;
-    };
-
-};
-
-static Page *createPage(CommonData &common){
-    return new PageAutopilot(common);
-}/**
- * with the code below we make this page known to the PageTask
- * we give it a type (name) that can be selected in the config
- * we define which function is to be called
- * and we provide the number of user parameters we expect
- * this will be number of BoatValue pointers in pageData.values
- */
-PageDescription registerPageAutopilot(
-    "Autopilot",    // Page name
-    createPage,     // Action
-    0,              // Number of bus values depends on selection in Web configuration
-    {"HDM","HDT", "COG", "STW", "SOG", "DBT","XTE", "DTW", "BTW"}, // Bus values we need in the page
-   true            // Show display header on/off
-);
-
-#endif

lib/obp60task/PageClock.cpp

@@ -4,29 +4,14 @@
 #include "OBP60Extensions.h"
 
 /*
- * PageClock: Clock page with
- *  - Analog mode  (mode == 'A')
- *  - Digital mode (mode == 'D')
- *  - Countdown timer mode (mode == 'T')
- *  - Keys in mode analog and digital clock:
- *      K1: MODE (A/D/T)
- *      K2: POS  (select field: HH / MM / SS)
- *      K3: 
- *      K4: 
- *      K5: TZ  (Local/UTC)
+ * TODO mode: race timer: keys
+ *   - prepare: set countdown to 5min
+ *     reset: abort current countdown and start over with 5min preparation
+ *   - 5min: key press
+ *   - 4min: key press to sync
+ *   - 1min: buzzer signal
+ *   - start: buzzer signal for start
  *
- * Regatta timer mode:
- *  - Format HH:MM:SS (24h, leading zeros)
- *  - Keys in timer mode:
- *      K1: MODE (A/D/T)
- *      K2: POS  (select field: HH / MM / SS)
- *      K3: +    (increment selected field)
- *      K4: -    (decrement selected field)
- *      K5: RUN  (start/stop countdown)
- *  - Selection marker: line under active field (width 2px, not wider than digits)
- *  - Editing only possible when timer is not running
- *  - When page is left, running timer continues in background using RTC time
- *    (on re-entry, remaining time is recalculated from RTC)
  */
 
 class PageClock : public Page
@@ -34,90 +19,16 @@ class PageClock : public Page
 bool simulation = false;
 int simtime;
 bool keylock = false;
-#ifdef BOARD_OBP60S3
-    char source = 'G';  // Time source (R)TC | (G)PS | (N)TP
-#endif
-#ifdef BOARD_OBP40S3
 char source = 'R';  // time source (R)TC | (G)PS | (N)TP
-#endif
-    char mode = 'A';    // Display mode (A)nalog | (D)igital | race (T)imer
-    char tz = 'L';      // Time zone (L)ocal | (U)TC
-    double timezone = 0; // There are timezones with non int offsets, e.g. 5.5 or 5.75
+char mode = 'A';    // display mode (A)nalog | (D)igital | race (T)imer
+char tz = 'L';      // time zone (L)ocal | (U)TC
+double timezone = 0; // there are timezones with non int offsets, e.g. 5.5 or 5.75
 double homelat;
 double homelon;
-    bool homevalid = false; // Homelat and homelon are valid
-
-    // Timer state (static so it survives page switches)
-    static bool timerInitialized;
-    static bool timerRunning;
-    static int timerHours;
-    static int timerMinutes;
-    static int timerSeconds;
-    // Preset seconds for sync button (default 4 minutes)
-    static const int timerPresetSeconds = 4 * 60;
-    // Initial timer setting at start (so we can restore it)
-    static int timerStartHours;
-    static int timerStartMinutes;
-    static int timerStartSeconds;
-    static int selectedField;       // 0 = hours, 1 = minutes, 2 = seconds
-    static bool showSelectionMarker;
-    static time_t timerEndEpoch;    // Absolute end time based on RTC
-
-    void setupTimerDefaults()
-    {
-        if (!timerInitialized) {
-            timerInitialized = true;
-            timerRunning = false;
-            timerHours = 0;
-            timerMinutes = 0;
-            timerSeconds = 0;
-            timerStartHours = 0;
-            timerStartMinutes = 0;
-            timerStartSeconds = 0;
-            selectedField = 0;
-            showSelectionMarker = true;
-            timerEndEpoch = 0;
-        }
-    }
-
-    // Limiter for overrun settings values
-    static int clamp(int value, int minVal, int maxVal)
-    {
-        if (value < minVal) return maxVal;
-        if (value > maxVal) return minVal;
-        return value;
-    }
-
-    void incrementSelected()
-    {
-        if (selectedField == 0) {
-            timerHours = clamp(timerHours + 1, 0, 23);
-        } else if (selectedField == 1) {
-            timerMinutes = clamp(timerMinutes + 1, 0, 59);
-        } else {
-            timerSeconds = clamp(timerSeconds + 1, 0, 59);
-        }
-    }
-
-    void decrementSelected()
-    {
-        if (selectedField == 0) {
-            timerHours = clamp(timerHours - 1, 0, 23);
-        } else if (selectedField == 1) {
-            timerMinutes = clamp(timerMinutes - 1, 0, 59);
-        } else {
-            timerSeconds = clamp(timerSeconds - 1, 0, 59);
-        }
-    }
-
-    int totalTimerSeconds() const
-    {
-        return timerHours * 3600 + timerMinutes * 60 + timerSeconds;
-    }
+bool homevalid = false; // homelat and homelon are valid
 
     public:
-    PageClock(CommonData& common)
-    {
+    PageClock(CommonData &common){
         commonData = &common;
         common.logger->logDebug(GwLog::LOG,"Instantiate PageClock");
         simulation = common.config->getBool(common.config->useSimuData);
@@ -126,166 +37,51 @@ public:
         homelon = common.config->getString(common.config->homeLON).toDouble();
         homevalid = homelat >= -180.0 and homelat <= 180 and homelon >= -90.0 and homelon <= 90.0;
         simtime = 38160; // time value 11:36
-        setupTimerDefaults();
     }
 
-    virtual void setupKeys()
-    {
+    virtual void setupKeys(){
         Page::setupKeys();
-
-        if (mode == 'T') {
-            // Timer mode: MODE, POS, +, -, RUN
-            commonData->keydata[0].label = "MODE";
-            commonData->keydata[1].label = "POS";
-            // K3: '+' while editing, 'SYNC' while running to set a preset countdown
-            commonData->keydata[2].label = timerRunning ? "SYNC" : "+";
-            commonData->keydata[3].label = "-";
-            commonData->keydata[4].label = timerRunning ? "RESET" : "START";
-        } else {
-            // Clock modes: like original
-            commonData->keydata[0].label = "MODE";
-            commonData->keydata[1].label = "SRC";
+        commonData->keydata[0].label = "SRC";
+        commonData->keydata[1].label = "MODE";
         commonData->keydata[4].label = "TZ";
     }
-    }
 
     // Key functions
-    virtual int handleKey(int key)
-    {
-        setupTimerDefaults();
+    virtual int handleKey(int key){
+        // Time source
+        if (key == 1) {
+            if (source == 'G') {
+                source = 'R';
+            } else {
+                source = 'G';
+            }
+            return 0;
+        }
+        if (key == 2) {
+            if (mode == 'A') {
+                mode = 'D';
+            } else if (mode == 'D') {
+                mode = 'T';
+            } else {
+                mode = 'A';
+            }
+            return 0;
+        }
+        // Time zone: Local / UTC
+        if (key == 5) {
+            if (tz == 'L') {
+                tz = 'U';
+            } else {
+                tz = 'L';
+            }
+            return 0;
+        }
 
         // Keylock function
         if(key == 11){              // Code for keylock
             keylock = !keylock;     // Toggle keylock
             return 0;               // Commit the key
         }
-
-        if (mode == 'T') {
-            // Timer mode key handling
-
-            // MODE (K1): cycle display mode A/D/T
-            if (key == 1) {
-                switch (mode) {
-                case 'A': mode = 'D'; break;
-                case 'D': mode = 'T'; break;
-                case 'T': mode = 'A'; break;
-                default:  mode = 'A'; break;
-                }
-                setupKeys();
-                return 0;
-            }
-
-            // POS (K2): select field HH / MM / SS (only if timer not running)
-            if (key == 2 && !timerRunning) {
-                selectedField = (selectedField + 1) % 3;
-                showSelectionMarker = true;
-                return 0;
-            }
-
-            // + (K3): increment selected field (only if timer not running)
-            if (key == 3 && !timerRunning) {
-                incrementSelected();
-                return 0;
-            }
-            if (key == 3 && timerRunning) {
-                // When timer is running, K3 acts as a synchronization button:
-                // set remaining countdown to the preset value (e.g. 4 minutes).
-                if (commonData->data.rtcValid) {
-                    int preset = timerPresetSeconds;
-                    // update start-setting so STOP will restore this preset
-                    timerStartHours = preset / 3600;
-                    timerStartMinutes = (preset % 3600) / 60;
-                    timerStartSeconds = preset % 60;
-
-                    struct tm rtcCopy = commonData->data.rtcTime;
-                    time_t nowEpoch = mktime(&rtcCopy);
-                    timerEndEpoch = nowEpoch + preset;
-
-                    // Update visible timer fields immediately
-                    timerHours = timerStartHours;
-                    timerMinutes = timerStartMinutes;
-                    timerSeconds = timerStartSeconds;
-//                    commonData->keydata[4].label = "RESET";
-                }
-                return 0;
-            }
-
-            // - (K4): decrement selected field (only if timer not running)
-            if (key == 4 && !timerRunning) {
-                decrementSelected();
-                return 0;
-            }
-            if (key == 4 && timerRunning) { // No action if timer running
-                return 0;
-            }
-
-            // RUN (K5): start/stop timer
-            if (key == 5) {
-                if (!timerRunning) {
-                    // Start timer if a non-zero duration is set
-                    int total = totalTimerSeconds();
-                    if (total > 0 && commonData->data.rtcValid) {
-                        // Remember initial timer setting at start
-                        timerStartHours = timerHours;
-                        timerStartMinutes = timerMinutes;
-                        timerStartSeconds = timerSeconds;
-
-                        struct tm rtcCopy = commonData->data.rtcTime;
-                        time_t nowEpoch = mktime(&rtcCopy);
-                        timerEndEpoch = nowEpoch + total;
-                        timerRunning = true;
-                        showSelectionMarker = false;
-                    }
-                } else {
-                    // Stop timer: restore initial start setting
-                    timerHours = timerStartHours;
-                    timerMinutes = timerStartMinutes;
-                    timerSeconds = timerStartSeconds;
-                    timerRunning = false;
-                    showSelectionMarker = true;
-                    // marker will become visible again only after POS press
-                }
-                return 0;
-            }
-
-            // In timer mode, other keys are passed through
-            return key;
-        }
-
-        // Clock (A/D) modes key handling – like original PageClock
-
-        // MODE (K1)
-        if (key == 1) {
-            switch (mode) {
-            case 'A': mode = 'D'; break;
-            case 'D': mode = 'T'; break;
-            case 'T': mode = 'A'; break;
-            default:  mode = 'A'; break;
-            }
-            setupKeys();
-            return 0;
-        }
-        
-        // Time source (K2)
-        if (key == 2) {
-            switch (source) {
-            case 'G': source = 'R'; break;
-            case 'R': source = 'G'; break;
-            default:  source = 'G'; break;
-            }
-            return 0;
-        }
-
-        // Time zone: Local / UTC (K5)
-        if (key == 5) {
-            switch (tz) {
-            case 'L': tz = 'U'; break;
-            case 'U': tz = 'L'; break;
-            default:  tz = 'L'; break;
-            }
-            return 0;
-        }
-
         return key;
     }
 
@@ -294,9 +90,6 @@ public:
         GwConfigHandler *config = commonData->config;
         GwLog *logger = commonData->logger;
 
-        setupTimerDefaults();
-        setupKeys(); // Ensure correct key labels for current mode
-
         static String svalue1old = "";
         static String unit1old = "";
         static String svalue2old = "";
@@ -319,16 +112,17 @@ public:
         String backlightMode = config->getString(config->backlight);
 
         // Get boat values for GPS time
-        GwApi::BoatValue* bvalue1 = pageData.values[0]; // First element in list
+        GwApi::BoatValue *bvalue1 = pageData.values[0]; // First element in list (only one value by PageOneValue)
         String name1 = bvalue1->getName().c_str();      // Value name
         name1 = name1.substring(0, 6);                  // String length limit for value name
         if(simulation == false){
             value1 = bvalue1->value;                    // Value as double in SI unit
-        } else {
+        }
+        else{
             value1 = simtime++;                         // Simulation data for time value 11:36 in seconds
         }                                               // Other simulation data see OBP60Formatter.cpp
         bool valid1 = bvalue1->valid;                   // Valid information 
-        String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value
+        String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
         String unit1 = formatValue(bvalue1, *commonData).unit;        // Unit of value
         if(valid1 == true){
             svalue1old = svalue1;                       // Save old value
@@ -336,25 +130,25 @@ public:
         }
 
         // Get boat values for GPS date
-        GwApi::BoatValue* bvalue2 = pageData.values[1]; // Second element in list
+        GwApi::BoatValue *bvalue2 = pageData.values[1]; // Second element in list (only one value by PageOneValue)
         String name2 = bvalue2->getName().c_str();      // Value name
         name2 = name2.substring(0, 6);                  // String length limit for value name
         value2 = bvalue2->value;                        // Value as double in SI unit
-        bool valid2 = bvalue2->valid;                   // Valid informationgetdisplay().print("RTC");
-        String svalue2 = formatValue(bvalue2, *commonData).svalue;    // Formatted value
+        bool valid2 = bvalue2->valid;                   // Valid information 
+        String svalue2 = formatValue(bvalue2, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
         String unit2 = formatValue(bvalue2, *commonData).unit;        // Unit of value
         if(valid2 == true){
             svalue2old = svalue2;                       // Save old value
             unit2old = unit2;                           // Save old unit
         }
 
-        // Get boat values for HDOP
-        GwApi::BoatValue* bvalue3 = pageData.values[2]; // Third element in list
+        // Get boat values for HDOP date
+        GwApi::BoatValue *bvalue3 = pageData.values[2]; // Third element in list (only one value by PageOneValue)
         String name3 = bvalue3->getName().c_str();      // Value name
         name3 = name3.substring(0, 6);                  // String length limit for value name
         value3 = bvalue3->value;                        // Value as double in SI unit
         bool valid3 = bvalue3->valid;                   // Valid information 
-        String svalue3 = formatValue(bvalue3, *commonData).svalue;    // Formatted value
+        String svalue3 = formatValue(bvalue3, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
         String unit3 = formatValue(bvalue3, *commonData).unit;        // Unit of value
         if(valid3 == true){
             svalue3old = svalue3;                       // Save old value
@@ -368,7 +162,7 @@ public:
         }
 
         // Logging boat values
-        if (bvalue1 == NULL) return PAGE_OK;
+        if (bvalue1 == NULL) return PAGE_OK; // WTF why this statement?
         LOG_DEBUG(GwLog::LOG,"Drawing at PageClock, %s:%f,  %s:%f", name1.c_str(), value1, name2.c_str(), value2);
 
         // Draw page
@@ -382,179 +176,6 @@ public:
         time_t tv = mktime(&commonData->data.rtcTime) + timezone * 3600;
         struct tm *local_tm = localtime(&tv);
 
-        if (mode == 'T') {
-            // REGATTA TIMER MODE: countdown timer HH:MM:SS in the center with 7-segment font
-            //*******************************************************************************
-
-            int dispH = timerHours;
-            int dispM = timerMinutes;
-            int dispS = timerSeconds;
-
-            // Update remaining time if timer is running (based on RTC)
-            if (timerRunning && commonData->data.rtcValid) {
-                struct tm rtcCopy = commonData->data.rtcTime;
-                time_t nowEpoch = mktime(&rtcCopy);
-                time_t remaining = timerEndEpoch - nowEpoch;
-                if(remaining <= 5 && remaining != 0){
-                    // Short pre buzzer alarm (100% power)
-                    setBuzzerPower(100);
-                    buzzer(TONE2, 75);
-                    setBuzzerPower(config->getInt(config->buzzerPower));
-                }
-                if (remaining <= 0) {
-                    remaining = 0;
-                    timerRunning = false;
-                    commonData->keydata[3].label = "-";
-                    commonData->keydata[4].label = "START";
-                    showSelectionMarker = true;
-                    // Buzzer alarm (100% power)
-                    setBuzzerPower(100);
-                    buzzer(TONE2, 800);
-                    setBuzzerPower(config->getInt(config->buzzerPower));
-
-                    // When countdown is finished, restore the initial start time
-                    timerHours = timerStartHours;
-                    timerMinutes = timerStartMinutes;
-                    timerSeconds = timerStartSeconds;
-                }
-                else{
-                    commonData->keydata[3].label = "";
-                    commonData->keydata[4].label = "RESET";
-                }
-                int rem = static_cast<int>(remaining);
-                dispH = rem / 3600;
-                rem -= dispH * 3600;
-                dispM = rem / 60;
-                dispS = rem % 60;
-            }
-
-            char buf[9]; // "HH:MM:SS"
-            snprintf(buf, sizeof(buf), "%02d:%02d:%02d", dispH, dispM, dispS);
-            String timeStr = String(buf);
-
-            // Clear central area and draw large digital time
-            getdisplay().fillRect(0, 110, getdisplay().width(), 80, commonData->bgcolor);
-
-            getdisplay().setFont(&DSEG7Classic_BoldItalic30pt7b);
-
-            // Determine widths for digits and colon to position selection underline exactly
-            int16_t x0, y0;
-            uint16_t wDigit, hDigit;
-            uint16_t wColon, hColon;
-
-            getdisplay().getTextBounds("00", 0, 0, &x0, &y0, &wDigit, &hDigit);
-            getdisplay().getTextBounds(":", 0, 0, &x0, &y0, &wColon, &hColon);
-
-            uint16_t totalWidth = 3 * wDigit + 2 * wColon;
-
-            int16_t baseX = (static_cast<int16_t>(getdisplay().width()) - static_cast<int16_t>(totalWidth)) / 2;
-            int16_t centerY = 150;
-
-            // Draw time string centered
-            int16_t x1b, y1b;
-            uint16_t wb, hb;
-            getdisplay().getTextBounds(timeStr, 0, 0, &x1b, &y1b, &wb, &hb);
-            int16_t textX = (static_cast<int16_t>(getdisplay().width()) - static_cast<int16_t>(wb)) / 2;
-            int16_t textY = centerY + hb / 2;
-
-            //getdisplay().setCursor(textX, textY); // horzontal jitter
-            getdisplay().setCursor(47, textY);      // static X position
-            getdisplay().print(timeStr);
-
-            // Selection marker (only visible when not running and POS pressed)
-            if (!timerRunning && showSelectionMarker) {
-                int16_t selX = baseX - 8; // Hours start
-                if (selectedField == 1) {
-                    selX = baseX + wDigit + wColon; // Minutes start
-                } else if (selectedField == 2) {
-                    selX = baseX + 2 * wDigit + 2 * wColon + 12; // Seconds start
-                }
-
-                int16_t underlineY = centerY + hb / 2 + 5;
-                //getdisplay().fillRect(selX, underlineY, wDigit, 6, commonData->fgcolor);
-                getdisplay().fillRoundRect(selX, underlineY, wDigit, 6, 2, commonData->fgcolor);
-            }
-
-            // Page label
-            getdisplay().setFont(&Ubuntu_Bold16pt8b);
-            getdisplay().setCursor(100, 70);
-            getdisplay().print("Regatta Timer");
-
-        } else if (mode == 'D') {
-            // DIGITAL CLOCK MODE: large 7-segment time based on GPS/RTC
-            //**********************************************************
-
-            int hour24 = 0;
-            int minute24 = 0;
-            int second24 = 0;
-
-            if (source == 'R' && commonData->data.rtcValid) {
-                time_t tv2 = mktime(&commonData->data.rtcTime);
-                if (tz == 'L') {
-                    tv2 += static_cast<time_t>(timezone * 3600);
-                }
-                struct tm* tm2 = localtime(&tv2);
-                hour24 = tm2->tm_hour;
-                minute24 = tm2->tm_min;
-                second24 = tm2->tm_sec;
-            } else {
-                double t = value1;
-                if (tz == 'L') {
-                    t += timezone * 3600;
-                }
-                if (t >= 86400) t -= 86400;
-                if (t < 0) t += 86400;
-                hour24 = static_cast<int>(t / 3600.0);
-                int rest = static_cast<int>(t) - hour24 * 3600;
-                minute24 = rest / 60;
-                second24 = rest % 60;
-            }
-
-            char buf[9]; // "HH:MM:SS"
-            snprintf(buf, sizeof(buf), "%02d:%02d:%02d", hour24, minute24, second24);
-            String timeStr = String(buf);
-
-            getdisplay().fillRect(0, 110, getdisplay().width(), 80, commonData->bgcolor);
-
-            getdisplay().setFont(&DSEG7Classic_BoldItalic30pt7b);
-
-            int16_t x1b, y1b;
-            uint16_t wb, hb;
-            getdisplay().getTextBounds(timeStr, 0, 0, &x1b, &y1b, &wb, &hb);
-
-            int16_t x = (static_cast<int16_t>(getdisplay().width()) - static_cast<int16_t>(wb)) / 2;
-            int16_t y = 150 + hb / 2;
-
-            //getdisplay().setCursor(x, y); // horizontal jitter
-            getdisplay().setCursor(47, y);  // static X position
-            getdisplay().print(timeStr); // Display actual time
-
-            // Small indicators: timezone and source
-            getdisplay().setFont(&Ubuntu_Bold8pt8b);
-
-            getdisplay().setCursor(47, 110);
-            if (source == 'G') {
-                getdisplay().print("GPS");
-            } else {
-                getdisplay().print("RTC");
-            }
-
-            getdisplay().setCursor(47 + 40, 110);
-            if (holdvalues == false) {
-                getdisplay().print(tz == 'L' ? "LOT" : "UTC");
-            } else {
-                getdisplay().print(unit2old); // date unit
-            }
-
-            // Page label
-            getdisplay().setFont(&Ubuntu_Bold16pt8b);
-            getdisplay().setCursor(100, 70);
-            getdisplay().print("Digital Clock");
-
-        } else {
-            // ANALOG CLOCK MODE (mode == 'A')
-            //********************************
-
         // Show values GPS date
         getdisplay().setFont(&Ubuntu_Bold8pt8b);
         getdisplay().setCursor(10, 65);
@@ -566,7 +187,8 @@ public:
                 // RTC value
                  if (tz == 'L') {
                      getdisplay().print(formatDate(dateformat, local_tm->tm_year + 1900, local_tm->tm_mon + 1, local_tm->tm_mday));
-                    } else {
+                 }
+                 else {
                      getdisplay().print(formatDate(dateformat, commonData->data.rtcTime.tm_year + 1900, commonData->data.rtcTime.tm_mon + 1, commonData->data.rtcTime.tm_mday));
                  }
             } else {
@@ -579,25 +201,28 @@ public:
         getdisplay().setCursor(10, 95);
         getdisplay().print("Date");                          // Name
 
-            // Horizontal separator left
+        // Horizintal separator left
         getdisplay().fillRect(0, 149, 60, 3, commonData->fgcolor);
 
-            // Show values GPS time (small text bottom left)
+        // Show values GPS time
         getdisplay().setFont(&Ubuntu_Bold8pt8b);
         getdisplay().setCursor(10, 250);
         if (holdvalues == false) {
             if (source == 'G') {
                 getdisplay().print(svalue1); // Value
-                } else if (commonData->data.rtcValid) {
+            }
+            else if (commonData->data.rtcValid) {
                  if (tz == 'L') {
                       getdisplay().print(formatTime('s', local_tm->tm_hour, local_tm->tm_min, local_tm->tm_sec));
-                    } else {
+                 }
+                 else {
                       getdisplay().print(formatTime('s', commonData->data.rtcTime.tm_hour, commonData->data.rtcTime.tm_min, commonData->data.rtcTime.tm_sec));
                  }
             } else {
                 getdisplay().print("---");
             }
-            } else {
+        }
+        else {
              getdisplay().print(svalue1old);
         }
         getdisplay().setFont(&Ubuntu_Bold12pt8b);
@@ -621,7 +246,7 @@ public:
         getdisplay().setCursor(335, 95);
         getdisplay().print("SunR");                          // Name
 
-            // Horizontal separator right
+        // Horizintal separator right
         getdisplay().fillRect(340, 149, 80, 3, commonData->fgcolor);
 
         // Show values sunset
@@ -641,6 +266,9 @@ public:
         getdisplay().setCursor(335, 220);
         getdisplay().print("SunS");                          // Name
 
+//*******************************************************************************************
+
+        // Draw clock
         int rInstrument = 110;     // Radius of clock
         float pi = 3.141592;
 
@@ -651,23 +279,31 @@ public:
         {
             // Scaling values
             float x = 200 + (rInstrument-30)*sin(i/180.0*pi);  //  x-coordinate dots
-                float y = 150 - (rInstrument - 30) * cos(i / 180.0 * pi);  //  y-coordinate dots
+            float y = 150 - (rInstrument-30)*cos(i/180.0*pi);  //  y-coordinate cots 
             const char *ii = "";
             switch (i)
             {
             case 0: ii="12"; break;
+            case 30 : ii=""; break;
+            case 60 : ii=""; break;
             case 90 : ii="3"; break;
+            case 120 : ii=""; break;
+            case 150 : ii=""; break;
             case 180 : ii="6"; break;
+            case 210 : ii=""; break;
+            case 240 : ii=""; break;
             case 270 : ii="9"; break;
+            case 300 : ii=""; break;
+            case 330 : ii=""; break;
             default: break;
             }
 
             // Print text centered on position x, y
-                int16_t x1c, y1c;     // Return values of getTextBounds
-                uint16_t wc, hc;      // Return values of getTextBounds
-                getdisplay().getTextBounds(ii, int(x), int(y), &x1c, &y1c, &wc, &hc); // Calc width of new string
-                getdisplay().setCursor(x - wc / 2, y + hc / 2);
-                if (i % 90 == 0) {
+            int16_t x1, y1;     // Return values of getTextBounds
+            uint16_t w, h;      // Return values of getTextBounds
+            getdisplay().getTextBounds(ii, int(x), int(y), &x1, &y1, &w, &h); // Calc width of new string
+            getdisplay().setCursor(x-w/2, y+h/2);
+            if(i % 30 == 0){
                 getdisplay().setFont(&Ubuntu_Bold12pt8b);
                 getdisplay().print(ii);
             }
@@ -676,9 +312,9 @@ public:
             float sinx = 0;
             float cosx = 0;
              if(i % 6 == 0){
-                    float x1d = 200 + rInstrument * sin(i / 180.0 * pi);
-                    float y1d = 150 - rInstrument * cos(i / 180.0 * pi);
-                    getdisplay().fillCircle((int)x1d, (int)y1d, 2, commonData->fgcolor);
+                float x1c = 200 + rInstrument*sin(i/180.0*pi);
+                float y1c = 150 - rInstrument*cos(i/180.0*pi);
+                getdisplay().fillCircle((int)x1c, (int)y1c, 2, commonData->fgcolor);
                 sinx=sin(i/180.0*pi);
                 cosx=cos(i/180.0*pi);
              }
@@ -704,7 +340,8 @@ public:
         getdisplay().setCursor(175, 110);
         if(holdvalues == false){
             getdisplay().print(tz == 'L' ? "LOT" : "UTC");
-            } else {
+        }
+        else{
             getdisplay().print(unit2old); // date unit
         }
 
@@ -721,10 +358,10 @@ public:
         double minute = 0;
         if (source == 'R') {
             if (tz == 'L') {
-                    time_t tv2 = mktime(&commonData->data.rtcTime) + timezone * 3600;
-                    struct tm* local_tm2 = localtime(&tv2);
-                    minute = local_tm2->tm_min;
-                    hour = local_tm2->tm_hour;
+                time_t tv = mktime(&commonData->data.rtcTime) + timezone * 3600;
+                struct tm *local_tm = localtime(&tv);
+                minute = local_tm->tm_min;
+                hour = local_tm->tm_hour;
             } else {
                 minute = commonData->data.rtcTime.tm_min;
                 hour = commonData->data.rtcTime.tm_hour;
@@ -800,35 +437,20 @@ public:
         // Center circle
         getdisplay().fillCircle(200, 150, startwidth + 6, commonData->bgcolor);
         getdisplay().fillCircle(200, 150, startwidth + 4, commonData->fgcolor);
-        }
 
         return PAGE_UPDATE;
     };
 };
 
-// Static member definitions
-bool PageClock::timerInitialized = false;
-bool PageClock::timerRunning = false;
-int PageClock::timerHours = 0;
-int PageClock::timerMinutes = 0;
-int PageClock::timerSeconds = 0;
-int PageClock::timerStartHours = 0;
-int PageClock::timerStartMinutes = 0;
-int PageClock::timerStartSeconds = 0;
-int PageClock::selectedField = 0;
-bool PageClock::showSelectionMarker = true;
-time_t PageClock::timerEndEpoch = 0;
-
-static Page* createPage(CommonData& common)
-{
+static Page *createPage(CommonData &common){
     return new PageClock(common);
 }
 /**
  * with the code below we make this page known to the PageTask
  * we give it a type (name) that can be selected in the config
  * we define which function is to be called
- * we provide the number of user parameters we expect (0 here)
- * and we provide the names of the fixed values we need
+ * and we provide the number of user parameters we expect (0 here)
+ * and will will provide the names of the fixed values we need
  */
 PageDescription registerPageClock(
     "Clock",            // Page name
@@ -839,4 +461,3 @@ PageDescription registerPageClock(
 );
 
 #endif
-

lib/obp60task/PageCompass.cpp

@@ -17,10 +17,10 @@ const int ShowSTW = 3;
 const int ShowSOG = 4;
 const int ShowDBS = 5;
 
-const int Compass_X0 = 200;         // X center point of compass band
-const int Compass_Y0 = 220;         // Y position of compass lines
-const int Compass_LineLength = 22;  // Length of compass lines
-const float Compass_LineDelta = 8.0;// Compass band: 1deg = 5 Pixels, 10deg = 50 Pixels 
+const int Compass_X0 = 200;         // center point of compass band
+const int Compass_Y0 = 220;         // position of compass lines
+const int Compass_LineLength = 22;  // length of compass lines
+const float Compass_LineDelta = 8.0;// compass band: 1deg = 5 Pixels, 10deg = 50 Pixels 
 
 class PageCompass : public Page
 {

lib/obp60task/PageDigitalOut.cpp

@@ -1,152 +0,0 @@
-#if defined BOARD_OBP60S3 || defined BOARD_OBP40S3
-
-#include <PCF8574.h>                  // PCF8574 modules from Horter
-#include "Pagedata.h"
-#include "OBP60Extensions.h"
-
-#include "images/OBP_400x300.xbm"     // OBP Logo
-#ifdef BOARD_OBP60S3
-#include "images/OBP60_400x300.xbm"   // MFD with logo
-#endif
-#ifdef BOARD_OBP40S3
-#include "images/OBP40_400x300.xbm"   // MFD with logo
-#endif
-
-class PageDigitalOut : public Page
-{
-
-// Status values
-bool button1 = false;
-bool button2 = false;
-bool button3 = false;
-bool button4 = false;
-bool button5 = false;
-
-    public:
-    PageDigitalOut(CommonData &common){
-        commonData = &common;
-        common.logger->logDebug(GwLog::LOG,"Instantiate PageDigitalOut");
-    }
-
-    // Set botton labels
-    virtual void setupKeys(){
-        Page::setupKeys();
-        commonData->keydata[0].label = "1";
-        commonData->keydata[1].label = "2";
-        commonData->keydata[2].label = "3";
-        commonData->keydata[3].label = "4";
-        commonData->keydata[4].label = "5";
-    }
-
-    virtual int handleKey(int key){
-        // Code for keylock
-        if(key == 11){
-            commonData->keylock = !commonData->keylock;
-            return 0;                       // Commit the key
-        }
-        // Code for button 1 
-        if(key == 1){
-            button1 = !button1;
-            setPCF8574PortPinModul1(0, button1 ? 0 : 1); // Attention! Inverse logic for PCF8574
-            return 0;                       // Commit the key
-        }
-        // Code for button 2
-        if(key == 2){
-            button2 = !button2;
-            setPCF8574PortPinModul1(1, button2 ? 0 : 1); // Attention! Inverse logic for PCF8574
-            return 0;                       // Commit the key
-        }
-        // Code for button 3
-        if(key == 3){
-            button3 = !button3;
-            setPCF8574PortPinModul1(2, button3 ? 0 : 1); // Attention! Inverse logic for PCF8574
-            return 0;                       // Commit the key
-        }
-        // Code for button 4
-        if(key == 4){
-            button4 = !button4;
-            setPCF8574PortPinModul1(3, button4 ? 0 : 1); // Attention! Inverse logic for PCF8574
-            return 0;                       // Commit the key
-        }
-        // Code for button 5
-        if(key == 5){
-            button5 = !button5;
-            setPCF8574PortPinModul1(4, button5 ? 0 : 1); // Attention! Inverse logic for PCF8574
-            return 0;                       // Commit the key
-        }
-        return key;
-    }
-
-    int displayPage(PageData &pageData){
-        GwConfigHandler *config = commonData->config;
-        GwLog *logger = commonData->logger;
-
-        // Get config data
-        String lengthformat = config->getString(config->lengthFormat);
-        bool simulation = config->getBool(config->useSimuData);
-        bool holdvalues = config->getBool(config->holdvalues);
-        String flashLED = config->getString(config->flashLED);
-        String backlightMode = config->getString(config->backlight);
-        String name1 = config->getString(config->mod1Out1);
-        String name2 = config->getString(config->mod1Out2);
-        String name3 = config->getString(config->mod1Out3);
-        String name4 = config->getString(config->mod1Out4);
-        String name5 = config->getString(config->mod1Out5);
-
-        // Optical warning by limit violation (unused)
-        if(String(flashLED) == "Limit Violation"){
-            setBlinkingLED(false);
-            setFlashLED(false); 
-        }
-
-        // Logging boat values
-        LOG_DEBUG(GwLog::LOG,"Drawing at PageDigitalOut");
-
-        // Draw page
-        //***********************************************************
-
-        // Set display in partial refresh mode
-        getdisplay().setPartialWindow(0, 0, getdisplay().width(), getdisplay().height()); // Set partial update
-        getdisplay().setTextColor(commonData->fgcolor);
-        getdisplay().setFont(&Ubuntu_Bold12pt8b);
-        // Write text
-        getdisplay().setCursor(100, 50 + 8);
-        getdisplay().print(name1);
-        getdisplay().setCursor(100, 100 + 8);
-        getdisplay().print(name2);
-        getdisplay().setCursor(100, 150 + 8);
-        getdisplay().print(name3);
-        getdisplay().setCursor(100,200 + 8);
-        getdisplay().print(name4);
-        getdisplay().setCursor(100, 250 + 8);
-        getdisplay().print(name5);
-        // Draw bottons
-        drawButtonCenter(50, 50, 40, 27, "1", commonData->fgcolor, commonData->bgcolor, button1);
-        drawButtonCenter(50, 100, 40, 27, "2", commonData->fgcolor, commonData->bgcolor, button2);
-        drawButtonCenter(50, 150, 40, 27, "3", commonData->fgcolor, commonData->bgcolor, button3);
-        drawButtonCenter(50, 200, 40, 27, "4", commonData->fgcolor, commonData->bgcolor, button4);
-        drawButtonCenter(50, 250, 40, 27, "5", commonData->fgcolor, commonData->bgcolor, button5);
-
-        return PAGE_UPDATE;
-    };
-};
-
-static Page* createPage(CommonData &common){
-    return new PageDigitalOut(common);
-}
-
-/**
- * with the code below we make this page known to the PageTask
- * we give it a type (name) that can be selected in the config
- * we define which function is to be called
- * and we provide the number of user parameters we expect
- * this will be number of BoatValue pointers in pageData.values
- */
-PageDescription registerPageDigitalOut(
-    "DigitalOut",   // Page name
-    createPage,     // Action
-    0,              // Number of bus values depends on selection in Web configuration
-    true            // Show display header on/off
-);
-
-#endif

lib/obp60task/PageFourValues.cpp

@@ -2,6 +2,7 @@
 
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
+#include "BoatDataCalibration.h"
 
 class PageFourValues : public Page
 {
@@ -45,6 +46,7 @@ class PageFourValues : public Page
         GwApi::BoatValue *bvalue1 = pageData.values[0]; // First element in list (only one value by PageOneValue)
         String name1 = xdrDelete(bvalue1->getName());   // Value name
         name1 = name1.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue1, logger); // Check if boat data value is to be calibrated
         double value1 = bvalue1->value;                 // Value as double in SI unit
         bool valid1 = bvalue1->valid;                   // Valid information 
         String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -54,6 +56,7 @@ class PageFourValues : public Page
         GwApi::BoatValue *bvalue2 = pageData.values[1]; // Second element in list
         String name2 = xdrDelete(bvalue2->getName());   // Value name
         name2 = name2.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue2, logger); // Check if boat data value is to be calibrated
         double value2 = bvalue2->value;                 // Value as double in SI unit
         bool valid2 = bvalue2->valid;                   // Valid information 
         String svalue2 = formatValue(bvalue2, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -63,6 +66,7 @@ class PageFourValues : public Page
         GwApi::BoatValue *bvalue3 = pageData.values[2]; // Third element in list
         String name3 = xdrDelete(bvalue3->getName());   // Value name
         name3 = name3.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue3, logger); // Check if boat data value is to be calibrated
         double value3 = bvalue3->value;                 // Value as double in SI unit
         bool valid3 = bvalue3->valid;                   // Valid information 
         String svalue3 = formatValue(bvalue3, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -72,6 +76,7 @@ class PageFourValues : public Page
         GwApi::BoatValue *bvalue4 = pageData.values[3]; // Fourth element in list
         String name4 = xdrDelete(bvalue4->getName());   // Value name
         name4 = name4.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue4, logger); // Check if boat data value is to be calibrated
         double value4 = bvalue4->value;                 // Value as double in SI unit
         bool valid4 = bvalue4->valid;                   // Valid information 
         String svalue4 = formatValue(bvalue4, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places

lib/obp60task/PageFourValues2.cpp

@@ -2,6 +2,7 @@
 
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
+#include "BoatDataCalibration.h"
 
 class PageFourValues2 : public Page
 {
@@ -45,6 +46,7 @@ class PageFourValues2 : public Page
         GwApi::BoatValue *bvalue1 = pageData.values[0]; // First element in list (only one value by PageOneValue)
         String name1 = xdrDelete(bvalue1->getName());   // Value name
         name1 = name1.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue1, logger); // Check if boat data value is to be calibrated
         double value1 = bvalue1->value;                 // Value as double in SI unit
         bool valid1 = bvalue1->valid;                   // Valid information 
         String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -54,6 +56,7 @@ class PageFourValues2 : public Page
         GwApi::BoatValue *bvalue2 = pageData.values[1]; // Second element in list (only one value by PageOneValue)
         String name2 = xdrDelete(bvalue2->getName());   // Value name
         name2 = name2.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue2, logger); // Check if boat data value is to be calibrated
         double value2 = bvalue2->value;                 // Value as double in SI unit
         bool valid2 = bvalue2->valid;                   // Valid information 
         String svalue2 = formatValue(bvalue2, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -63,6 +66,7 @@ class PageFourValues2 : public Page
         GwApi::BoatValue *bvalue3 = pageData.values[2]; // Second element in list (only one value by PageOneValue)
         String name3 = xdrDelete(bvalue3->getName());   // Value name
         name3 = name3.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue3, logger); // Check if boat data value is to be calibrated
         double value3 = bvalue3->value;                 // Value as double in SI unit
         bool valid3 = bvalue3->valid;                   // Valid information 
         String svalue3 = formatValue(bvalue3, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -72,6 +76,7 @@ class PageFourValues2 : public Page
         GwApi::BoatValue *bvalue4 = pageData.values[3]; // Second element in list (only one value by PageOneValue)
         String name4 = xdrDelete(bvalue4->getName());   // Value name
         name4 = name4.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue4, logger); // Check if boat data value is to be calibrated
         double value4 = bvalue4->value;                 // Value as double in SI unit
         bool valid4 = bvalue4->valid;                   // Valid information 
         String svalue4 = formatValue(bvalue4, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places

lib/obp60task/PageNavigation.cpp

@@ -1,508 +0,0 @@
-#if defined BOARD_OBP60S3 || defined BOARD_OBP40S3
-
-#include "Pagedata.h"
-#include "OBP60Extensions.h"
-#include "NetworkClient.h"      // Network connection
-#include "ImageDecoder.h"       // Image decoder for navigation map
-
-#include "Logo_OBP_400x300_sw.h"
-
-// Defines for reading of navigation map 
-#define JSON_BUFFER 30000       // Max buffer size for JSON content (30 kB picture + values)
-NetworkClient net(JSON_BUFFER); // Define network client
-ImageDecoder decoder;           // Define image decoder        
-
-class PageNavigation : public Page
-{
-// Values for buttons
-bool firstRun = true;    // Detect the first page run
-int zoom = 15;           // Default zoom level
-bool showValues = false; // Show values HDT, SOG, DBT in navigation map
-
-    private:
-    uint8_t* imageBackupData = nullptr;
-    int imageBackupWidth = 0;
-    int imageBackupHeight = 0;
-    size_t imageBackupSize = 0;
-    bool hasImageBackup = false;
-
-    public:
-    PageNavigation(CommonData &common){
-        commonData = &common;
-        common.logger->logDebug(GwLog::LOG,"Instantiate PageNavigation");
-        imageBackupData = (uint8_t*)heap_caps_malloc((GxEPD_WIDTH * GxEPD_HEIGHT), MALLOC_CAP_SPIRAM);
-    }
-
-    // Set botton labels
-    virtual void setupKeys(){
-        Page::setupKeys();
-        commonData->keydata[0].label = "ZOOM -";
-        commonData->keydata[1].label = "ZOOM +";
-        commonData->keydata[4].label = "VALUES";
-    }
-    
-    virtual int handleKey(int key){
-        // Code for keylock
-        if(key == 11){
-            commonData->keylock = !commonData->keylock;
-            return 0;                   // Commit the key
-        }
-        // Code for zoom -
-        if(key == 1){
-            zoom --;                    // Zoom -
-            if(zoom <7){
-                zoom = 7;
-            }
-            return 0;                   // Commit the key
-        }
-        // Code for zoom -
-        if(key == 2){
-            zoom ++;                    // Zoom +
-            if(zoom >17){
-                zoom = 17;
-            }
-            return 0;                   // Commit the key
-        }
-        if(key == 5){
-            showValues = !showValues;   // Toggle show values
-            return 0;                   // Commit the key
-        }
-        return key;
-    }
-
-    int displayPage(PageData &pageData){
-        GwConfigHandler *config = commonData->config;
-        GwLog *logger = commonData->logger;
-
-        // Get config data
-        String lengthformat = config->getString(config->lengthFormat);
-        bool simulation = config->getBool(config->useSimuData);
-        bool holdvalues = config->getBool(config->holdvalues);
-        String flashLED = config->getString(config->flashLED);
-        String backlightMode = config->getString(config->backlight);
-        String mapsource = config->getString(config->mapsource);
-        String ipAddress = config->getString(config->ipAddress);
-        int localPort = config->getInt(config->localPort);
-        String mapType = config->getString(config->maptype);
-        int zoomLevel = config->getInt(config->zoomlevel);
-        bool grid = config->getBool(config->grid);
-        String orientation = config->getString(config->orientation);
-        int refreshDistance = config->getInt(config->refreshDistance);
-        bool showValuesMap = config->getBool(config->showvalues);
-        bool ownHeading = config->getBool(config->ownheading);
-
-        if(firstRun == true){
-            zoom = zoomLevel;           // Over write zoom level with setup value
-            showValues = showValuesMap; // Over write showValues with setup value 
-            firstRun = false;           // Restet variable
-        }
-
-        // Local variables
-        String server = "norbert-walter.dnshome.de";
-        int port = 80;
-        int mType = 1;
-        int dType = 1;
-        int mapRot = 0;
-        int symbolRot = 0;
-        int mapGrid = 0;
-
-        
-        // Old values for hold function
-        static double value1old = 0;
-        static String svalue1old = "";
-        static String unit1old = "";
-        static double value2old = 0;
-        static String svalue2old = "";
-        static String unit2old = "";
-        static double value3old = 0;    // Deg
-        static String svalue3old = "";
-        static String unit3old = "";
-        static double value4old = 0;
-        static String svalue4old = "";
-        static String unit4old = "";
-        static double value5old = 0;
-        static String svalue5old = "";
-        static String unit5old = "";
-        static double value6old = 0;
-        static String svalue6old = "";
-        static String unit6old = "";
-
-        static double latitude = 0;
-        static double latitudeold = 0;
-        static double longitude = 0;
-        static double longitudeold = 0;
-        static double trueHeading = 0;
-        static double magneticHeading = 0;
-        static double speedOverGround = 0;
-        static double depthBelowTransducer = 0;
-        static int lostCounter = 0; // Counter for connection lost to the map server (increment by each page refresh)
-        int imgWidth = 0;
-        int imgHeight = 0;
-
-        // Get boat values #1 Latitude
-        GwApi::BoatValue *bvalue1 = pageData.values[0]; // First element in list (only one value by PageOneValue)
-        String name1 = xdrDelete(bvalue1->getName());   // Value name
-        name1 = name1.substring(0, 6);                  // String length limit for value name
-        double value1 = bvalue1->value;                 // Value as double in SI unit
-        bool valid1 = bvalue1->valid;                   // Valid information 
-        String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
-        String unit1 = formatValue(bvalue1, *commonData).unit;        // Unit of value
-
-        // Get boat values #2 Longitude
-        GwApi::BoatValue *bvalue2 = pageData.values[1]; // Second element in list (only one value by PageOneValue)
-        String name2 = xdrDelete(bvalue2->getName());   // Value name
-        name2 = name2.substring(0, 6);                  // String length limit for value name
-        double value2 = bvalue2->value;                 // Value as double in SI unit
-        bool valid2 = bvalue2->valid;                   // Valid information 
-        String svalue2 = formatValue(bvalue2, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
-        String unit2 = formatValue(bvalue2, *commonData).unit;        // Unit of value
-
-        // Get boat values #3 HDT
-        GwApi::BoatValue *bvalue3 = pageData.values[2]; // Second element in list (only one value by PageOneValue)
-        String name3 = xdrDelete(bvalue3->getName());   // Value name
-        name3 = name3.substring(0, 6);                  // String length limit for value name
-        double value3 = bvalue3->value;                 // Value as double in SI unit
-        bool valid3 = bvalue3->valid;                   // Valid information 
-        String svalue3 = formatValue(bvalue3, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
-        String unit3 = formatValue(bvalue3, *commonData).unit;        // Unit of value
-
-        // Get boat values #4 HDM
-        GwApi::BoatValue *bvalue4 = pageData.values[3]; // Second element in list (only one value by PageOneValue)
-        String name4 = xdrDelete(bvalue4->getName());   // Value name
-        name4 = name4.substring(0, 6);                  // String length limit for value name
-        double value4 = bvalue4->value;                 // Value as double in SI unit
-        bool valid4 = bvalue4->valid;                   // Valid information 
-        String svalue4 = formatValue(bvalue4, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
-        String unit4 = formatValue(bvalue4, *commonData).unit;        // Unit of value
-
-        // Get boat values #5 SOG
-        GwApi::BoatValue *bvalue5 = pageData.values[4]; // Second element in list (only one value by PageOneValue)
-        String name5 = xdrDelete(bvalue5->getName());   // Value name
-        name5 = name5.substring(0, 6);                  // String length limit for value name
-        double value5 = bvalue5->value;                 // Value as double in SI unit
-        bool valid5 = bvalue5->valid;                   // Valid information 
-        String svalue5 = formatValue(bvalue5, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
-        String unit5 = formatValue(bvalue5, *commonData).unit;        // Unit of value
-
-        // Get boat values #6 DBT
-        GwApi::BoatValue *bvalue6 = pageData.values[5]; // Second element in list (only one value by PageOneValue)
-        String name6 = xdrDelete(bvalue6->getName());   // Value name
-        name6 = name6.substring(0, 6);                  // String length limit for value name
-        double value6 = bvalue6->value;                 // Value as double in SI unit
-        bool valid6 = bvalue6->valid;                   // Valid information 
-        String svalue6 = formatValue(bvalue6, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
-        String unit6 = formatValue(bvalue6, *commonData).unit;        // Unit of value
-
-        // Optical warning by limit violation (unused)
-        if(String(flashLED) == "Limit Violation"){
-            setBlinkingLED(false);
-            setFlashLED(false); 
-        }
-
-        // Logging boat values
-        if (bvalue1 == NULL) return PAGE_OK; // WTF why this statement?
-        LOG_DEBUG(GwLog::LOG,"Drawing at PageNavigation, %s: %f, %s: %f, %s: %f, %s: %f, %s: %f, %s: %f", name1.c_str(), value1, name2.c_str(), value2, name3.c_str(), value3, name4.c_str(), value4, name5.c_str(), value5, name6.c_str(), value6);
-
-        // Set variables
-        //***********************************************************
-
-        // Latitude
-        if(valid1){
-            latitude = value1;
-            latitudeold = value1;
-            value3old = value1;
-        }
-        else{
-            latitude = value1old;
-        }
-        // Longitude
-        if(valid2){
-            longitude = value2;
-            longitudeold = value2;
-            value2old = value2;
-        }
-        else{
-            longitude = value2old;
-        }
-        // HDT value (True Heading, GPS)
-        if(valid3){
-            trueHeading = (value3 * 360) / (2 * PI);
-            value3old = trueHeading;
-        }
-        else{
-            trueHeading = value3old;
-        }
-        // HDM value (Magnetic Heading)
-        if(valid4){
-            magneticHeading = (value4 * 360) / (2 * PI);
-            value4old = magneticHeading;
-        }
-        else{
-            speedOverGround = value4old;
-        }
-        // SOG value (Speed Over Ground)
-        if(valid5){
-            speedOverGround = value5;
-            value5old = value5;
-        }
-        else{
-            speedOverGround = value5old;
-        }
-        // DBT value (Depth Below Transducer)
-        if(valid6){
-            depthBelowTransducer = value6;
-            value6old = value6;
-        }
-        else{
-            depthBelowTransducer = value6old;
-        }
-
-        // Prepare config values for URL
-        //***********************************************************
-
-        // Server settings
-        if(mapsource == "OBP Service"){
-            server = "norbert-walter.dnshome.de";
-            port = 80;
-        }
-        else if(mapsource == "Local Service"){
-            server = String(ipAddress);
-            port = localPort;
-        }
-        else{
-            server = "norbert-walter.dnshome.de";
-            port = 80;
-        }
-
-        // Type of navigation map
-        if(mapType == "Open Street Map"){
-            mType = 1;  // Map type
-            dType = 1;  // Dithering type
-        }
-        else if(mapType == "Google Street"){
-            mType = 3;
-            dType = 2;
-        }
-        else if(mapType == "Open Topo Map"){
-            mType = 5;
-            dType = 2;
-        }
-        else if(mapType == "Stadimaps Toner"){
-            mType = 7;
-            dType = 1;
-        }
-        else if(mapType == "Free Nautical Chart"){
-            mType = 9;
-            dType = 1;
-        }
-        else{
-            mType = 1;
-            dType = 1;
-        }
-
-        // Map grid on/off
-        if(grid == true){
-            mapGrid = 1;
-        }
-        else{
-            mapGrid = 0;
-        }
-
-        // Map orientation
-        if(orientation == "North Direction"){
-            mapRot = 0;
-            // If true heading available then use HDT oterwise HDM
-            if(valid3 == true){
-                symbolRot = trueHeading;
-            }
-            else{
-                symbolRot = magneticHeading;
-            }
-        }
-        else if(orientation == "Travel Direction"){
-            // If true heading available then use HDT oterwise HDM
-            if(valid3 == true){
-                mapRot = trueHeading;
-                symbolRot = trueHeading;
-            }
-            else{
-                mapRot = magneticHeading;
-                symbolRot = magneticHeading;
-            }
-        }
-        else{
-            mapRot = 0;
-            // If true heading available then use HDT oterwise HDM
-            if(valid3 == true){
-                symbolRot = trueHeading;
-            }
-            else{
-                symbolRot = magneticHeading;
-            }
-        }
-
-        // Load navigation map
-        //***********************************************************
-
-        // URL to OBP Maps Converter
-        // For more details see: https://github.com/norbert-walter/maps-converter
-        String url = String("http://") + server + ":" + port +  // OBP Server
-                    String("/get_image_json?") +               // Service: Output B&W picture as JSON (Base64 + gzip)
-                    "zoom=" + zoom +   // Default zoom level: 15
-                    "&lat=" + String(latitude, 6) +   // Latitude
-                    "&lon=" + String(longitude, 6) +  // Longitude
-                    "&mrot=" + mapRot + // Rotation angle navigation map in degree
-                    "&mtype=" + mType + // Default Map: Open Street Map
-                    "&dtype=" + dType + // Dithering type: Atkinson dithering
-                    "&width=400" +     // With navigation map
-                    "&height=250" +    // Height navigation map
-                    "&cutout=0" +      // No picture cutouts
-                    "&tab=0" +         // No tab size
-                    "&border=2" +      // Border line size: 2 pixel
-                    "&symbol=2" +      // Symbol: Triangle
-                    "&srot=" + symbolRot + // Symbol rotation angle
-                    "&ssize=15" +      // Symbole size: 15 pixel
-                    "&grid=" + mapGrid // Show grid: On
-                    ;         
-        
-        // Draw page
-        //***********************************************************
-
-        // ############### Draw Navigation Map ################
-        
-        // Set display in partial refresh mode
-        getdisplay().setPartialWindow(0, 0, getdisplay().width(), getdisplay().height()); // Set partial update
-        getdisplay().setTextColor(commonData->fgcolor);
-
-        // If a network connection to URL then load the navigation map
-        if (net.fetchAndDecompressJson(url)) {
-
-            auto& json = net.json();                // Extract JSON content
-            int numPix = json["number_pixels"] | 0; // Read number of pixels
-            imgWidth = json["width"] | 0;           // Read width of image
-            imgHeight = json["height"] | 0;         // Read height og image
-
-            const char* b64src = json["picture_base64"].as<const char*>();  // Read picture as Base64 content
-            size_t b64len = strlen(b64src);                                 // Calculate length of Base64 content
-            // Copy Base64 content in PSRAM
-            char* b64 = (char*) heap_caps_malloc(b64len + 1, MALLOC_CAP_SPIRAM);    // Allcate PSRAM for Base64 content
-            if (!b64) {
-                LOG_DEBUG(GwLog::ERROR,"Error PageNavigation: PSRAM alloc base64 failed");
-                return PAGE_UPDATE;
-            }
-            memcpy(b64, b64src, b64len + 1);    // Copy Base64 content in PSRAM
-
-            // Set image buffer in PSRAM
-            //size_t imgSize = getdisplay().width() * getdisplay().height();
-            size_t imgSize = numPix;    // Calculate image size
-            uint8_t* imageData = (uint8_t*) heap_caps_malloc(imgSize, MALLOC_CAP_SPIRAM);           // Allocate PSRAM for image
-            if (!imageData) {
-                LOG_DEBUG(GwLog::ERROR,"Error PageNavigation: PPSRAM alloc image buffer failed");
-                free(b64);
-                return PAGE_UPDATE;
-            }
-
-            // Decode Base64 content to image
-            size_t decodedSize = 0;
-            decoder.decodeBase64(b64, imageData, imgSize, decodedSize);
-
-            // Copy actual navigation man to ackup map
-            imageBackupWidth  = imgWidth;
-            imageBackupHeight = imgHeight;
-            imageBackupSize   = imgSize;
-            if (decodedSize > 0) {
-                memcpy(imageBackupData, imageData, decodedSize);
-                imageBackupSize = decodedSize;
-            }
-            hasImageBackup = true;
-            lostCounter = 0;
-
-            // Show image (navigation map)
-            getdisplay().drawBitmap(0, 25, imageData, imgWidth, imgHeight, commonData->fgcolor);
-
-            // Clean PSRAM
-            free(b64);
-            free(imageData);
-        }
-        // If no network connection then use backup navigation map
-        else{
-            // Show backup image (backup navigation map)
-            if (hasImageBackup) {
-                getdisplay().drawBitmap(0, 25, imageBackupData, imageBackupWidth, imageBackupHeight, commonData->fgcolor);
-            }    
-
-            // Show info: Connection lost when 5 page refreshes has a connection lost to the map server
-            // Short connection losts are uncritical
-            if(lostCounter >= 5){
-                getdisplay().setFont(&Ubuntu_Bold12pt8b);
-                getdisplay().fillRect(200, 250 , 200, 25, commonData->fgcolor); // Black rect
-                getdisplay().fillRect(202, 252 , 196, 21, commonData->bgcolor); // White rect
-                getdisplay().setCursor(210, 270);
-                getdisplay().print("Map server lost");
-            }
-
-            lostCounter++; // Increment lost counter
-        }
-
-
-        // ############### Draw Values ################
-        getdisplay().setFont(&Ubuntu_Bold12pt8b);
-
-        // Show zoom level
-        getdisplay().fillRect(355, 25 , 45, 25, commonData->fgcolor);   // Black rect
-        getdisplay().fillRect(357, 27 , 41, 21, commonData->bgcolor);   // White rect
-        getdisplay().setCursor(364, 45);
-        getdisplay().print(zoom);
-        // If true heading available then use HDT oterwise HDM
-        if(showValues == true){
-            // Frame
-            getdisplay().fillRect(0, 25 , 130, 65, commonData->fgcolor);   // Black rect
-            getdisplay().fillRect(2, 27 , 126, 61, commonData->bgcolor);   // White rect
-            if(valid3 == true){
-                // HDT
-                getdisplay().setCursor(10, 45);
-                getdisplay().print(name3);
-                getdisplay().setCursor(70, 45);
-                getdisplay().print(svalue3);
-            }
-            else{
-                // HDM
-                getdisplay().setCursor(10, 45);
-                getdisplay().print(name4);
-                getdisplay().setCursor(70, 45);
-                getdisplay().print(svalue4);
-            }
-            // SOG
-            getdisplay().setCursor(10, 65);
-            getdisplay().print(name5);
-            getdisplay().setCursor(70, 65);
-            getdisplay().print(svalue5);
-            // DBT
-            getdisplay().setCursor(10, 85);
-            getdisplay().print(name6);
-            getdisplay().setCursor(70, 85);
-            getdisplay().print(svalue6);
-        }
-        
-        return PAGE_UPDATE;
-    };
-};
-
-static Page *createPage(CommonData &common){
-    return new PageNavigation(common);
-}/**
- * with the code below we make this page known to the PageTask
- * we give it a type (name) that can be selected in the config
- * we define which function is to be called
- * and we provide the number of user parameters we expect
- * this will be number of BoatValue pointers in pageData.values
- */
-PageDescription registerPageNavigation(
-    "Navigation",       // Page name
-    createPage,         // Action
-    0,                  // Number of bus values depends on selection in Web configuration
-    {"LAT","LON","HDT","HDM","SOG","DBT"},  // Bus values we need in the page
-    true                // Show display header on/off
-);
-
-#endif

lib/obp60task/PageOneValue.cpp

@@ -2,260 +2,49 @@
 
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
-#include "OBPDataOperations.h"
-#include "OBPcharts.h"
+#include "BoatDataCalibration.h"
 
-class PageOneValue : public Page {
-private:
-    GwLog* logger;
-
-    enum PageMode {
-        VALUE,
-        BOTH,
-        CHART
-    };
-    enum DisplayMode {
-        FULL,
-        HALF
-    };
-
-    static constexpr char HORIZONTAL = 'H';
-    static constexpr char VERTICAL = 'V';
-    static constexpr int8_t FULL_SIZE = 0;
-    static constexpr int8_t HALF_SIZE_TOP = 1;
-    static constexpr int8_t HALF_SIZE_BOTTOM = 2;
-
-    static constexpr bool PRNT_NAME = true;
-    static constexpr bool NO_PRNT_NAME = false;
-    static constexpr bool PRNT_VALUE = true;
-    static constexpr bool NO_PRNT_VALUE = false;
-
-    int width; // Screen width
-    int height; // Screen height
-
-    bool keylock = false; // Keylock
-    PageMode pageMode = VALUE; // Page display mode
-    int8_t dataIntv = 1; // Update interval for wind history chart:
-                         // (1)|(2)|(3)|(4)|(8) x 240 seconds for 4, 8, 12, 16, 32 min. history chart
-
-    // String lengthformat;
-    bool useSimuData;
-    bool holdValues;
-    String flashLED;
-    String backlightMode;
-    String tempFormat;
-
-    // Old values for hold function
-    String sValue1Old = "";
-    String unit1Old = "";
-
-    // Data buffer pointer (owned by HstryBuffers)
-    RingBuffer<uint16_t>* dataHstryBuf = nullptr;
-    std::unique_ptr<Chart> dataChart; // Chart object
-
-    // display data value in display <mode> [FULL|HALF]
-    void showData(GwApi::BoatValue* bValue1, DisplayMode mode)
+class PageOneValue : public Page
 {
-        int nameXoff, nameYoff, unitXoff, unitYoff, value1Xoff, value1Yoff;
-        const GFXfont *nameFnt, *unitFnt, *valueFnt1, *valueFnt2, *valueFnt3;
-
-        if (mode == FULL) { // full size data display
-            nameXoff = 0;
-            nameYoff = 0;
-            nameFnt = &Ubuntu_Bold32pt8b;
-            unitXoff = 0;
-            unitYoff = 0;
-            unitFnt = &Ubuntu_Bold20pt8b;
-            value1Xoff = 0;
-            value1Yoff = 0;
-            valueFnt1 = &Ubuntu_Bold20pt8b;
-            valueFnt2 = &Ubuntu_Bold32pt8b;
-            valueFnt3 = &DSEG7Classic_BoldItalic60pt7b;
-        } else { // half size data and chart display
-            nameXoff = -10;
-            nameYoff = -34;
-            nameFnt = &Ubuntu_Bold20pt8b;
-            unitXoff = -295;
-            unitYoff = -119;
-            unitFnt = &Ubuntu_Bold12pt8b;
-            valueFnt1 = &Ubuntu_Bold12pt8b;
-            value1Xoff = 153;
-            value1Yoff = -119;
-            valueFnt2 = &Ubuntu_Bold20pt8b;
-            valueFnt3 = &DSEG7Classic_BoldItalic42pt7b;
-        }
-
-        String name1 = xdrDelete(bValue1->getName()); // Value name
-        name1 = name1.substring(0, 6); // String length limit for value name
-        double value1 = bValue1->value; // Value as double in SI unit
-        bool valid1 = bValue1->valid; // Valid information
-        String sValue1 = formatValue(bValue1, *commonData).svalue; // Formatted value as string including unit conversion and switching decimal places
-        String unit1 = formatValue(bValue1, *commonData).unit; // Unit of value
-
-        // Show name
-        getdisplay().setTextColor(commonData->fgcolor);
-        getdisplay().setFont(nameFnt);
-        getdisplay().setCursor(20 + nameXoff, 100 + nameYoff);
-        getdisplay().print(name1); // name
-
-        // Show unit
-        getdisplay().setFont(unitFnt);
-        getdisplay().setCursor(305 + unitXoff, 240 + unitYoff);
-
-        if (holdValues) {
-            getdisplay().print(unit1Old); // name
-        } else {
-            getdisplay().print(unit1); // name
-        }
-
-        // Switch font depending on value format and adjust position
-        if (bValue1->getFormat() == "formatLatitude" || bValue1->getFormat() == "formatLongitude") {
-            getdisplay().setFont(valueFnt1);
-            getdisplay().setCursor(20 + value1Xoff, 180 + value1Yoff);
-        } else if (bValue1->getFormat() == "formatTime" || bValue1->getFormat() == "formatDate") {
-            getdisplay().setFont(valueFnt2);
-            getdisplay().setCursor(20 + value1Xoff, 200 + value1Yoff);
-        } else {
-            getdisplay().setFont(valueFnt3);
-            getdisplay().setCursor(20 + value1Xoff, 240 + value1Yoff);
-        }
-
-        // Show bus data
-        if (!holdValues || useSimuData) {
-            getdisplay().print(sValue1); // Real value as formated string
-        } else {
-            getdisplay().print(sValue1Old); // Old value as formated string
-        }
-
-        if (valid1 == true) {
-            sValue1Old = sValue1; // Save the old value
-            unit1Old = unit1; // Save the old unit
-        }
-    }
-
     public:
-    PageOneValue(CommonData& common)
-    {
+    PageOneValue(CommonData &common){
         commonData = &common;
-        logger = commonData->logger;
-        LOG_DEBUG(GwLog::LOG, "Instantiate PageOneValue");
-
-        width = getdisplay().width(); // Screen width
-        height = getdisplay().height(); // Screen height
-
-        // Get config data
-        // lengthformat = commonData->config->getString(commonData->config->lengthFormat);
-        useSimuData = commonData->config->getBool(commonData->config->useSimuData);
-        holdValues = commonData->config->getBool(commonData->config->holdvalues);
-        flashLED = commonData->config->getString(commonData->config->flashLED);
-        backlightMode = commonData->config->getString(commonData->config->backlight);
-        tempFormat = commonData->config->getString(commonData->config->tempFormat); // [K|°C|°F]
+        common.logger->logDebug(GwLog::LOG,"Instantiate PageOneValue");
     }
 
-    virtual void setupKeys()
-    {
-        Page::setupKeys();
-
-#if defined BOARD_OBP60S3
-        constexpr int ZOOM_KEY = 4;
-#elif defined BOARD_OBP40S3
-        constexpr int ZOOM_KEY = 1;
-#endif
-
-        if (dataHstryBuf) { // show "Mode" key only if chart supported boat data type is available
-            commonData->keydata[0].label = "MODE";
-            commonData->keydata[ZOOM_KEY].label = "ZOOM";
-        } else {
-            commonData->keydata[0].label = "";
-            commonData->keydata[ZOOM_KEY].label = "";
-        }
-    }
-
-    // Key functions
-    virtual int handleKey(int key)
-    {
-        if (dataHstryBuf) { // if boat data type supports charts
-
-            // Set page mode: value | value/half chart | full chart
-            if (key == 1) {
-                switch (pageMode) {
-                case VALUE:
-                    pageMode = BOTH;
-                    break;
-                case BOTH:
-                    pageMode = CHART;
-                    break;
-                case CHART:
-                    pageMode = VALUE;
-                    break;
-                }
-                return 0; // Commit the key
-            }
-
-            // Set time frame to show for history chart
-#if defined BOARD_OBP60S3
-            if (key == 5) {
-#elif defined BOARD_OBP40S3
-            if (key == 2) {
-#endif
-                if (dataIntv == 1) {
-                    dataIntv = 2;
-                } else if (dataIntv == 2) {
-                    dataIntv = 3;
-                } else if (dataIntv == 3) {
-                    dataIntv = 4;
-                } else if (dataIntv == 4) {
-                    dataIntv = 8;
-                } else {
-                    dataIntv = 1;
-                }
-                return 0; // Commit the key
-            }
-        }
-
-        // Keylock function
-        if (key == 11) { // Code for keylock
+    virtual int handleKey(int key){
+        // Code for keylock
+        if(key == 11){
             commonData->keylock = !commonData->keylock;
             return 0;                   // Commit the key
         }
         return key;
     }
 
-    virtual void displayNew(PageData& pageData)
-    {
-#ifdef BOARD_OBP60S3
-        // Clear optical warning
-        if (flashLED == "Limit Violation") {
-            setBlinkingLED(false);
-            setFlashLED(false);
-        }
-#endif
-        // buffer initialization will fail, if page is default page, because <displayNew> is not executed at system start for default page
-        if (!dataChart) { // Create chart objects if they don't exist
+    int displayPage(PageData &pageData){
+        GwConfigHandler *config = commonData->config;
+        GwLog *logger = commonData->logger;
 
-            GwApi::BoatValue* bValue1 = pageData.values[0]; // Page boat data element
-            String bValName1 = bValue1->getName(); // Value name
-            String bValFormat = bValue1->getFormat(); // Value format
+        // Old values for hold function
+        static String svalue1old = "";
+        static String unit1old = "";
 
-            dataHstryBuf = pageData.hstryBuffers->getBuffer(bValName1);
+        // Get config data
+        String lengthformat = config->getString(config->lengthFormat);
+        // bool simulation = config->getBool(config->useSimuData);
+        bool holdvalues = config->getBool(config->holdvalues);
+        String flashLED = config->getString(config->flashLED);
+        String backlightMode = config->getString(config->backlight);
         
-            if (dataHstryBuf) {
-                dataChart.reset(new Chart(*dataHstryBuf, Chart::dfltChrtDta[bValFormat].range, *commonData, useSimuData));
-                LOG_DEBUG(GwLog::DEBUG, "PageOneValue: Created chart objects for %s", bValName1);
-            } else {
-                LOG_DEBUG(GwLog::DEBUG, "PageOneValue: No chart objects available for %s", bValName1);
-            }
-        }
-
-        setupKeys(); // adjust <mode> key depending on chart supported boat data type
-    }
-
-    int displayPage(PageData& pageData)
-    {
-        LOG_DEBUG(GwLog::LOG, "Display PageOneValue");
-
-        // Get boat value for page
-        GwApi::BoatValue* bValue1 = pageData.values[0]; // Page boat data element
+        // Get boat values
+        GwApi::BoatValue *bvalue1 = pageData.values[0]; // First element in list (only one value by PageOneValue)
+        String name1 = xdrDelete(bvalue1->getName());   // Value name
+        name1 = name1.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue1, logger); // Check if boat data value is to be calibrated
+        double value1 = bvalue1->value;                 // Value as double in SI unit
+        bool valid1 = bvalue1->valid;                   // Valid information
+        String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
+        String unit1 = formatValue(bvalue1, *commonData).unit;        // Unit of value
 
         // Optical warning by limit violation (unused)
         if(String(flashLED) == "Limit Violation"){
@@ -263,38 +52,63 @@ public:
             setFlashLED(false); 
         }
 
-        if (bValue1 == NULL)
-            return PAGE_OK; // no data, no page to display
-
-        LOG_DEBUG(GwLog::DEBUG, "PageOneValue: printing %s, %.3f", bValue1->getName().c_str(), bValue1->value);
+        // Logging boat values
+        if (bvalue1 == NULL) return PAGE_OK; // WTF why this statement?
+        LOG_DEBUG(GwLog::LOG,"Drawing at PageOneValue, %s: %f", name1.c_str(), value1);
 
         // Draw page
         //***********************************************************
 
-        getdisplay().setPartialWindow(0, 0, width, height); // Set partial update
+        /// Set display in partial refresh mode
+        getdisplay().setPartialWindow(0, 0, getdisplay().width(), getdisplay().height()); // Set partial update
 
-        if (pageMode == VALUE || dataHstryBuf == nullptr) {
-            // show only data value; ignore other pageMode options if no chart supported boat data history buffer is available
-            showData(bValue1, FULL);
+        // Show name
+        getdisplay().setTextColor(commonData->fgcolor);
+        getdisplay().setFont(&Ubuntu_Bold32pt8b);
+        getdisplay().setCursor(20, 100);
+        getdisplay().print(name1);                           // Page name
 
-        } else if (pageMode == CHART) { // show only data chart
-            if (dataChart) {
-                dataChart->showChrt(HORIZONTAL, FULL_SIZE, dataIntv, PRNT_NAME, PRNT_VALUE, *bValue1);
+        // Show unit
+        getdisplay().setFont(&Ubuntu_Bold20pt8b);
+        getdisplay().setCursor(270, 100);
+        if(holdvalues == false){
+            getdisplay().print(unit1);                       // Unit
+        }
+        else{
+            getdisplay().print(unit1old);
         }
 
-        } else if (pageMode == BOTH) { // show data value and chart
-            showData(bValue1, HALF);
-            if (dataChart) {
-                dataChart->showChrt(HORIZONTAL, HALF_SIZE_BOTTOM, dataIntv, NO_PRNT_NAME, NO_PRNT_VALUE, *bValue1);
+        // Switch font if format for any values
+        if(bvalue1->getFormat() == "formatLatitude" || bvalue1->getFormat() == "formatLongitude"){
+            getdisplay().setFont(&Ubuntu_Bold20pt8b);
+            getdisplay().setCursor(20, 180);
         }
+        else if(bvalue1->getFormat() == "formatTime" || bvalue1->getFormat() == "formatDate"){
+            getdisplay().setFont(&Ubuntu_Bold32pt8b);
+            getdisplay().setCursor(20, 200);
+        }
+        else{
+            getdisplay().setFont(&DSEG7Classic_BoldItalic60pt7b);
+            getdisplay().setCursor(20, 240);
+        }
+
+        // Show bus data
+        if(holdvalues == false){
+            getdisplay().print(svalue1);                                     // Real value as formated string
+        }
+        else{
+            getdisplay().print(svalue1old);                                  // Old value as formated string
+        }
+        if(valid1 == true){
+            svalue1old = svalue1;                                       // Save the old value
+            unit1old = unit1;                                           // Save the old unit
         }
 
         return PAGE_UPDATE;
     };
 };
 
-static Page* createPage(CommonData& common)
-{
+static Page* createPage(CommonData &common){
     return new PageOneValue(common);
 }
 

lib/obp60task/PageRudderPosition.cpp

@@ -2,6 +2,7 @@
 
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
+#include "BoatDataCalibration.h"
 
 class PageRudderPosition : public Page
 {
@@ -40,6 +41,7 @@ public:
         GwApi::BoatValue *bvalue1 = pageData.values[0]; // First element in list
         String name1 = bvalue1->getName().c_str();      // Value name
         name1 = name1.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue1, logger); // Check if boat data value is to be calibrated
         value1 = bvalue1->value;                        // Raw value without unit convertion
         bool valid1 = bvalue1->valid;                   // Valid information 
         String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places

lib/obp60task/PageSixValues.cpp

@@ -2,6 +2,7 @@
 
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
+#include "BoatDataCalibration.h"
 
 const int SixValues_x1 = 5;
 const int SixValues_DeltaX = 200;
@@ -56,6 +57,7 @@ class PageSixValues : public Page
                 bvalue = pageData.values[i];
                 DataName[i] = xdrDelete(bvalue->getName());
                 DataName[i] = DataName[i].substring(0, 6);                  // String length limit for value name
+                calibrationData.calibrateInstance(bvalue, logger);          // Check if boat data value is to be calibrated
                 DataValue[i] = bvalue->value;                 // Value as double in SI unit
                 DataValid[i] = bvalue->valid;
                 DataText[i] = formatValue(bvalue, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places

lib/obp60task/PageSkyView.cpp

@@ -1,204 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-#if defined BOARD_OBP60S3 || defined BOARD_OBP40S3
-
-#include "Pagedata.h"
-#include "OBP60Extensions.h"
-
-#include <vector>
-#include <algorithm> // for vector sorting
-
-/*
- * SkyView / Satellites
- */
-
-class PageSkyView : public Page
-{
-private:
-    String flashLED;
-    GwBoatData *bd;
-
-public:
-    PageSkyView(CommonData &common)
-    {
-        commonData = &common;
-
-        // task name access is for example purpose only
-        TaskHandle_t currentTaskHandle = xTaskGetCurrentTaskHandle();
-        const char* taskName = pcTaskGetName(currentTaskHandle);
-        common.logger->logDebug(GwLog::LOG, "Instantiate PageSkyView in task '%s'", taskName);
-
-        flashLED = common.config->getString(common.config->flashLED);
-    }
-
-    int handleKey(int key) {
-        // return 0 to mark the key handled completely
-        // return the key to allow further action
-        if (key == 11) {
-            commonData->keylock = !commonData->keylock;
-            return 0;
-        }
-        return key;
-    }
-
-    void displayNew(PageData &pageData) {
-#ifdef BOARD_OBP60S3
-        // Clear optical warning
-        if (flashLED == "Limit Violation") {
-            setBlinkingLED(false);
-            setFlashLED(false);
-        }
-#endif
-        bd = pageData.api->getBoatData();
-    };
-
-    // Comparator function to sort by SNR
-    static bool compareBySNR(const GwSatInfo& a, const GwSatInfo& b) {
-       return a.SNR > b.SNR; // Sort in descending order
-    }
-
-    int displayPage(PageData &pageData) {
-        GwLog *logger = commonData->logger;
-
-        std::vector<GwSatInfo> sats;
-        int nSat = bd->SatInfo->getNumSats();
-
-        logger->logDebug(GwLog::LOG, "Drawing at PageSkyView, %d satellites", nSat);
-
-        for (int i = 0; i < nSat; i++) {
-            sats.push_back(*bd->SatInfo->getAt(i));
-        }
-        std::sort(sats.begin(), sats.end(), compareBySNR);
-
-        // Draw page
-        //***********************************************************
-
-        // Set display in partial refresh mode
-        getdisplay().setPartialWindow(0, 0, getdisplay().width(), getdisplay().height()); // Set partial update
-
-        // current position
-        getdisplay().setFont(&Ubuntu_Bold8pt8b);
-
-        // sky view
-        Point c = {130, 148};
-        uint16_t r = 120;
-        uint16_t r1 = r / 2;
-
-        getdisplay().fillCircle(c.x, c.y, r + 2, commonData->fgcolor);
-        getdisplay().fillCircle(c.x, c.y, r - 1, commonData->bgcolor);
-        getdisplay().drawCircle(c.x, c.y, r1, commonData->fgcolor);
-
-        // separation lines
-        getdisplay().drawLine(c.x - r, c.y, c.x + r, c.y, commonData->fgcolor);
-        getdisplay().drawLine(c.x, c.y - r, c.x, c.y + r, commonData->fgcolor);
-        Point p = {c.x, c.y - r};
-        Point p1, p2;
-        p1 = rotatePoint(c, p, 45);
-        p2 = rotatePoint(c, p, 45 + 180);
-        getdisplay().drawLine(p1.x, p1.y, p2.x, p2.y,  commonData->fgcolor);
-        p1 = rotatePoint(c, p, -45);
-        p2 = rotatePoint(c, p, -45 + 180);
-        getdisplay().drawLine(p1.x, p1.y, p2.x, p2.y, commonData->fgcolor);
-
-        // directions 
-
-        int16_t x1, y1;
-        uint16_t w, h;
-        getdisplay().setFont(&Ubuntu_Bold12pt8b);
-
-		getdisplay().getTextBounds("N", 0, 150, &x1, &y1, &w, &h);
-        getdisplay().setCursor(c.x - w / 2, c.y - r + h + 3);
-        getdisplay().print("N");
-
-		getdisplay().getTextBounds("S", 0, 150, &x1, &y1, &w, &h);
-        getdisplay().setCursor(c.x - w / 2, c.y + r - 3);
-        getdisplay().print("S");
-
-		getdisplay().getTextBounds("E", 0, 150, &x1, &y1, &w, &h);
-        getdisplay().setCursor(c.x + r - w - 3, c.y + h / 2);
-        getdisplay().print("E");
-        
-		getdisplay().getTextBounds("W", 0, 150, &x1, &y1, &w, &h);
-        getdisplay().setCursor(c.x - r + 3 , c.y + h / 2);
-        getdisplay().print("W");
-
-        // show satellites in "map"
-        getdisplay().setFont(&IBM8x8px);
-        for (int i = 0; i < nSat; i++) {
-            float arad = (sats[i].Azimut * M_PI / 180.0) + M_PI;
-            float erad = sats[i].Elevation * M_PI / 180.0;
-            uint16_t x = c.x + sin(arad) * erad * r1;
-            uint16_t y = c.y + cos(arad) * erad * r1;
-            getdisplay().fillRect(x-4, y-4, 8, 8, commonData->fgcolor);
-            getdisplay().setCursor(x-7, y+12);
-            getdisplay().printf("%02d", static_cast<int>(sats[i].PRN));
-        }
-
-        // Signal / Noise bars
-        getdisplay().setFont(&Ubuntu_Bold8pt8b);
-        getdisplay().setCursor(325, 34);
-        getdisplay().print("SNR");
-//        getdisplay().drawRect(270, 20, 125, 257, commonData->fgcolor);
-        int maxsat = std::min(nSat, 12);
-        for (int i = 0; i < maxsat; i++) {
-            uint16_t y = 29 + (i + 1) * 20;
-            getdisplay().setCursor(276, y);
-            char buffer[3];
-            snprintf(buffer, 3, "%02d", static_cast<int>(sats[i].PRN));
-            getdisplay().print(String(buffer));
-            getdisplay().drawRect(305, y-12, 85, 14, commonData->fgcolor);
-            getdisplay().setCursor(315, y);
-            // TODO SNR as number or as bar via mode key?
-            if (sats[i].SNR <= 100) {
-                // getdisplay().print(sats[i].SNR);
-                getdisplay().fillRect(307, y-10, int(81 * sats[i].SNR / 100.0), 10, commonData->fgcolor);
-            } else {
-                getdisplay().print("n/a");
-            }
-        }
-
-        // Show SatInfo and HDOP
-        getdisplay().setFont(&Ubuntu_Bold8pt8b);
-
-        getdisplay().setCursor(220, 34);
-        getdisplay().print("Sat:");
-
-        GwApi::BoatValue *bv_satinfo = pageData.values[0]; // SatInfo
-        String sval_satinfo = formatValue(bv_satinfo, *commonData).svalue;
-        getdisplay().setCursor(220, 49);
-        getdisplay().print(sval_satinfo);
-        
-        getdisplay().setCursor(220, 254);
-        getdisplay().print("HDOP:");
-
-        GwApi::BoatValue *bv_hdop = pageData.values[1]; // HDOP
-        double hdop = formatValue(bv_hdop, *commonData).value * 4; // 4 is factor for UERE (translation in meter)
-        char sval_hdop[20];
-        dtostrf(hdop, 0, 1, sval_hdop);  // Only one prefix
-        strcat(sval_hdop, "m");
-        getdisplay().setCursor(220, 269);
-        getdisplay().print(sval_hdop);
-
-        return PAGE_UPDATE;
-    };
-};
-
-static Page* createPage(CommonData &common){
-    return new PageSkyView(common);
-}
-
-/**
- * with the code below we make this page known to the PageTask
- * we give it a type (name) that can be selected in the config
- * we define which function is to be called
- * and we provide the number of user parameters we expect
- * this will be number of BoatValue pointers in pageData.values
- */
-PageDescription registerPageSkyView(
-    "SkyView",              // Page name
-    createPage,             // Action
-    0,                      // Number of bus values depends on selection in Web configuration
-    {"SatInfo", "HDOP"},    // Bus values we need in the page
-    true                    // Show display header on/off
-);
-
-#endif

lib/obp60task/PageSystem.cpp

@@ -1,15 +1,5 @@
 #if defined BOARD_OBP60S3 || defined BOARD_OBP40S3
 
-/*
- * Special system page, called directly with fast key sequence 5,4
- * Out of normal page order.
- * Consists of some sub-pages with following content:
- *   1. Hard and software information
- *   2. System settings
- *   3. NMEA2000 device list
- *   4. SD Card information if available
- */
-
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
 #include "images/logo64.xbm"
@@ -17,7 +7,8 @@
 #include "qrcode.h"
 
 #ifdef BOARD_OBP40S3
-#include "dirent.h"
+#include <SD.h>
+#include <FS.h>
 #endif
 
 #define STRINGIZE_IMPL(x) #x
@@ -28,12 +19,20 @@
 #define DISPLAYINFO STRINGIZE(EPDTYPE)
 #define GXEPD2INFO STRINGIZE(GXEPD2VERS)
 
+/*
+ * Special system page, called directly with fast key sequence 5,4
+ * Out of normal page order.
+ * Consists of some sub-pages with following content:
+ *   1. Hard and software information
+ *   2. System settings
+ *   3. NMEA2000 device list
+ */
+
 class PageSystem : public Page
 {
-private:
 uint64_t chipid;
 bool simulation;
-    bool use_sdcard;
+bool sdcard;
 String buzzer_mode;
 uint8_t buzzer_power;
 String cpuspeed;
@@ -56,12 +55,11 @@ public:
         common.logger->logDebug(GwLog::LOG,"Instantiate PageSystem");
         if (hasFRAM) {
             mode = fram.read(FRAM_SYSTEM_MODE);
-            common.logger->logDebug(GwLog::DEBUG, "Loaded mode '%c' from FRAM", mode);
         }
         chipid = ESP.getEfuseMac();
         simulation = common.config->getBool(common.config->useSimuData);
 #ifdef BOARD_OBP40S3
-        use_sdcard = common.config->getBool(common.config->useSDCard);
+        sdcard = common.config->getBool(common.config->useSDCard);
 #endif
         buzzer_mode = common.config->getString(common.config->buzzerMode);
         buzzer_mode.toLowerCase();
@@ -78,7 +76,7 @@ public:
         homelon = common.config->getString(common.config->homeLON).toDouble();
     }
 
-    void setupKeys() {
+    virtual void setupKeys(){
         commonData->keydata[0].label = "EXIT";
         commonData->keydata[1].label = "MODE";
         commonData->keydata[2].label = "";
@@ -87,7 +85,7 @@ public:
         commonData->keydata[5].label = "ILUM";
     }
 
-    int handleKey(int key) {
+    virtual int handleKey(int key){
         // do *NOT* handle key #1 this handled by obp60task as exit
         // Switch display mode
         commonData->logger->logDebug(GwLog::LOG, "System keyboard handler");
@@ -97,7 +95,7 @@ public:
             } else if (mode == 'S') {
                 mode = 'D';
             } else if (mode == 'D') {
-                if (hasSDCard) {
+                if (sdcard) {
                     mode = 'C';
                 } else {
                     mode = 'N';
@@ -119,7 +117,6 @@ public:
         }
         // standby / deep sleep
         if (key == 5) {
-            commonData->logger->logDebug(GwLog::LOG, "System going into deep sleep mode...");
            deepSleep(*commonData);
         }
         // Code for keylock
@@ -135,7 +132,6 @@ public:
         }
         // standby / deep sleep
         if (key == 12) {
-            commonData->logger->logDebug(GwLog::LOG, "System going into deep sleep mode...");
             deepSleep(*commonData);
         }
 #endif
@@ -182,7 +178,7 @@ public:
         }
 
         // Logging boat values
-        logger->logDebug(GwLog::LOG, "Drawing at PageSystem, Mode=%c", mode);
+        LOG_DEBUG(GwLog::LOG,"Drawing at PageSystem");
 
         // Draw page
         //***********************************************************
@@ -261,37 +257,14 @@ public:
             getdisplay().setCursor(8, y0 + 48);
             getdisplay().print("SD-Card:");
             getdisplay().setCursor(90, y0 + 48);
-            if (hasSDCard) {
-                uint64_t cardsize = ((uint64_t) sdcard->csd.capacity) * sdcard->csd.sector_size / (1024 * 1024);
-                getdisplay().printf("%llu MB", cardsize);
+            if (sdcard) {
+                uint64_t cardsize = SD.cardSize() / (1024 * 1024);
+                getdisplay().print(String(cardsize) + String(" MB"));
             } else {
                 getdisplay().print("off");
             }
 #endif
 
-            // Uptime
-            int64_t uptime = esp_timer_get_time() / 1000000;
-            String uptime_unit;
-            if (uptime < 120) {
-                uptime_unit = " seconds";
-            } else {
-                if (uptime < 2 * 3600) {
-                    uptime /= 60;
-                    uptime_unit = " minutes";
-                } else if (uptime < 2 * 3600 * 24) {
-                    uptime /= 3600;
-                    uptime_unit = " hours";
-                } else {
-                    uptime /= 86400;
-                    uptime_unit = " days";
-                }
-            }
-            getdisplay().setCursor(8, y0 + 80);
-            getdisplay().print("Uptime:");
-            getdisplay().setCursor(90, y0 + 80);
-            getdisplay().print(uptime);
-            getdisplay().print(uptime_unit);
-
             // CPU speed config / active
             getdisplay().setCursor(202, y0);
             getdisplay().print("CPU speed:");
@@ -398,61 +371,8 @@ public:
             x0 = 20;
             y0 = 72;
             getdisplay().setCursor(x0, y0);
-#ifdef BOARD_OBP60S3
-            // This mode should not be callable by devices without card hardware
-            // In case of accidential reaching this, display a friendly message
-            getdisplay().print("This mode is not indended to be reached!\n");
-            getdisplay().print("There's nothing to see here. Move on.");
-#endif
-#ifdef BOARD_OBP40S3
             getdisplay().print("Work in progress...");
 
-            /* TODO
-               this code should go somewhere else. only for testing purposes here
-               identify card as OBP-Card:
-                 magic.dat
-                 version.dat
-                 readme.txt
-                 IMAGES/
-                 CHARTS/
-                 LOGS/
-                 DATA/
-                hint: file access with fopen, fgets, fread, fclose
-            */
-
-            // Simple test for magic file in root
-            getdisplay().setCursor(x0, y0 + 32);
-            String file_magic = MOUNT_POINT "/magic.dat";
-            logger->logDebug(GwLog::LOG, "Test magicfile: %s", file_magic.c_str());
-            struct stat st;
-            if (stat(file_magic.c_str(), &st) == 0) {
-                getdisplay().printf("File %s exists", file_magic.c_str());
-            } else {
-                getdisplay().printf("File %s not found", file_magic.c_str());
-            }
-
-            // Root directory check
-            DIR* dir = opendir(MOUNT_POINT);
-            int dy = 0;
-            if (dir != NULL) {
-                logger->logDebug(GwLog::LOG, "Root directory: %s", MOUNT_POINT);
-                struct dirent* entry;
-                while (((entry = readdir(dir)) != NULL) and (dy < 140)) {
-                    getdisplay().setCursor(x0, y0 + 64 + dy);
-                    getdisplay().print(entry->d_name);
-                    // type 1 is file, type 2 is dir
-                    if (entry->d_type == 2) {
-                        getdisplay().print("/");
-                    }
-                    dy += 20;
-                    logger->logDebug(GwLog::DEBUG, "    %s type %d", entry->d_name, entry->d_type);
-                }
-                closedir(dir);
-            } else {
-                logger->logDebug(GwLog::LOG, "Failed to open root directory");
-            }
-
-#endif
 
         } else {
             // NMEA2000 device list

lib/obp60task/PageThreeValues.cpp

@@ -2,6 +2,7 @@
 
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
+#include "BoatDataCalibration.h"
 
 class PageThreeValues : public Page
 {
@@ -43,6 +44,7 @@ class PageThreeValues : public Page
         GwApi::BoatValue *bvalue1 = pageData.values[0]; // First element in list (only one value by PageOneValue)
         String name1 = xdrDelete(bvalue1->getName());   // Value name
         name1 = name1.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue1, logger); // Check if boat data value is to be calibrated
         double value1 = bvalue1->value;                 // Value as double in SI unit
         bool valid1 = bvalue1->valid;                   // Valid information 
         String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -52,6 +54,7 @@ class PageThreeValues : public Page
         GwApi::BoatValue *bvalue2 = pageData.values[1]; // Second element in list
         String name2 = xdrDelete(bvalue2->getName());   // Value name
         name2 = name2.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue2, logger); // Check if boat data value is to be calibrated
         double value2 = bvalue2->value;                 // Value as double in SI unit
         bool valid2 = bvalue2->valid;                   // Valid information 
         String svalue2 = formatValue(bvalue2, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -61,6 +64,7 @@ class PageThreeValues : public Page
         GwApi::BoatValue *bvalue3 = pageData.values[2]; // Third element in list
         String name3 = xdrDelete(bvalue3->getName());      // Value name
         name3 = name3.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue3, logger); // Check if boat data value is to be calibrated
         double value3 = bvalue3->value;                 // Value as double in SI unit
         bool valid3 = bvalue3->valid;                   // Valid information 
         String svalue3 = formatValue(bvalue3, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places

lib/obp60task/PageTwoValues.cpp

@@ -2,266 +2,61 @@
 
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
-#include "OBPDataOperations.h"
-#include "OBPcharts.h"
+#include "BoatDataCalibration.h"
 
-class PageTwoValues : public Page {
-private:
-    GwLog* logger;
-
-    enum PageMode {
-        VALUES,
-        VAL1_CHART,
-        VAL2_CHART,
-        CHARTS
-    };
-    enum DisplayMode {
-        FULL,
-        HALF
-    };
-
-    static constexpr char HORIZONTAL = 'H';
-    static constexpr char VERTICAL = 'V';
-    static constexpr int8_t FULL_SIZE = 0;
-    static constexpr int8_t HALF_SIZE_TOP = 1;
-    static constexpr int8_t HALF_SIZE_BOTTOM = 2;
-
-    static constexpr bool PRNT_NAME = true;
-    static constexpr bool NO_PRNT_NAME = false;
-    static constexpr bool PRNT_VALUE = true;
-    static constexpr bool NO_PRNT_VALUE = false;
-
-    static constexpr int YOFFSET = 130; // y offset for display of 2nd boat value
-
-    int width; // Screen width
-    int height; // Screen height
-
-    bool keylock = false; // Keylock
-    PageMode pageMode = VALUES; // Page display mode
-    int8_t dataIntv = 1; // Update interval for wind history chart:
-                         // (1)|(2)|(3)|(4)|(8) x 240 seconds for 4, 8, 12, 16, 32 min. history chart
-
-    // String lengthformat;
-    bool useSimuData;
-    bool holdValues;
-    String flashLED;
-    String backlightMode;
-    String tempFormat;
-
-    // Data buffer pointer (owned by HstryBuffers)
-    static constexpr int NUMVALUES = 2; // two data values in this page
-    RingBuffer<uint16_t>* dataHstryBuf[NUMVALUES] = { nullptr };
-    std::unique_ptr<Chart> dataChart[NUMVALUES]; // Chart object
-
-    // Old values for hold function
-    String sValueOld[NUMVALUES] = { "", "" };
-    String unitOld[NUMVALUES] = { "", "" };
-
-    // display data values in display <mode> [FULL|HALF]
-    void showData(const std::vector<GwApi::BoatValue*>& bValue, DisplayMode mode)
+class PageTwoValues : public Page
 {
-        getdisplay().setTextColor(commonData->fgcolor);
-
-        int numValues = bValue.size(); // do we have to handle 1 or 2 values?
-
-        for (int i = 0; i < numValues; i++) {
-            int yOffset = YOFFSET * i;
-            String name = xdrDelete(bValue[i]->getName()); // Value name
-            name = name.substring(0, 6); // String length limit for value name
-            double value = bValue[i]->value; // Value as double in SI unit
-            bool valid = bValue[i]->valid; // Valid information
-            String sValue = formatValue(bValue[i], *commonData).svalue; // Formatted value as string including unit conversion and switching decimal places
-            String unit = formatValue(bValue[i], *commonData).unit; // Unit of value
-
-            // Show name
-            getdisplay().setFont(&Ubuntu_Bold20pt8b);
-            getdisplay().setCursor(20, 75 + yOffset);
-            getdisplay().print(name); // name
-
-            // Show unit
-            getdisplay().setFont(&Ubuntu_Bold12pt8b);
-            getdisplay().setCursor(20, 125 + yOffset);
-
-            if (holdValues) {
-                getdisplay().print(unitOld[i]); // name
-            } else {
-                getdisplay().print(unit); // name
-            }
-
-            // Switch font depending on value format and adjust position
-            if (bValue[i]->getFormat() == "formatLatitude" || bValue[i]->getFormat() == "formatLongitude") {
-                getdisplay().setFont(&Ubuntu_Bold20pt8b);
-                getdisplay().setCursor(50, 125 + yOffset);
-            } else if (bValue[i]->getFormat() == "formatTime" || bValue[i]->getFormat() == "formatDate") {
-                getdisplay().setFont(&Ubuntu_Bold20pt8b);
-                getdisplay().setCursor(170, 105 + yOffset);
-            } else { // Default font for other formats
-                getdisplay().setFont(&DSEG7Classic_BoldItalic42pt7b);
-                getdisplay().setCursor(180, 125 + yOffset);
-            }
-
-            // Show bus data
-            if (!holdValues || useSimuData) {
-                getdisplay().print(sValue); // Real value as formated string
-            } else {
-                getdisplay().print(sValueOld[i]); // Old value as formated string
-            }
-
-            if (valid == true) {
-                sValueOld[i] = sValue; // Save the old value
-                unitOld[i] = unit; // Save the old unit
-            }
-        }
-
-        if (numValues == 2 && mode == FULL) { // print line only, if we want to show 2 data values
-            getdisplay().fillRect(0, 145, width, 3, commonData->fgcolor);             // Horizontal line 3 pix
-        }
-    }
-
     public:
-    PageTwoValues(CommonData& common)
-    {
+    PageTwoValues(CommonData &common){
         commonData = &common;
-        logger = commonData->logger;
-        LOG_DEBUG(GwLog::LOG, "Instantiate PageTwoValues");
-
-        width = getdisplay().width(); // Screen width
-        height = getdisplay().height(); // Screen height
-
-        // Get config data
-        // lengthformat = commonData->config->getString(commonData->config->lengthFormat);
-        useSimuData = commonData->config->getBool(commonData->config->useSimuData);
-        holdValues = commonData->config->getBool(commonData->config->holdvalues);
-        flashLED = commonData->config->getString(commonData->config->flashLED);
-        backlightMode = commonData->config->getString(commonData->config->backlight);
-        tempFormat = commonData->config->getString(commonData->config->tempFormat); // [K|°C|°F]
+        common.logger->logDebug(GwLog::LOG,"Instantiate PageTwoValue");
     }
 
-    virtual void setupKeys()
-    {
-        Page::setupKeys();
-
-#if defined BOARD_OBP60S3
-        constexpr int ZOOM_KEY = 4;
-#elif defined BOARD_OBP40S3
-        constexpr int ZOOM_KEY = 1;
-#endif
-
-        if (dataHstryBuf[0] || dataHstryBuf[1]) { // show "Mode" key only if at least 1 chart supported boat data type is available
-            commonData->keydata[0].label = "MODE";
-            commonData->keydata[ZOOM_KEY].label = "ZOOM";
-        } else {
-            commonData->keydata[0].label = "";
-            commonData->keydata[ZOOM_KEY].label = "";
-        }
-    }
-
-    // Key functions
-    virtual int handleKey(int key)
-    {
-        if (dataHstryBuf[0] || dataHstryBuf[1]) { // if at least 1 boat data type supports charts
-
-            // Set page mode: value | value/half chart | full charts
-            if (key == 1) {
-                switch (pageMode) {
-
-                case VALUES:
-
-                    if (dataHstryBuf[0]) {
-                        pageMode = VAL1_CHART;
-                    } else if (dataHstryBuf[1]) {
-                        pageMode = VAL2_CHART;
-                    }
-                    break;
-
-                case VAL1_CHART:
-
-                    if (dataHstryBuf[1]) {
-                        pageMode = VAL2_CHART;
-                    } else {
-                        pageMode = CHARTS;
-                    }
-                    break;
-
-                case VAL2_CHART:
-                    pageMode = CHARTS;
-                    break;
-
-                case CHARTS:
-                    pageMode = VALUES;
-                    break;
-                }
-                return 0; // Commit the key
-            }
-
-            // Set time frame to show for history chart
-#if defined BOARD_OBP60S3
-            if (key == 5) {
-#elif defined BOARD_OBP40S3
-            if (key == 2) {
-#endif
-                if (dataIntv == 1) {
-                    dataIntv = 2;
-                } else if (dataIntv == 2) {
-                    dataIntv = 3;
-                } else if (dataIntv == 3) {
-                    dataIntv = 4;
-                } else if (dataIntv == 4) {
-                    dataIntv = 8;
-                } else {
-                    dataIntv = 1;
-                }
-                return 0; // Commit the key
-            }
-        }
-
-        // Keylock function
-        if (key == 11) { // Code for keylock
+    virtual int handleKey(int key){
+        // Code for keylock
+        if(key == 11){
             commonData->keylock = !commonData->keylock;
             return 0;                   // Commit the key
         }
         return key;
     }
 
-    virtual void displayNew(PageData& pageData)
-    {
-#ifdef BOARD_OBP60S3
-        // Clear optical warning
-        if (flashLED == "Limit Violation") {
-            setBlinkingLED(false);
-            setFlashLED(false);
-        }
-#endif
-        // buffer initialization will fail, if page is default page, because <displayNew> is not executed at system start for default page
-        for (int i = 0; i < NUMVALUES; i++) {
-            if (!dataChart[i]) { // Create chart objects if they don't exist
+    int displayPage(PageData &pageData){
+        GwConfigHandler *config = commonData->config;
+        GwLog *logger = commonData->logger;
 
-                GwApi::BoatValue* bValue = pageData.values[i]; // Page boat data element
-                String bValName = bValue->getName(); // Value name
-                String bValFormat = bValue->getFormat(); // Value format
+        // Old values for hold function
+        static String svalue1old = "";
+        static String unit1old = "";
+        static String svalue2old = "";
+        static String unit2old = "";
 
-                dataHstryBuf[i] = pageData.hstryBuffers->getBuffer(bValName);
+        // Get config data
+        String lengthformat = config->getString(config->lengthFormat);
+        // bool simulation = config->getBool(config->useSimuData);
+        bool holdvalues = config->getBool(config->holdvalues);
+        String flashLED = config->getString(config->flashLED);
+        String backlightMode = config->getString(config->backlight);
         
-                if (dataHstryBuf[i]) {
-                    dataChart[i].reset(new Chart(*dataHstryBuf[i], Chart::dfltChrtDta[bValFormat].range, *commonData, useSimuData));
-                    LOG_DEBUG(GwLog::DEBUG, "PageTwoValues: Created chart object%d for %s", i, bValName.c_str());
-                } else {
-                    LOG_DEBUG(GwLog::DEBUG, "PageTwoValues: No chart object available for %s", bValName.c_str());
-                }
-            }
-        }
+        // Get boat values #1
+        GwApi::BoatValue *bvalue1 = pageData.values[0]; // First element in list (only one value by PageOneValue)
+        String name1 = xdrDelete(bvalue1->getName());   // Value name
+        name1 = name1.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue1, logger); // Check if boat data value is to be calibrated
+        double value1 = bvalue1->value;                 // Value as double in SI unit
+        bool valid1 = bvalue1->valid;                   // Valid information 
+        String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
+        String unit1 = formatValue(bvalue1, *commonData).unit;        // Unit of value
 
-        setupKeys(); // adjust <mode> key depending on chart supported boat data type
-    }
-
-    int displayPage(PageData& pageData)
-    {
-        LOG_DEBUG(GwLog::LOG, "Display PageTwoValues");
-
-        // Get boat values for page
-        std::vector<GwApi::BoatValue*> bValue;
-        bValue.push_back(pageData.values[0]); // Page boat data element 1
-        bValue.push_back(pageData.values[1]); // Page boat data element 2
+        // Get boat values #2
+        GwApi::BoatValue *bvalue2 = pageData.values[1]; // Second element in list
+        String name2 = xdrDelete(bvalue2->getName());   // Value name
+        name2 = name2.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue2, logger); // Check if boat data value is to be calibrated
+        double value2 = bvalue2->value;                 // Value as double in SI unit
+        bool valid2 = bvalue2->valid;                   // Valid information 
+        String svalue2 = formatValue(bvalue2, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
+        String unit2 = formatValue(bvalue2, *commonData).unit;        // Unit of value
 
         // Optical warning by limit violation (unused)
         if(String(flashLED) == "Limit Violation"){
@@ -269,59 +64,115 @@ public:
             setFlashLED(false); 
         }
 
-        if (bValue[0] == NULL && bValue[1] == NULL)
-            return PAGE_OK; // no data, no page to display
-
-        LOG_DEBUG(GwLog::DEBUG, "PageTwoValues: printing #1: %s, %.3f, #2: %s, %.3f",
-            bValue[0]->getName().c_str(), bValue[0]->value, bValue[1]->getName().c_str(), bValue[1]->value);
+        // Logging boat values
+        if (bvalue1 == NULL) return PAGE_OK; // WTF why this statement?
+        LOG_DEBUG(GwLog::LOG,"Drawing at PageTwoValues, %s: %f, %s: %f", name1.c_str(), value1, name2.c_str(), value2);
 
         // Draw page
         //***********************************************************
 
-        getdisplay().setPartialWindow(0, 0, width, height); // Set partial update
+        // Set display in partial refresh mode
+        getdisplay().setPartialWindow(0, 0, getdisplay().width(), getdisplay().height()); // Set partial update
 
-        if (pageMode == VALUES || (dataHstryBuf[0] == nullptr && dataHstryBuf[1] == nullptr)) {
-            // show only data value; ignore other pageMode options if no chart supported boat data history buffer is available
-            showData(bValue, FULL);
+        // ############### Value 1 ################
 
-        } else if (pageMode == VAL1_CHART) { // show data value 1 and chart
-            showData({bValue[0]}, HALF);
-            if (dataChart[0]) {
-                dataChart[0]->showChrt(HORIZONTAL, HALF_SIZE_BOTTOM, dataIntv, NO_PRNT_NAME, NO_PRNT_VALUE, *bValue[0]);
+        // Show name
+        getdisplay().setTextColor(commonData->fgcolor);
+        getdisplay().setFont(&Ubuntu_Bold20pt8b);
+        getdisplay().setCursor(20, 80);
+        getdisplay().print(name1);                           // Page name
+
+        // Show unit
+        getdisplay().setFont(&Ubuntu_Bold12pt8b);
+        getdisplay().setCursor(20, 130);
+        if(holdvalues == false){
+            getdisplay().print(unit1);                       // Unit
+        }
+        else{
+            getdisplay().print(unit1old);
         }
 
-        } else if (pageMode == VAL2_CHART) { // show data value 2 and chart
-            showData({bValue[1]}, HALF);
-            if (dataChart[1]) {
-                dataChart[1]->showChrt(HORIZONTAL, HALF_SIZE_BOTTOM, dataIntv, NO_PRNT_NAME, NO_PRNT_VALUE, *bValue[1]);
+        // Switch font if format for any values
+        if(bvalue1->getFormat() == "formatLatitude" || bvalue1->getFormat() == "formatLongitude"){
+            getdisplay().setFont(&Ubuntu_Bold20pt8b);
+            getdisplay().setCursor(50, 130);
+        }
+        else if(bvalue1->getFormat() == "formatTime" || bvalue1->getFormat() == "formatDate"){
+            getdisplay().setFont(&Ubuntu_Bold20pt8b);
+            getdisplay().setCursor(170, 105);
+        }
+        else{
+            getdisplay().setFont(&DSEG7Classic_BoldItalic42pt7b);
+            getdisplay().setCursor(180, 130);
         }
 
-        } else if (pageMode == CHARTS) { // show both data charts
-            if (dataChart[0]) {
-                if (dataChart[1]) {
-                    dataChart[0]->showChrt(HORIZONTAL, HALF_SIZE_TOP, dataIntv, PRNT_NAME, PRNT_VALUE, *bValue[0]);
-                } else {
-                    dataChart[0]->showChrt(HORIZONTAL, FULL_SIZE, dataIntv, PRNT_NAME, PRNT_VALUE, *bValue[0]);
+        // Show bus data
+        if(holdvalues == false){
+            getdisplay().print(svalue1);                                     // Real value as formated string
         }
+        else{
+            getdisplay().print(svalue1old);                                  // Old value as formated string
         }
-            if (dataChart[1]) {
-                if (dataChart[0]) {
-                    dataChart[1]->showChrt(HORIZONTAL, HALF_SIZE_BOTTOM, dataIntv, PRNT_NAME, PRNT_VALUE, *bValue[1]);
-                } else {
-                    dataChart[1]->showChrt(HORIZONTAL, FULL_SIZE, dataIntv, PRNT_NAME, PRNT_VALUE, *bValue[1]);
+        if(valid1 == true){
+            svalue1old = svalue1;                                       // Save the old value
+            unit1old = unit1;                                           // Save the old unit
         }
+
+        // ############### Horizontal Line ################
+
+        // Horizontal line 3 pix
+        getdisplay().fillRect(0, 145, 400, 3, commonData->fgcolor);
+
+        // ############### Value 2 ################
+
+        // Show name
+        getdisplay().setFont(&Ubuntu_Bold20pt8b);
+        getdisplay().setCursor(20, 190);
+        getdisplay().print(name2);                           // Page name
+
+        // Show unit
+        getdisplay().setFont(&Ubuntu_Bold12pt8b);
+        getdisplay().setCursor(20, 240);
+        if(holdvalues == false){
+            getdisplay().print(unit2);                       // Unit
         }
+        else{
+            getdisplay().print(unit2old);
+        }
+
+        // Switch font if format for any values
+        if(bvalue2->getFormat() == "formatLatitude" || bvalue2->getFormat() == "formatLongitude"){
+            getdisplay().setFont(&Ubuntu_Bold20pt8b);
+            getdisplay().setCursor(50, 240);
+        }
+        else if(bvalue2->getFormat() == "formatTime" || bvalue2->getFormat() == "formatDate"){
+            getdisplay().setFont(&Ubuntu_Bold20pt8b);
+            getdisplay().setCursor(170, 215);
+        }
+        else{
+            getdisplay().setFont(&DSEG7Classic_BoldItalic42pt7b);
+            getdisplay().setCursor(180, 240);
+        }
+
+        // Show bus data
+        if(holdvalues == false){
+            getdisplay().print(svalue2);                                     // Real value as formated string
+        }
+        else{
+            getdisplay().print(svalue2old);                                  // Old value as formated string
+        }
+        if(valid2 == true){
+            svalue2old = svalue2;                                       // Save the old value
+            unit2old = unit2;                                           // Save the old unit
         }
 
         return PAGE_UPDATE;
     };
 };
 
-static Page* createPage(CommonData& common)
-{
+static Page *createPage(CommonData &common){
     return new PageTwoValues(common);
 }
-
 /**
  * with the code below we make this page known to the PageTask
  * we give it a type (name) that can be selected in the config

lib/obp60task/PageWind.cpp

@@ -3,6 +3,7 @@
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
 #include "N2kMessages.h"
+#include "BoatDataCalibration.h"
 
 #define front_width 120
 #define front_height 162
@@ -246,8 +247,8 @@ public:
         if(key == 1){               // Mode switch
             if(mode == 'N'){
                 mode = 'L';
-        //    } else if (mode == 'L') {
-        //        mode = 'X';
+            } else if (mode == 'L') {
+                mode = 'X';
             } else {
                 mode = 'N';
             }
@@ -323,6 +324,7 @@ public:
         }
         String name1 = bvalue1->getName().c_str();      // Value name
         name1 = name1.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue1, logger); // Check if boat data value is to be calibrated
         double value1 = bvalue1->value;                 // Value as double in SI unit
         // bool valid1 = bvalue1->valid;                   // Valid information
         String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -336,6 +338,7 @@ public:
         }
         String name2 = bvalue2->getName().c_str();      // Value name
         name2 = name2.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue2, logger); // Check if boat data value is to be calibrated
         double value2 = bvalue2->value;                 // Value as double in SI unit
         // bool valid2 = bvalue2->valid;                   // Valid information
         if (simulation) {

lib/obp60task/PageWindPlot.cpp

@@ -1,140 +1,110 @@
 #if defined BOARD_OBP60S3 || defined BOARD_OBP40S3
 
-#include "Pagedata.h"
+#include "BoatDataCalibration.h"
 #include "OBP60Extensions.h"
-#include "OBPDataOperations.h"
-#include "OBPcharts.h"
+#include "OBPRingBuffer.h"
+#include "Pagedata.h"
+#include <vector>
+
+static const double radToDeg = 180.0 / M_PI; // Conversion factor from radians to degrees
+
+// Get maximum difference of last <amount> of TWD ringbuffer values to center chart
+int getRng(const RingBuffer<int16_t>& windDirHstry, int center, size_t amount)
+{
+    int minVal = windDirHstry.getMinVal();
+    size_t count = windDirHstry.getCurrentSize();
+    //    size_t capacity = windDirHstry.getCapacity();
+    //    size_t last = windDirHstry.getLastIdx();
+
+    if (windDirHstry.isEmpty() || amount <= 0) {
+        return minVal;
+    }
+    if (amount > count)
+        amount = count;
+
+    int value = 0;
+    int rng = 0;
+    int maxRng = minVal;
+    // Start from the newest value (last) and go backwards x times
+    for (size_t i = 0; i < amount; i++) {
+        //        value = windDirHstry.get(((last - i) % capacity + capacity) % capacity);
+        value = windDirHstry.get(count - 1 - i);
+
+        if (value == minVal) {
+            continue;
+        }
+
+        value = value / 1000.0 * radToDeg;
+        rng = abs(((value - center + 540) % 360) - 180);
+        if (rng > maxRng)
+            maxRng = rng;
+    }
+    if (maxRng > 180) {
+        maxRng = 180;
+    }
+
+    return maxRng;
+}
 
 // ****************************************************************
 class PageWindPlot : public Page {
 
-private:
-    GwLog* logger;
-
-    enum ChartMode {
-        DIRECTION,
-        SPEED,
-        BOTH
-    };
-
-    static constexpr char HORIZONTAL = 'H';
-    static constexpr char VERTICAL = 'V';
-    static constexpr int8_t FULL_SIZE = 0;
-    static constexpr int8_t HALF_SIZE_LEFT = 1;
-    static constexpr int8_t HALF_SIZE_RIGHT = 2;
-
-    static constexpr bool PRNT_NAME = true;
-    static constexpr bool NO_PRNT_NAME = false;
-    static constexpr bool PRNT_VALUE = true;
-    static constexpr bool NO_PRNT_VALUE = false;
-
-    int width; // Screen width
-    int height; // Screen height
-
     bool keylock = false; // Keylock
-    ChartMode chrtMode = DIRECTION;
-    bool showTruW = true; // Show true wind or apparent wind in chart area
-    bool oldShowTruW = false; // remember recent user selection of wind data type
-
-    int8_t dataIntv = 1; // Update interval for wind history chart:
-                         // (1)|(2)|(3)|(4)|(8) x 240 seconds for 4, 8, 12, 16, 32 min. history chart
-    bool useSimuData;
-    // bool holdValues;
-    String flashLED;
-    String backlightMode;
-
-#ifdef BOARD_OBP40S3
-    String wndSrc; // Wind source true/apparent wind - preselection for OBP40
-#endif
-
-    // Data buffers pointers (owned by HstryBuffers)
-    RingBuffer<uint16_t>* twdHstry = nullptr;
-    RingBuffer<uint16_t>* twsHstry = nullptr;
-    RingBuffer<uint16_t>* awdHstry = nullptr;
-    RingBuffer<uint16_t>* awsHstry = nullptr;
-
-    // Chart objects
-    std::unique_ptr<Chart> twdChart, awdChart; // Chart object for wind direction
-    std::unique_ptr<Chart> twsChart, awsChart; // Chart object for wind speed
-
-    // Active charts and values
-    Chart* wdChart = nullptr;
-    Chart* wsChart = nullptr;
-    GwApi::BoatValue* wdBVal = nullptr;
-    GwApi::BoatValue* wsBVal = nullptr;
+    char chrtMode = 'D'; // Chart mode: 'D' for TWD, 'S' for TWS, 'B' for both
+    int dataIntv = 1; // Update interval for wind history chart:
+                      // (1)|(2)|(3)|(4) seconds for approx. 4, 8, 12, 16 min. history chart
+    bool showTWS = true; // Show TWS value in chart area
 
 public:
     PageWindPlot(CommonData& common)
     {
         commonData = &common;
-        logger = commonData->logger;
-        LOG_DEBUG(GwLog::LOG, "Instantiate PageWindPlot");
-
-        width = getdisplay().width(); // Screen width
-        height = getdisplay().height(); // Screen height
-
-        // Get config data
-        useSimuData = common.config->getBool(common.config->useSimuData);
-        // holdValues = common.config->getBool(common.config->holdvalues);
-        flashLED = common.config->getString(common.config->flashLED);
-        backlightMode = common.config->getString(common.config->backlight);
-
-        oldShowTruW = !showTruW; // makes wind source being initialized at initial page call
+        common.logger->logDebug(GwLog::LOG, "Instantiate PageWindPlot");
     }
 
     virtual void setupKeys()
     {
         Page::setupKeys();
-        commonData->keydata[0].label = "MODE";
-#if defined BOARD_OBP60S3
-        commonData->keydata[1].label = "SRC";
-        commonData->keydata[4].label = "ZOOM";
-#elif defined BOARD_OBP40S3
-        commonData->keydata[1].label = "ZOOM";
-#endif
+        //        commonData->keydata[0].label = "MODE";
+        commonData->keydata[1].label = "INTV";
+        commonData->keydata[4].label = "TWS";
     }
 
     // Key functions
     virtual int handleKey(int key)
     {
-        // Set chart mode
+        // Set chart mode TWD | TWS -> to be implemented
         if (key == 1) {
-            if (chrtMode == DIRECTION) {
-                chrtMode = SPEED;
-            } else if (chrtMode == SPEED) {
-                chrtMode = BOTH;
+            if (chrtMode == 'D') {
+                chrtMode = 'S';
+            } else if (chrtMode == 'S') {
+                chrtMode = 'B';
             } else {
-                chrtMode = DIRECTION;
+                chrtMode = 'D';
             }
             return 0; // Commit the key
         }
 
-#if defined BOARD_OBP60S3
-        // Set data source TRUE | APP
+        // Set interval for wind history chart update time
         if (key == 2) {
-            showTruW = !showTruW;
-            return 0; // Commit the key
-        }
-
-        // Set interval for wind history chart update time (interval)
-        if (key == 5) {
-#elif defined BOARD_OBP40S3
-        if (key == 2) {
-#endif
             if (dataIntv == 1) {
                 dataIntv = 2;
             } else if (dataIntv == 2) {
                 dataIntv = 3;
             } else if (dataIntv == 3) {
                 dataIntv = 4;
-            } else if (dataIntv == 4) {
-                dataIntv = 8;
             } else {
                 dataIntv = 1;
             }
             return 0; // Commit the key
         }
 
+        // Switch TWS on/off
+        if (key == 5) {
+            showTWS = !showTWS;
+            return 0; // Commit the key
+        }
+
         // Keylock function
         if (key == 11) { // Code for keylock
             commonData->keylock = !commonData->keylock;
@@ -143,126 +113,366 @@ public:
         return key;
     }
 
-    virtual void displayNew(PageData& pageData)
+    int displayPage(PageData& pageData)
     {
-#ifdef BOARD_OBP60S3
-        // Clear optical warning
-        if (flashLED == "Limit Violation") {
+        GwConfigHandler* config = commonData->config;
+        GwLog* logger = commonData->logger;
+
+        float twsValue; // TWS value in chart area
+        static String twdName, twdUnit; // TWD name and unit
+        static int updFreq; // Update frequency for TWD
+        static int16_t twdLowest, twdHighest; // TWD range
+        // static int16_t twdBufMinVal; // lowest possible twd buffer value; used for non-set data
+
+        // current boat data values; TWD only for validation test, TWS for display of current value
+        const int numBoatData = 2;
+        GwApi::BoatValue* bvalue;
+        String BDataName[numBoatData];
+        double BDataValue[numBoatData];
+        bool BDataValid[numBoatData];
+        String BDataText[numBoatData];
+        String BDataUnit[numBoatData];
+        String BDataFormat[numBoatData];
+
+        static bool isInitialized = false; // Flag to indicate that page is initialized
+        static bool wndDataValid = false; // Flag to indicate if wind data is valid
+        static int numNoData; // Counter for multiple invalid data values in a row
+        static bool simulation = false;
+        static bool holdValues = false;
+
+        static int width; // Screen width
+        static int height; // Screen height
+        static int xCenter; // Center of screen in x direction
+        static const int yOffset = 48; // Offset for y coordinates of chart area
+        static int cHeight; // height of chart area
+        static int bufSize; // History buffer size: 960 values for appox. 16 min. history chart
+        static int intvBufSize; // Buffer size used for currently selected time interval
+        int count; // current size of buffer
+        static int numWndVals; // number of wind values available for current interval selection
+        static int bufStart; // 1st data value in buffer to show
+        int numAddedBufVals; // Number of values added to buffer since last display
+        size_t currIdx; // Current index in TWD history buffer
+        static size_t lastIdx; // Last index of TWD history buffer
+        static size_t lastAddedIdx = 0; // Last index of TWD history buffer when new data was added
+        static int oldDataIntv; // remember recent user selection of data interval
+
+        static int wndCenter; // chart wind center value position
+        static int wndLeft; // chart wind left value position
+        static int wndRight; // chart wind right value position
+        static int chrtRng; // Range of wind values from mid wind value to min/max wind value in degrees
+        int diffRng; // Difference between mid and current wind value
+        static const int dfltRng = 40; // Default range for chart
+        int midWndDir; // New value for wndCenter after chart start / shift
+        static int simTwd; // Simulation value for TWD
+        static float simTws; // Simulation value for TWS
+
+        int x, y; // x and y coordinates for drawing
+        static int prevX, prevY; // Last x and y coordinates for drawing
+        static float chrtScl; // Scale for wind values in pixels per degree
+        int chrtVal; // Current wind value
+        static int chrtPrevVal; // Last wind value in chart area for check if value crosses 180 degree line
+
+        LOG_DEBUG(GwLog::LOG, "Display page WindPlot");
+
+        // Get config data
+        simulation = config->getBool(config->useSimuData);
+        holdValues = config->getBool(config->holdvalues);
+        String flashLED = config->getString(config->flashLED);
+        String backlightMode = config->getString(config->backlight);
+
+        if (!isInitialized) {
+            width = getdisplay().width();
+            height = getdisplay().height();
+            xCenter = width / 2;
+            cHeight = height - yOffset - 22;
+            bufSize = pageData.boatHstry.twdHstry->getCapacity();
+            numNoData = 0;
+            simTwd = pageData.boatHstry.twdHstry->getLast() / 1000.0 * radToDeg;
+            simTws = 0;
+            twsValue = 0;
+            bufStart = 0;
+            oldDataIntv = 0;
+            numAddedBufVals, currIdx, lastIdx = 0;
+            lastAddedIdx = pageData.boatHstry.twdHstry->getLastIdx();
+            pageData.boatHstry.twdHstry->getMetaData(twdName, twdUnit, updFreq, twdLowest, twdHighest);
+            wndCenter = INT_MIN;
+            midWndDir = 0;
+            diffRng = dfltRng;
+            chrtRng = dfltRng;
+
+            isInitialized = true; // Set flag to indicate that page is now initialized
+        }
+
+        // read boat data values; TWD only for validation test, TWS for display of current value
+        for (int i = 0; i < numBoatData; i++) {
+            bvalue = pageData.values[i];
+            BDataName[i] = xdrDelete(bvalue->getName());
+            BDataName[i] = BDataName[i].substring(0, 6); // String length limit for value name
+            calibrationData.calibrateInstance(bvalue, logger); // Check if boat data value is to be calibrated
+            BDataValue[i] = bvalue->value; // Value as double in SI unit
+            BDataValid[i] = bvalue->valid;
+            BDataText[i] = formatValue(bvalue, *commonData).svalue; // Formatted value as string including unit conversion and switching decimal places
+            BDataUnit[i] = formatValue(bvalue, *commonData).unit;
+            BDataFormat[i] = bvalue->getFormat(); // Unit of value
+        }
+
+        // Optical warning by limit violation (unused)
+        if (String(flashLED) == "Limit Violation") {
             setBlinkingLED(false);
             setFlashLED(false);
         }
-#endif
-#ifdef BOARD_OBP40S3
-        // we can only initialize user defined wind source here, because "pageData" is not available at object instantiation
-        wndSrc = commonData->config->getString("page" + String(pageData.pageNumber) + "wndsrc");
-        if (wndSrc == "True wind") {
-            showTruW = true;
+
+        // Identify buffer size and buffer start position for chart
+        count = pageData.boatHstry.twdHstry->getCurrentSize();
+        currIdx = pageData.boatHstry.twdHstry->getLastIdx();
+        numAddedBufVals = (currIdx - lastAddedIdx + bufSize) % bufSize; // Number of values added to buffer since last display
+        if (dataIntv != oldDataIntv || count == 1) {
+            // new data interval selected by user
+            intvBufSize = cHeight * dataIntv;
+            numWndVals = min(count, (cHeight - 60) * dataIntv);
+            bufStart = max(0, count - numWndVals);
+            lastAddedIdx = currIdx;
+            oldDataIntv = dataIntv;
         } else {
-            showTruW = false; // Wind source is apparent wind
+            numWndVals = numWndVals + numAddedBufVals;
+            lastAddedIdx = currIdx;
+            if (count == bufSize) {
+                bufStart = max(0, bufStart - numAddedBufVals);
             }
-        oldShowTruW = !showTruW; // Force chart update in displayPage
-#endif
+        }
+        LOG_DEBUG(GwLog::DEBUG, "PageWindPlot Dataset: count: %d, TWD: %.0f, TWS: %.1f, TWD_valid? %d, intvBufSize: %d, numWndVals: %d, bufStart: %d, numAddedBufVals: %d, lastIdx: %d, old: %d, act: %d",
+            count, pageData.boatHstry.twdHstry->getLast() / 1000.0 * radToDeg, pageData.boatHstry.twsHstry->getLast() / 10.0 * 1.94384, BDataValid[0],
+            intvBufSize, numWndVals, bufStart, numAddedBufVals, pageData.boatHstry.twdHstry->getLastIdx(), oldDataIntv, dataIntv);
 
-        if (!twdChart) { // Create true wind charts if they don't exist
-            twdHstry = pageData.hstryBuffers->getBuffer("TWD");
-            twsHstry = pageData.hstryBuffers->getBuffer("TWS");
-
-            if (twdHstry) {
-                twdChart.reset(new Chart(*twdHstry, Chart::dfltChrtDta["formatCourse"].range, *commonData, useSimuData));
-            }
-            if (twsHstry) {
-                twsChart.reset(new Chart(*twsHstry, Chart::dfltChrtDta["formatKnots"].range, *commonData, useSimuData));
-            }
-        }
-
-        if (!awdChart) { // Create apparent wind charts if they don't exist
-            awdHstry = pageData.hstryBuffers->getBuffer("AWD");
-            awsHstry = pageData.hstryBuffers->getBuffer("AWS");
-
-            if (awdHstry) {
-                awdChart.reset(new Chart(*awdHstry, Chart::dfltChrtDta["formatCourse"].range, *commonData, useSimuData));
-            }
-            if (awsHstry) {
-                awsChart.reset(new Chart(*awsHstry, Chart::dfltChrtDta["formatKnots"].range, *commonData, useSimuData));
-            }
-            if (twdHstry && twsHstry && awdHstry && awsHstry) {
-                LOG_DEBUG(GwLog::DEBUG, "PageWindPlot: Created wind charts");
+        // Set wndCenter from 1st real buffer value
+        if (wndCenter == INT_MIN || (wndCenter == 0 && count == 1)) {
+            midWndDir = pageData.boatHstry.twdHstry->getMid(numWndVals);
+            if (midWndDir != INT16_MIN) {
+                midWndDir = midWndDir / 1000.0 * radToDeg;
+                wndCenter = int((midWndDir + (midWndDir >= 0 ? 5 : -5)) / 10) * 10; // Set new center value; round to nearest 10 degree value
             } else {
-                LOG_DEBUG(GwLog::DEBUG, "PageWindPlot: Some/all chart objects for wind data missing");
+                wndCenter = 0;
             }
-        }
-    }
-
-    int displayPage(PageData& pageData)
-    {
-        LOG_DEBUG(GwLog::LOG, "Display PageWindPlot");
-        ulong pageTime = millis();
-
-        if (showTruW != oldShowTruW) {
-
-            // Switch active charts based on showTruW
-            if (showTruW) {
-                wdChart = twdChart.get();
-                wsChart = twsChart.get();
-                wdBVal = pageData.values[0];
-                wsBVal = pageData.values[1];
+            LOG_DEBUG(GwLog::DEBUG, "PageWindPlot Range Init: count: %d, TWD: %.0f, wndCenter: %d, diffRng: %d, chrtRng: %d", count, pageData.boatHstry.twdHstry->getLast() / 1000.0 * radToDeg,
+                wndCenter, diffRng, chrtRng);
         } else {
-                wdChart = awdChart.get();
-                wsChart = awsChart.get();
-                wdBVal = pageData.values[2];
-                wsBVal = pageData.values[3];
+            // check and adjust range between left, center, and right chart limit
+            diffRng = getRng(*pageData.boatHstry.twdHstry, wndCenter, numWndVals);
+            diffRng = (diffRng == INT16_MIN ? 0 : diffRng);
+            if (diffRng > chrtRng) {
+                chrtRng = int((diffRng + (diffRng >= 0 ? 9 : -1)) / 10) * 10; // Round up to next 10 degree value
+            } else if (diffRng + 10 < chrtRng) { // Reduce chart range for higher resolution if possible
+                chrtRng = max(dfltRng, int((diffRng + (diffRng >= 0 ? 9 : -1)) / 10) * 10);
             }
-
-            oldShowTruW = showTruW;
         }
-        LOG_DEBUG(GwLog::DEBUG, "PageWindPlot: draw with data %s: %.2f, %s: %.2f", wdBVal->getName().c_str(), wdBVal->value, wsBVal->getName().c_str(), wsBVal->value);
+        chrtScl = float(width) / float(chrtRng) / 2.0; // Chart scale: pixels per degree
+        wndLeft = wndCenter - chrtRng;
+        if (wndLeft < 0)
+            wndLeft += 360;
+        wndRight = (chrtRng < 180 ? wndCenter + chrtRng : wndCenter + chrtRng - 1);
+        if (wndRight >= 360)
+            wndRight -= 360;
 
         // Draw page
-        //***********************************************************
+        //***********************************************************************
 
         // Set display in partial refresh mode
         getdisplay().setPartialWindow(0, 0, width, height); // Set partial update
         getdisplay().setTextColor(commonData->fgcolor);
 
-        if (chrtMode == DIRECTION) {
-            if (wdChart) {
-                wdChart->showChrt(VERTICAL, FULL_SIZE, dataIntv, PRNT_NAME, PRNT_VALUE, *wdBVal);
-            }
+        // chart lines
+        getdisplay().fillRect(0, yOffset, width, 2, commonData->fgcolor);
+        getdisplay().fillRect(xCenter, yOffset, 1, cHeight, commonData->fgcolor);
 
-        } else if (chrtMode == SPEED) {
-            if (wsChart) {
-                wsChart->showChrt(HORIZONTAL, FULL_SIZE, dataIntv, PRNT_NAME, PRNT_VALUE, *wsBVal);
-            }
+        // chart labels
+        char sWndLbl[4]; // char buffer for Wind angle label
+        getdisplay().setFont(&Ubuntu_Bold12pt8b);
+        getdisplay().setCursor(xCenter - 88, yOffset - 3);
+        getdisplay().print("TWD"); // Wind data name
+        snprintf(sWndLbl, 4, "%03d", (wndCenter < 0) ? (wndCenter + 360) : wndCenter);
+        drawTextCenter(xCenter, yOffset - 11, sWndLbl);
+        getdisplay().drawCircle(xCenter + 25, yOffset - 17, 2, commonData->fgcolor); // <degree> symbol
+        getdisplay().drawCircle(xCenter + 25, yOffset - 17, 3, commonData->fgcolor); // <degree> symbol
+        getdisplay().setCursor(1, yOffset - 3);
+        snprintf(sWndLbl, 4, "%03d", (wndLeft < 0) ? (wndLeft + 360) : wndLeft);
+        getdisplay().print(sWndLbl); // Wind left value
+        getdisplay().drawCircle(46, yOffset - 17, 2, commonData->fgcolor); // <degree> symbol
+        getdisplay().drawCircle(46, yOffset - 17, 3, commonData->fgcolor); // <degree> symbol
+        getdisplay().setCursor(width - 50, yOffset - 3);
+        snprintf(sWndLbl, 4, "%03d", (wndRight < 0) ? (wndRight + 360) : wndRight);
+        getdisplay().print(sWndLbl); // Wind right value
+        getdisplay().drawCircle(width - 5, yOffset - 17, 2, commonData->fgcolor); // <degree> symbol
+        getdisplay().drawCircle(width - 5, yOffset - 17, 3, commonData->fgcolor); // <degree> symbol
 
-        } else if (chrtMode == BOTH) {
-            if (wdChart) {
-                wdChart->showChrt(VERTICAL, HALF_SIZE_LEFT, dataIntv, PRNT_NAME, PRNT_VALUE, *wdBVal);
+        if (pageData.boatHstry.twdHstry->getMax() == pageData.boatHstry.twdHstry->getMinVal()) {
+            // only <INT16_MIN> values in buffer -> no valid wind data available
+            wndDataValid = false;
+        } else if (!BDataValid[0]) {
+            // currently no valid TWD data available
+            numNoData++;
+            wndDataValid = true;
+            if (numNoData > 3) {
+                // If more than 4 invalid values in a row, send message
+                wndDataValid = false;
             }
-            if (wsChart) {
-                wsChart->showChrt(VERTICAL, HALF_SIZE_RIGHT, dataIntv, PRNT_NAME, PRNT_VALUE, *wsBVal);
+        } else {
+            numNoData = 0; // reset data error counter
+            wndDataValid = true; // At least some wind data available
+        }
+        // Draw wind values in chart
+        //***********************************************************************
+        if (wndDataValid) {
+            for (int i = 0; i < (numWndVals / dataIntv); i++) {
+                chrtVal = static_cast<int>(pageData.boatHstry.twdHstry->get(bufStart + (i * dataIntv))); // show the latest wind values in buffer; keep 1st value constant in a rolling buffer
+                if (chrtVal == INT16_MIN) {
+                    chrtPrevVal = INT16_MIN;
+                } else {
+                    chrtVal = static_cast<int>((chrtVal / 1000.0 * radToDeg) + 0.5); // Convert to degrees and round
+                    x = ((chrtVal - wndLeft + 360) % 360) * chrtScl;
+                    y = yOffset + cHeight - i; // Position in chart area
+
+//                    if (i >= (numWndVals / dataIntv) - 10)
+                    if (i >= (numWndVals / dataIntv) - 1)
+                        LOG_DEBUG(GwLog::DEBUG, "PageWindPlot Chart: i: %d, chrtVal: %d, bufStart: %d, count: %d, linesToShow: %d", i, chrtVal, bufStart, count, (numWndVals / dataIntv));
+
+                    if ((i == 0) || (chrtPrevVal == INT16_MIN)) {
+                        // just a dot for 1st chart point or after some invalid values
+                        prevX = x;
+                        prevY = y;
+                    } else {
+                        // cross borders check; shift values to [-180..0..180]; when crossing borders, range is 2x 180 degrees
+                        int wndLeftDlt = -180 - ((wndLeft >= 180) ? (wndLeft - 360) : wndLeft);
+                        int chrtVal180 = ((chrtVal + wndLeftDlt + 180) % 360 + 360) % 360 - 180;
+                        int chrtPrevVal180 = ((chrtPrevVal + wndLeftDlt + 180) % 360 + 360) % 360 - 180;
+                        if (((chrtPrevVal180 >= -180) && (chrtPrevVal180 < -90) && (chrtVal180 > 90)) || ((chrtPrevVal180 <= 179) && (chrtPrevVal180 > 90) && chrtVal180 <= -90)) {
+                            // If current value crosses chart borders compared to previous value, split line
+                            int xSplit = (((chrtPrevVal180 > 0 ? wndRight : wndLeft) - wndLeft + 360) % 360) * chrtScl;
+                            getdisplay().drawLine(prevX, prevY, xSplit, y, commonData->fgcolor);
+                            getdisplay().drawLine(prevX, prevY - 1, ((xSplit != prevX) ? xSplit : xSplit - 1), ((xSplit != prevX) ? y - 1 : y), commonData->fgcolor);
+                            prevX = (((chrtVal180 > 0 ? wndRight : wndLeft) - wndLeft + 360) % 360) * chrtScl;
                         }
                     }
 
-        LOG_DEBUG(GwLog::DEBUG, "PageWindPlot: page time %ldms", millis() - pageTime);
+                    // Draw line with 2 pixels width + make sure vertical line are drawn correctly
+                    getdisplay().drawLine(prevX, prevY, x, y, commonData->fgcolor);
+                    getdisplay().drawLine(prevX, prevY - 1, ((x != prevX) ? x : x - 1), ((x != prevX) ? y - 1 : y), commonData->fgcolor);
+                    chrtPrevVal = chrtVal;
+                    prevX = x;
+                    prevY = y;
+                }
+                // Reaching chart area top end
+                if (i >= (cHeight - 1)) {
+                    oldDataIntv = 0; // force reset of buffer start and number of values to show in next display loop
+
+                    int minWndDir = pageData.boatHstry.twdHstry->getMin(numWndVals) / 1000.0 * radToDeg;
+                    int maxWndDir = pageData.boatHstry.twdHstry->getMax(numWndVals) / 1000.0 * radToDeg;
+                    LOG_DEBUG(GwLog::DEBUG, "PageWindPlot FreeTop: Minimum: %d, Maximum: %d, OldwndCenter: %d", minWndDir, maxWndDir, wndCenter);
+//                    if ((minWndDir + 540 >= wndCenter + 540) || (maxWndDir + 540 <= wndCenter + 540)) {
+                    if (((minWndDir - wndCenter >= 0) && (minWndDir - wndCenter < 180)) || ((maxWndDir - wndCenter <= 0) && (maxWndDir - wndCenter >=180))) {
+                        // Check if all wind value are left or right of center value -> optimize chart range
+                        midWndDir = pageData.boatHstry.twdHstry->getMid(numWndVals) / 1000.0 * radToDeg;
+                        if (midWndDir != INT16_MIN) {
+                            wndCenter = int((midWndDir + (midWndDir >= 0 ? 5 : -5)) / 10) * 10; // Set new center value; round to nearest 10 degree value
+                        }
+                    }
+                    LOG_DEBUG(GwLog::DEBUG, "PageWindPlot FreeTop: cHeight: %d, bufStart: %d, numWndVals: %d, wndCenter: %d", cHeight, bufStart, numWndVals, wndCenter);
+                    break;
+                }
+            }
+
+        } else {
+            // No valid data available
+            LOG_DEBUG(GwLog::LOG, "PageWindPlot: No valid data available");
+            getdisplay().setFont(&Ubuntu_Bold10pt8b);
+            getdisplay().fillRect(xCenter - 33, height / 2 - 20, 66, 24, commonData->bgcolor); // Clear area for message
+            drawTextCenter(xCenter, height / 2 - 10, "No data");
+        }
+
+        // Print TWS value
+        if (showTWS) {
+            int currentZone;
+            static int lastZone = 0;
+            static bool flipTws = false;
+            int xPosTws;
+            static const int yPosTws = yOffset + 40;
+
+            twsValue = pageData.boatHstry.twsHstry->getLast() / 10.0 * 1.94384; // TWS value in knots
+
+            xPosTws = flipTws ? 20 : width - 138;
+            currentZone = (y >= yPosTws - 38) && (y <= yPosTws + 6) && (x >= xPosTws - 4) && (x <= xPosTws + 146) ? 1 : 0; // Define current zone for TWS value
+            if (currentZone != lastZone) {
+                // Only flip when x moves to a different zone
+                if ((y >= yPosTws - 38) && (y <= yPosTws + 6) && (x >= xPosTws - 4) && (x <= xPosTws + 146)) {
+                    flipTws = !flipTws;
+                    xPosTws = flipTws ? 20 : width - 145;
+                }
+            }
+            lastZone = currentZone;
+
+            getdisplay().fillRect(xPosTws - 4, yPosTws - 38, 142, 44, commonData->bgcolor); // Clear area for TWS value
+            getdisplay().setFont(&DSEG7Classic_BoldItalic16pt7b);
+            getdisplay().setCursor(xPosTws, yPosTws);
+            if (!BDataValid[1]) {
+                getdisplay().print("--.-");
+            } else {
+                double dbl = BDataValue[1] * 3.6 / 1.852;
+                if (dbl < 10.0) {
+                    getdisplay().printf("!%3.1f", dbl); // Value, round to 1 decimal
+                } else {
+                    getdisplay().printf("%4.1f", dbl); // Value, round to 1 decimal
+                }
+            }
+            getdisplay().setFont(&Ubuntu_Bold12pt8b);
+            getdisplay().setCursor(xPosTws + 82, yPosTws - 14);
+//            getdisplay().print("TWS"); // Name
+            getdisplay().print(BDataName[1]); // Name
+            getdisplay().setFont(&Ubuntu_Bold8pt8b);
+//            getdisplay().setCursor(xPosTws + 78, yPosTws + 1);
+            getdisplay().setCursor(xPosTws + 82, yPosTws + 1);
+//            getdisplay().printf(" kn"); // Unit
+            getdisplay().print(BDataUnit[1]); // Unit
+        }
+
+        // chart Y axis labels; print at last to overwrite potential chart lines in label area
+        int yPos;
+        int chrtLbl;
+        getdisplay().setFont(&Ubuntu_Bold8pt8b);
+        for (int i = 1; i <= 3; i++) {
+            yPos = yOffset + (i * 60);
+            getdisplay().fillRect(0, yPos, width, 1, commonData->fgcolor);
+            getdisplay().fillRect(0, yPos - 8, 24, 16, commonData->bgcolor); // Clear small area to remove potential chart lines
+            getdisplay().setCursor(1, yPos + 4);
+            if (count >= intvBufSize) {
+                // Calculate minute value for label
+                chrtLbl = ((i - 1 + (prevY < yOffset + 30)) * dataIntv) * -1; // change label if last data point is more than 30 lines (= seconds) from chart line
+            } else {
+                int j = 3 - i;
+                chrtLbl = (int((((numWndVals / dataIntv) - 50) * dataIntv / 60) + 1) - (j * dataIntv)) * -1; // 50 lines left below last chart line
+            }
+            getdisplay().printf("%3d", chrtLbl); // Wind value label
+        }
+
         return PAGE_UPDATE;
-    }
+    };
 };
 
 static Page* createPage(CommonData& common)
 {
     return new PageWindPlot(common);
 }
-
-/* with the code below we make this page known to the PageTask
+/**
+ * with the code below we make this page known to the PageTask
  * we give it a type (name) that can be selected in the config
  * we define which function is to be called
  * and we provide the number of user parameters we expect (0 here)
- * and will will provide the names of the fixed values we need */
+ * and will will provide the names of the fixed values we need
+ */
 PageDescription registerPageWindPlot(
     "WindPlot", // Page name
     createPage, // Action
     0, // Number of bus values depends on selection in Web configuration
-    { "TWD", "TWS", "AWD", "AWS" }, // Bus values we need in the page
+    { "TWD", "TWS" }, // Bus values we need in the page
+//    {}, // Bus values we need in the page
     true // Show display header on/off
 );
 

lib/obp60task/PageWindRose.cpp

@@ -2,6 +2,7 @@
 
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
+#include "BoatDataCalibration.h"
 
 class PageWindRose : public Page
 {
@@ -51,6 +52,7 @@ public:
         GwApi::BoatValue *bvalue1 = pageData.values[0]; // First element in list (only one value by PageOneValue)
         String name1 = xdrDelete(bvalue1->getName());   // Value name
         name1 = name1.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue1, logger); // Check if boat data value is to be calibrated
         double value1 = bvalue1->value;                 // Value as double in SI unit
         bool valid1 = bvalue1->valid;                   // Valid information
         value1 = formatValue(bvalue1, *commonData).value;// Format only nesaccery for simulation data for pointer
@@ -65,6 +67,7 @@ public:
         GwApi::BoatValue *bvalue2 = pageData.values[1]; // Second element in list
         String name2 = xdrDelete(bvalue2->getName());   // Value name
         name2 = name2.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue2, logger); // Check if boat data value is to be calibrated
         double value2 = bvalue2->value;                 // Value as double in SI unit
         bool valid2 = bvalue2->valid;                   // Valid information 
         String svalue2 = formatValue(bvalue2, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -78,6 +81,7 @@ public:
         GwApi::BoatValue *bvalue3 = pageData.values[2]; // Third element in list
         String name3 = xdrDelete(bvalue3->getName());   // Value name
         name3 = name3.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue3, logger); // Check if boat data value is to be calibrated
         double value3 = bvalue3->value;                 // Value as double in SI unit
         bool valid3 = bvalue3->valid;                   // Valid information 
         String svalue3 = formatValue(bvalue3, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -91,6 +95,7 @@ public:
         GwApi::BoatValue *bvalue4 = pageData.values[3]; // Fourth element in list
         String name4 = xdrDelete(bvalue4->getName());   // Value name
         name4 = name4.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue4, logger); // Check if boat data value is to be calibrated
         double value4 = bvalue4->value;                 // Value as double in SI unit
         bool valid4 = bvalue4->valid;                   // Valid information 
         String svalue4 = formatValue(bvalue4, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -104,6 +109,7 @@ public:
         GwApi::BoatValue *bvalue5 = pageData.values[4]; // Fifth element in list
         String name5 = xdrDelete(bvalue5->getName());   // Value name
         name5 = name5.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue5, logger); // Check if boat data value is to be calibrated
         double value5 = bvalue5->value;                 // Value as double in SI unit
         bool valid5 = bvalue5->valid;                   // Valid information 
         String svalue5 = formatValue(bvalue5, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -117,6 +123,7 @@ public:
         GwApi::BoatValue *bvalue6 = pageData.values[5]; // Sixth element in list
         String name6 = xdrDelete(bvalue6->getName());   // Value name
         name6 = name6.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue6, logger); // Check if boat data value is to be calibrated
         double value6 = bvalue6->value;                 // Value as double in SI unit
         bool valid6 = bvalue6->valid;                   // Valid information 
         String svalue6 = formatValue(bvalue6, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places

lib/obp60task/PageWindRoseFlex.cpp

@@ -2,34 +2,20 @@
 
 #include "Pagedata.h"
 #include "OBP60Extensions.h"
+#include "BoatDataCalibration.h"
 
 class PageWindRoseFlex : public Page
 {
 int16_t lp = 80;                    // Pointer length
-char source = 'A';		    // data source (A)pparent | (T)rue
 
 public:
     PageWindRoseFlex(CommonData &common){
         commonData = &common;
         common.logger->logDebug(GwLog::LOG,"Instantiate PageWindRoseFlex");
     }
-    virtual void setupKeys(){
-        Page::setupKeys();
-        commonData->keydata[1].label = "SRC";
-    }
 
     // Key functions
     virtual int handleKey(int key){
-	if(key == 2){ 
-	 // Code for set source 
-	    if(source == 'A'){ 
-		    source = 'T'; 
-	    } else { 
-		    source = 'A'; 
-	    } 
-	   } 
-	return key;               // Commit the key
-
         // Code for keylock
         if(key == 11){
             commonData->keylock = !commonData->keylock;
@@ -54,11 +40,6 @@ public:
         static String unit5old = "";
         static String svalue6old = "";
         static String unit6old = "";
-        static GFXfont name3font;
-        static GFXfont name4font;
-        static GFXfont name5font;
-        static GFXfont name6font;
-
 
         // Get config data
         String lengthformat = config->getString(config->lengthFormat);
@@ -67,19 +48,14 @@ public:
         String flashLED = config->getString(config->flashLED);
         String backlightMode = config->getString(config->backlight);
 
-	GwApi::BoatValue *bvalue1; // Value 1 for angle
-        GwApi::BoatValue *bvalue2; // Value 2 for speed
-
-	// Get boat value for wind angle (AWA/TWA), shown by pointer
-        if (source == 'A') {
-            bvalue1 = pageData.values[4];
-        } else {
-            bvalue1 = pageData.values[6];
-        }
-        String name1 = bvalue1->getName().c_str();      // Value name
+        // Get boat values #1
+        GwApi::BoatValue *bvalue1 = pageData.values[0]; // First element in list (only one value by PageOneValue)
+        String name1 = xdrDelete(bvalue1->getName());   // Value name
         name1 = name1.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue1, logger); // Check if boat data value is to be calibrated
         double value1 = bvalue1->value;                 // Value as double in SI unit
         bool valid1 = bvalue1->valid;                   // Valid information
+        value1 = formatValue(bvalue1, *commonData).value;// Format only nesaccery for simulation data for pointer
         String svalue1 = formatValue(bvalue1, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
         String unit1 = formatValue(bvalue1, *commonData).unit;        // Unit of value
         if(valid1 == true){
@@ -87,19 +63,13 @@ public:
             unit1old = unit1;                           // Save old unit
         }
 
-	// Get boat value for wind speed (AWS/TWS), shown in top left corner
-        if (source == 'A') {
-            bvalue2 =pageData.values[5];
-        } else {
-            bvalue2 = pageData.values[7];
-        }
-        String name2 = bvalue2->getName().c_str();      // Value name
+        // Get boat values #2
+        GwApi::BoatValue *bvalue2 = pageData.values[1]; // Second element in list
+        String name2 = xdrDelete(bvalue2->getName());   // Value name
         name2 = name2.substring(0, 6);                  // String length limit for value name
+        calibrationData.calibrateInstance(bvalue2, logger); // Check if boat data value is to be calibrated
         double value2 = bvalue2->value;                 // Value as double in SI unit
         bool valid2 = bvalue2->valid;                   // Valid information
-        if (simulation) {
-            value2 = 0.62731; // some random value
-        }
         String svalue2 = formatValue(bvalue2, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
         String unit2 = formatValue(bvalue2, *commonData).unit;        // Unit of value
         if(valid2 == true){
@@ -107,18 +77,11 @@ public:
             unit2old = unit2;                           // Save old unit
         }
 
-
-
-        // Get boat value for bottom left  corner
-        GwApi::BoatValue *bvalue3 = pageData.values[0]; 
+        // Get boat values #3
+        GwApi::BoatValue *bvalue3 = pageData.values[2]; // Third element in list
         String name3 = xdrDelete(bvalue3->getName());   // Value name
         name3 = name3.substring(0, 6);                  // String length limit for value name
-        if (name3.length()>3){
-            name3font=Ubuntu_Bold8pt8b;
-        }
-        else{
-            name3font=Ubuntu_Bold12pt8b;
-        }
+        calibrationData.calibrateInstance(bvalue3, logger); // Check if boat data value is to be calibrated
         double value3 = bvalue3->value;                 // Value as double in SI unit
         bool valid3 = bvalue3->valid;                   // Valid information
         String svalue3 = formatValue(bvalue3, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -128,16 +91,11 @@ public:
             unit3old = unit3;                           // Save old unit
         }
 
-        // Get boat value  for top right corner
-        GwApi::BoatValue *bvalue4 = pageData.values[1]; 
+        // Get boat values #4
+        GwApi::BoatValue *bvalue4 = pageData.values[3]; // Fourth element in list
         String name4 = xdrDelete(bvalue4->getName());   // Value name
         name4 = name4.substring(0, 6);                  // String length limit for value name
-        if (name4.length()>3){
-            name4font=Ubuntu_Bold8pt8b;
-        }
-        else{
-            name4font=Ubuntu_Bold12pt8b;
-        }
+        calibrationData.calibrateInstance(bvalue4, logger); // Check if boat data value is to be calibrated
         double value4 = bvalue4->value;                 // Value as double in SI unit
         bool valid4 = bvalue4->valid;                   // Valid information
         String svalue4 = formatValue(bvalue4, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -147,16 +105,11 @@ public:
             unit4old = unit4;                           // Save old unit
         }
 
-        // Get boat value bottom right corner
-        GwApi::BoatValue *bvalue5 = pageData.values[2]; 
+        // Get boat values #5
+        GwApi::BoatValue *bvalue5 = pageData.values[4]; // Fifth element in list
         String name5 = xdrDelete(bvalue5->getName());   // Value name
         name5 = name5.substring(0, 6);                  // String length limit for value name
-        if (name5.length()>3){
-            name5font=Ubuntu_Bold8pt8b;
-        }
-        else{
-            name5font=Ubuntu_Bold12pt8b;
-        }
+        calibrationData.calibrateInstance(bvalue5, logger); // Check if boat data value is to be calibrated
         double value5 = bvalue5->value;                 // Value as double in SI unit
         bool valid5 = bvalue5->valid;                   // Valid information
         String svalue5 = formatValue(bvalue5, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -166,16 +119,11 @@ public:
             unit5old = unit5;                           // Save old unit
         }
 
-        // Get boat value for center (name is not displayed)
-        GwApi::BoatValue *bvalue6 = pageData.values[3]; 
+        // Get boat values #5
+        GwApi::BoatValue *bvalue6 = pageData.values[5]; // Sixth element in list
         String name6 = xdrDelete(bvalue6->getName());   // Value name
         name6 = name6.substring(0, 6);                  // String length limit for value name
-        if (name6.length()>3){
-            name6font=Ubuntu_Bold8pt8b;
-        }
-        else{
-            name6font=Ubuntu_Bold8pt8b;
-        }
+        calibrationData.calibrateInstance(bvalue6, logger); // Check if boat data value is to be calibrated
         double value6 = bvalue6->value;                 // Value as double in SI unit
         bool valid6 = bvalue6->valid;                   // Valid information
         String svalue6 = formatValue(bvalue6, *commonData).svalue;    // Formatted value as string including unit conversion and switching decimal places
@@ -185,7 +133,6 @@ public:
             unit6old = unit6;                           // Save old unit
         }
 
-
         // Optical warning by limit violation (unused)
         if(String(flashLED) == "Limit Violation"){
             setBlinkingLED(false);
@@ -204,7 +151,7 @@ public:
 
         getdisplay().setTextColor(commonData->fgcolor);
 
-        // Show AWS or TWS top left
+        // Show value 2 at position of value 1 (top left)
         getdisplay().setFont(&DSEG7Classic_BoldItalic20pt7b);
         getdisplay().setCursor(10, 65);
         getdisplay().print(svalue2);                     // Value
@@ -224,11 +171,11 @@ public:
         // Horizintal separator left
         getdisplay().fillRect(0, 149, 60, 3, commonData->fgcolor);
 
-        // Show value 3 (=first user-configured parameter) at bottom left
+        // Show value 3 at bottom left
         getdisplay().setFont(&DSEG7Classic_BoldItalic20pt7b);
         getdisplay().setCursor(10, 270);
         getdisplay().print(svalue3);                     // Value
-        getdisplay().setFont(&name3font);
+        getdisplay().setFont(&Ubuntu_Bold12pt8b);
         getdisplay().setCursor(10, 220);
         getdisplay().print(name3);                       // Name
         getdisplay().setFont(&Ubuntu_Bold8pt8b);
@@ -241,15 +188,21 @@ public:
             getdisplay().print(unit3old);                // Unit
         }
 
-        // Show value 4 (=second user-configured parameter) at top right
+        // Show value 4 at top right
         getdisplay().setFont(&DSEG7Classic_BoldItalic20pt7b);
         getdisplay().setCursor(295, 65);
+        if(valid3 == true){
+           // getdisplay().print(abs(value3 * 180 / M_PI), 0); // Value
             getdisplay().print(svalue4);     // Value
-        getdisplay().setFont(&name4font);
-        getdisplay().setCursor(325, 95);
+        }
+        else{
+            getdisplay().print("---");                   // Value
+        }
+        getdisplay().setFont(&Ubuntu_Bold12pt8b);
+        getdisplay().setCursor(335, 95);
         getdisplay().print(name4);                       // Name
         getdisplay().setFont(&Ubuntu_Bold8pt8b);
-        getdisplay().setCursor(325, 115);
+        getdisplay().setCursor(335, 115);
         getdisplay().print(" ");
         if(holdvalues == false){
             getdisplay().print(unit4);                   // Unit
@@ -261,15 +214,15 @@ public:
         // Horizintal separator right
         getdisplay().fillRect(340, 149, 80, 3, commonData->fgcolor);
 
-        // Show value 5 (=third user-configured parameter) at bottom right
+        // Show value 5 at bottom right
         getdisplay().setFont(&DSEG7Classic_BoldItalic20pt7b);
         getdisplay().setCursor(295, 270);
         getdisplay().print(svalue5);                     // Value
-        getdisplay().setFont(&name5font);
-        getdisplay().setCursor(325, 220);
+        getdisplay().setFont(&Ubuntu_Bold12pt8b);
+        getdisplay().setCursor(335, 220);
         getdisplay().print(name5);                       // Name
         getdisplay().setFont(&Ubuntu_Bold8pt8b);
-        getdisplay().setCursor(325, 190);
+        getdisplay().setCursor(335, 190);
         getdisplay().print(" ");
         if(holdvalues == false){
             getdisplay().print(unit5);                   // Unit
@@ -371,51 +324,30 @@ public:
         }
 
         // Center circle
-        getdisplay().fillCircle(200, 150, startwidth + 8, commonData->bgcolor);
-        getdisplay().fillCircle(200, 150, startwidth + 6, commonData->fgcolor);
-        getdisplay().fillCircle(200, 150, startwidth + 4, commonData->bgcolor);
-    	getdisplay().setFont(&Ubuntu_Bold10pt8b);
-    	if (source=='A'){
-		getdisplay().setCursor(193, 155);
-	}
-	else {
-		getdisplay().setCursor(195, 156);
-	}
-    	getdisplay().print({source}); 
-
+        getdisplay().fillCircle(200, 150, startwidth + 6, commonData->bgcolor);
+        getdisplay().fillCircle(200, 150, startwidth + 4, commonData->fgcolor);
 
 //*******************************************************************************************
 
-	// Show value6 (=fourth user-configured parameter) 
-if ( cos(value1) > 0){ 
-    //pointer points upwards 
+        // Show value6, so that it does not collide with the wind pointer
         getdisplay().setFont(&DSEG7Classic_BoldItalic16pt7b);
+        if (cos(value1) > 0){
             getdisplay().setCursor(160, 200);
             getdisplay().print(svalue6);                     // Value
             getdisplay().setFont(&Ubuntu_Bold8pt8b);
             getdisplay().setCursor(190, 215);
-    getdisplay().print(" ");
-    if(holdvalues == false){
-        getdisplay().print(unit6);                   // Unit
-    }
-    else{  
-        getdisplay().print(unit6old);                // Unit
-    }
-}
-else{ 
-    // pointer points downwards
-    getdisplay().setFont(&DSEG7Classic_BoldItalic16pt7b);
+        } else{
             getdisplay().setCursor(160, 130);
             getdisplay().print(svalue6);                     // Value
             getdisplay().setFont(&Ubuntu_Bold8pt8b);
             getdisplay().setCursor(190, 90);
+        }
         getdisplay().print(" ");
         if(holdvalues == false){
             getdisplay().print(unit6);                   // Unit
         }
         else{
             getdisplay().print(unit6old);                // Unit
-    }
         }
 
         return PAGE_UPDATE;
@@ -429,14 +361,13 @@ static Page *createPage(CommonData &common){
  * with the code below we make this page known to the PageTask
  * we give it a type (name) that can be selected in the config
  * we define which function is to be called
- * and we provide the number of user parameters we expect (4 here)
+ * and we provide the number of user parameters we expect (0 here)
  * and will will provide the names of the fixed values we need
  */
 PageDescription registerPageWindRoseFlex(
     "WindRoseFlex", // Page name
     createPage,     // Action
-    4,              // Number of bus values depends on selection in Web configuration
-    {"AWA", "AWS", "TWA", "TWS"},    // fixed  values we need in the page. They are inserted AFTER the web-configured values.	
+    6,              // Number of bus values depends on selection in Web configuration; was zero
     true            // Show display header on/off
 );
 

lib/obp60task/Pagedata.h

@@ -4,20 +4,19 @@
 #include <functional>
 #include <vector>
 #include "LedSpiTask.h"
+#include "OBPRingBuffer.h"
+#include "OBPDataOperations.h"
 
 #define MAX_PAGE_NUMBER 10    // Max number of pages for show data
 
 typedef std::vector<GwApi::BoatValue *> ValueList;
 
-class HstryBuffers;
-
 typedef struct{
-  GwApi *api;
   String pageName;
   uint8_t pageNumber; // page number in sequence of visible pages
   //the values will always contain the user defined values first
   ValueList values;
-  HstryBuffers* hstryBuffers; // list of all boat history buffers
+  tBoatHstryData boatHstry;
 } PageData;
 
 // Sensor data structure (only for extended sensors, not for NMEA bus sensors)
@@ -51,7 +50,7 @@ typedef struct{
   double rotationAngle = 0;     // Rotation angle in radiant
   bool validRotAngle = false;   // Valid flag magnet present for rotation sensor
   struct tm rtcTime;            // UTC time from internal RTC
-  bool rtcValid = false;        // Internal RTC chip
+  bool rtcValid = false;
   int sunsetHour = 0;
   int sunsetMinute = 0;
   int sunriseHour = 0;
@@ -101,15 +100,15 @@ typedef struct{
 
 typedef struct{
   GwApi::Status status;
-    GwLog *logger = nullptr;
-    GwConfigHandler *config = nullptr;
+  GwLog *logger=NULL;
+  GwConfigHandler *config=NULL;
   SensorData data;
   SunData sundata;
   TouchKeyData keydata[6];
   BacklightData backlight;
   AlarmData alarm;
-    GwApi::BoatValue *time = nullptr;
-    GwApi::BoatValue *date = nullptr;
+  GwApi::BoatValue *time=NULL;
+  GwApi::BoatValue *date=NULL;
   uint16_t fgcolor;
   uint16_t bgcolor;
   bool keylock = false;
@@ -124,7 +123,6 @@ class Page{
     int refreshtime = 1000;
     virtual int displayPage(PageData &pageData)=0;
     virtual void displayNew(PageData &pageData){}
-    virtual void leavePage(PageData &pageData){}
     virtual void setupKeys() {
 #ifdef HARDWARE_V21
         commonData->keydata[0].label = "";
@@ -183,9 +181,9 @@ class PageDescription{
 
 class PageStruct{
     public:
-        Page *page = nullptr;
+        Page *page=NULL;
         PageData parameters;
-        PageDescription *description = nullptr;
+        PageDescription *description=NULL;
 };
 
 // Standard format functions without overhead
@@ -196,16 +194,10 @@ String formatLongitude(double lon);
 
 // Structure for formatted boat values
 typedef struct{
-  double value; // SI value of boat data value
-  double cvalue; // value converted to target unit
-  String svalue; // value converted to target unit and formatted
-  String unit; // target value unit
+  double value;
+  String svalue;
+  String unit;
 } FormattedData;
 
 // Formatter for boat values
 FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata);
-FormattedData formatValue(GwApi::BoatValue *value, CommonData &commondata, bool ignoreSimuDataSetting);
-
-// Helper method for conversion of any data value from SI to user defined format (defined in OBP60Formatter)
-double convertValue(const double &value, const String &format, CommonData &commondata);
-double convertValue(const double &value, const String &name, const String &format, CommonData &commondata);

lib/obp60task/fonts/IBM8x8px.h

@@ -1,202 +0,0 @@
-const uint8_t IBM8x8pxBitmaps[] PROGMEM = {
-	0x00,				/* 0x20 space */
-	0x6F, 0xF6, 0x60, 0x60,	/* 0x21 exclam */
-	0xDE, 0xF6,			/* 0x22 quotedbl */
-	0x6C, 0xDB, 0xFB, 0x6F, 0xED, 0x9B, 0x00,	/* 0x23 numbersign */
-	0x31, 0xFC, 0x1E, 0x0F, 0xE3, 0x00,	/* 0x24 dollar */
-	0xC7, 0x98, 0x61, 0x86, 0x78, 0xC0,	/* 0x25 percent */
-	0x38, 0xD8, 0xE3, 0xBD, 0xD9, 0x9D, 0x80,	/* 0x26 ampersand */
-	0x6F, 0x00,			/* 0x27 quotesingle */
-	0x36, 0xCC, 0xC6, 0x30,	/* 0x28 parenleft */
-	0xC6, 0x33, 0x36, 0xC0,	/* 0x29 parenright */
-	0x66, 0x3C, 0xFF, 0x3C, 0x66,	/* 0x2A asterisk */
-	0x30, 0xCF, 0xCC, 0x30,	/* 0x2B plus */
-	0x6F, 0x00,			/* 0x2C comma */
-	0xFC,				/* 0x2D hyphen */
-	0xF0,				/* 0x2E period */
-	0x06, 0x18, 0x61, 0x86, 0x18, 0x20, 0x00,	/* 0x2F slash */
-	0x7D, 0x8F, 0x3E, 0xFF, 0x7C, 0xDF, 0x00,	/* 0x30 zero */
-	0x31, 0xC3, 0x0C, 0x30, 0xCF, 0xC0,	/* 0x31 one */
-	0x7B, 0x30, 0xCE, 0x63, 0x1F, 0xC0,	/* 0x32 two */
-	0x7B, 0x30, 0xCE, 0x0F, 0x37, 0x80,	/* 0x33 three */
-	0x1C, 0x79, 0xB6, 0x6F, 0xE1, 0x87, 0x80,	/* 0x34 four */
-	0xFF, 0x0F, 0x83, 0x0F, 0x37, 0x80,	/* 0x35 five */
-	0x39, 0x8C, 0x3E, 0xCF, 0x37, 0x80,	/* 0x36 six */
-	0xFF, 0x30, 0xC6, 0x30, 0xC3, 0x00,	/* 0x37 seven */
-	0x7B, 0x3C, 0xDE, 0xCF, 0x37, 0x80,	/* 0x38 eight */
-	0x7B, 0x3C, 0xDF, 0x0C, 0x67, 0x00,	/* 0x39 nine */
-	0xF0, 0xF0,			/* 0x3A colon */
-	0x6C, 0x37, 0x80,	/* 0x3B semicolon */
-	0x19, 0x99, 0x86, 0x18, 0x60,	/* 0x3C less */
-	0xFC, 0x00, 0x3F,	/* 0x3D equal */
-	0xC3, 0x0C, 0x33, 0x33, 0x00,	/* 0x3E greater */
-	0x7B, 0x30, 0xC6, 0x30, 0x03, 0x00,	/* 0x3F question */
-	0x7D, 0x8F, 0x7E, 0xFD, 0xF8, 0x1E, 0x00,	/* 0x40 at */
-	0x31, 0xEC, 0xF3, 0xFF, 0x3C, 0xC0,	/* 0x41 A */
-	0xFC, 0xCD, 0x9B, 0xE6, 0x6C, 0xFF, 0x00,	/* 0x42 B */
-	0x3C, 0xCF, 0x06, 0x0C, 0x0C, 0xCF, 0x00,	/* 0x43 C */
-	0xF8, 0xD9, 0x9B, 0x36, 0x6D, 0xBE, 0x00,	/* 0x44 D */
-	0xFE, 0xC5, 0xA3, 0xC6, 0x8C, 0x7F, 0x80,	/* 0x45 E */
-	0xFE, 0xC5, 0xA3, 0xC6, 0x8C, 0x3C, 0x00,	/* 0x46 F */
-	0x3C, 0xCF, 0x06, 0x0C, 0xEC, 0xCF, 0x80,	/* 0x47 G */
-	0xCF, 0x3C, 0xFF, 0xCF, 0x3C, 0xC0,	/* 0x48 H */
-	0xF6, 0x66, 0x66, 0xF0,	/* 0x49 I */
-	0x1E, 0x18, 0x30, 0x6C, 0xD9, 0x9E, 0x00,	/* 0x4A J */
-	0xE6, 0xCD, 0xB3, 0xC6, 0xCC, 0xF9, 0x80,	/* 0x4B K */
-	0xF0, 0xC1, 0x83, 0x06, 0x2C, 0xFF, 0x80,	/* 0x4C L */
-	0xC7, 0xDF, 0xFF, 0xFD, 0x78, 0xF1, 0x80,	/* 0x4D M */
-	0xC7, 0xCF, 0xDE, 0xFC, 0xF8, 0xF1, 0x80,	/* 0x4E N */
-	0x38, 0xDB, 0x1E, 0x3C, 0x6D, 0x8E, 0x00,	/* 0x4F O */
-	0xFC, 0xCD, 0x9B, 0xE6, 0x0C, 0x3C, 0x00,	/* 0x50 P */
-	0x7B, 0x3C, 0xF3, 0xDD, 0xE1, 0xC0,	/* 0x51 Q */
-	0xFC, 0xCD, 0x9B, 0xE6, 0xCC, 0xF9, 0x80,	/* 0x52 R */
-	0x7B, 0x3E, 0x1C, 0x1F, 0x37, 0x80,	/* 0x53 S */
-	0xFE, 0xD3, 0x0C, 0x30, 0xC7, 0x80,	/* 0x54 T */
-	0xCF, 0x3C, 0xF3, 0xCF, 0x3F, 0xC0,	/* 0x55 U */
-	0xCF, 0x3C, 0xF3, 0xCD, 0xE3, 0x00,	/* 0x56 V */
-	0xC7, 0x8F, 0x1E, 0xBF, 0xFD, 0xF1, 0x80,	/* 0x57 W */
-	0xC7, 0x8D, 0xB1, 0xC3, 0x8D, 0xB1, 0x80,	/* 0x58 X */
-	0xCF, 0x3C, 0xDE, 0x30, 0xC7, 0x80,	/* 0x59 Y */
-	0xFF, 0x8E, 0x30, 0xC3, 0x2C, 0xFF, 0x80,	/* 0x5A Z */
-	0xFC, 0xCC, 0xCC, 0xF0,	/* 0x5B bracketleft */
-	0xC0, 0xC0, 0xC0, 0xC0, 0xC0, 0xC0, 0x80,	/* 0x5C backslash */
-	0xF3, 0x33, 0x33, 0xF0,	/* 0x5D bracketright */
-	0x10, 0x71, 0xB6, 0x30,	/* 0x5E asciicircum */
-	0xFF,				/* 0x5F underscore */
-	0xD9, 0x80,			/* 0x60 grave */
-	0x78, 0x19, 0xF6, 0x67, 0x60,	/* 0x61 a */
-	0xE0, 0xC1, 0x83, 0xE6, 0x6C, 0xF7, 0x00,	/* 0x62 b */
-	0x7B, 0x3C, 0x33, 0x78,	/* 0x63 c */
-	0x1C, 0x18, 0x33, 0xEC, 0xD9, 0x9D, 0x80,	/* 0x64 d */
-	0x7B, 0x3F, 0xF0, 0x78,	/* 0x65 e */
-	0x39, 0xB6, 0x3C, 0x61, 0x8F, 0x00,	/* 0x66 f */
-	0x77, 0x9B, 0x33, 0xE0, 0xDF, 0x00,	/* 0x67 g */
-	0xE0, 0xC1, 0xB3, 0xB6, 0x6C, 0xF9, 0x80,	/* 0x68 h */
-	0x60, 0xE6, 0x66, 0xF0,	/* 0x69 i */
-	0x0C, 0x00, 0xC3, 0x0F, 0x3C, 0xDE,	/* 0x6A j */
-	0xE0, 0xC1, 0x9B, 0x67, 0x8D, 0xB9, 0x80,	/* 0x6B k */
-	0xE6, 0x66, 0x66, 0xF0,	/* 0x6C l */
-	0xCD, 0xFF, 0xFE, 0xBC, 0x60,	/* 0x6D m */
-	0xFB, 0x3C, 0xF3, 0xCC,	/* 0x6E n */
-	0x7B, 0x3C, 0xF3, 0x78,	/* 0x6F o */
-	0xDC, 0xCD, 0x9B, 0xE6, 0x1E, 0x00,	/* 0x70 p */
-	0x77, 0x9B, 0x33, 0xE0, 0xC3, 0xC0,	/* 0x71 q */
-	0xDC, 0xED, 0x9B, 0x0F, 0x00,	/* 0x72 r */
-	0x7F, 0x07, 0x83, 0xF8,	/* 0x73 s */
-	0x23, 0x3E, 0xC6, 0x34, 0xC0,	/* 0x74 t */
-	0xCD, 0x9B, 0x36, 0x67, 0x60,	/* 0x75 u */
-	0xCF, 0x3C, 0xDE, 0x30,	/* 0x76 v */
-	0xC7, 0xAF, 0xFF, 0xF6, 0xC0,	/* 0x77 w */
-	0xC6, 0xD8, 0xE3, 0x6C, 0x60,	/* 0x78 x */
-	0xCF, 0x3C, 0xDF, 0x0F, 0xE0,	/* 0x79 y */
-	0xFE, 0x63, 0x19, 0xFC,	/* 0x7A z */
-	0x1C, 0xC3, 0x38, 0x30, 0xC1, 0xC0,	/* 0x7B braceleft */
-	0xFC, 0xFC,			/* 0x7C bar */
-	0xE0, 0xC3, 0x07, 0x30, 0xCE, 0x00,	/* 0x7D braceright */
-	0x77, 0xB8,			/* 0x7E asciitilde */
-	0x10, 0x71, 0xB6, 0x3C, 0x7F, 0xC0	/* 0x7F uni007F */
-};
-
-const GFXglyph IBM8x8pxGlyphs[] PROGMEM = {
-	{ 0, 1, 1, 2, 0, -1 }, /* 0x20 space */
-	{ 1, 4, 7, 5, 0, -7 }, /* 0x21 exclam */
-	{ 5, 5, 3, 6, 0, -7 }, /* 0x22 quotedbl */
-	{ 7, 7, 7, 8, 0, -7 }, /* 0x23 numbersign */
-	{ 14, 6, 7, 7, 0, -7 }, /* 0x24 dollar */
-	{ 20, 7, 6, 8, 0, -6 }, /* 0x25 percent */
-	{ 26, 7, 7, 8, 0, -7 }, /* 0x26 ampersand */
-	{ 33, 3, 3, 4, 0, -7 }, /* 0x27 quotesingle */
-	{ 35, 4, 7, 5, 0, -7 }, /* 0x28 parenleft */
-	{ 39, 4, 7, 5, 0, -7 }, /* 0x29 parenright */
-	{ 43, 8, 5, 9, 0, -6 }, /* 0x2A asterisk */
-	{ 48, 6, 5, 7, 0, -6 }, /* 0x2B plus */
-	{ 52, 3, 3, 4, 0, -2 }, /* 0x2C comma */
-	{ 54, 6, 1, 7, 0, -4 }, /* 0x2D hyphen */
-	{ 55, 2, 2, 3, 0, -2 }, /* 0x2E period */
-	{ 56, 7, 7, 8, 0, -7 }, /* 0x2F slash */
-	{ 63, 7, 7, 8, 0, -7 }, /* 0x30 zero */
-	{ 70, 6, 7, 7, 0, -7 }, /* 0x31 one */
-	{ 76, 6, 7, 7, 0, -7 }, /* 0x32 two */
-	{ 82, 6, 7, 7, 0, -7 }, /* 0x33 three */
-	{ 88, 7, 7, 8, 0, -7 }, /* 0x34 four */
-	{ 95, 6, 7, 7, 0, -7 }, /* 0x35 five */
-	{ 101, 6, 7, 7, 0, -7 }, /* 0x36 six */
-	{ 107, 6, 7, 7, 0, -7 }, /* 0x37 seven */
-	{ 113, 6, 7, 7, 0, -7 }, /* 0x38 eight */
-	{ 119, 6, 7, 7, 0, -7 }, /* 0x39 nine */
-	{ 125, 2, 6, 3, 0, -6 }, /* 0x3A colon */
-	{ 127, 3, 6, 4, 0, -6 }, /* 0x3B semicolon */
-	{ 130, 5, 7, 6, 0, -7 }, /* 0x3C less */
-	{ 135, 6, 4, 7, 0, -5 }, /* 0x3D equal */
-	{ 138, 5, 7, 6, 0, -7 }, /* 0x3E greater */
-	{ 143, 6, 7, 7, 0, -7 }, /* 0x3F question */
-	{ 149, 7, 7, 8, 0, -7 }, /* 0x40 at */
-	{ 156, 6, 7, 7, 0, -7 }, /* 0x41 A */
-	{ 162, 7, 7, 8, 0, -7 }, /* 0x42 B */
-	{ 169, 7, 7, 8, 0, -7 }, /* 0x43 C */
-	{ 176, 7, 7, 8, 0, -7 }, /* 0x44 D */
-	{ 183, 7, 7, 8, 0, -7 }, /* 0x45 E */
-	{ 190, 7, 7, 8, 0, -7 }, /* 0x46 F */
-	{ 197, 7, 7, 8, 0, -7 }, /* 0x47 G */
-	{ 204, 6, 7, 7, 0, -7 }, /* 0x48 H */
-	{ 210, 4, 7, 5, 0, -7 }, /* 0x49 I */
-	{ 214, 7, 7, 8, 0, -7 }, /* 0x4A J */
-	{ 221, 7, 7, 8, 0, -7 }, /* 0x4B K */
-	{ 228, 7, 7, 8, 0, -7 }, /* 0x4C L */
-	{ 235, 7, 7, 8, 0, -7 }, /* 0x4D M */
-	{ 242, 7, 7, 8, 0, -7 }, /* 0x4E N */
-	{ 249, 7, 7, 8, 0, -7 }, /* 0x4F O */
-	{ 256, 7, 7, 8, 0, -7 }, /* 0x50 P */
-	{ 263, 6, 7, 7, 0, -7 }, /* 0x51 Q */
-	{ 269, 7, 7, 8, 0, -7 }, /* 0x52 R */
-	{ 276, 6, 7, 7, 0, -7 }, /* 0x53 S */
-	{ 282, 6, 7, 7, 0, -7 }, /* 0x54 T */
-	{ 288, 6, 7, 7, 0, -7 }, /* 0x55 U */
-	{ 294, 6, 7, 7, 0, -7 }, /* 0x56 V */
-	{ 300, 7, 7, 8, 0, -7 }, /* 0x57 W */
-	{ 307, 7, 7, 8, 0, -7 }, /* 0x58 X */
-	{ 314, 6, 7, 7, 0, -7 }, /* 0x59 Y */
-	{ 320, 7, 7, 8, 0, -7 }, /* 0x5A Z */
-	{ 327, 4, 7, 5, 0, -7 }, /* 0x5B bracketleft */
-	{ 331, 7, 7, 8, 0, -7 }, /* 0x5C backslash */
-	{ 338, 4, 7, 5, 0, -7 }, /* 0x5D bracketright */
-	{ 342, 7, 4, 8, 0, -7 }, /* 0x5E asciicircum */
-	{ 346, 8, 1, 9, 0, 0 }, /* 0x5F underscore */
-	{ 347, 3, 3, 4, 0, -7 }, /* 0x60 grave */
-	{ 349, 7, 5, 8, 0, -5 }, /* 0x61 a */
-	{ 354, 7, 7, 8, 0, -7 }, /* 0x62 b */
-	{ 361, 6, 5, 7, 0, -5 }, /* 0x63 c */
-	{ 365, 7, 7, 8, 0, -7 }, /* 0x64 d */
-	{ 372, 6, 5, 7, 0, -5 }, /* 0x65 e */
-	{ 376, 6, 7, 7, 0, -7 }, /* 0x66 f */
-	{ 382, 7, 6, 8, 0, -5 }, /* 0x67 g */
-	{ 388, 7, 7, 8, 0, -7 }, /* 0x68 h */
-	{ 395, 4, 7, 5, 0, -7 }, /* 0x69 i */
-	{ 399, 6, 8, 7, 0, -7 }, /* 0x6A j */
-	{ 405, 7, 7, 8, 0, -7 }, /* 0x6B k */
-	{ 412, 4, 7, 5, 0, -7 }, /* 0x6C l */
-	{ 416, 7, 5, 8, 0, -5 }, /* 0x6D m */
-	{ 421, 6, 5, 7, 0, -5 }, /* 0x6E n */
-	{ 425, 6, 5, 7, 0, -5 }, /* 0x6F o */
-	{ 429, 7, 6, 8, 0, -5 }, /* 0x70 p */
-	{ 435, 7, 6, 8, 0, -5 }, /* 0x71 q */
-	{ 441, 7, 5, 8, 0, -5 }, /* 0x72 r */
-	{ 446, 6, 5, 7, 0, -5 }, /* 0x73 s */
-	{ 450, 5, 7, 6, 0, -7 }, /* 0x74 t */
-	{ 455, 7, 5, 8, 0, -5 }, /* 0x75 u */
-	{ 460, 6, 5, 7, 0, -5 }, /* 0x76 v */
-	{ 464, 7, 5, 8, 0, -5 }, /* 0x77 w */
-	{ 469, 7, 5, 8, 0, -5 }, /* 0x78 x */
-	{ 474, 6, 6, 7, 0, -5 }, /* 0x79 y */
-	{ 479, 6, 5, 7, 0, -5 }, /* 0x7A z */
-	{ 483, 6, 7, 7, 0, -7 }, /* 0x7B braceleft */
-	{ 489, 2, 7, 3, 0, -7 }, /* 0x7C bar */
-	{ 491, 6, 7, 7, 0, -7 }, /* 0x7D braceright */
-	{ 497, 7, 2, 8, 0, -7 }, /* 0x7E asciitilde */
-	{ 499, 7, 6, 8, 0, -6 } /* 0x7F uni007F */
-};
-
-const GFXfont IBM8x8px PROGMEM = {
-  (uint8_t  *)IBM8x8pxBitmaps,
-  (GFXglyph *)IBM8x8pxGlyphs,
-  0x20, 0x7F, 8 };

lib/obp60task/gen_set.py

@@ -1,55 +1,47 @@
 #!/usr/bin/env python3
+# A tool to generate that part of config.json  that deals with pages and fields.
+#
+#Usage: 1. modify this script (e.g.add a page, change number of fields, etc.)
+#       2. Delete all lines from config.json from the curly backet before "name": "page1type"  to o the end of the file (as of today, delete from line 917 to the end of the File)
+#       3. run ./gen_set.py >> config.json
 
-"""
-A tool to generate that part of config.json that deals with pages and fields.
-
-Usage example:
-
- 1. Delete all lines from config.json from the curly backet before
-    "name": "page1type"  to the end of the file
-
- 2. run ./gen_set.py -d obp60 -p 10 >> config.json
-
-TODO Better handling of default pages
-
-"""
-
-import os
-import sys
-import getopt
-import re
 import json
 
-__version__ = "0.3"
+# List of all pages and the number of parameters they expect.
+no_of_fields_per_page = {
+    "Wind": 0,
+    "XTETrack": 0,
+    "Battery2": 0,
+    "Battery": 0,
+    "BME280": 0,
+    "Clock": 0,
+    "Compass" : 0,
+    "DST810": 0,
+    "Fluid": 1,
+    "FourValues2": 4,
+    "FourValues": 4,
+    "Generator": 0,
+    "KeelPosition": 0,
+    "OneValue": 1,
+    "RollPitch": 2,
+    "RudderPosition": 0,
+    "SixValues" : 6,
+    "Solar": 0,
+    "ThreeValues": 3,
+    "TwoValues": 2,
+    "Voltage": 0,
+    "WhitePage": 0,
+    "WindPlot": 0,
+    "WindRose": 0,
+    "WindRoseFlex": 6,
+    "Anchor", 0
+}
 
-def detect_pages(filename):
-    # returns a dictionary with page name and the number of gui fields
-    pagefiles = []
-    with open(filename, 'r') as fh:
-        pattern = r'extern PageDescription\s*register(Page[^;\s]*)'
-        for line in fh:
-            if "extern PageDescription" in line:
-                match = re.search(pattern, line)
-                if match:
-                    pagefiles.append(match.group(1))
-    try:
-        pagefiles.remove('PageSystem')
-    except ValueError:
-        pass
-    pagedata = {}
-    for pf in pagefiles:
-        filename = pf + ".cpp"
-        with open(filename, 'r') as fh:
-            content = fh.read()
-        pattern =  r'PageDescription\s*?register' + pf + r'\s*\(\s*"([^"]+)".*?\n\s*(\d+)'
-        match = re.search(pattern, content, re.DOTALL)
-        if match:
-            pagedata[match.group(1)] = int(match.group(2))
-    return pagedata
-
-def get_default_page(pageno):
+# No changes needed beyond this point
+# max number of pages supported by OBP60
+no_of_pages = 10
 # Default selection for each page
-    default_pages = (
+default_pages = [
     "Voltage",
     "WindRose",
     "OneValue",
@@ -59,51 +51,36 @@ def get_default_page(pageno):
     "FourValues2",
     "Clock",
     "RollPitch",
-        "Battery2"
-    )
-    if pageno > len(default_pages):
-        return "OneValue"
-    return default_pages[pageno - 1]
-
-def number_to_text(number):
-    if number < 0 or number > 99:
-        raise ValueError("Only numbers from 0 to 99 are allowed.")
-    numbers = ("zero", "one", "two", "three", "four", "five", "six", "seven",
-        "eight", "nine", "ten", "eleven", "twelve", "thirteen", "fourteen",
-        "fifteen", "sixteen", "seventeen", "eighteen", "nineteen")
-    tens = ("", "", "twenty", "thirty", "forty", "fifty", "sixty", "seventy",
-        "eighty", "ninety")
-    if number < 20:
-        return numbers[number]
-    else:
-        q, r = divmod(number, 10)
-        return tens[q] + numbers[r]
-
-def create_json(device, no_of_pages, pagedata):
-
-    pages = sorted(pagedata.keys())
-    max_no_of_fields_per_page = max(pagedata.values())
+    "Battery2",
+]
+numbers = [
+    "one",
+    "two",
+    "three",
+    "four",
+    "five",
+    "six",
+    "seven",
+    "eight",
+    "nine",
+    "ten",
+]
+pages = sorted(no_of_fields_per_page.keys())
+max_no_of_fields_per_page = max(no_of_fields_per_page.values())
 
 output = []
 
 for page_no in range(1, no_of_pages + 1):
-
-        category = f"{device.upper()} Page {page_no}"
-        capabilities = {device.lower(): "true"}
-        visiblepages = [str(vp) for vp in range(page_no, no_of_pages + 1)]
-
     page_data = {
         "name": f"page{page_no}type",
         "label": "Type",
         "type": "list",
-            "default": get_default_page(page_no),
+        "default": default_pages[page_no - 1],
         "description": f"Type of page for page {page_no}",
         "list": pages,
-            "category": category,
-            "capabilities": {device.lower(): "true"},
-            "condition": {
-                "visiblePages": visiblepages
-            },
+        "category": f"OBP60 Page {page_no}",
+        "capabilities": {"obp60": "true"},
+        "condition": [{"visiblePages": vp} for vp in range(page_no, no_of_pages + 1)],
         #"fields": [],
     }
     output.append(page_data)
@@ -114,13 +91,14 @@ def create_json(device, no_of_pages, pagedata):
             "label": f"Field {field_no}",
             "type": "boatData",
             "default": "",
-                "description": "The display for field {}".format(number_to_text(field_no)),
-                "category": category,
-                "capabilities": capabilities,
-                "condition": { 
-                    f"page{page_no}type": [ p for p in pages if pagedata[p] >= field_no ]
-                    ,"visiblePages": visiblepages
-                }
+            "description": f"The display for field {numbers[field_no - 1]}",
+            "category": f"OBP60 Page {page_no}",
+            "capabilities": {"obp60": "true"},
+            "condition": [
+                {f"page{page_no}type": page}
+                for page in pages
+                if no_of_fields_per_page[page] >= field_no
+            ],
         }
         output.append(field_data)
 
@@ -139,68 +117,17 @@ def create_json(device, no_of_pages, pagedata):
         {"l":"Fuel Gasoline (6)","v":"6"}
         ],
         "description": "Fluid type in tank",
-            "category": category,
-            "capabilities": capabilities,
-            "condition": {
-                f"page{page_no}type": "Fluid",
-                "visiblePages": visiblepages
-            }
+        "category": f"OBP60 Page {page_no}",
+        "capabilities": {
+        "obp60":"true"
+        },
+        "condition":[{f"page{page_no}type":"Fluid"}]
         } 
     output.append(fluid_data)
 
-        if device.upper() == 'OBP40':
-            windsource = {
-                "name": f"page{page_no}wndsrc",
-                "label": "Wind source",
-                "type": "list",
-                "default": "True wind",
-                "description": f"Wind source for page {page_no}: [true|apparent]",
-                "list": [
-                    "True wind",
-                    "Apparent wind"
-                ],
-                "category": category,
-                "capabilities": capabilities,
-                "condition": {
-                    f"page{page_no}type": "WindPlot",
-                    "visiblePages": visiblepages
-                }
-            }
-            output.append(windsource)
-
-    return json.dumps(output, indent=4)
-
-def usage():
-    print("{} v{}".format(os.path.basename(__file__), __version__))
-    print()
-    print("Command line options")
-    print(" -d --device     device name to use e.g. obp60")
-    print(" -p --pages      number of pages to create")
-    print(" -h              show this help")
-    print()
-
-if __name__ == '__main__':
-    try:
-        options, remainder = getopt.getopt(sys.argv[1:], 'd:p:', ['device=','--pages='])
-    except getopt.GetoptError as err:
-        print(err)
-        usage()
-        sys.exit(2)
-
-    device = "obp60"
-    no_of_pages = 10
-    for opt, arg in options:
-        if opt in ('-d', '--device'):
-            device = arg
-        elif opt in ('-p', '--pages'):
-            no_of_pages = int(arg)
-        elif opt == '-h':
-            usage()
-            sys.exit(0)
-
-    # automatic detect pages and number of fields from sourcecode
-    pagedata = detect_pages("obp60task.cpp")
-
-    json_output = create_json(device, no_of_pages, pagedata)
+json_output = json.dumps(output, indent=4)
+# print omitting first and last line containing [ ] of JSON array
+#print(json_output[1:-1])
 # print omitting first line containing [  of JSON array
 print(json_output[1:])
+# print(",")

lib/obp60task/index.js

@@ -1,14 +0,0 @@
-// Add a new register card in web configuration interface
-// This is a Java Script! 
-(function(){
-    const api=window.esp32nmea2k;
-    if (! api) return;
-    const tabName="Screen";
-    api.registerListener((id, data) => {
-    //    if (!data.testboard) return; //do nothing if we are not active
-        let page = api.addTabPage(tabName, "Screen");
-        api.addEl('button', '', page, 'Screenshot').addEventListener('click', function (ev) {
-	window.open('/api/user/OBP60Task/screenshot', 'screenshot');
-        })
-    }, api.EVENTS.init);
-})();

lib/obp60task/obp60task.cpp

@@ -12,13 +12,20 @@
 #include <GxEPD2_BW.h>                  // GxEPD2 lib for b/w E-Ink displays
 #include "OBP60Extensions.h"            // Functions lib for extension board
 #include "OBP60Keypad.h"                // Functions for keypad
+#include "BoatDataCalibration.h"        // Functions lib for data instance calibration
+#include "OBPRingBuffer.h"              // Functions lib with ring buffer for history storage of some boat data
 #include "OBPDataOperations.h"          // Functions lib for data operations such as true wind calculation
 
 #ifdef BOARD_OBP40S3
-#include "driver/rtc_io.h"              // Needs for weakup from deep sleep
+#include "driver/rtc_io.h"              // Needs for wakeup from deep sleep
+#include <FS.h>                         // SD-Card access
+#include <SD.h>
 #include <SPI.h>
 #endif
 
+// True type character sets includes
+// See OBP60ExtensionPort.cpp
+
 // Pictures
 //#include GxEPD_BitmapExamples         // Example picture
 #include "MFD_OBP60_400x300_sw.h"       // MFD with logo
@@ -27,6 +34,7 @@
 #include "OBP60QRWiFi.h"                // Functions lib for WiFi QR code
 #include "OBPSensorTask.h"              // Functions lib for sensor data
 
+
 // Global vars
 bool initComplete = false;      // Initialization complete
 int taskRunCounter = 0;         // Task couter for loop section
@@ -39,23 +47,63 @@ void OBP60Init(GwApi *api){
     GwConfigHandler *config = api->getConfig();
 
     // Set a new device name and hidden the original name in the main config
-    String devicename = config->getConfigItem(config->deviceName, true)->asString();
-    config->setValue(GwConfigDefinitions::systemName, devicename, GwConfigInterface::ConfigType::HIDDEN);
+    String devicename = api->getConfig()->getConfigItem(api->getConfig()->deviceName,true)->asString();
+    api->getConfig()->setValue(GwConfigDefinitions::systemName, devicename, GwConfigInterface::ConfigType::HIDDEN);
 
-    logger->prefix = devicename + ":";
-    logger->logDebug(GwLog::LOG,"obp60init running");
+    api->getLogger()->logDebug(GwLog::LOG,"obp60init running");
     
     // Check I2C devices
     
-    // Init power
-    String powermode = config->getConfigItem(config->powerMode,true)->asString();
-    logger->logDebug(GwLog::DEBUG, "Power Mode is: %s", powermode.c_str());
-    powerInit(powermode);
 
     // Init hardware
     hardwareInit(api);
 
+    // Init power rail 5.0V
+    String powermode = api->getConfig()->getConfigItem(api->getConfig()->powerMode,true)->asString();
+    api->getLogger()->logDebug(GwLog::DEBUG,"Power Mode is: %s", powermode.c_str());
+    if(powermode == "Max Power" || powermode == "Only 5.0V"){
+        #ifdef HARDWARE_V21
+        setPortPin(OBP_POWER_50, true); // Power on 5.0V rail
+        #endif
         #ifdef BOARD_OBP40S3
+        setPortPin(OBP_POWER_EPD, true);// Power on ePaper display
+        setPortPin(OBP_POWER_SD, true); // Power on SD card
+        #endif
+    }
+    else{
+        #ifdef HARDWARE_V21
+        setPortPin(OBP_POWER_50, false); // Power off 5.0V rail
+        #endif
+        #ifdef BOARD_OBP40S3
+        setPortPin(OBP_POWER_EPD, false);// Power off ePaper display
+        setPortPin(OBP_POWER_SD, false); // Power off SD card
+        #endif
+    }
+
+    #ifdef BOARD_OBP40S3
+    bool sdcard = config->getBool(config->useSDCard);
+    if (sdcard) {
+        SPIClass SD_SPI = SPIClass(HSPI);
+        SD_SPI.begin(SD_SPI_CLK, SD_SPI_MISO, SD_SPI_MOSI);
+        if (SD.begin(SD_SPI_CS, SD_SPI, 80000000)) {
+            String sdtype = "unknown";
+            uint8_t cardType = SD.cardType();
+            switch (cardType) {
+                case CARD_MMC:
+                   sdtype = "MMC";
+                   break;
+                case CARD_SD:
+                   sdtype = "SDSC";
+                   break;
+                case CARD_SDHC:
+                   sdtype = "SDHC";
+                   break;
+            }
+            uint64_t cardSize = SD.cardSize() / (1024 * 1024);
+            LOG_DEBUG(GwLog::LOG,"SD card type %s of size %d MB detected", sdtype, cardSize);
+        }
+    }
+
     // Deep sleep wakeup configuration
     esp_sleep_enable_ext0_wakeup(OBP_WAKEWUP_PIN, 0);   // 1 = High, 0 = Low
     rtc_gpio_pullup_en(OBP_WAKEWUP_PIN);                // Activate pullup resistor
@@ -64,7 +112,7 @@ void OBP60Init(GwApi *api){
 
     // Settings for e-paper display
     String fastrefresh = api->getConfig()->getConfigItem(api->getConfig()->fastRefresh,true)->asString();
-    logger->logDebug(GwLog::DEBUG, "Fast Refresh Mode is: %s", fastrefresh.c_str());
+    api->getLogger()->logDebug(GwLog::DEBUG,"Fast Refresh Mode is: %s", fastrefresh.c_str());
     #ifdef DISPLAY_GDEY042T81
     if(fastrefresh == "true"){
         static const bool useFastFullUpdate = true;   // Enable fast full display update only for GDEY042T81
@@ -83,11 +131,11 @@ void OBP60Init(GwApi *api){
 
     // Get CPU speed
     int freq = getCpuFrequencyMhz();
-    logger->logDebug(GwLog::LOG,"CPU speed at boot: %i MHz", freq);
+    api->getLogger()->logDebug(GwLog::LOG,"CPU speed at boot: %i MHz", freq);
     
     // Settings for backlight
     String backlightMode = api->getConfig()->getConfigItem(api->getConfig()->backlight,true)->asString();
-    logger->logDebug(GwLog::DEBUG,"Backlight Mode is: %s", backlightMode.c_str());
+    api->getLogger()->logDebug(GwLog::DEBUG,"Backlight Mode is: %s", backlightMode.c_str());
     uint brightness = uint(api->getConfig()->getConfigItem(api->getConfig()->blBrightness,true)->asInt());
     String backlightColor = api->getConfig()->getConfigItem(api->getConfig()->blColor,true)->asString();
     if(String(backlightMode) == "On"){
@@ -102,7 +150,7 @@ void OBP60Init(GwApi *api){
 
     // Settings flash LED mode
     String ledMode = api->getConfig()->getConfigItem(api->getConfig()->flashLED,true)->asString();
-    logger->logDebug(GwLog::DEBUG,"LED Mode is: %s", ledMode.c_str());
+    api->getLogger()->logDebug(GwLog::DEBUG,"LED Mode is: %s", ledMode.c_str());
     if(String(ledMode) == "Off"){
         setBlinkingLED(false);
     }
@@ -120,8 +168,8 @@ void OBP60Init(GwApi *api){
 typedef struct {
         int page0=0;
         QueueHandle_t queue;
-        GwLog* logger = nullptr;
-//        GwApi* api = nullptr;
+        GwLog* logger = NULL;
+//        GwApi* api = NULL;
         uint sensitivity = 100;
         bool use_syspage = true;
     } MyData;
@@ -146,8 +194,16 @@ void keyboardTask(void *param){
     vTaskDelete(NULL);
 }
 
-// --- Class BoatValueList --------------
-bool BoatValueList::addValueToList(GwApi::BoatValue *v){
+class BoatValueList{
+    public:
+    static const int MAXVALUES=100;
+    //we create a list containing all our BoatValues
+    //this is the list we later use to let the api fill all the values
+    //additionally we put the necessary values into the paga data - see below
+    GwApi::BoatValue *allBoatValues[MAXVALUES];
+    int numValues=0;
+    
+    bool addValueToList(GwApi::BoatValue *v){
         for (int i=0;i<numValues;i++){
             if (allBoatValues[i] == v){
                 //already in list...
@@ -160,7 +216,7 @@ bool BoatValueList::addValueToList(GwApi::BoatValue *v){
         return true;
     }
     //helper to ensure that each BoatValue is only queried once
-GwApi::BoatValue *BoatValueList::findValueOrCreate(String name){
+    GwApi::BoatValue *findValueOrCreate(String name){
         for (int i=0;i<numValues;i++){
             if (allBoatValues[i]->getName() == name) {
                 return allBoatValues[i];
@@ -170,12 +226,13 @@ GwApi::BoatValue *BoatValueList::findValueOrCreate(String name){
         addValueToList(rt);
         return rt;
     }
-// --- End Class BoatValueList --------------
+};
 
 //we want to have a list that has all our page definitions
 //this way each page can easily be added here
 //needs some minor tricks for the safe static initialization
 typedef std::vector<PageDescription*> Pages;
+//the page list class
 class PageList{
     public:
         Pages pages;
@@ -225,7 +282,7 @@ void registerAllPages(PageList &list){
     extern PageDescription registerPageWindRose;
     list.add(&registerPageWindRose);
     extern PageDescription registerPageWindRoseFlex;
-    list.add(&registerPageWindRoseFlex);
+    list.add(&registerPageWindRoseFlex); // 
     extern PageDescription registerPageVoltage;
     list.add(&registerPageVoltage);
     extern PageDescription registerPageDST810;
@@ -256,18 +313,25 @@ void registerAllPages(PageList &list){
     list.add(&registerPageXTETrack);
     extern PageDescription registerPageFluid;
     list.add(&registerPageFluid);
-    extern PageDescription registerPageSkyView;
-    list.add(&registerPageSkyView);
-    extern PageDescription registerPageNavigation;
-    list.add(&registerPageNavigation);
-    extern PageDescription registerPageDigitalOut;
-    list.add(&registerPageDigitalOut);
-    extern PageDescription registerPageAutopilot;
-    list.add(&registerPageAutopilot);
+    extern PageDescription registerPageAnchor;
+    list.add(&registerPageAnchor);
 }
 
 // Undervoltage detection for shutdown display
-void underVoltageError(CommonData &common) {
+void underVoltageDetection(GwApi *api, CommonData &common){
+    // Read settings
+    double voffset = (api->getConfig()->getConfigItem(api->getConfig()->vOffset,true)->asString()).toFloat();
+    double vslope = (api->getConfig()->getConfigItem(api->getConfig()->vSlope,true)->asString()).toFloat();
+    // Read supply voltage
+    #if defined VOLTAGE_SENSOR && defined LIPO_ACCU_1200
+    float actVoltage = (float(analogRead(OBP_ANALOG0)) * 3.3 / 4096 + 0.53) * 2;   // Vin = 1/2 for OBP40
+    float minVoltage = 3.65;  // Absolut minimum volatge for 3,7V LiPo accu
+    #else
+    float actVoltage = (float(analogRead(OBP_ANALOG0)) * 3.3 / 4096 + 0.17) * 20;   // Vin = 1/20 for OBP60
+    float minVoltage = MIN_VOLTAGE;
+    #endif
+    double calVoltage = actVoltage * vslope + voffset;  // Calibration
+    if(calVoltage < minVoltage){
         #if defined VOLTAGE_SENSOR && defined LIPO_ACCU_1200
         // Switch off all power lines
         setPortPin(OBP_BACKLIGHT_LED, false);   // Backlight Off
@@ -307,22 +371,129 @@ void underVoltageError(CommonData &common) {
         getdisplay().nextPage();                // Partial update
         getdisplay().powerOff();                // Display power off
         #endif
+        // Stop system
         while(true){
-        esp_deep_sleep_start(); // Deep Sleep without wakeup. Wakeup only after power cycle (restart).
+            esp_deep_sleep_start();             // Deep Sleep without weakup. Weakup only after power cycle (restart).
+        }
     }
 }
 
-inline bool underVoltageDetection(float voffset, float vslope) {
-    // Read supply voltage
-#if defined VOLTAGE_SENSOR && defined LIPO_ACCU_1200
-    float actVoltage = (float(analogRead(OBP_ANALOG0)) * 3.3 / 4096 + 0.53) * 2;   // Vin = 1/2 for OBP40
-    float minVoltage = 3.65;  // Absolut minimum volatge for 3,7V LiPo accu
-#else
-    float actVoltage = (float(analogRead(OBP_ANALOG0)) * 3.3 / 4096 + 0.17) * 20;   // Vin = 1/20 for OBP60
-    float minVoltage = MIN_VOLTAGE;
-#endif
-    float calVoltage = actVoltage * vslope + voffset;  // Calibration
-    return (calVoltage < minVoltage);
+//bool addTrueWind(GwApi* api, BoatValueList* boatValues, double *twd, double *tws, double *twa) {
+bool addTrueWind(GwApi* api, BoatValueList* boatValues) {
+    // Calculate true wind data and add to obp60task boat data list
+
+    double awaVal, awsVal, cogVal, stwVal, sogVal, hdtVal, hdmVal, varVal;
+    double twd, tws, twa;
+    bool isCalculated = false;
+    const double DBL_MIN = std::numeric_limits<double>::lowest();
+
+    GwApi::BoatValue *twdBVal = boatValues->findValueOrCreate("TWD");
+    GwApi::BoatValue *twsBVal = boatValues->findValueOrCreate("TWS");
+    GwApi::BoatValue *twaBVal = boatValues->findValueOrCreate("TWA");
+    GwApi::BoatValue *awaBVal = boatValues->findValueOrCreate("AWA");
+    GwApi::BoatValue *awsBVal = boatValues->findValueOrCreate("AWS");
+    GwApi::BoatValue *cogBVal = boatValues->findValueOrCreate("COG");
+    GwApi::BoatValue *stwBVal = boatValues->findValueOrCreate("STW");
+    GwApi::BoatValue *sogBVal = boatValues->findValueOrCreate("SOG");
+    GwApi::BoatValue *hdtBVal = boatValues->findValueOrCreate("HDT");
+    GwApi::BoatValue *hdmBVal = boatValues->findValueOrCreate("HDM");
+    GwApi::BoatValue *varBVal = boatValues->findValueOrCreate("VAR");
+    awaVal = awaBVal->valid ? awaBVal->value : DBL_MIN;
+    awsVal = awsBVal->valid ? awsBVal->value : DBL_MIN;
+    cogVal = cogBVal->valid ? cogBVal->value : DBL_MIN;
+    stwVal = stwBVal->valid ? stwBVal->value : DBL_MIN;
+    sogVal = sogBVal->valid ? sogBVal->value : DBL_MIN;
+    hdtVal = hdtBVal->valid ? hdtBVal->value : DBL_MIN;
+    hdmVal = hdmBVal->valid ? hdmBVal->value : DBL_MIN;
+    varVal = varBVal->valid ? varBVal->value : DBL_MIN;
+    api->getLogger()->logDebug(GwLog::DEBUG,"obp60task addTrueWind: AWA %.1f, AWS %.1f, COG %.1f, STW %.1f, SOG %.1f, HDT %.1f, HDM %.1f, VAR %.1f", awaBVal->value * RAD_TO_DEG, awsBVal->value * 3.6 / 1.852,
+            cogBVal->value * RAD_TO_DEG, stwBVal->value * 3.6 / 1.852, sogBVal->value * 3.6 / 1.852, hdtBVal->value * RAD_TO_DEG, hdmBVal->value * RAD_TO_DEG, varBVal->value * RAD_TO_DEG);
+
+    isCalculated = WindUtils::calcTrueWind(&awaVal, &awsVal, &cogVal, &stwVal, &sogVal, &hdtVal, &hdmVal, &varVal, &twd, &tws, &twa);
+
+    if (isCalculated) { // Replace values only, if successfully calculated and not already available
+        if (!twdBVal->valid) {
+            twdBVal->value = twd;
+            twdBVal->valid = true;
+        }
+        if (!twsBVal->valid) {
+            twsBVal->value = tws;
+            twsBVal->valid = true;
+        }
+        if (!twaBVal->valid) {
+            twaBVal->value = twa;
+            twaBVal->valid = true;
+        }
+    }
+    api->getLogger()->logDebug(GwLog::DEBUG,"obp60task addTrueWind: TWD_Valid %d, isCalculated %d, TWD %.1f, TWA %.1f, TWS %.1f", twdBVal->valid, isCalculated, twdBVal->value * RAD_TO_DEG,
+        twaBVal->value * RAD_TO_DEG, twsBVal->value * 3.6 / 1.852);
+
+    return isCalculated;
+}
+
+void initHstryBuf(GwApi* api, BoatValueList* boatValues, tBoatHstryData hstryBufList) {
+    // Init history buffers for TWD, TWS
+
+    GwApi::BoatValue *calBVal; // temp variable just for data calibration -> we don't want to calibrate the original data here
+
+    int hstryUpdFreq = 1000; // Update frequency for history buffers in ms
+    int hstryMinVal = 0; // Minimum value for these history buffers
+    int twdHstryMax = 6283; // Max value for wind direction (TWD) in rad (0...2*PI), shifted by 1000 for 3 decimals
+    int twsHstryMax = 1000; // Max value for wind speed (TWS) in m/s, shifted by 10 for 1 decimal
+    // Initialize history buffers with meta data
+    hstryBufList.twdHstry->setMetaData("TWD", "formatCourse", hstryUpdFreq, hstryMinVal, twdHstryMax);
+    hstryBufList.twsHstry->setMetaData("TWS", "formatKnots", hstryUpdFreq, hstryMinVal, twsHstryMax);
+
+    GwApi::BoatValue *twdBVal = boatValues->findValueOrCreate(hstryBufList.twdHstry->getName());
+    GwApi::BoatValue *twsBVal = boatValues->findValueOrCreate(hstryBufList.twsHstry->getName());
+    GwApi::BoatValue *twaBVal = boatValues->findValueOrCreate("TWA");
+}
+
+void handleHstryBuf(GwApi* api, BoatValueList* boatValues, tBoatHstryData hstryBufList) {
+    // Handle history buffers for TWD, TWS
+
+    GwLog *logger = api->getLogger();
+
+    int16_t twdHstryMin = hstryBufList.twdHstry->getMinVal();
+    int16_t twdHstryMax = hstryBufList.twdHstry->getMaxVal();
+    int16_t twsHstryMin = hstryBufList.twsHstry->getMinVal();
+    int16_t twsHstryMax = hstryBufList.twsHstry->getMaxVal();
+    int16_t twdBuf, twsBuf;
+    GwApi::BoatValue *calBVal; // temp variable just for data calibration -> we don't want to calibrate the original data here
+
+    GwApi::BoatValue *twdBVal = boatValues->findValueOrCreate(hstryBufList.twdHstry->getName());
+    GwApi::BoatValue *twsBVal = boatValues->findValueOrCreate(hstryBufList.twsHstry->getName());
+    GwApi::BoatValue *twaBVal = boatValues->findValueOrCreate("TWA");
+
+    api->getLogger()->logDebug(GwLog::DEBUG,"obp60task handleHstryBuf: twdBVal: %.1f, twaBVal: %.1f, twsBVal: %.1f, TWD_isValid? %d", twdBVal->value * RAD_TO_DEG,
+        twaBVal->value * RAD_TO_DEG, twsBVal->value * 3.6 / 1.852, twdBVal->valid);
+    calBVal = new GwApi::BoatValue("TWD"); // temporary solution for calibration of history buffer values
+    calBVal->setFormat(twdBVal->getFormat());
+    if (twdBVal->valid) {
+        calBVal->value = twdBVal->value;
+        calBVal->valid = twdBVal->valid;
+        calibrationData.calibrateInstance(calBVal, logger); // Check if boat data value is to be calibrated
+        twdBuf = static_cast<int16_t>(std::round(calBVal->value * 1000));
+        if (twdBuf >= twdHstryMin && twdBuf <= twdHstryMax) {
+            hstryBufList.twdHstry->add(twdBuf);
+        }
+    }
+    delete calBVal;
+    calBVal = nullptr;
+
+    calBVal = new GwApi::BoatValue("TWS"); // temporary solution for calibration of history buffer values
+    calBVal->setFormat(twsBVal->getFormat());
+    if (twsBVal->valid) {
+        calBVal->value = twsBVal->value;
+        calBVal->valid = twsBVal->valid;
+        calibrationData.calibrateInstance(calBVal, logger); // Check if boat data value is to be calibrated
+        twsBuf = static_cast<int16_t>(std::round(calBVal->value * 10));
+        if (twsBuf >= twsHstryMin && twsBuf <= twsHstryMax) {
+            hstryBufList.twsHstry->add(twsBuf);
+        }
+    }
+    delete calBVal;
+    calBVal = nullptr;
 }
 
 // OBP60 Task
@@ -332,7 +503,7 @@ void OBP60Task(GwApi *api){
 //    return;
     GwLog *logger=api->getLogger();
     GwConfigHandler *config=api->getConfig();
-#if defined HARDWARE_V20 || HARDWARE_V21
+#ifdef HARDWARE_V21
     startLedTask(api);
 #endif
     PageList allPages;
@@ -341,7 +512,7 @@ void OBP60Task(GwApi *api){
     commonData.logger=logger;
     commonData.config=config;
 
-#if defined HARDWARE_V20 || HARDWARE_V21
+#ifdef HARDWARE_V21
     // Keyboard coordinates for page footer
     initKeys(commonData);
 #endif
@@ -432,12 +603,16 @@ void OBP60Task(GwApi *api){
 #endif
     LOG_DEBUG(GwLog::LOG,"...done");
 
-    int lastPage=-1; // initialize with an impiossible value, so we can detect wether we are during startup and no page has been displayed yet
+    int lastPage=pageNumber;
 
     BoatValueList boatValues; //all the boat values for the api query
-    HstryBuffers hstryBufferList(1920, &boatValues, logger);  // Create empty list of boat data history buffers (1.920 values = seconds = 32 min.)
-    WindUtils trueWind(&boatValues, logger);  // Create helper object for true wind calculation
-    CalibrationData calibrationDataList(logger); // all boat data types which are supposed to be calibrated
+    //commonData.distanceformat=config->getString(xxx);
+    //add all necessary data to common data
+
+    // Create ring buffers for history storage of some boat data
+    RingBuffer<int16_t> twdHstry(960); // Circular buffer to store wind direction values; store 960 TWD values for 16 minutes history
+    RingBuffer<int16_t> twsHstry(960); // Circular buffer to store wind speed values (TWS)
+    tBoatHstryData hstryBufList = {&twdHstry, &twsHstry};
 
     //fill the page data from config
     numPages=config->getInt(config->visiblePages,1);
@@ -459,7 +634,6 @@ void OBP60Task(GwApi *api){
        pages[i].page=description->creator(commonData);
        pages[i].parameters.pageName=pageType;
        pages[i].parameters.pageNumber = i + 1;
-       pages[i].parameters.api = api;
        LOG_DEBUG(GwLog::DEBUG,"found page %s for number %d",pageType.c_str(),i);
        //fill in all the user defined parameters
        for (int uid=0;uid<description->userParam;uid++){
@@ -478,26 +652,23 @@ void OBP60Task(GwApi *api){
             LOG_DEBUG(GwLog::DEBUG,"added fixed value %s to page %d",value->getName().c_str(),i);
             pages[i].parameters.values.push_back(value); 
        }
-
-       // Read the specified boat data types of relevant pages and create a history buffer for each type
-       if (pages[i].parameters.pageName == "OneValue" || pages[i].parameters.pageName == "TwoValues" || pages[i].parameters.pageName == "WindPlot") {
-           for (auto pVal : pages[i].parameters.values) {
-                hstryBufferList.addBuffer(pVal->getName());
+        if (pages[i].description->pageName == "WindPlot") {
+            // Add boat history data to page parameters
+            pages[i].parameters.boatHstry = hstryBufList;
         }
     }
-       // Add list of history buffers to page parameters
-       pages[i].parameters.hstryBuffers = &hstryBufferList;
-
-    }
-
     // add out of band system page (always available)
     Page *syspage = allPages.pages[0]->creator(commonData);
 
-    // Read user settings from config file
+    // Read all calibration data settings from config
+    calibrationData.readConfig(config, logger);
+
+    // Check user setting for true wind calculation
     bool calcTrueWnds = api->getConfig()->getBool(api->getConfig()->calcTrueWnds, false);
-    bool useSimuData = api->getConfig()->getBool(api->getConfig()->useSimuData, false);
-    // Read user calibration data settings from config file
-    calibrationDataList.readConfig(config);
+    // bool simulation = api->getConfig()->getBool(api->getConfig()->useSimuData, false);
+
+    // Initialize history buffer for certain boat data
+    initHstryBuf(api, &boatValues, hstryBufList);
 
     // Display screenshot handler for HTTP request
     // http://192.168.15.1/api/user/OBP60Task/screenshot
@@ -529,12 +700,10 @@ void OBP60Task(GwApi *api){
 
     commonData.backlight.mode = backlightMapping(config->getConfigItem(config->backlight,true)->asString());
     commonData.backlight.color = colorMapping(config->getConfigItem(config->blColor,true)->asString());
-    commonData.backlight.brightness = uint(config->getConfigItem(config->blBrightness,true)->asInt());
+    commonData.backlight.brightness = 2.55 * uint(config->getConfigItem(config->blBrightness,true)->asInt());
     commonData.powermode = api->getConfig()->getConfigItem(api->getConfig()->powerMode,true)->asString();
 
-    bool uvoltage = config->getConfigItem(config->underVoltage, true)->asBoolean();
-    float voffset = (config->getConfigItem(config->vOffset,true)->asString()).toFloat();
-    float vslope = (config->getConfigItem(config->vSlope,true)->asString()).toFloat();
+    bool uvoltage = api->getConfig()->getConfigItem(api->getConfig()->underVoltage,true)->asBoolean();
     String cpuspeed = api->getConfig()->getConfigItem(api->getConfig()->cpuSpeed,true)->asString();
     uint hdopAccuracy = uint(api->getConfig()->getConfigItem(api->getConfig()->hdopAccuracy,true)->asInt());
 
@@ -542,7 +711,7 @@ void OBP60Task(GwApi *api){
     double homelon = commonData.config->getString(commonData.config->homeLON).toDouble();
     bool homevalid = homelat >= -180.0 and homelat <= 180 and homelon >= -90.0 and homelon <= 90.0;
     if (homevalid) {
-        LOG_DEBUG(GwLog::LOG, "Home location set to lat=%f, lon=%f", homelat, homelon);
+        LOG_DEBUG(GwLog::LOG, "Home location set to %f : %f", homelat, homelon);
     } else {
         LOG_DEBUG(GwLog::LOG, "No valid home location found");
     }
@@ -576,7 +745,6 @@ void OBP60Task(GwApi *api){
     //####################################################################################
 
     bool systemPage = false;
-    bool systemPageNew = false;
     Page *currentPage;
     while (true){
         delay(100);     // Delay 100ms (loop time)
@@ -584,10 +752,7 @@ void OBP60Task(GwApi *api){
 
         // Undervoltage detection
         if(uvoltage == true){
-            if (underVoltageDetection(voffset, vslope)) {
-                LOG_DEBUG(GwLog::ERROR, "Undervoltage detected, shutting down!");
-                underVoltageError(commonData);
-            }
+            underVoltageDetection(api, commonData);
         }
 
         // Set CPU speed after boot after 1min 
@@ -632,7 +797,6 @@ void OBP60Task(GwApi *api){
                     systemPage = true; // System page is out of band
                     syspage->setupKeys();
                     keyboardMessage = 0;
-                    systemPageNew = true;
                 }
                 else {
                     currentPage = pages[pageNumber].page;
@@ -656,7 +820,7 @@ void OBP60Task(GwApi *api){
                     // if(String(backlight) == "Control by Key"){
                         if(keyboardMessage == 6){
                             LOG_DEBUG(GwLog::LOG,"Toggle Backlight LED");
-                            stepsBacklightLED(commonData.backlight.brightness, commonData.backlight.color);
+                            toggleBacklightLED(commonData.backlight.brightness, commonData.backlight.color);
                         }
                     }
                     #ifdef BOARD_OBP40S3
@@ -718,8 +882,8 @@ void OBP60Task(GwApi *api){
                 }
             }
             
-            // Full display update afer a new selected page and 8s wait time
-            if(millis() > starttime4 + 8000 && delayedDisplayUpdate == true){
+            // Full display update afer a new selected page and 4s wait time
+            if(millis() > starttime4 + 4000 && delayedDisplayUpdate == true){
                 starttime1 = millis();
                 starttime2 = millis();
                 getdisplay().setFullWindow();    // Set full update
@@ -729,7 +893,6 @@ void OBP60Task(GwApi *api){
                 else{
                     getdisplay().fillScreen(commonData.fgcolor); // Clear display
                     #ifdef DISPLAY_GDEY042T81
-                        getdisplay().hibernate();                  // Set display in hybenate mode
                         getdisplay().init(115200, true, 2, false); // Init for Waveshare boards with "clever" reset circuit, 2ms reset pulse
                     #else
                         getdisplay().init(115200);               // Init for normal displays
@@ -757,7 +920,6 @@ void OBP60Task(GwApi *api){
                 else{
                     getdisplay().fillScreen(commonData.fgcolor); // Clear display
                     #ifdef DISPLAY_GDEY042T81
-                        getdisplay().hibernate();                  // Set display in hybenate mode
                         getdisplay().init(115200, true, 2, false); // Init for Waveshare boards with "clever" reset circuit, 2ms reset pulse
                     #else
                         getdisplay().init(115200);               // Init for normal displays
@@ -782,7 +944,6 @@ void OBP60Task(GwApi *api){
                 else{
                     getdisplay().fillScreen(commonData.fgcolor); // Clear display
                     #ifdef DISPLAY_GDEY042T81
-                        getdisplay().hibernate();                  // Set display in hybenate mode
                         getdisplay().init(115200, true, 2, false); // Init for Waveshare boards with "clever" reset circuit, 2ms reset pulse
                     #else
                         getdisplay().init(115200);               // Init for normal displays
@@ -812,10 +973,10 @@ void OBP60Task(GwApi *api){
                 api->getStatus(commonData.status);
 
                 if (calcTrueWnds) {
-                    trueWind.addWinds(); // calculate true wind data from apparent wind values
+                    addTrueWind(api, &boatValues);
                 }
-                calibrationDataList.handleCalibration(&boatValues); // Process calibration for all boat data in <calibrationDataList>
-                hstryBufferList.handleHstryBufs(useSimuData, commonData); // Handle history buffers for certain boat data for windplot page and other usage
+                // Handle history buffers for TWD, TWS for wind plot page and other usage
+                 handleHstryBuf(api, &boatValues, hstryBufList);
 
                 // Clear display
                 // getdisplay().fillRect(0, 0, getdisplay().width(), getdisplay().height(), commonData.bgcolor);
@@ -831,11 +992,6 @@ void OBP60Task(GwApi *api){
                 if (systemPage) {
                     displayFooter(commonData);
                     PageData sysparams; // empty
-                    sysparams.api = api;
-                    if (systemPageNew) {
-                        syspage->displayNew(sysparams);
-                        systemPageNew = false;
-                    }
                     syspage->displayPage(sysparams);
                 }
                 else {
@@ -852,10 +1008,7 @@ void OBP60Task(GwApi *api){
                     }
                     else{
                         if (lastPage != pageNumber){
-			    if (lastPage != -1){ // skip cleanup if we are during startup, and no page has been displayed yet. 
-                                pages[lastPage].page->leavePage(pages[lastPage].parameters); // call page cleanup code
-                                if (hasFRAM) fram.write(FRAM_PAGE_NO, pageNumber); // remember new page for device restart
-			    }
+                            if (hasFRAM) fram.write(FRAM_PAGE_NO, pageNumber); // remember page for device restart
                             currentPage->setupKeys();
                             currentPage->displayNew(pages[pageNumber].parameters);
                             lastPage=pageNumber;

lib/obp60task/obp60task.h

@@ -41,24 +41,5 @@
     #ifdef BOARD_OBP40S3
     DECLARE_CAPABILITY(obp40,true)
     #endif
-    #ifdef BOARD_OBP60S3
-    DECLARE_STRING_CAPABILITY(HELP_URL, "https://obp60-v2-docu.readthedocs.io/en/latest/"); // Link to help pages
-    #endif
-    #ifdef BOARD_OBP40S3
-    DECLARE_STRING_CAPABILITY(HELP_URL, "https://obp40-v1-docu.readthedocs.io/en/latest/"); // Link to help pages
-    #endif
-
-    class BoatValueList{
-        public:
-        static const int MAXVALUES=100;
-        //we create a list containing all our BoatValues
-        //this is the list we later use to let the api fill all the values
-        //additionally we put the necessary values into the paga data - see below
-        GwApi::BoatValue *allBoatValues[MAXVALUES];
-        int numValues=0;
-        
-        bool addValueToList(GwApi::BoatValue *v);
-        //helper to ensure that each BoatValue is only queried once
-        GwApi::BoatValue *findValueOrCreate(String name);
-    };
+    DECLARE_STRING_CAPABILITY(HELP_URL, "https://obp60-v2-docu.readthedocs.io/de/latest/"); // Link to help pages
 #endif

lib/obp60task/platformio.ini

@@ -16,16 +16,12 @@ board_build.variants_dir = variants
 board = obp60_s3_n16r8  #ESP32-S3 N16R8, 16MB flash, 8MB PSRAM, production series
 #board_build.partitions = default_8MB.csv #ESP32-S3 N8, 8MB flash
 board_build.partitions = default_16MB.csv #ESP32-S3 N16, 16MB flash
-custom_config = lib/obp60task/config_obp60.json
-custom_script = lib/obp60task/extra_task.py
 framework = arduino
 lib_deps = 
     ${basedeps.lib_deps}
     Wire
     SPI
     ESP32time
-    HTTPClient
-    WiFiClientSecure
     esphome/AsyncTCP-esphome@2.0.1
     robtillaart/PCF8574@0.3.9
     adafruit/Adafruit Unified Sensor @ 1.1.13
@@ -70,8 +66,7 @@ platform = espressif32@6.8.1
 board_build.variants_dir = variants
 board = obp40_s3_n8r8   #ESP32-S3 N8R8, 8MB flash, 8MB PSRAM, OBP60 clone (CrowPanel 4.2)
 board_build.partitions = default_8MB.csv #ESP32-S3 N8, 8MB flash
-custom_config = lib/obp60task/config_obp40.json
-custom_script = lib/obp60task/extra_task.py
+custom_config = config_obp40.json
 framework = arduino
 lib_deps =
     ${basedeps.lib_deps}
@@ -79,8 +74,6 @@ lib_deps =
     SPI
     SD
     ESP32time
-    HTTPClient
-    WiFiClientSecure
     esphome/AsyncTCP-esphome@2.0.1
     robtillaart/PCF8574@0.3.9
     adafruit/Adafruit Unified Sensor @ 1.1.13
@@ -106,8 +99,8 @@ build_flags=
     -D HARDWARE_V10                 #OBP40 hardware revision V1.0 SKU:DIE07300S V1.1 (CrowPanel 4.2)
     -D DISPLAY_GDEY042T81           #new E-Ink display from Good Display (Waveshare), R10 2.2 ohm - good (contast lost by shunshine)
     #-D DISPLAY_ZJY400300-042CAAMFGN #alternativ E-Ink display from ZZE Technology, R10 2.2 ohm - very good   
-    -D LIPO_ACCU_1200               #Hardware extension, LiPo accu 3,7V 1200mAh
-    -D VOLTAGE_SENSOR               #Hardware extension, LiPo voltage sensor with two resistors
+    #-D LIPO_ACCU_1200               #Hardware extension, LiPo accu 3,7V 1200mAh
+    #-D VOLTAGE_SENSOR               #Hardware extension, LiPo voltage sensor with two resistors
     ${env.build_flags}
 upload_port = /dev/ttyUSB0          #OBP40 download via external USB/Serail converter
 upload_protocol = esptool           #firmware upload via USB OTG seriell, by first upload need to set the ESP32-S3 in the upload mode with shortcut GND to Pin27

lib/obp60task/puff.c

@@ -1,840 +0,0 @@
-/*
- * puff.c
- * Copyright (C) 2002-2013 Mark Adler
- * For conditions of distribution and use, see copyright notice in puff.h
- * version 2.3, 21 Jan 2013
- *
- * puff.c is a simple inflate written to be an unambiguous way to specify the
- * deflate format.  It is not written for speed but rather simplicity.  As a
- * side benefit, this code might actually be useful when small code is more
- * important than speed, such as bootstrap applications.  For typical deflate
- * data, zlib's inflate() is about four times as fast as puff().  zlib's
- * inflate compiles to around 20K on my machine, whereas puff.c compiles to
- * around 4K on my machine (a PowerPC using GNU cc).  If the faster decode()
- * function here is used, then puff() is only twice as slow as zlib's
- * inflate().
- *
- * All dynamically allocated memory comes from the stack.  The stack required
- * is less than 2K bytes.  This code is compatible with 16-bit int's and
- * assumes that long's are at least 32 bits.  puff.c uses the short data type,
- * assumed to be 16 bits, for arrays in order to conserve memory.  The code
- * works whether integers are stored big endian or little endian.
- *
- * In the comments below are "Format notes" that describe the inflate process
- * and document some of the less obvious aspects of the format.  This source
- * code is meant to supplement RFC 1951, which formally describes the deflate
- * format:
- *
- *    http://www.zlib.org/rfc-deflate.html
- */
-
-/*
- * Change history:
- *
- * 1.0  10 Feb 2002     - First version
- * 1.1  17 Feb 2002     - Clarifications of some comments and notes
- *                      - Update puff() dest and source pointers on negative
- *                        errors to facilitate debugging deflators
- *                      - Remove longest from struct huffman -- not needed
- *                      - Simplify offs[] index in construct()
- *                      - Add input size and checking, using longjmp() to
- *                        maintain easy readability
- *                      - Use short data type for large arrays
- *                      - Use pointers instead of long to specify source and
- *                        destination sizes to avoid arbitrary 4 GB limits
- * 1.2  17 Mar 2002     - Add faster version of decode(), doubles speed (!),
- *                        but leave simple version for readability
- *                      - Make sure invalid distances detected if pointers
- *                        are 16 bits
- *                      - Fix fixed codes table error
- *                      - Provide a scanning mode for determining size of
- *                        uncompressed data
- * 1.3  20 Mar 2002     - Go back to lengths for puff() parameters [Gailly]
- *                      - Add a puff.h file for the interface
- *                      - Add braces in puff() for else do [Gailly]
- *                      - Use indexes instead of pointers for readability
- * 1.4  31 Mar 2002     - Simplify construct() code set check
- *                      - Fix some comments
- *                      - Add FIXLCODES #define
- * 1.5   6 Apr 2002     - Minor comment fixes
- * 1.6   7 Aug 2002     - Minor format changes
- * 1.7   3 Mar 2003     - Added test code for distribution
- *                      - Added zlib-like license
- * 1.8   9 Jan 2004     - Added some comments on no distance codes case
- * 1.9  21 Feb 2008     - Fix bug on 16-bit integer architectures [Pohland]
- *                      - Catch missing end-of-block symbol error
- * 2.0  25 Jul 2008     - Add #define to permit distance too far back
- *                      - Add option in TEST code for puff to write the data
- *                      - Add option in TEST code to skip input bytes
- *                      - Allow TEST code to read from piped stdin
- * 2.1   4 Apr 2010     - Avoid variable initialization for happier compilers
- *                      - Avoid unsigned comparisons for even happier compilers
- * 2.2  25 Apr 2010     - Fix bug in variable initializations [Oberhumer]
- *                      - Add const where appropriate [Oberhumer]
- *                      - Split if's and ?'s for coverage testing
- *                      - Break out test code to separate file
- *                      - Move NIL to puff.h
- *                      - Allow incomplete code only if single code length is 1
- *                      - Add full code coverage test to Makefile
- * 2.3  21 Jan 2013     - Check for invalid code length codes in dynamic blocks
- */
-
-#include <setjmp.h>             /* for setjmp(), longjmp(), and jmp_buf */
-#include "puff.h"               /* prototype for puff() */
-
-#define local static            /* for local function definitions */
-
-/*
- * Maximums for allocations and loops.  It is not useful to change these --
- * they are fixed by the deflate format.
- */
-#define MAXBITS 15              /* maximum bits in a code */
-#define MAXLCODES 286           /* maximum number of literal/length codes */
-#define MAXDCODES 30            /* maximum number of distance codes */
-#define MAXCODES (MAXLCODES+MAXDCODES)  /* maximum codes lengths to read */
-#define FIXLCODES 288           /* number of fixed literal/length codes */
-
-/* input and output state */
-struct state {
-    /* output state */
-    unsigned char *out;         /* output buffer */
-    unsigned long outlen;       /* available space at out */
-    unsigned long outcnt;       /* bytes written to out so far */
-
-    /* input state */
-    const unsigned char *in;    /* input buffer */
-    unsigned long inlen;        /* available input at in */
-    unsigned long incnt;        /* bytes read so far */
-    int bitbuf;                 /* bit buffer */
-    int bitcnt;                 /* number of bits in bit buffer */
-
-    /* input limit error return state for bits() and decode() */
-    jmp_buf env;
-};
-
-/*
- * Return need bits from the input stream.  This always leaves less than
- * eight bits in the buffer.  bits() works properly for need == 0.
- *
- * Format notes:
- *
- * - Bits are stored in bytes from the least significant bit to the most
- *   significant bit.  Therefore bits are dropped from the bottom of the bit
- *   buffer, using shift right, and new bytes are appended to the top of the
- *   bit buffer, using shift left.
- */
-local int bits(struct state *s, int need)
-{
-    long val;           /* bit accumulator (can use up to 20 bits) */
-
-    /* load at least need bits into val */
-    val = s->bitbuf;
-    while (s->bitcnt < need) {
-        if (s->incnt == s->inlen)
-            longjmp(s->env, 1);         /* out of input */
-        val |= (long)(s->in[s->incnt++]) << s->bitcnt;  /* load eight bits */
-        s->bitcnt += 8;
-    }
-
-    /* drop need bits and update buffer, always zero to seven bits left */
-    s->bitbuf = (int)(val >> need);
-    s->bitcnt -= need;
-
-    /* return need bits, zeroing the bits above that */
-    return (int)(val & ((1L << need) - 1));
-}
-
-/*
- * Process a stored block.
- *
- * Format notes:
- *
- * - After the two-bit stored block type (00), the stored block length and
- *   stored bytes are byte-aligned for fast copying.  Therefore any leftover
- *   bits in the byte that has the last bit of the type, as many as seven, are
- *   discarded.  The value of the discarded bits are not defined and should not
- *   be checked against any expectation.
- *
- * - The second inverted copy of the stored block length does not have to be
- *   checked, but it's probably a good idea to do so anyway.
- *
- * - A stored block can have zero length.  This is sometimes used to byte-align
- *   subsets of the compressed data for random access or partial recovery.
- */
-local int stored(struct state *s)
-{
-    unsigned len;       /* length of stored block */
-
-    /* discard leftover bits from current byte (assumes s->bitcnt < 8) */
-    s->bitbuf = 0;
-    s->bitcnt = 0;
-
-    /* get length and check against its one's complement */
-    if (s->incnt + 4 > s->inlen)
-        return 2;                               /* not enough input */
-    len = s->in[s->incnt++];
-    len |= s->in[s->incnt++] << 8;
-    if (s->in[s->incnt++] != (~len & 0xff) ||
-        s->in[s->incnt++] != ((~len >> 8) & 0xff))
-        return -2;                              /* didn't match complement! */
-
-    /* copy len bytes from in to out */
-    if (s->incnt + len > s->inlen)
-        return 2;                               /* not enough input */
-    if (s->out != NIL) {
-        if (s->outcnt + len > s->outlen)
-            return 1;                           /* not enough output space */
-        while (len--)
-            s->out[s->outcnt++] = s->in[s->incnt++];
-    }
-    else {                                      /* just scanning */
-        s->outcnt += len;
-        s->incnt += len;
-    }
-
-    /* done with a valid stored block */
-    return 0;
-}
-
-/*
- * Huffman code decoding tables.  count[1..MAXBITS] is the number of symbols of
- * each length, which for a canonical code are stepped through in order.
- * symbol[] are the symbol values in canonical order, where the number of
- * entries is the sum of the counts in count[].  The decoding process can be
- * seen in the function decode() below.
- */
-struct huffman {
-    short *count;       /* number of symbols of each length */
-    short *symbol;      /* canonically ordered symbols */
-};
-
-/*
- * Decode a code from the stream s using huffman table h.  Return the symbol or
- * a negative value if there is an error.  If all of the lengths are zero, i.e.
- * an empty code, or if the code is incomplete and an invalid code is received,
- * then -10 is returned after reading MAXBITS bits.
- *
- * Format notes:
- *
- * - The codes as stored in the compressed data are bit-reversed relative to
- *   a simple integer ordering of codes of the same lengths.  Hence below the
- *   bits are pulled from the compressed data one at a time and used to
- *   build the code value reversed from what is in the stream in order to
- *   permit simple integer comparisons for decoding.  A table-based decoding
- *   scheme (as used in zlib) does not need to do this reversal.
- *
- * - The first code for the shortest length is all zeros.  Subsequent codes of
- *   the same length are simply integer increments of the previous code.  When
- *   moving up a length, a zero bit is appended to the code.  For a complete
- *   code, the last code of the longest length will be all ones.
- *
- * - Incomplete codes are handled by this decoder, since they are permitted
- *   in the deflate format.  See the format notes for fixed() and dynamic().
- */
-#ifdef SLOW
-local int decode(struct state *s, const struct huffman *h)
-{
-    int len;            /* current number of bits in code */
-    int code;           /* len bits being decoded */
-    int first;          /* first code of length len */
-    int count;          /* number of codes of length len */
-    int index;          /* index of first code of length len in symbol table */
-
-    code = first = index = 0;
-    for (len = 1; len <= MAXBITS; len++) {
-        code |= bits(s, 1);             /* get next bit */
-        count = h->count[len];
-        if (code - count < first)       /* if length len, return symbol */
-            return h->symbol[index + (code - first)];
-        index += count;                 /* else update for next length */
-        first += count;
-        first <<= 1;
-        code <<= 1;
-    }
-    return -10;                         /* ran out of codes */
-}
-
-/*
- * A faster version of decode() for real applications of this code.   It's not
- * as readable, but it makes puff() twice as fast.  And it only makes the code
- * a few percent larger.
- */
-#else /* !SLOW */
-local int decode(struct state *s, const struct huffman *h)
-{
-    int len;            /* current number of bits in code */
-    int code;           /* len bits being decoded */
-    int first;          /* first code of length len */
-    int count;          /* number of codes of length len */
-    int index;          /* index of first code of length len in symbol table */
-    int bitbuf;         /* bits from stream */
-    int left;           /* bits left in next or left to process */
-    short *next;        /* next number of codes */
-
-    bitbuf = s->bitbuf;
-    left = s->bitcnt;
-    code = first = index = 0;
-    len = 1;
-    next = h->count + 1;
-    while (1) {
-        while (left--) {
-            code |= bitbuf & 1;
-            bitbuf >>= 1;
-            count = *next++;
-            if (code - count < first) { /* if length len, return symbol */
-                s->bitbuf = bitbuf;
-                s->bitcnt = (s->bitcnt - len) & 7;
-                return h->symbol[index + (code - first)];
-            }
-            index += count;             /* else update for next length */
-            first += count;
-            first <<= 1;
-            code <<= 1;
-            len++;
-        }
-        left = (MAXBITS+1) - len;
-        if (left == 0)
-            break;
-        if (s->incnt == s->inlen)
-            longjmp(s->env, 1);         /* out of input */
-        bitbuf = s->in[s->incnt++];
-        if (left > 8)
-            left = 8;
-    }
-    return -10;                         /* ran out of codes */
-}
-#endif /* SLOW */
-
-/*
- * Given the list of code lengths length[0..n-1] representing a canonical
- * Huffman code for n symbols, construct the tables required to decode those
- * codes.  Those tables are the number of codes of each length, and the symbols
- * sorted by length, retaining their original order within each length.  The
- * return value is zero for a complete code set, negative for an over-
- * subscribed code set, and positive for an incomplete code set.  The tables
- * can be used if the return value is zero or positive, but they cannot be used
- * if the return value is negative.  If the return value is zero, it is not
- * possible for decode() using that table to return an error--any stream of
- * enough bits will resolve to a symbol.  If the return value is positive, then
- * it is possible for decode() using that table to return an error for received
- * codes past the end of the incomplete lengths.
- *
- * Not used by decode(), but used for error checking, h->count[0] is the number
- * of the n symbols not in the code.  So n - h->count[0] is the number of
- * codes.  This is useful for checking for incomplete codes that have more than
- * one symbol, which is an error in a dynamic block.
- *
- * Assumption: for all i in 0..n-1, 0 <= length[i] <= MAXBITS
- * This is assured by the construction of the length arrays in dynamic() and
- * fixed() and is not verified by construct().
- *
- * Format notes:
- *
- * - Permitted and expected examples of incomplete codes are one of the fixed
- *   codes and any code with a single symbol which in deflate is coded as one
- *   bit instead of zero bits.  See the format notes for fixed() and dynamic().
- *
- * - Within a given code length, the symbols are kept in ascending order for
- *   the code bits definition.
- */
-local int construct(struct huffman *h, const short *length, int n)
-{
-    int symbol;         /* current symbol when stepping through length[] */
-    int len;            /* current length when stepping through h->count[] */
-    int left;           /* number of possible codes left of current length */
-    short offs[MAXBITS+1];      /* offsets in symbol table for each length */
-
-    /* count number of codes of each length */
-    for (len = 0; len <= MAXBITS; len++)
-        h->count[len] = 0;
-    for (symbol = 0; symbol < n; symbol++)
-        (h->count[length[symbol]])++;   /* assumes lengths are within bounds */
-    if (h->count[0] == n)               /* no codes! */
-        return 0;                       /* complete, but decode() will fail */
-
-    /* check for an over-subscribed or incomplete set of lengths */
-    left = 1;                           /* one possible code of zero length */
-    for (len = 1; len <= MAXBITS; len++) {
-        left <<= 1;                     /* one more bit, double codes left */
-        left -= h->count[len];          /* deduct count from possible codes */
-        if (left < 0)
-            return left;                /* over-subscribed--return negative */
-    }                                   /* left > 0 means incomplete */
-
-    /* generate offsets into symbol table for each length for sorting */
-    offs[1] = 0;
-    for (len = 1; len < MAXBITS; len++)
-        offs[len + 1] = offs[len] + h->count[len];
-
-    /*
-     * put symbols in table sorted by length, by symbol order within each
-     * length
-     */
-    for (symbol = 0; symbol < n; symbol++)
-        if (length[symbol] != 0)
-            h->symbol[offs[length[symbol]]++] = symbol;
-
-    /* return zero for complete set, positive for incomplete set */
-    return left;
-}
-
-/*
- * Decode literal/length and distance codes until an end-of-block code.
- *
- * Format notes:
- *
- * - Compressed data that is after the block type if fixed or after the code
- *   description if dynamic is a combination of literals and length/distance
- *   pairs terminated by and end-of-block code.  Literals are simply Huffman
- *   coded bytes.  A length/distance pair is a coded length followed by a
- *   coded distance to represent a string that occurs earlier in the
- *   uncompressed data that occurs again at the current location.
- *
- * - Literals, lengths, and the end-of-block code are combined into a single
- *   code of up to 286 symbols.  They are 256 literals (0..255), 29 length
- *   symbols (257..285), and the end-of-block symbol (256).
- *
- * - There are 256 possible lengths (3..258), and so 29 symbols are not enough
- *   to represent all of those.  Lengths 3..10 and 258 are in fact represented
- *   by just a length symbol.  Lengths 11..257 are represented as a symbol and
- *   some number of extra bits that are added as an integer to the base length
- *   of the length symbol.  The number of extra bits is determined by the base
- *   length symbol.  These are in the static arrays below, lens[] for the base
- *   lengths and lext[] for the corresponding number of extra bits.
- *
- * - The reason that 258 gets its own symbol is that the longest length is used
- *   often in highly redundant files.  Note that 258 can also be coded as the
- *   base value 227 plus the maximum extra value of 31.  While a good deflate
- *   should never do this, it is not an error, and should be decoded properly.
- *
- * - If a length is decoded, including its extra bits if any, then it is
- *   followed a distance code.  There are up to 30 distance symbols.  Again
- *   there are many more possible distances (1..32768), so extra bits are added
- *   to a base value represented by the symbol.  The distances 1..4 get their
- *   own symbol, but the rest require extra bits.  The base distances and
- *   corresponding number of extra bits are below in the static arrays dist[]
- *   and dext[].
- *
- * - Literal bytes are simply written to the output.  A length/distance pair is
- *   an instruction to copy previously uncompressed bytes to the output.  The
- *   copy is from distance bytes back in the output stream, copying for length
- *   bytes.
- *
- * - Distances pointing before the beginning of the output data are not
- *   permitted.
- *
- * - Overlapped copies, where the length is greater than the distance, are
- *   allowed and common.  For example, a distance of one and a length of 258
- *   simply copies the last byte 258 times.  A distance of four and a length of
- *   twelve copies the last four bytes three times.  A simple forward copy
- *   ignoring whether the length is greater than the distance or not implements
- *   this correctly.  You should not use memcpy() since its behavior is not
- *   defined for overlapped arrays.  You should not use memmove() or bcopy()
- *   since though their behavior -is- defined for overlapping arrays, it is
- *   defined to do the wrong thing in this case.
- */
-local int codes(struct state *s,
-                const struct huffman *lencode,
-                const struct huffman *distcode)
-{
-    int symbol;         /* decoded symbol */
-    int len;            /* length for copy */
-    unsigned dist;      /* distance for copy */
-    static const short lens[29] = { /* Size base for length codes 257..285 */
-        3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 15, 17, 19, 23, 27, 31,
-        35, 43, 51, 59, 67, 83, 99, 115, 131, 163, 195, 227, 258};
-    static const short lext[29] = { /* Extra bits for length codes 257..285 */
-        0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, 2, 2, 2, 2,
-        3, 3, 3, 3, 4, 4, 4, 4, 5, 5, 5, 5, 0};
-    static const short dists[30] = { /* Offset base for distance codes 0..29 */
-        1, 2, 3, 4, 5, 7, 9, 13, 17, 25, 33, 49, 65, 97, 129, 193,
-        257, 385, 513, 769, 1025, 1537, 2049, 3073, 4097, 6145,
-        8193, 12289, 16385, 24577};
-    static const short dext[30] = { /* Extra bits for distance codes 0..29 */
-        0, 0, 0, 0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6,
-        7, 7, 8, 8, 9, 9, 10, 10, 11, 11,
-        12, 12, 13, 13};
-
-    /* decode literals and length/distance pairs */
-    do {
-        symbol = decode(s, lencode);
-        if (symbol < 0)
-            return symbol;              /* invalid symbol */
-        if (symbol < 256) {             /* literal: symbol is the byte */
-            /* write out the literal */
-            if (s->out != NIL) {
-                if (s->outcnt == s->outlen)
-                    return 1;
-                s->out[s->outcnt] = symbol;
-            }
-            s->outcnt++;
-        }
-        else if (symbol > 256) {        /* length */
-            /* get and compute length */
-            symbol -= 257;
-            if (symbol >= 29)
-                return -10;             /* invalid fixed code */
-            len = lens[symbol] + bits(s, lext[symbol]);
-
-            /* get and check distance */
-            symbol = decode(s, distcode);
-            if (symbol < 0)
-                return symbol;          /* invalid symbol */
-            dist = dists[symbol] + bits(s, dext[symbol]);
-#ifndef INFLATE_ALLOW_INVALID_DISTANCE_TOOFAR_ARRR
-            if (dist > s->outcnt)
-                return -11;     /* distance too far back */
-#endif
-
-            /* copy length bytes from distance bytes back */
-            if (s->out != NIL) {
-                if (s->outcnt + len > s->outlen)
-                    return 1;
-                while (len--) {
-                    s->out[s->outcnt] =
-#ifdef INFLATE_ALLOW_INVALID_DISTANCE_TOOFAR_ARRR
-                        dist > s->outcnt ?
-                            0 :
-#endif
-                            s->out[s->outcnt - dist];
-                    s->outcnt++;
-                }
-            }
-            else
-                s->outcnt += len;
-        }
-    } while (symbol != 256);            /* end of block symbol */
-
-    /* done with a valid fixed or dynamic block */
-    return 0;
-}
-
-/*
- * Process a fixed codes block.
- *
- * Format notes:
- *
- * - This block type can be useful for compressing small amounts of data for
- *   which the size of the code descriptions in a dynamic block exceeds the
- *   benefit of custom codes for that block.  For fixed codes, no bits are
- *   spent on code descriptions.  Instead the code lengths for literal/length
- *   codes and distance codes are fixed.  The specific lengths for each symbol
- *   can be seen in the "for" loops below.
- *
- * - The literal/length code is complete, but has two symbols that are invalid
- *   and should result in an error if received.  This cannot be implemented
- *   simply as an incomplete code since those two symbols are in the "middle"
- *   of the code.  They are eight bits long and the longest literal/length\
- *   code is nine bits.  Therefore the code must be constructed with those
- *   symbols, and the invalid symbols must be detected after decoding.
- *
- * - The fixed distance codes also have two invalid symbols that should result
- *   in an error if received.  Since all of the distance codes are the same
- *   length, this can be implemented as an incomplete code.  Then the invalid
- *   codes are detected while decoding.
- */
-local int fixed(struct state *s)
-{
-    static int virgin = 1;
-    static short lencnt[MAXBITS+1], lensym[FIXLCODES];
-    static short distcnt[MAXBITS+1], distsym[MAXDCODES];
-    static struct huffman lencode, distcode;
-
-    /* build fixed huffman tables if first call (may not be thread safe) */
-    if (virgin) {
-        int symbol;
-        short lengths[FIXLCODES];
-
-        /* construct lencode and distcode */
-        lencode.count = lencnt;
-        lencode.symbol = lensym;
-        distcode.count = distcnt;
-        distcode.symbol = distsym;
-
-        /* literal/length table */
-        for (symbol = 0; symbol < 144; symbol++)
-            lengths[symbol] = 8;
-        for (; symbol < 256; symbol++)
-            lengths[symbol] = 9;
-        for (; symbol < 280; symbol++)
-            lengths[symbol] = 7;
-        for (; symbol < FIXLCODES; symbol++)
-            lengths[symbol] = 8;
-        construct(&lencode, lengths, FIXLCODES);
-
-        /* distance table */
-        for (symbol = 0; symbol < MAXDCODES; symbol++)
-            lengths[symbol] = 5;
-        construct(&distcode, lengths, MAXDCODES);
-
-        /* do this just once */
-        virgin = 0;
-    }
-
-    /* decode data until end-of-block code */
-    return codes(s, &lencode, &distcode);
-}
-
-/*
- * Process a dynamic codes block.
- *
- * Format notes:
- *
- * - A dynamic block starts with a description of the literal/length and
- *   distance codes for that block.  New dynamic blocks allow the compressor to
- *   rapidly adapt to changing data with new codes optimized for that data.
- *
- * - The codes used by the deflate format are "canonical", which means that
- *   the actual bits of the codes are generated in an unambiguous way simply
- *   from the number of bits in each code.  Therefore the code descriptions
- *   are simply a list of code lengths for each symbol.
- *
- * - The code lengths are stored in order for the symbols, so lengths are
- *   provided for each of the literal/length symbols, and for each of the
- *   distance symbols.
- *
- * - If a symbol is not used in the block, this is represented by a zero as the
- *   code length.  This does not mean a zero-length code, but rather that no
- *   code should be created for this symbol.  There is no way in the deflate
- *   format to represent a zero-length code.
- *
- * - The maximum number of bits in a code is 15, so the possible lengths for
- *   any code are 1..15.
- *
- * - The fact that a length of zero is not permitted for a code has an
- *   interesting consequence.  Normally if only one symbol is used for a given
- *   code, then in fact that code could be represented with zero bits.  However
- *   in deflate, that code has to be at least one bit.  So for example, if
- *   only a single distance base symbol appears in a block, then it will be
- *   represented by a single code of length one, in particular one 0 bit.  This
- *   is an incomplete code, since if a 1 bit is received, it has no meaning,
- *   and should result in an error.  So incomplete distance codes of one symbol
- *   should be permitted, and the receipt of invalid codes should be handled.
- *
- * - It is also possible to have a single literal/length code, but that code
- *   must be the end-of-block code, since every dynamic block has one.  This
- *   is not the most efficient way to create an empty block (an empty fixed
- *   block is fewer bits), but it is allowed by the format.  So incomplete
- *   literal/length codes of one symbol should also be permitted.
- *
- * - If there are only literal codes and no lengths, then there are no distance
- *   codes.  This is represented by one distance code with zero bits.
- *
- * - The list of up to 286 length/literal lengths and up to 30 distance lengths
- *   are themselves compressed using Huffman codes and run-length encoding.  In
- *   the list of code lengths, a 0 symbol means no code, a 1..15 symbol means
- *   that length, and the symbols 16, 17, and 18 are run-length instructions.
- *   Each of 16, 17, and 18 are followed by extra bits to define the length of
- *   the run.  16 copies the last length 3 to 6 times.  17 represents 3 to 10
- *   zero lengths, and 18 represents 11 to 138 zero lengths.  Unused symbols
- *   are common, hence the special coding for zero lengths.
- *
- * - The symbols for 0..18 are Huffman coded, and so that code must be
- *   described first.  This is simply a sequence of up to 19 three-bit values
- *   representing no code (0) or the code length for that symbol (1..7).
- *
- * - A dynamic block starts with three fixed-size counts from which is computed
- *   the number of literal/length code lengths, the number of distance code
- *   lengths, and the number of code length code lengths (ok, you come up with
- *   a better name!) in the code descriptions.  For the literal/length and
- *   distance codes, lengths after those provided are considered zero, i.e. no
- *   code.  The code length code lengths are received in a permuted order (see
- *   the order[] array below) to make a short code length code length list more
- *   likely.  As it turns out, very short and very long codes are less likely
- *   to be seen in a dynamic code description, hence what may appear initially
- *   to be a peculiar ordering.
- *
- * - Given the number of literal/length code lengths (nlen) and distance code
- *   lengths (ndist), then they are treated as one long list of nlen + ndist
- *   code lengths.  Therefore run-length coding can and often does cross the
- *   boundary between the two sets of lengths.
- *
- * - So to summarize, the code description at the start of a dynamic block is
- *   three counts for the number of code lengths for the literal/length codes,
- *   the distance codes, and the code length codes.  This is followed by the
- *   code length code lengths, three bits each.  This is used to construct the
- *   code length code which is used to read the remainder of the lengths.  Then
- *   the literal/length code lengths and distance lengths are read as a single
- *   set of lengths using the code length codes.  Codes are constructed from
- *   the resulting two sets of lengths, and then finally you can start
- *   decoding actual compressed data in the block.
- *
- * - For reference, a "typical" size for the code description in a dynamic
- *   block is around 80 bytes.
- */
-local int dynamic(struct state *s)
-{
-    int nlen, ndist, ncode;             /* number of lengths in descriptor */
-    int index;                          /* index of lengths[] */
-    int err;                            /* construct() return value */
-    short lengths[MAXCODES];            /* descriptor code lengths */
-    short lencnt[MAXBITS+1], lensym[MAXLCODES];         /* lencode memory */
-    short distcnt[MAXBITS+1], distsym[MAXDCODES];       /* distcode memory */
-    struct huffman lencode, distcode;   /* length and distance codes */
-    static const short order[19] =      /* permutation of code length codes */
-        {16, 17, 18, 0, 8, 7, 9, 6, 10, 5, 11, 4, 12, 3, 13, 2, 14, 1, 15};
-
-    /* construct lencode and distcode */
-    lencode.count = lencnt;
-    lencode.symbol = lensym;
-    distcode.count = distcnt;
-    distcode.symbol = distsym;
-
-    /* get number of lengths in each table, check lengths */
-    nlen = bits(s, 5) + 257;
-    ndist = bits(s, 5) + 1;
-    ncode = bits(s, 4) + 4;
-    if (nlen > MAXLCODES || ndist > MAXDCODES)
-        return -3;                      /* bad counts */
-
-    /* read code length code lengths (really), missing lengths are zero */
-    for (index = 0; index < ncode; index++)
-        lengths[order[index]] = bits(s, 3);
-    for (; index < 19; index++)
-        lengths[order[index]] = 0;
-
-    /* build huffman table for code lengths codes (use lencode temporarily) */
-    err = construct(&lencode, lengths, 19);
-    if (err != 0)               /* require complete code set here */
-        return -4;
-
-    /* read length/literal and distance code length tables */
-    index = 0;
-    while (index < nlen + ndist) {
-        int symbol;             /* decoded value */
-        int len;                /* last length to repeat */
-
-        symbol = decode(s, &lencode);
-        if (symbol < 0)
-            return symbol;          /* invalid symbol */
-        if (symbol < 16)                /* length in 0..15 */
-            lengths[index++] = symbol;
-        else {                          /* repeat instruction */
-            len = 0;                    /* assume repeating zeros */
-            if (symbol == 16) {         /* repeat last length 3..6 times */
-                if (index == 0)
-                    return -5;          /* no last length! */
-                len = lengths[index - 1];       /* last length */
-                symbol = 3 + bits(s, 2);
-            }
-            else if (symbol == 17)      /* repeat zero 3..10 times */
-                symbol = 3 + bits(s, 3);
-            else                        /* == 18, repeat zero 11..138 times */
-                symbol = 11 + bits(s, 7);
-            if (index + symbol > nlen + ndist)
-                return -6;              /* too many lengths! */
-            while (symbol--)            /* repeat last or zero symbol times */
-                lengths[index++] = len;
-        }
-    }
-
-    /* check for end-of-block code -- there better be one! */
-    if (lengths[256] == 0)
-        return -9;
-
-    /* build huffman table for literal/length codes */
-    err = construct(&lencode, lengths, nlen);
-    if (err && (err < 0 || nlen != lencode.count[0] + lencode.count[1]))
-        return -7;      /* incomplete code ok only for single length 1 code */
-
-    /* build huffman table for distance codes */
-    err = construct(&distcode, lengths + nlen, ndist);
-    if (err && (err < 0 || ndist != distcode.count[0] + distcode.count[1]))
-        return -8;      /* incomplete code ok only for single length 1 code */
-
-    /* decode data until end-of-block code */
-    return codes(s, &lencode, &distcode);
-}
-
-/*
- * Inflate source to dest.  On return, destlen and sourcelen are updated to the
- * size of the uncompressed data and the size of the deflate data respectively.
- * On success, the return value of puff() is zero.  If there is an error in the
- * source data, i.e. it is not in the deflate format, then a negative value is
- * returned.  If there is not enough input available or there is not enough
- * output space, then a positive error is returned.  In that case, destlen and
- * sourcelen are not updated to facilitate retrying from the beginning with the
- * provision of more input data or more output space.  In the case of invalid
- * inflate data (a negative error), the dest and source pointers are updated to
- * facilitate the debugging of deflators.
- *
- * puff() also has a mode to determine the size of the uncompressed output with
- * no output written.  For this dest must be (unsigned char *)0.  In this case,
- * the input value of *destlen is ignored, and on return *destlen is set to the
- * size of the uncompressed output.
- *
- * The return codes are:
- *
- *   2:  available inflate data did not terminate
- *   1:  output space exhausted before completing inflate
- *   0:  successful inflate
- *  -1:  invalid block type (type == 3)
- *  -2:  stored block length did not match one's complement
- *  -3:  dynamic block code description: too many length or distance codes
- *  -4:  dynamic block code description: code lengths codes incomplete
- *  -5:  dynamic block code description: repeat lengths with no first length
- *  -6:  dynamic block code description: repeat more than specified lengths
- *  -7:  dynamic block code description: invalid literal/length code lengths
- *  -8:  dynamic block code description: invalid distance code lengths
- *  -9:  dynamic block code description: missing end-of-block code
- * -10:  invalid literal/length or distance code in fixed or dynamic block
- * -11:  distance is too far back in fixed or dynamic block
- *
- * Format notes:
- *
- * - Three bits are read for each block to determine the kind of block and
- *   whether or not it is the last block.  Then the block is decoded and the
- *   process repeated if it was not the last block.
- *
- * - The leftover bits in the last byte of the deflate data after the last
- *   block (if it was a fixed or dynamic block) are undefined and have no
- *   expected values to check.
- */
-int puff(unsigned char *dest,           /* pointer to destination pointer */
-         unsigned long *destlen,        /* amount of output space */
-         const unsigned char *source,   /* pointer to source data pointer */
-         unsigned long *sourcelen)      /* amount of input available */
-{
-    struct state s;             /* input/output state */
-    int last, type;             /* block information */
-    int err;                    /* return value */
-
-    /* initialize output state */
-    s.out = dest;
-    s.outlen = *destlen;                /* ignored if dest is NIL */
-    s.outcnt = 0;
-
-    /* initialize input state */
-    s.in = source;
-    s.inlen = *sourcelen;
-    s.incnt = 0;
-    s.bitbuf = 0;
-    s.bitcnt = 0;
-
-    /* return if bits() or decode() tries to read past available input */
-    if (setjmp(s.env) != 0)             /* if came back here via longjmp() */
-        err = 2;                        /* then skip do-loop, return error */
-    else {
-        /* process blocks until last block or error */
-        do {
-            last = bits(&s, 1);         /* one if last block */
-            type = bits(&s, 2);         /* block type 0..3 */
-            err = type == 0 ?
-                    stored(&s) :
-                    (type == 1 ?
-                        fixed(&s) :
-                        (type == 2 ?
-                            dynamic(&s) :
-                            -1));       /* type == 3, invalid */
-            if (err != 0)
-                break;                  /* return with error */
-        } while (!last);
-    }
-
-    /* update the lengths and return */
-    if (err <= 0) {
-        *destlen = s.outcnt;
-        *sourcelen = s.incnt;
-    }
-    return err;
-}

lib/obp60task/puff.h

@@ -1,35 +0,0 @@
-/* puff.h
-  Copyright (C) 2002-2013 Mark Adler, all rights reserved
-  version 2.3, 21 Jan 2013
-
-  This software is provided 'as-is', without any express or implied
-  warranty.  In no event will the author be held liable for any damages
-  arising from the use of this software.
-
-  Permission is granted to anyone to use this software for any purpose,
-  including commercial applications, and to alter it and redistribute it
-  freely, subject to the following restrictions:
-
-  1. The origin of this software must not be misrepresented; you must not
-     claim that you wrote the original software. If you use this software
-     in a product, an acknowledgment in the product documentation would be
-     appreciated but is not required.
-  2. Altered source versions must be plainly marked as such, and must not be
-     misrepresented as being the original software.
-  3. This notice may not be removed or altered from any source distribution.
-
-  Mark Adler    madler@alumni.caltech.edu
- */
-
-
-/*
- * See puff.c for purpose and usage.
- */
-#ifndef NIL
-#  define NIL ((unsigned char *)0)      /* for no output option */
-#endif
-
-int puff(unsigned char *dest,           /* pointer to destination pointer */
-         unsigned long *destlen,        /* amount of output space */
-         const unsigned char *source,   /* pointer to source data pointer */
-         unsigned long *sourcelen);     /* amount of input available */

lib/sensors/GwSensor.cpp

@@ -3,7 +3,7 @@
   This code is free software; you can redistribute it and/or
   modify it under the terms of the GNU Lesser General Public
   License as published by the Free Software Foundation; either
-  version 2 of the License, or (at your option) any later version.
+  version 2.1 of the License, or (at your option) any later version.
   This code is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU

lib/sensors/GwSensor.h

@@ -3,7 +3,7 @@
   This code is free software; you can redistribute it and/or
   modify it under the terms of the GNU Lesser General Public
   License as published by the Free Software Foundation; either
-  version 2 of the License, or (at your option) any later version.
+  version 2.1 of the License, or (at your option) any later version.
   This code is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
@@ -93,7 +93,6 @@ class GwSensorConfig{
     }
     bool readConfig(T* s,GwConfigHandler *cfg){
         if (s == nullptr) return false;
-        if (prefix != s->prefix) return false;
         configReader(s,cfg);
         return s->ok;
     }

lib/serial/GwSerial.cpp

@@ -66,8 +66,18 @@ GwSerial::~GwSerial()
     if (lock != nullptr) vSemaphoreDelete(lock);
 }
 
-int GwSerial::getType() {
-    return type;
+String GwSerial::getMode(){
+    switch (type){
+        case GWSERIAL_TYPE_UNI:
+            return "UNI";
+        case GWSERIAL_TYPE_BI:
+            return "BI";
+        case GWSERIAL_TYPE_RX:
+            return "RX";
+        case GWSERIAL_TYPE_TX:
+            return "TX";
+    }
+    return "UNKNOWN";
 }
 
 bool GwSerial::isInitialized() { return initialized; }

lib/serial/GwSerial.h

@@ -42,7 +42,7 @@ class GwSerial : public GwChannelInterface{
         virtual Stream *getStream(bool partialWrites);
         bool getAvailableWrite(){return availableWrite;}
         virtual void begin(unsigned long baud, uint32_t config=SERIAL_8N1, int8_t rxPin=-1, int8_t txPin=-1)=0;
-        virtual int getType() override;
+        virtual String getMode() override;
     friend GwSerialStream;
 };
 
@@ -122,7 +122,6 @@ template<typename T>
             setError(serial,logger);
         };
 
-
     };
 
 

lib/socketserver/GwUdpReader.cpp

@@ -6,6 +6,7 @@
 #include "GwSocketHelper.h"
 #include "GWWifi.h"
 
+
 GwUdpReader::GwUdpReader(const GwConfigHandler *config, GwLog *logger, int minId)
 {
     this->config = config;