From 5944e2620fd8ac8007fe04ac746c8ee60ac8a90b Mon Sep 17 00:00:00 2001
From: sniperbeamer <sniperbeamer@b624d157-de02-0410-bad0-e51aec6abb33>
Date: Fri, 27 Feb 2009 10:55:02 +0000
Subject: [PATCH] Fix: Crash when moving entry to another group (Bug #2644545)

git-svn-id: https://svn.code.sf.net/p/keepassx/code/trunk@277 b624d157-de02-0410-bad0-e51aec6abb33
---
 src/dialogs/EditEntryDlg.cpp | 1 -
 src/lib/EntryView.cpp        | 9 +++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/dialogs/EditEntryDlg.cpp b/src/dialogs/EditEntryDlg.cpp
index c4ab1ba..98f099b 100644
--- a/src/dialogs/EditEntryDlg.cpp
+++ b/src/dialogs/EditEntryDlg.cpp
@@ -220,7 +220,6 @@ void CEditEntryDlg::OnButtonOK()
 	if(Combo_Group->currentIndex()!=GroupIndex){
 		db->moveEntry(entry,groups[Combo_Group->currentIndex()]);
 		EntryMoved=true;
-		ModFlag=true;
 	}
 
 	if(EntryMoved)
diff --git a/src/lib/EntryView.cpp b/src/lib/EntryView.cpp
index 965b024..9409bb1 100644
--- a/src/lib/EntryView.cpp
+++ b/src/lib/EntryView.cpp
@@ -216,9 +216,10 @@ void KeepassEntryView::updateEntry(EntryViewItem* item){
 }
 
 void KeepassEntryView::editEntry(EntryViewItem* item){
-	CEntry old = item->EntryHandle->data();
+	IEntryHandle* handle = item->EntryHandle;
+	CEntry old = handle->data();
 	
-	CEditEntryDlg dlg(db,item->EntryHandle,this,true);
+	CEditEntryDlg dlg(db,handle,this,true);
 	int result = dlg.exec();
 	switch(result){
 		case 0: //canceled or no changes
@@ -230,14 +231,14 @@ void KeepassEntryView::editEntry(EntryViewItem* item){
 		//entry moved to another group
 		case 2: //modified
 		case 3: //not modified
+			Items.removeOne(item);
 			delete item;
-			Items.removeAt(Items.indexOf(item));
 			emit fileModified();
 			break;
 	}
 	
 	IGroupHandle* bGroup;
-	if ((result==1 || result==2) && config->backup() && item->EntryHandle->group() != (bGroup=db->backupGroup())){
+	if ((result==1 || result==2) && config->backup() && handle->group() != (bGroup=db->backupGroup())){
 		old.LastAccess = QDateTime::currentDateTime();
 		old.LastMod = old.LastAccess;
 		if (bGroup==NULL)